<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198304] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198304">198304</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2016-03-16 15:06:41 -0700 (Wed, 16 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
<http://webkit.org/b/155445>
Reviewed by Darin Adler.
* Scripts/webkitpy/style/checker.py:
(_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
on TestWebKitAPI since this project uses a config.h header as of
<a href="http://trac.webkit.org/projects/webkit/changeset/95188">r95188</a>. Also remove references to WebKitAPITest, which ceased
to exist in <a href="http://trac.webkit.org/projects/webkit/changeset/95944">r95944</a>.
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier): Add tests.
Remove reference to WebKitAPITest project.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerpy">trunk/Tools/Scripts/webkitpy/style/checker.py</a></li>
<li><a href="#trunkToolsScriptswebkitpystylechecker_unittestpy">trunk/Tools/Scripts/webkitpy/style/checker_unittest.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (198303 => 198304)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-03-16 21:49:26 UTC (rev 198303)
+++ trunk/Tools/ChangeLog 2016-03-16 22:06:41 UTC (rev 198304)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-03-16 David Kilzer <ddkilzer@apple.com>
+
+ check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
+ <http://webkit.org/b/155445>
+
+ Reviewed by Darin Adler.
+
+ * Scripts/webkitpy/style/checker.py:
+ (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
+ on TestWebKitAPI since this project uses a config.h header as of
+ r95188. Also remove references to WebKitAPITest, which ceased
+ to exist in r95944.
+
+ * Scripts/webkitpy/style/checker_unittest.py:
+ (GlobalVariablesTest.test_path_rules_specifier): Add tests.
+ Remove reference to WebKitAPITest project.
+
</ins><span class="cx"> 2016-03-16 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> [mac] Printing test snapshots are upside-down after r198242
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (198303 => 198304)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checker.py 2016-03-16 21:49:26 UTC (rev 198303)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py 2016-03-16 22:06:41 UTC (rev 198304)
</span><span class="lines">@@ -136,15 +136,13 @@
</span><span class="cx">
</span><span class="cx"> ([# TestNetscapePlugIn has no config.h and uses funny names like
</span><span class="cx"> # NPP_SetWindow.
</span><del>- os.path.join('Tools', 'DumpRenderTree', 'TestNetscapePlugIn'),
- # The API test harnesses have no config.h and use funny macros like
- # TEST_CLASS_NAME.
- os.path.join('Tools', 'WebKitAPITest'),
- os.path.join('Tools', 'TestWebKitAPI')],
</del><ins>+ os.path.join('Tools', 'DumpRenderTree', 'TestNetscapePlugIn')],
</ins><span class="cx"> ["-build/include",
</span><span class="cx"> "-readability/naming"]),
</span><span class="cx"> ([# There is no clean way to avoid "yy_*" names used by flex.
</span><del>- os.path.join('Source', 'WebCore', 'css', 'CSSParser.cpp')],
</del><ins>+ os.path.join('Source', 'WebCore', 'css', 'CSSParser.cpp'),
+ # TestWebKitAPI uses funny macros like EXPECT_WK_STREQ.
+ os.path.join('Tools', 'TestWebKitAPI')],
</ins><span class="cx"> ["-readability/naming"]),
</span><span class="cx">
</span><span class="cx"> ([# The GTK+ APIs use GTK+ naming style, which includes
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylechecker_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checker_unittest.py (198303 => 198304)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checker_unittest.py 2016-03-16 21:49:26 UTC (rev 198303)
+++ trunk/Tools/Scripts/webkitpy/style/checker_unittest.py 2016-03-16 22:06:41 UTC (rev 198304)
</span><span class="lines">@@ -213,8 +213,14 @@
</span><span class="cx">
</span><span class="cx"> assertCheck("random_path.cpp",
</span><span class="cx"> "build/include")
</span><del>- assertNoCheck(os.path.join('Tools', 'WebKitAPITest', 'main.cpp'),
</del><ins>+ assertNoCheck(os.path.join('Tools', 'DumpRenderTree', 'TestNetscapePlugIn', 'main.cpp'),
</ins><span class="cx"> "build/include")
</span><ins>+ assertNoCheck(os.path.join('Tools', 'DumpRenderTree', 'TestNetscapePlugIn', 'main.cpp'),
+ "readability/naming")
+ assertCheck(os.path.join('Tools', 'TestWebKitAPI', 'Tests', 'WTF', 'RefLogger.cpp'),
+ "build/include")
+ assertNoCheck(os.path.join('Tools', 'TestWebKitAPI', 'Tests', 'mac', 'WillSendSubmitEvent.mm'),
+ "readability/naming")
</ins><span class="cx"> assertCheck("random_path.cpp",
</span><span class="cx"> "readability/naming")
</span><span class="cx"> assertNoCheck(os.path.join('Source', 'WebKit', 'gtk', 'webkit', 'webkit.h'),
</span></span></pre>
</div>
</div>
</body>
</html>