<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198189] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198189">198189</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-03-14 20:53:07 -0700 (Mon, 14 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/197981">r197981</a>.
Caused a massive PLT regression on Mac.
Reverted changeset:
"Font antialiasing (smoothing) changes when elements are
rendered into compositing layers"
https://bugs.webkit.org/show_bug.cgi?id=23364
http://trac.webkit.org/changeset/197981</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGraphicsLayercpp">trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGraphicsLayerh">trunk/Source/WebCore/platform/graphics/GraphicsLayer.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsTiledBackingh">trunk/Source/WebCore/platform/graphics/TiledBacking.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAcpp">trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAh">trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaPlatformCALayercpp">trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaPlatformCALayerh">trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaTileControllercpp">trunk/Source/WebCore/platform/graphics/ca/TileController.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaTileControllerh">trunk/Source/WebCore/platform/graphics/ca/TileController.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaTileGridcpp">trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscacocoaPlatformCALayerCocoah">trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscacocoaPlatformCALayerCocoamm">trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscawinPlatformCALayerWincpp">trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscawinPlatformCALayerWinh">trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h</a></li>
<li><a href="#trunkSourceWebCoreplatformiosLegacyTileGridTilemm">trunk/Source/WebCore/platform/ios/LegacyTileGridTile.mm</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingcpp">trunk/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewPrivateh">trunk/Source/WebKit/mac/WebView/WebViewPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebProcessCreationParameterscpp">trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp</a></li>
<li><a href="#trunkSourceWebKit2SharedWebProcessCreationParametersh">trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h</a></li>
<li><a href="#trunkSourceWebKit2SharedmacRemoteLayerTreeTransactionh">trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h</a></li>
<li><a href="#trunkSourceWebKit2SharedmacRemoteLayerTreeTransactionmm">trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKContextcpp">trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKContextPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolcpp">trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolh">trunk/Source/WebKit2/UIProcess/WebProcessPool.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemotecpp">trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemoteh">trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcesscpp">trunk/Source/WebKit2/WebProcess/WebProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcessh">trunk/Source/WebKit2/WebProcess/WebProcess.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcessmessagesin">trunk/Source/WebKit2/WebProcess/WebProcess.messages.in</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
<li><a href="#trunkToolsWebKitTestRunnerTestControllercpp">trunk/Tools/WebKitTestRunner/TestController.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/ChangeLog 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2016-03-14 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Unreviewed, rolling out r197981.
+
+ Caused a massive PLT regression on Mac.
+
+ Reverted changeset:
+
+ "Font antialiasing (smoothing) changes when elements are
+ rendered into compositing layers"
+ https://bugs.webkit.org/show_bug.cgi?id=23364
+ http://trac.webkit.org/changeset/197981
+
+2016-03-14 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Unreviewed, rolling out r198145.
</span><span class="cx">
</span><span class="cx"> This attempt to disable the feature did not fix the PLT
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsGraphicsLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -105,22 +105,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if !USE(CA)
-bool GraphicsLayer::supportsSmoothedLayerText()
-{
- return false;
-}
-
-void GraphicsLayer::setSmoothedLayerTextEnabled(bool)
-{
-}
-
-bool GraphicsLayer::smoothedLayerTextEnabled()
-{
- return false;
-}
-#endif
-
</del><span class="cx"> GraphicsLayer::GraphicsLayer(Type type, GraphicsLayerClient& client)
</span><span class="cx"> : m_client(client)
</span><span class="cx"> , m_anchorPoint(0.5f, 0.5f, 0)
</span><span class="lines">@@ -131,7 +115,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> , m_type(type)
</span><span class="cx"> , m_contentsOpaque(false)
</span><del>- , m_supportsSmoothedFonts(false)
</del><span class="cx"> , m_preserves3D(false)
</span><span class="cx"> , m_backfaceVisibility(true)
</span><span class="cx"> , m_usingTiledBacking(false)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsGraphicsLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -364,9 +364,6 @@
</span><span class="cx"> bool contentsOpaque() const { return m_contentsOpaque; }
</span><span class="cx"> virtual void setContentsOpaque(bool b) { m_contentsOpaque = b; }
</span><span class="cx">
</span><del>- bool supportsSmoothedFonts() const { return m_supportsSmoothedFonts; }
- virtual void setSupportsSmoothedFonts(bool b) { m_supportsSmoothedFonts = b; }
-
</del><span class="cx"> bool backfaceVisibility() const { return m_backfaceVisibility; }
</span><span class="cx"> virtual void setBackfaceVisibility(bool b) { m_backfaceVisibility = b; }
</span><span class="cx">
</span><span class="lines">@@ -543,11 +540,7 @@
</span><span class="cx"> static bool supportsBackgroundColorContent();
</span><span class="cx"> static bool supportsLayerType(Type);
</span><span class="cx"> static bool supportsContentsTiling();
</span><del>- static bool supportsSmoothedLayerText();
</del><span class="cx">
</span><del>- WEBCORE_EXPORT static void setSmoothedLayerTextEnabled(bool);
- WEBCORE_EXPORT static bool smoothedLayerTextEnabled();
-
</del><span class="cx"> void updateDebugIndicators();
</span><span class="cx">
</span><span class="cx"> virtual bool canThrottleLayerFlush() const { return false; }
</span><span class="lines">@@ -620,7 +613,6 @@
</span><span class="cx"> const Type m_type;
</span><span class="cx">
</span><span class="cx"> bool m_contentsOpaque : 1;
</span><del>- bool m_supportsSmoothedFonts : 1;
</del><span class="cx"> bool m_preserves3D: 1;
</span><span class="cx"> bool m_backfaceVisibility : 1;
</span><span class="cx"> bool m_usingTiledBacking : 1;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsTiledBackingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/TiledBacking.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/TiledBacking.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/TiledBacking.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -79,8 +79,6 @@
</span><span class="cx"> virtual void setTiledScrollingIndicatorPosition(const FloatPoint&) = 0;
</span><span class="cx"> virtual void setTopContentInset(float) = 0;
</span><span class="cx">
</span><del>- virtual void setTileContentsFormatFlags(unsigned) = 0;
-
</del><span class="cx"> virtual void setVelocity(const VelocityData&) = 0;
</span><span class="cx">
</span><span class="cx"> enum {
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -309,26 +309,6 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool isSmoothedLayerTextEnabled = true;
-
-bool GraphicsLayer::supportsSmoothedLayerText()
-{
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
- return isSmoothedLayerTextEnabled;
-#endif
- return false;
-}
-
-void GraphicsLayer::setSmoothedLayerTextEnabled(bool flag)
-{
- isSmoothedLayerTextEnabled = flag;
-}
-
-bool GraphicsLayer::smoothedLayerTextEnabled()
-{
- return isSmoothedLayerTextEnabled;
-}
-
</del><span class="cx"> std::unique_ptr<GraphicsLayer> GraphicsLayer::create(GraphicsLayerFactory* factory, GraphicsLayerClient& client, Type layerType)
</span><span class="cx"> {
</span><span class="cx"> std::unique_ptr<GraphicsLayer> graphicsLayer;
</span><span class="lines">@@ -729,15 +709,6 @@
</span><span class="cx"> noteLayerPropertyChanged(ContentsOpaqueChanged);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void GraphicsLayerCA::setSupportsSmoothedFonts(bool supportsSmoothedFonts)
-{
- if (m_supportsSmoothedFonts == supportsSmoothedFonts)
- return;
-
- GraphicsLayer::setSupportsSmoothedFonts(supportsSmoothedFonts);
- noteLayerPropertyChanged(ContentsFormatChanged);
-}
-
</del><span class="cx"> void GraphicsLayerCA::setBackfaceVisibility(bool visible)
</span><span class="cx"> {
</span><span class="cx"> if (m_backfaceVisibility == visible)
</span><span class="lines">@@ -1609,9 +1580,6 @@
</span><span class="cx"> if (m_uncommittedChanges & ContentsOpaqueChanged)
</span><span class="cx"> updateContentsOpaque(pageScaleFactor);
</span><span class="cx">
</span><del>- if (m_uncommittedChanges & ContentsFormatChanged)
- updateContentsFormat();
-
</del><span class="cx"> if (m_uncommittedChanges & BackfaceVisibilityChanged)
</span><span class="cx"> updateBackfaceVisibility();
</span><span class="cx">
</span><span class="lines">@@ -1922,20 +1890,6 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void GraphicsLayerCA::updateContentsFormat()
-{
- PlatformCALayer::ContentsFormatFlags formatFlags = 0;
- if (supportsSmoothedFonts())
- formatFlags |= PlatformCALayer::SmoothedFonts;
-
- m_layer->setContentsFormat(formatFlags);
-
- if (LayerMap* layerCloneMap = m_layerClones.get()) {
- for (auto& layer : layerCloneMap->values())
- layer->setContentsFormat(formatFlags);
- }
-}
-
</del><span class="cx"> void GraphicsLayerCA::updateBackfaceVisibility()
</span><span class="cx"> {
</span><span class="cx"> if (m_structuralLayer && structuralLayerPurpose() == StructuralLayerForReplicaFlattening) {
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -95,8 +95,6 @@
</span><span class="cx"> WEBCORE_EXPORT void setBackgroundColor(const Color&) override;
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void setContentsOpaque(bool) override;
</span><del>- WEBCORE_EXPORT void setSupportsSmoothedFonts(bool) override;
-
</del><span class="cx"> WEBCORE_EXPORT void setBackfaceVisibility(bool) override;
</span><span class="cx">
</span><span class="cx"> // return true if we started an animation
</span><span class="lines">@@ -393,7 +391,6 @@
</span><span class="cx"> void updateMasksToBounds();
</span><span class="cx"> void updateContentsVisibility();
</span><span class="cx"> void updateContentsOpaque(float pageScaleFactor);
</span><del>- void updateContentsFormat();
</del><span class="cx"> void updateBackfaceVisibility();
</span><span class="cx"> void updateStructuralLayer();
</span><span class="cx"> void updateDrawsContent();
</span><span class="lines">@@ -458,44 +455,43 @@
</span><span class="cx"> bool appendToUncommittedAnimations(const KeyframeValueList&, const FilterOperation*, const Animation*, const String& animationName, int animationIndex, double timeOffset);
</span><span class="cx">
</span><span class="cx"> enum LayerChange : uint64_t {
</span><del>- NoChange = 0,
- NameChanged = 1LLU << 1,
- ChildrenChanged = 1LLU << 2, // also used for content layer, and preserves-3d, and size if tiling changes?
- GeometryChanged = 1LLU << 3,
- TransformChanged = 1LLU << 4,
- ChildrenTransformChanged = 1LLU << 5,
- Preserves3DChanged = 1LLU << 6,
- MasksToBoundsChanged = 1LLU << 7,
- DrawsContentChanged = 1LLU << 8,
- BackgroundColorChanged = 1LLU << 9,
- ContentsOpaqueChanged = 1LLU << 10,
- ContentsFormatChanged = 1LLU << 11,
- BackfaceVisibilityChanged = 1LLU << 12,
- OpacityChanged = 1LLU << 13,
- AnimationChanged = 1LLU << 14,
- DirtyRectsChanged = 1LLU << 15,
- ContentsImageChanged = 1LLU << 16,
- ContentsPlatformLayerChanged = 1LLU << 17,
- ContentsColorLayerChanged = 1LLU << 18,
- ContentsRectsChanged = 1LLU << 19,
- MasksToBoundsRectChanged = 1LLU << 20,
- MaskLayerChanged = 1LLU << 21,
- ReplicatedLayerChanged = 1LLU << 22,
- ContentsNeedsDisplay = 1LLU << 23,
- AcceleratesDrawingChanged = 1LLU << 24,
- ContentsScaleChanged = 1LLU << 25,
- ContentsVisibilityChanged = 1LLU << 26,
- CoverageRectChanged = 1LLU << 27,
- FiltersChanged = 1LLU << 28,
- BackdropFiltersChanged = 1LLU << 29,
- BackdropFiltersRectChanged = 1LLU << 30,
- TilingAreaChanged = 1LLU << 31,
- TilesAdded = 1LLU << 32,
- DebugIndicatorsChanged = 1LLU << 33,
- CustomAppearanceChanged = 1LLU << 34,
- BlendModeChanged = 1LLU << 35,
- ShapeChanged = 1LLU << 36,
- WindRuleChanged = 1LLU << 37,
</del><ins>+ NoChange = 0,
+ NameChanged = 1LLU << 1,
+ ChildrenChanged = 1LLU << 2, // also used for content layer, and preserves-3d, and size if tiling changes?
+ GeometryChanged = 1LLU << 3,
+ TransformChanged = 1LLU << 4,
+ ChildrenTransformChanged = 1LLU << 5,
+ Preserves3DChanged = 1LLU << 6,
+ MasksToBoundsChanged = 1LLU << 7,
+ DrawsContentChanged = 1LLU << 8,
+ BackgroundColorChanged = 1LLU << 9,
+ ContentsOpaqueChanged = 1LLU << 10,
+ BackfaceVisibilityChanged = 1LLU << 11,
+ OpacityChanged = 1LLU << 12,
+ AnimationChanged = 1LLU << 13,
+ DirtyRectsChanged = 1LLU << 14,
+ ContentsImageChanged = 1LLU << 15,
+ ContentsPlatformLayerChanged = 1LLU << 16,
+ ContentsColorLayerChanged = 1LLU << 17,
+ ContentsRectsChanged = 1LLU << 18,
+ MasksToBoundsRectChanged = 1LLU << 19,
+ MaskLayerChanged = 1LLU << 20,
+ ReplicatedLayerChanged = 1LLU << 21,
+ ContentsNeedsDisplay = 1LLU << 22,
+ AcceleratesDrawingChanged = 1LLU << 23,
+ ContentsScaleChanged = 1LLU << 24,
+ ContentsVisibilityChanged = 1LLU << 25,
+ CoverageRectChanged = 1LLU << 26,
+ FiltersChanged = 1LLU << 27,
+ BackdropFiltersChanged = 1LLU << 28,
+ BackdropFiltersRectChanged = 1LLU << 29,
+ TilingAreaChanged = 1LLU << 30,
+ TilesAdded = 1LLU << 31,
+ DebugIndicatorsChanged = 1LLU << 32,
+ CustomAppearanceChanged = 1LLU << 33,
+ BlendModeChanged = 1LLU << 34,
+ ShapeChanged = 1LLU << 35,
+ WindRuleChanged = 1LLU << 36,
</ins><span class="cx"> };
</span><span class="cx"> typedef uint64_t LayerChangeFlags;
</span><span class="cx"> enum ScheduleFlushOrNot { ScheduleFlush, DontScheduleFlush };
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaPlatformCALayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -80,6 +80,11 @@
</span><span class="cx"> CGContextSetRGBFillColor(context, 0, 0.5f, 0.25f, 1);
</span><span class="cx">
</span><span class="cx"> CGContextFillRect(context, indicatorBox);
</span><ins>+
+ if (platformCALayer->acceleratesDrawing())
+ CGContextSetRGBFillColor(context, 1, 0, 0, 1);
+ else
+ CGContextSetRGBFillColor(context, 1, 1, 1, 1);
</ins><span class="cx">
</span><span class="cx"> if (platformCALayer->owner()->isUsingDisplayListDrawing(platformCALayer)) {
</span><span class="cx"> CGContextSetRGBStrokeColor(context, 0, 0, 0, 0.65);
</span><span class="lines">@@ -87,16 +92,6 @@
</span><span class="cx"> CGContextStrokeRect(context, indicatorBox);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (!platformCALayer->isOpaque() && (platformCALayer->contentsFormat() & SmoothedFonts)) {
- CGContextSetRGBFillColor(context, 1, 1, 1, 0.4);
- platformCALayer->drawTextAtPoint(context, indicatorBox.origin.x + 7, indicatorBox.origin.y + 24, CGSizeMake(1, -1), 22, text, strlen(text));
- }
-
- if (platformCALayer->acceleratesDrawing())
- CGContextSetRGBFillColor(context, 1, 0, 0, 1);
- else
- CGContextSetRGBFillColor(context, 1, 1, 1, 1);
-
</del><span class="cx"> platformCALayer->drawTextAtPoint(context, indicatorBox.origin.x + 5, indicatorBox.origin.y + 22, CGSizeMake(1, -1), 22, text, strlen(text));
</span><span class="cx">
</span><span class="cx"> CGContextEndTransparencyLayer(context);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaPlatformCALayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -139,14 +139,6 @@
</span><span class="cx"> virtual bool isOpaque() const = 0;
</span><span class="cx"> virtual void setOpaque(bool) = 0;
</span><span class="cx">
</span><del>- enum ContentsFormatFlag {
- DeepColor = 1 << 0,
- SmoothedFonts = 1 << 1,
- };
- typedef unsigned ContentsFormatFlags;
- virtual void setContentsFormat(ContentsFormatFlags) = 0;
- virtual ContentsFormatFlags contentsFormat() const = 0;
-
</del><span class="cx"> virtual FloatRect bounds() const = 0;
</span><span class="cx"> virtual void setBounds(const FloatRect&) = 0;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaTileControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/TileController.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/TileController.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/TileController.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -175,15 +175,6 @@
</span><span class="cx"> tileGrid().updateTileLayerProperties();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void TileController::setTileContentsFormatFlags(PlatformCALayer::ContentsFormatFlags flags)
-{
- if (flags == m_contentsFormatFlags)
- return;
-
- m_contentsFormatFlags = flags;
- tileGrid().updateTileLayerProperties();
-}
-
</del><span class="cx"> void TileController::setVisibleRect(const FloatRect& rect)
</span><span class="cx"> {
</span><span class="cx"> if (rect == m_visibleRect)
</span><span class="lines">@@ -684,7 +675,6 @@
</span><span class="cx"> layer->setBorderWidth(m_tileDebugBorderWidth);
</span><span class="cx"> layer->setEdgeAntialiasingMask(0);
</span><span class="cx"> layer->setOpaque(m_tilesAreOpaque);
</span><del>- layer->setContentsFormat(m_contentsFormatFlags);
</del><span class="cx"> #ifndef NDEBUG
</span><span class="cx"> layer->setName("Tile");
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaTileControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/TileController.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/TileController.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/TileController.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -78,9 +78,6 @@
</span><span class="cx"> WEBCORE_EXPORT void setTilesOpaque(bool);
</span><span class="cx"> bool tilesAreOpaque() const { return m_tilesAreOpaque; }
</span><span class="cx">
</span><del>- void setTileContentsFormatFlags(PlatformCALayer::ContentsFormatFlags) override;
- PlatformCALayer::ContentsFormatFlags tileContentsFormatFlags() const { return m_contentsFormatFlags; }
-
</del><span class="cx"> PlatformCALayer& rootLayer() { return *m_tileCacheLayer; }
</span><span class="cx"> const PlatformCALayer& rootLayer() const { return *m_tileCacheLayer; }
</span><span class="cx">
</span><span class="lines">@@ -209,8 +206,6 @@
</span><span class="cx">
</span><span class="cx"> int m_marginSize { kDefaultTileSize };
</span><span class="cx">
</span><del>- PlatformCALayer::ContentsFormatFlags m_contentsFormatFlags { 0 };
-
</del><span class="cx"> // m_marginTop and m_marginBottom are the height in pixels of the top and bottom margin tiles. The width
</span><span class="cx"> // of those tiles will be equivalent to the width of the other tiles in the grid. m_marginRight and
</span><span class="cx"> // m_marginLeft are the width in pixels of the right and left margin tiles, respectively. The height of
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaTileGridcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -175,7 +175,6 @@
</span><span class="cx"> {
</span><span class="cx"> bool acceleratesDrawing = m_controller.acceleratesDrawing();
</span><span class="cx"> bool opaque = m_controller.tilesAreOpaque();
</span><del>- PlatformCALayer::ContentsFormatFlags formatFlags = m_controller.tileContentsFormatFlags();
</del><span class="cx"> Color tileDebugBorderColor = m_controller.tileDebugBorderColor();
</span><span class="cx"> float tileDebugBorderWidth = m_controller.tileDebugBorderWidth();
</span><span class="cx">
</span><span class="lines">@@ -183,7 +182,6 @@
</span><span class="cx"> const TileInfo& tileInfo = it->value;
</span><span class="cx"> tileInfo.layer->setAcceleratesDrawing(acceleratesDrawing);
</span><span class="cx"> tileInfo.layer->setOpaque(opaque);
</span><del>- tileInfo.layer->setContentsFormat(formatFlags);
</del><span class="cx"> tileInfo.layer->setBorderColor(tileDebugBorderColor);
</span><span class="cx"> tileInfo.layer->setBorderWidth(tileDebugBorderWidth);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscacocoaPlatformCALayerCocoah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -72,9 +72,6 @@
</span><span class="cx"> bool isOpaque() const override;
</span><span class="cx"> void setOpaque(bool) override;
</span><span class="cx">
</span><del>- void setContentsFormat(ContentsFormatFlags) override;
- ContentsFormatFlags contentsFormat() const override { return m_contentsFormatFlags; }
-
</del><span class="cx"> FloatRect bounds() const override;
</span><span class="cx"> void setBounds(const FloatRect&) override;
</span><span class="cx">
</span><span class="lines">@@ -182,7 +179,6 @@
</span><span class="cx"> std::unique_ptr<PlatformCALayerList> m_customSublayers;
</span><span class="cx"> GraphicsLayer::CustomAppearance m_customAppearance;
</span><span class="cx"> std::unique_ptr<FloatRoundedRect> m_shapeRoundedRect;
</span><del>- ContentsFormatFlags m_contentsFormatFlags { 0 };
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscacocoaPlatformCALayerCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> #import <WebKitAdditions/LayerBackingStoreAdditions.mm>
</span><span class="cx"> #else
</span><span class="cx"> namespace WebCore {
</span><del>-static void setBackingStoreFormat(CALayer *, PlatformCALayer::ContentsFormatFlags)
</del><ins>+static void setBackingStoreFormat(CALayer *)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> } // namespace WebCore
</span><span class="lines">@@ -308,7 +308,7 @@
</span><span class="cx"> [m_layer setDelegate:[WebActionDisablingCALayerDelegate shared]];
</span><span class="cx">
</span><span class="cx"> if (m_layerType == LayerTypeWebLayer || m_layerType == LayerTypeTiledBackingTileLayer)
</span><del>- setBackingStoreFormat(m_layer.get(), 0);
</del><ins>+ setBackingStoreFormat(m_layer.get());
</ins><span class="cx">
</span><span class="cx"> // So that the scrolling thread's performance logging code can find all the tiles, mark this as being a tile.
</span><span class="cx"> if (m_layerType == LayerTypeTiledBackingTileLayer)
</span><span class="lines">@@ -545,22 +545,6 @@
</span><span class="cx"> END_BLOCK_OBJC_EXCEPTIONS
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PlatformCALayerCocoa::setContentsFormat(ContentsFormatFlags flags)
-{
- if (flags == m_contentsFormatFlags)
- return;
-
- m_contentsFormatFlags = flags;
-
- if (usesTiledBackingLayer()) {
- WebTiledBackingLayer* tiledBackingLayer = static_cast<WebTiledBackingLayer*>(m_layer.get());
- tiledBackingLayer.tiledBacking->setTileContentsFormatFlags(flags);
- return;
- }
-
- setBackingStoreFormat(m_layer.get(), flags);
-}
-
</del><span class="cx"> FloatRect PlatformCALayerCocoa::bounds() const
</span><span class="cx"> {
</span><span class="cx"> return [m_layer bounds];
</span><span class="lines">@@ -1072,7 +1056,7 @@
</span><span class="cx"> graphicsContext.setIsCALayerContext(true);
</span><span class="cx"> graphicsContext.setIsAcceleratedContext(platformCALayer->acceleratesDrawing());
</span><span class="cx">
</span><del>- if (!layerContents->platformCALayerContentsOpaque() && !(platformCALayer->contentsFormat() & SmoothedFonts)) {
</del><ins>+ if (!layerContents->platformCALayerContentsOpaque()) {
</ins><span class="cx"> // Turn off font smoothing to improve the appearance of text rendered onto a transparent background.
</span><span class="cx"> graphicsContext.setShouldSmoothFonts(false);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscawinPlatformCALayerWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -377,16 +377,6 @@
</span><span class="cx"> setNeedsCommit();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PlatformCALayerWin::setContentsFormat(ContentsFormatFlags formatFlags)
-{
- m_contentsFormat = formatFlags;
-}
-
-PlatformCALayer::ContentsFormatFlags PlatformCALayerWin::contentsFormat() const
-{
- return m_contentsFormat;
-}
-
</del><span class="cx"> FloatRect PlatformCALayerWin::bounds() const
</span><span class="cx"> {
</span><span class="cx"> return CACFLayerGetBounds(m_layer.get());
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscawinPlatformCALayerWinh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -64,9 +64,6 @@
</span><span class="cx"> bool isOpaque() const override;
</span><span class="cx"> void setOpaque(bool) override;
</span><span class="cx">
</span><del>- void setContentsFormat(ContentsFormatFlags) override;
- ContentsFormatFlags contentsFormat() const override;
-
</del><span class="cx"> FloatRect bounds() const override;
</span><span class="cx"> void setBounds(const FloatRect&) override;
</span><span class="cx">
</span><span class="lines">@@ -166,7 +163,6 @@
</span><span class="cx"> HashMap<String, RefPtr<PlatformCAAnimation>> m_animations;
</span><span class="cx"> std::unique_ptr<PlatformCALayerList> m_customSublayers;
</span><span class="cx"> GraphicsLayer::CustomAppearance m_customAppearance;
</span><del>- ContentsFormatFlags m_contentsFormat { 0 };
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformiosLegacyTileGridTilemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ios/LegacyTileGridTile.mm (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ios/LegacyTileGridTile.mm 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/platform/ios/LegacyTileGridTile.mm 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -28,13 +28,11 @@
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx">
</span><del>-#include "BlockExceptions.h"
</del><span class="cx"> #include "Color.h"
</span><span class="cx"> #include "LegacyTileCache.h"
</span><span class="cx"> #include "LegacyTileGrid.h"
</span><span class="cx"> #include "LegacyTileLayer.h"
</span><span class="cx"> #include "LegacyTileLayerPool.h"
</span><del>-#include "PlatformCALayer.h"
</del><span class="cx"> #include "QuartzCoreSPI.h"
</span><span class="cx"> #include "WAKWindow.h"
</span><span class="cx"> #include <algorithm>
</span><span class="lines">@@ -45,7 +43,7 @@
</span><span class="cx"> #import <WebKitAdditions/LayerBackingStoreAdditions.mm>
</span><span class="cx"> #else
</span><span class="cx"> namespace WebCore {
</span><del>-static void setBackingStoreFormat(CALayer *, PlatformCALayer::ContentsFormatFlags)
</del><ins>+static void setBackingStoreFormat(CALayer *)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> } // namespace WebCore
</span><span class="lines">@@ -73,7 +71,7 @@
</span><span class="cx"> m_tileLayer = adoptNS([[LegacyTileLayer alloc] init]);
</span><span class="cx"> }
</span><span class="cx"> LegacyTileLayer* layer = m_tileLayer.get();
</span><del>- setBackingStoreFormat(layer, 0);
</del><ins>+ setBackingStoreFormat(layer);
</ins><span class="cx"> [layer setTileGrid:tileGrid];
</span><span class="cx"> [layer setOpaque:m_tileGrid->tileCache().tilesOpaque()];
</span><span class="cx"> [layer setEdgeAntialiasingMask:0];
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -178,10 +178,6 @@
</span><span class="cx"> graphicsLayer->setAcceleratesDrawing(compositor().acceleratedDrawingEnabled());
</span><span class="cx"> graphicsLayer->setUsesDisplayListDrawing(compositor().displayListDrawingEnabled());
</span><span class="cx"> #endif
</span><del>-
- // FIXME: ideally we'd only do this if the layer contains smoothed text.
- if (GraphicsLayer::supportsSmoothedLayerText())
- graphicsLayer->setSupportsSmoothedFonts(true);
</del><span class="cx">
</span><span class="cx"> return graphicsLayer;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-03-14 Chris Dumez <cdumez@apple.com>
+
+ Unreviewed, rolling out r197981.
+
+ Caused a massive PLT regression on Mac.
+
+ Reverted changeset:
+
+ "Font antialiasing (smoothing) changes when elements are
+ rendered into compositing layers"
+ https://bugs.webkit.org/show_bug.cgi?id=23364
+ http://trac.webkit.org/changeset/197981
+
</ins><span class="cx"> 2016-03-14 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add a baseURL parameter to _WKUserStyleSheet
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -140,7 +140,6 @@
</span><span class="cx"> #import <WebCore/GCController.h>
</span><span class="cx"> #import <WebCore/GeolocationController.h>
</span><span class="cx"> #import <WebCore/GeolocationError.h>
</span><del>-#import <WebCore/GraphicsLayer.h>
</del><span class="cx"> #import <WebCore/HTMLNames.h>
</span><span class="cx"> #import <WebCore/HTMLVideoElement.h>
</span><span class="cx"> #import <WebCore/HistoryController.h>
</span><span class="lines">@@ -3238,16 +3237,6 @@
</span><span class="cx"> return FontCascade::shouldUseSmoothing();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-+ (void)_setSmoothedLayerTextEnabled:(BOOL)f
-{
- GraphicsLayer::setSmoothedLayerTextEnabled(f);
-}
-
-+ (BOOL)_smoothedLayerTextEnabled
-{
- return GraphicsLayer::smoothedLayerTextEnabled();
-}
-
</del><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> + (void)_setUsesTestModeFocusRingColor:(BOOL)f
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebViewPrivate.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -532,9 +532,6 @@
</span><span class="cx"> + (void)_setShouldUseFontSmoothing:(BOOL)f;
</span><span class="cx"> + (BOOL)_shouldUseFontSmoothing;
</span><span class="cx">
</span><del>-+ (void)_setSmoothedLayerTextEnabled:(BOOL)f;
-+ (BOOL)_smoothedLayerTextEnabled;
-
</del><span class="cx"> #if !TARGET_OS_IPHONE
</span><span class="cx"> // These two methods are useful for a test harness that needs a consistent appearance for the focus rings
</span><span class="cx"> // regardless of OS X version.
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-03-14 Chris Dumez <cdumez@apple.com>
+
+ Unreviewed, rolling out r197981.
+
+ Caused a massive PLT regression on Mac.
+
+ Reverted changeset:
+
+ "Font antialiasing (smoothing) changes when elements are
+ rendered into compositing layers"
+ https://bugs.webkit.org/show_bug.cgi?id=23364
+ http://trac.webkit.org/changeset/197981
+
</ins><span class="cx"> 2016-03-14 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add a baseURL parameter to _WKUserStyleSheet
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebProcessCreationParameterscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -35,7 +35,20 @@
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><span class="cx"> WebProcessCreationParameters::WebProcessCreationParameters()
</span><del>- : defaultRequestTimeoutInterval(INT_MAX)
</del><ins>+ : shouldAlwaysUseComplexTextCodePath(false)
+ , shouldEnableMemoryPressureReliefLogging(false)
+ , shouldUseFontSmoothing(true)
+ , defaultRequestTimeoutInterval(INT_MAX)
+#if PLATFORM(COCOA)
+ , shouldEnableJIT(false)
+ , shouldEnableFTLJIT(false)
+#endif
+ , memoryCacheDisabled(false)
+#if ENABLE(SERVICE_CONTROLS)
+ , hasImageServices(false)
+ , hasSelectionServices(false)
+ , hasRichContentServices(false)
+#endif
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -83,7 +96,6 @@
</span><span class="cx"> encoder << shouldEnableMemoryPressureReliefLogging;
</span><span class="cx"> encoder << shouldSuppressMemoryPressureHandler;
</span><span class="cx"> encoder << shouldUseFontSmoothing;
</span><del>- encoder << enabledSmoothedLayerText;
</del><span class="cx"> encoder << resourceLoadStatisticsEnabled;
</span><span class="cx"> encoder << fontWhitelist;
</span><span class="cx"> encoder << iconDatabaseEnabled;
</span><span class="lines">@@ -202,8 +214,6 @@
</span><span class="cx"> return false;
</span><span class="cx"> if (!decoder.decode(parameters.shouldUseFontSmoothing))
</span><span class="cx"> return false;
</span><del>- if (!decoder.decode(parameters.enabledSmoothedLayerText))
- return false;
</del><span class="cx"> if (!decoder.decode(parameters.resourceLoadStatisticsEnabled))
</span><span class="cx"> return false;
</span><span class="cx"> if (!decoder.decode(parameters.fontWhitelist))
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebProcessCreationParametersh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -103,11 +103,10 @@
</span><span class="cx">
</span><span class="cx"> CacheModel cacheModel;
</span><span class="cx">
</span><del>- bool shouldAlwaysUseComplexTextCodePath { false };
- bool shouldEnableMemoryPressureReliefLogging { false };
</del><ins>+ bool shouldAlwaysUseComplexTextCodePath;
+ bool shouldEnableMemoryPressureReliefLogging;
</ins><span class="cx"> bool shouldSuppressMemoryPressureHandler { false };
</span><del>- bool shouldUseFontSmoothing { true };
- bool enabledSmoothedLayerText { true };
</del><ins>+ bool shouldUseFontSmoothing;
</ins><span class="cx"> bool resourceLoadStatisticsEnabled { false };
</span><span class="cx">
</span><span class="cx"> Vector<String> fontWhitelist;
</span><span class="lines">@@ -139,8 +138,8 @@
</span><span class="cx"> String uiProcessBundleResourcePath;
</span><span class="cx"> SandboxExtension::Handle uiProcessBundleResourcePathExtensionHandle;
</span><span class="cx">
</span><del>- bool shouldEnableJIT { false };
- bool shouldEnableFTLJIT { false };
</del><ins>+ bool shouldEnableJIT;
+ bool shouldEnableFTLJIT;
</ins><span class="cx">
</span><span class="cx"> RefPtr<API::Data> bundleParameterData;
</span><span class="cx">
</span><span class="lines">@@ -153,12 +152,12 @@
</span><span class="cx"> HashMap<WebCore::SessionID, HashMap<unsigned, double>> plugInAutoStartOriginHashes;
</span><span class="cx"> Vector<String> plugInAutoStartOrigins;
</span><span class="cx">
</span><del>- bool memoryCacheDisabled { false };
</del><ins>+ bool memoryCacheDisabled;
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(SERVICE_CONTROLS)
</span><del>- bool hasImageServices { false };
- bool hasSelectionServices { false };
- bool hasRichContentServices { false };
</del><ins>+ bool hasImageServices;
+ bool hasSelectionServices;
+ bool hasRichContentServices;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(NETSCAPE_PLUGIN_API)
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedmacRemoteLayerTreeTransactionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -87,8 +87,7 @@
</span><span class="cx"> FiltersChanged = 1LLU << 32,
</span><span class="cx"> AnimationsChanged = 1LLU << 33,
</span><span class="cx"> EdgeAntialiasingMaskChanged = 1LLU << 34,
</span><del>- ContentsFormatFlagsChanged = 1LLU << 35,
- CustomAppearanceChanged = 1LLU << 36,
</del><ins>+ CustomAppearanceChanged = 1LLU << 35,
</ins><span class="cx"> };
</span><span class="cx"> typedef uint64_t LayerChange;
</span><span class="cx">
</span><span class="lines">@@ -154,7 +153,6 @@
</span><span class="cx"> WebCore::Color backgroundColor;
</span><span class="cx"> WebCore::Color borderColor;
</span><span class="cx"> unsigned edgeAntialiasingMask;
</span><del>- WebCore::PlatformCALayer::ContentsFormatFlags contentsFormatFlags;
</del><span class="cx"> WebCore::GraphicsLayer::CustomAppearance customAppearance;
</span><span class="cx"> WebCore::PlatformCALayer::FilterType minificationFilter;
</span><span class="cx"> WebCore::PlatformCALayer::FilterType magnificationFilter;
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedmacRemoteLayerTreeTransactionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -211,9 +211,6 @@
</span><span class="cx"> if (changedProperties & OpaqueChanged)
</span><span class="cx"> encoder << opaque;
</span><span class="cx">
</span><del>- if (changedProperties & ContentsFormatFlagsChanged)
- encoder << contentsFormatFlags;
-
</del><span class="cx"> if (changedProperties & MaskLayerChanged)
</span><span class="cx"> encoder << maskLayerID;
</span><span class="cx">
</span><span class="lines">@@ -377,11 +374,6 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (result.changedProperties & ContentsFormatFlagsChanged) {
- if (!decoder.decode(result.contentsFormatFlags))
- return false;
- }
-
</del><span class="cx"> if (result.changedProperties & MaskLayerChanged) {
</span><span class="cx"> if (!decoder.decode(result.maskLayerID))
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -347,11 +347,6 @@
</span><span class="cx"> toImpl(contextRef)->setShouldUseFontSmoothing(useFontSmoothing);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WKContextEnableSmoothedLayerText(WKContextRef contextRef, bool smoothedLayerText)
-{
- toImpl(contextRef)->enableSmoothedLayerText(smoothedLayerText);
-}
-
</del><span class="cx"> void WKContextSetAdditionalPluginsDirectory(WKContextRef contextRef, WKStringRef pluginsDirectory)
</span><span class="cx"> {
</span><span class="cx"> #if ENABLE(NETSCAPE_PLUGIN_API)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKContextPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -50,8 +50,6 @@
</span><span class="cx">
</span><span class="cx"> WK_EXPORT void WKContextSetShouldUseFontSmoothing(WKContextRef context, bool useFontSmoothing);
</span><span class="cx">
</span><del>-WK_EXPORT void WKContextEnableSmoothedLayerText(WKContextRef context, bool);
-
</del><span class="cx"> WK_EXPORT void WKContextRegisterURLSchemeAsSecure(WKContextRef context, WKStringRef urlScheme);
</span><span class="cx">
</span><span class="cx"> WK_EXPORT void WKContextRegisterURLSchemeAsBypassingContentSecurityPolicy(WKContextRef context, WKStringRef urlScheme);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -148,6 +148,8 @@
</span><span class="cx"> , m_visitedLinkStore(VisitedLinkStore::create())
</span><span class="cx"> , m_visitedLinksPopulated(false)
</span><span class="cx"> , m_plugInAutoStartProvider(this)
</span><ins>+ , m_alwaysUsesComplexTextCodePath(false)
+ , m_shouldUseFontSmoothing(true)
</ins><span class="cx"> , m_memorySamplerEnabled(false)
</span><span class="cx"> , m_memorySamplerInterval(1400.0)
</span><span class="cx"> , m_websiteDataStore(m_configuration->shouldHaveLegacyDataStore() ? API::WebsiteDataStore::create(legacyWebsiteDataStoreConfiguration(m_configuration)).ptr() : nullptr)
</span><span class="lines">@@ -584,7 +586,6 @@
</span><span class="cx">
</span><span class="cx"> parameters.shouldAlwaysUseComplexTextCodePath = m_alwaysUsesComplexTextCodePath;
</span><span class="cx"> parameters.shouldUseFontSmoothing = m_shouldUseFontSmoothing;
</span><del>- parameters.enabledSmoothedLayerText = m_enabledSmoothedLayerText;
</del><span class="cx">
</span><span class="cx"> // FIXME: This leaves UI process and WebProcess disagreeing about the state if the client hasn't set the path.
</span><span class="cx"> // iconDatabasePath is non-empty by default, but m_iconDatabase isn't enabled in UI process unless setDatabasePath is called explicitly.
</span><span class="lines">@@ -871,12 +872,6 @@
</span><span class="cx"> sendToAllProcesses(Messages::WebProcess::SetShouldUseFontSmoothing(useFontSmoothing));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessPool::enableSmoothedLayerText(bool enableSmoothedText)
-{
- m_enabledSmoothedLayerText = enableSmoothedText;
- sendToAllProcesses(Messages::WebProcess::EnableSmoothedLayerText(enableSmoothedText));
-}
-
</del><span class="cx"> void WebProcessPool::registerURLSchemeAsEmptyDocument(const String& urlScheme)
</span><span class="cx"> {
</span><span class="cx"> m_schemesToRegisterAsEmptyDocument.add(urlScheme);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -191,7 +191,6 @@
</span><span class="cx">
</span><span class="cx"> void setAlwaysUsesComplexTextCodePath(bool);
</span><span class="cx"> void setShouldUseFontSmoothing(bool);
</span><del>- void enableSmoothedLayerText(bool);
</del><span class="cx">
</span><span class="cx"> void registerURLSchemeAsEmptyDocument(const String&);
</span><span class="cx"> void registerURLSchemeAsSecure(const String&);
</span><span class="lines">@@ -464,9 +463,8 @@
</span><span class="cx"> HashSet<String> m_schemesToRegisterAsCachePartitioned;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- bool m_alwaysUsesComplexTextCodePath { false };
- bool m_shouldUseFontSmoothing { true };
- bool m_enabledSmoothedLayerText { true };
</del><ins>+ bool m_alwaysUsesComplexTextCodePath;
+ bool m_shouldUseFontSmoothing;
</ins><span class="cx">
</span><span class="cx"> Vector<String> m_fontWhitelist;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemotecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -401,20 +401,6 @@
</span><span class="cx"> m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::MaskLayerChanged);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PlatformCALayerRemote::setContentsFormat(ContentsFormatFlags formatFlags)
-{
- if (formatFlags == m_properties.contentsFormatFlags)
- return;
-
- m_properties.contentsFormatFlags = formatFlags;
- m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::ContentsFormatFlagsChanged);
-}
-
-PlatformCALayer::ContentsFormatFlags PlatformCALayerRemote::contentsFormat() const
-{
- return m_properties.contentsFormatFlags;
-}
-
</del><span class="cx"> void PlatformCALayerRemote::setClonedLayer(const PlatformCALayer* layer)
</span><span class="cx"> {
</span><span class="cx"> if (isEquivalentLayer(layer, m_properties.clonedLayerID))
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemoteh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -76,9 +76,6 @@
</span><span class="cx"> bool isOpaque() const override;
</span><span class="cx"> void setOpaque(bool) override;
</span><span class="cx">
</span><del>- void setContentsFormat(ContentsFormatFlags) override;
- ContentsFormatFlags contentsFormat() const override;
-
</del><span class="cx"> WebCore::FloatRect bounds() const override;
</span><span class="cx"> void setBounds(const WebCore::FloatRect&) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -76,7 +76,6 @@
</span><span class="cx"> #include <WebCore/FrameLoader.h>
</span><span class="cx"> #include <WebCore/GCController.h>
</span><span class="cx"> #include <WebCore/GlyphPage.h>
</span><del>-#include <WebCore/GraphicsLayer.h>
</del><span class="cx"> #include <WebCore/IconDatabase.h>
</span><span class="cx"> #include <WebCore/JSDOMWindow.h>
</span><span class="cx"> #include <WebCore/Language.h>
</span><span class="lines">@@ -344,8 +343,6 @@
</span><span class="cx"> if (parameters.shouldUseFontSmoothing)
</span><span class="cx"> setShouldUseFontSmoothing(true);
</span><span class="cx">
</span><del>- enableSmoothedLayerText(parameters.enabledSmoothedLayerText);
-
</del><span class="cx"> #if PLATFORM(COCOA) || USE(CFNETWORK)
</span><span class="cx"> SessionTracker::setIdentifierBase(parameters.uiProcessBundleIdentifier);
</span><span class="cx"> #endif
</span><span class="lines">@@ -478,11 +475,6 @@
</span><span class="cx"> WebCore::FontCascade::setShouldUseSmoothing(useFontSmoothing);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcess::enableSmoothedLayerText(bool smoothedLayerText)
-{
- WebCore::GraphicsLayer::setSmoothedLayerTextEnabled(smoothedLayerText);
-}
-
</del><span class="cx"> void WebProcess::userPreferredLanguagesChanged(const Vector<String>& languages) const
</span><span class="cx"> {
</span><span class="cx"> overrideUserPreferredLanguages(languages);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.h 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -238,8 +238,6 @@
</span><span class="cx"> void setDefaultRequestTimeoutInterval(double);
</span><span class="cx"> void setAlwaysUsesComplexTextCodePath(bool);
</span><span class="cx"> void setShouldUseFontSmoothing(bool);
</span><del>- void enableSmoothedLayerText(bool);
-
</del><span class="cx"> void setResourceLoadStatisticsEnabled(bool);
</span><span class="cx"> void userPreferredLanguagesChanged(const Vector<String>&) const;
</span><span class="cx"> void fullKeyboardAccessModeChanged(bool fullKeyboardAccessEnabled);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcessmessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.messages.in (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.messages.in 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.messages.in 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -42,7 +42,6 @@
</span><span class="cx"> SetDefaultRequestTimeoutInterval(double timeoutInterval)
</span><span class="cx"> SetAlwaysUsesComplexTextCodePath(bool alwaysUseComplexText)
</span><span class="cx"> SetShouldUseFontSmoothing(bool useFontSmoothing)
</span><del>- EnableSmoothedLayerText(bool smoothedLayerText)
</del><span class="cx"> SetResourceLoadStatisticsEnabled(bool resourceLoadStatisticsEnabled);
</span><span class="cx"> UserPreferredLanguagesChanged(Vector<String> languages)
</span><span class="cx"> FullKeyboardAccessModeChanged(bool fullKeyboardAccessEnabled)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Tools/ChangeLog 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-03-14 Chris Dumez <cdumez@apple.com>
+
+ Unreviewed, rolling out r197981.
+
+ Caused a massive PLT regression on Mac.
+
+ Reverted changeset:
+
+ "Font antialiasing (smoothing) changes when elements are
+ rendered into compositing layers"
+ https://bugs.webkit.org/show_bug.cgi?id=23364
+ http://trac.webkit.org/changeset/197981
+
</ins><span class="cx"> 2016-03-14 Dewei Zhu <dewei_zhu@apple.com>
</span><span class="cx">
</span><span class="cx"> Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -1846,7 +1846,6 @@
</span><span class="cx"> [[webView window] setAutodisplay:NO];
</span><span class="cx"> #endif
</span><span class="cx"> [webView setTracksRepaints:NO];
</span><del>- [WebView _setSmoothedLayerTextEnabled:NO];
</del><span class="cx">
</span><span class="cx"> [WebCache clearCachedCredentials];
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerTestControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (198188 => 198189)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/TestController.cpp 2016-03-15 03:51:39 UTC (rev 198188)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2016-03-15 03:53:07 UTC (rev 198189)
</span><span class="lines">@@ -717,7 +717,6 @@
</span><span class="cx"> WKPagePostMessageToInjectedBundle(TestController::singleton().mainWebView()->page(), messageName.get(), resetMessageBody.get());
</span><span class="cx">
</span><span class="cx"> WKContextSetShouldUseFontSmoothing(TestController::singleton().context(), false);
</span><del>- WKContextEnableSmoothedLayerText(TestController::singleton().context(), false);
</del><span class="cx">
</span><span class="cx"> WKContextSetCacheModel(TestController::singleton().context(), kWKCacheModelDocumentBrowser);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>