<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198181] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198181">198181</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2016-03-14 17:59:57 -0700 (Mon, 14 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/197114">r197114</a>): Crash in WebCore::MediaDevicesRequest::didCompletePermissionCheck
https://bugs.webkit.org/show_bug.cgi?id=155453
Reviewed by Eric Carlson.
<rdar://problem/24879447>
Reviewed by Dan Bates.
Further refinement to test case: Remove use of 'setTimeout', and ensure the code gets
called by using 'testRunner.waitUntilDone()'/'testRunner.notifyDone()'.
* fast/mediastream/enumerating-crash.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamenumeratingcrashhtml">trunk/LayoutTests/fast/mediastream/enumerating-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (198180 => 198181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-03-15 00:48:40 UTC (rev 198180)
+++ trunk/LayoutTests/ChangeLog 2016-03-15 00:59:57 UTC (rev 198181)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-03-14 Brent Fulgham <bfulgham@apple.com>
+
+ REGRESSION (r197114): Crash in WebCore::MediaDevicesRequest::didCompletePermissionCheck
+ https://bugs.webkit.org/show_bug.cgi?id=155453
+
+ Reviewed by Eric Carlson.
+ <rdar://problem/24879447>
+
+ Reviewed by Dan Bates.
+
+ Further refinement to test case: Remove use of 'setTimeout', and ensure the code gets
+ called by using 'testRunner.waitUntilDone()'/'testRunner.notifyDone()'.
+
+ * fast/mediastream/enumerating-crash.html:
+
</ins><span class="cx"> 2016-03-14 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Display Content Security Policy hash in details sidebar for script and style elements
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamenumeratingcrashhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/enumerating-crash.html (198180 => 198181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/enumerating-crash.html 2016-03-15 00:48:40 UTC (rev 198180)
+++ trunk/LayoutTests/fast/mediastream/enumerating-crash.html 2016-03-15 00:59:57 UTC (rev 198181)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+<!DOCTYPE html>
</ins><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> </head>
</span><span class="lines">@@ -4,28 +5,25 @@
</span><span class="cx"> <body>
</span><span class="cx"> <p>Test to ensure we don't crash when enumerating media devices. The test passes if it does not crash.</p>
</span><span class="cx"> <script>
</span><del>- if (window.testRunner)
</del><ins>+ if (window.testRunner) {
</ins><span class="cx"> testRunner.dumpAsText();
</span><ins>+ testRunner.waitUntilDone();
+ }
</ins><span class="cx"> </script>
</span><span class="cx"> </body>
</span><span class="cx"> <script>
</span><span class="cx"> function shouldNotCrash() {
</span><del>- try {
- document.addEventListener("webglcontextlost", function () {
- var x = window.navigator.mediaDevices;
- x.enumerateDevices();
- x.getUserMediaFromJS(123456789.);
- }, true);
</del><ins>+ document.addEventListener("webglcontextlost", function () {
+ var mediaDevices = window.navigator.mediaDevices;
+ mediaDevices.enumerateDevices();
+ mediaDevices.getUserMedia(123456789.);
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, true);
</ins><span class="cx">
</span><del>- var dispatch_fn = function() {
- var evt = document.createEvent("Event");
- evt.initEvent("webglcontextlost", false, false);
- document.dispatchEvent(evt);
- }
- window.setInterval(dispatch_fn, 202);
- } catch(e) {
- document.write("Errlog shouldNotCrash: " + e.name + ": " + e.message + "<br>");
- }
</del><ins>+ var event = document.createEvent("Event");
+ event.initEvent("webglcontextlost", false, false);
+ document.dispatchEvent(event);
</ins><span class="cx"> }
</span><span class="cx"> shouldNotCrash();
</span><span class="cx"> </script>
</span></span></pre>
</div>
</div>
</body>
</html>