<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198081] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198081">198081</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2016-03-13 12:02:57 -0700 (Sun, 13 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/198079">r198079</a>): Windows build broke because of "%PRId64" format specifier
Source/WebCore:
* platform/network/ParsedContentRange.cpp: Add #include
<wtf/StdLibExtras.h> and remove local definition of "PRId64".
Source/WTF:
This fixes the following build failure in WebCore for Windows:
C:\Source\WebCore\page\DOMTimer.cpp(396): error C2146: syntax error: missing ')' before identifier 'PRId64' [C:\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj]
C:\Source\WebCore\page\DOMTimer.cpp(399): error C2146: syntax error: missing ')' before identifier 'PRId64' [C:\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj]
* wtf/StdLibExtras.h: Define "PRId64" for Windows here so it may
be shared. This should fix DOMTimer.cpp after <a href="http://trac.webkit.org/projects/webkit/changeset/198079">r198079</a> since it
already includes StdLibExtras.h.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfStdLibExtrash">trunk/Source/WTF/wtf/StdLibExtras.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkParsedContentRangecpp">trunk/Source/WebCore/platform/network/ParsedContentRange.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (198080 => 198081)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-03-13 15:46:50 UTC (rev 198080)
+++ trunk/Source/WTF/ChangeLog 2016-03-13 19:02:57 UTC (rev 198081)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-03-13 David Kilzer <ddkilzer@apple.com>
+
+ REGRESSION (r198079): Windows build broke because of "%PRId64" format specifier
+
+ This fixes the following build failure in WebCore for Windows:
+ C:\Source\WebCore\page\DOMTimer.cpp(396): error C2146: syntax error: missing ')' before identifier 'PRId64' [C:\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj]
+ C:\Source\WebCore\page\DOMTimer.cpp(399): error C2146: syntax error: missing ')' before identifier 'PRId64' [C:\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj]
+
+ * wtf/StdLibExtras.h: Define "PRId64" for Windows here so it may
+ be shared. This should fix DOMTimer.cpp after r198079 since it
+ already includes StdLibExtras.h.
+
</ins><span class="cx"> 2016-03-11 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
</span></span></pre></div>
<a id="trunkSourceWTFwtfStdLibExtrash"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/StdLibExtras.h (198080 => 198081)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/StdLibExtras.h 2016-03-13 15:46:50 UTC (rev 198080)
+++ trunk/Source/WTF/wtf/StdLibExtras.h 2016-03-13 19:02:57 UTC (rev 198081)
</span><span class="lines">@@ -70,6 +70,11 @@
</span><span class="cx"> #define STRINGIZE(exp) #exp
</span><span class="cx"> #define STRINGIZE_VALUE_OF(exp) STRINGIZE(exp)
</span><span class="cx">
</span><ins>+// Make "PRId64" format specifier work for Visual C++ on Windows.
+#if OS(WINDOWS) && !defined(PRId64)
+#define PRId64 "lld"
+#endif
+
</ins><span class="cx"> /*
</span><span class="cx"> * The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
</span><span class="cx"> * sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM with GCC:
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (198080 => 198081)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-13 15:46:50 UTC (rev 198080)
+++ trunk/Source/WebCore/ChangeLog 2016-03-13 19:02:57 UTC (rev 198081)
</span><span class="lines">@@ -1,3 +1,10 @@
</span><ins>+2016-03-13 David Kilzer <ddkilzer@apple.com>
+
+ REGRESSION (r198079): Windows build broke because of "%PRId64" format specifier
+
+ * platform/network/ParsedContentRange.cpp: Add #include
+ <wtf/StdLibExtras.h> and remove local definition of "PRId64".
+
</ins><span class="cx"> 2016-03-13 Joonghun Park <jh718.park@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL] Fix debug build error since r197690. Unreviewed.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkParsedContentRangecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ParsedContentRange.cpp (198080 => 198081)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ParsedContentRange.cpp 2016-03-13 15:46:50 UTC (rev 198080)
+++ trunk/Source/WebCore/platform/network/ParsedContentRange.cpp 2016-03-13 19:02:57 UTC (rev 198081)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "ParsedContentRange.h"
</span><span class="cx">
</span><ins>+#include <wtf/StdLibExtras.h>
</ins><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -121,10 +122,6 @@
</span><span class="cx"> m_isValid = areContentRangeValuesValid(m_firstBytePosition, m_lastBytePosition, m_instanceLength);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-#if OS(WINDOWS) && !defined(PRId64)
-#define PRId64 "lld"
-#endif
-
</del><span class="cx"> String ParsedContentRange::headerValue() const
</span><span class="cx"> {
</span><span class="cx"> if (!m_isValid)
</span></span></pre>
</div>
</div>
</body>
</html>