<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198065] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198065">198065</a></dd>
<dt>Author</dt> <dd>nvasilyev@apple.com</dd>
<dt>Date</dt> <dd>2016-03-12 10:16:32 -0800 (Sat, 12 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Convert toolbar and tab bar to position absolute to reduce repaint areas
https://bugs.webkit.org/show_bug.cgi?id=155386
Reviewed by Timothy Hatcher.
Using CSS flexbox causes unnecessary large repaints.
Convert top level elements (.toolbar, .tab-bar, #main)
from flexbox to "position: absolute".
* UserInterface/Views/Main.css:
(#main):
* UserInterface/Views/TabBar.css:
(.tab-bar):
* UserInterface/Views/Toolbar.css:
(.toolbar):
(body.mac-platform:not(.docked, .mavericks) .toolbar):
(body.mac-platform:not(.docked, .mavericks)):
(body.window-inactive:not(.mavericks) .toolbar): Deleted.
* UserInterface/Views/Variables.css:
(:root):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsMaincss">trunk/Source/WebInspectorUI/UserInterface/Views/Main.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTabBarcss">trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsToolbarcss">trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVariablescss">trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (198064 => 198065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-12 17:30:41 UTC (rev 198064)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-12 18:16:32 UTC (rev 198065)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2016-03-12 Nikita Vasilyev <nvasilyev@apple.com>
+
+ Web Inspector: Convert toolbar and tab bar to position absolute to reduce repaint areas
+ https://bugs.webkit.org/show_bug.cgi?id=155386
+
+ Reviewed by Timothy Hatcher.
+
+ Using CSS flexbox causes unnecessary large repaints.
+ Convert top level elements (.toolbar, .tab-bar, #main)
+ from flexbox to "position: absolute".
+
+ * UserInterface/Views/Main.css:
+ (#main):
+ * UserInterface/Views/TabBar.css:
+ (.tab-bar):
+ * UserInterface/Views/Toolbar.css:
+ (.toolbar):
+ (body.mac-platform:not(.docked, .mavericks) .toolbar):
+ (body.mac-platform:not(.docked, .mavericks)):
+ (body.window-inactive:not(.mavericks) .toolbar): Deleted.
+ * UserInterface/Views/Variables.css:
+ (:root):
+
</ins><span class="cx"> 2016-03-11 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Wrong TimelineOverview height after switching from Events to Frames
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsMaincss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Main.css (198064 => 198065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2016-03-12 17:30:41 UTC (rev 198064)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2016-03-12 18:16:32 UTC (rev 198065)
</span><span class="lines">@@ -28,9 +28,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> body {
</span><del>- display: flex;
- flex-direction: column;
-
</del><span class="cx"> font-family: -apple-system, sans-serif;
</span><span class="cx"> font-size: 11px;
</span><span class="cx">
</span><span class="lines">@@ -118,14 +115,17 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #main {
</span><ins>+ position: absolute;
+ top: calc(var(--toolbar-height) + var(--tab-bar-height));
+ left: 0;
+ right: 0;
+ bottom: 0;
+
</ins><span class="cx"> display: flex;
</span><del>- flex: 1;
- min-height: 0;
</del><span class="cx">
</span><span class="cx"> background-color: white;
</span><span class="cx">
</span><span class="cx"> /* The position and z-index are needed to make negative z-index work in the DOM tree. */
</span><del>- position: relative;
</del><span class="cx"> z-index: 0;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTabBarcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css (198064 => 198065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css 2016-03-12 17:30:41 UTC (rev 198064)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css 2016-03-12 18:16:32 UTC (rev 198065)
</span><span class="lines">@@ -24,19 +24,21 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> .tab-bar {
</span><ins>+ position: absolute;
+ top: var(--toolbar-height);
+ left: 0;
+ right: 0;
+ height: var(--tab-bar-height);
+
</ins><span class="cx"> display: flex;
</span><span class="cx"> justify-content: space-between;
</span><span class="cx"> flex-wrap: wrap;
</span><span class="cx">
</span><del>- position: relative;
-
</del><span class="cx"> border-bottom: 1px solid hsl(0, 0%, 65%);
</span><span class="cx">
</span><span class="cx"> background-image: linear-gradient(to bottom, hsl(0, 0%, 78%), hsl(0, 0%, 72%));
</span><span class="cx"> background-size: 100% 200%;
</span><span class="cx">
</span><del>- height: 24px;
-
</del><span class="cx"> white-space: nowrap;
</span><span class="cx"> overflow: hidden;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsToolbarcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (198064 => 198065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2016-03-12 17:30:41 UTC (rev 198064)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2016-03-12 18:16:32 UTC (rev 198065)
</span><span class="lines">@@ -24,16 +24,20 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> .toolbar {
</span><ins>+ position: absolute;
+ top: 0;
+ left: 0;
+ right: 0;
+ height: var(--toolbar-height);
+
</ins><span class="cx"> display: flex;
</span><ins>+ padding-top: 3px;
+ padding-bottom: 3px;
</ins><span class="cx">
</span><span class="cx"> white-space: nowrap;
</span><span class="cx"> overflow: hidden;
</span><span class="cx">
</span><span class="cx"> outline: none;
</span><del>-
- padding-top: 3px;
- padding-bottom: 3px;
- height: 36px;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> body:not(.mavericks) .toolbar,
</span><span class="lines">@@ -49,9 +53,12 @@
</span><span class="cx">
</span><span class="cx"> body.mac-platform:not(.docked, .mavericks) .toolbar {
</span><span class="cx"> padding-top: 21px;
</span><del>- height: 54px;
</del><span class="cx"> }
</span><span class="cx">
</span><ins>+body.mac-platform:not(.docked, .mavericks) {
+ --toolbar-height: 54px;
+}
+
</ins><span class="cx"> .toolbar .control-section {
</span><span class="cx"> display: flex;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVariablescss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css (198064 => 198065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2016-03-12 17:30:41 UTC (rev 198064)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2016-03-12 18:16:32 UTC (rev 198065)
</span><span class="lines">@@ -69,6 +69,9 @@
</span><span class="cx"> --memory-max-comparison-stroke-color: hsl(220, 10%, 55%);
</span><span class="cx"> --memory-extra-fill-color: hsl(211, 53%, 70%);
</span><span class="cx"> --memory-extra-stroke-color: hsl(211, 53%, 55%);
</span><ins>+
+ --toolbar-height: 36px;
+ --tab-bar-height: 24px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> body.window-inactive {
</span></span></pre>
</div>
</div>
</body>
</html>