<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198000] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198000">198000</a></dd>
<dt>Author</dt> <dd>keith_miller@apple.com</dd>
<dt>Date</dt> <dd>2016-03-10 23:13:10 -0800 (Thu, 10 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ES6] Make RegExp.prototype.toString spec compliant
https://bugs.webkit.org/show_bug.cgi?id=155341
Patch by Saam barati <sbarati@apple.com> on 2016-03-10
Reviewed by Filip Pizlo.
Before we were directly calling into the flagsString
function. Instead, we must get the "flags" property
of the thisObject. This will usually call into the flags
getter, but not always. Specifically, you can you a Proxy
to observe this behavior.
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
(JSC::regExpProtoGetterGlobal):
* tests/es6.yaml:
* tests/es6/Proxy_internal_get_calls_RegExp.prototype.toString.js: Added.
(test.get var):
(test.):
* tests/stress/regexp-prototype-tostring.js: Added.
(assert):
(test):
(test.get var):
(test.):
(let.handler.get switch):
(let.handler):
(get test):
(test.get RegExp):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreAPItestsTypedArrayCTestcpp">trunk/Source/JavaScriptCore/API/tests/TypedArrayCTest.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreAPItestsTypedArrayCTestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/tests/TypedArrayCTest.cpp (197999 => 198000)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/tests/TypedArrayCTest.cpp 2016-03-11 07:10:18 UTC (rev 197999)
+++ trunk/Source/JavaScriptCore/API/tests/TypedArrayCTest.cpp 2016-03-11 07:13:10 UTC (rev 198000)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> 10,
</span><span class="cx"> };
</span><span class="cx">
</span><del>-static const unsigned byteSizes[kJSTypedArrayTypeNone] =
</del><ins>+static const unsigned byteSizes[kJSTypedArrayTypeArrayBuffer] =
</ins><span class="cx"> {
</span><span class="cx"> 1, // kJSTypedArrayTypeInt8Array
</span><span class="cx"> 2, // kJSTypedArrayTypeInt16Array
</span><span class="lines">@@ -59,9 +59,8 @@
</span><span class="cx"> 8, // kJSTypedArrayTypeFloat64Array
</span><span class="cx"> };
</span><span class="cx">
</span><del>-static const char* typeToString[kJSTypedArrayTypeNone] =
</del><ins>+static const char* typeToString[kJSTypedArrayTypeArrayBuffer] =
</ins><span class="cx"> {
</span><del>-
</del><span class="cx"> "kJSTypedArrayTypeInt8Array",
</span><span class="cx"> "kJSTypedArrayTypeInt16Array",
</span><span class="cx"> "kJSTypedArrayTypeInt32Array",
</span><span class="lines">@@ -91,7 +90,7 @@
</span><span class="cx">
</span><span class="cx"> static int testAccess(JSGlobalContextRef context, JSObjectRef typedArray, JSTypedArrayType type, unsigned elementLength, void* expectedPtr = nullptr, JSObjectRef expectedBuffer = nullptr, unsigned expectedOffset = 0)
</span><span class="cx"> {
</span><del>- JSValueRef exception;
</del><ins>+ JSValueRef exception = nullptr;
</ins><span class="cx"> // Test typedArray basic functions.
</span><span class="cx"> JSTypedArrayType actualType = JSValueGetTypedArrayType(context, typedArray, &exception);
</span><span class="cx"> if (type != actualType || exception) {
</span><span class="lines">@@ -151,7 +150,7 @@
</span><span class="cx"> static int testConstructors(JSGlobalContextRef context, JSTypedArrayType type, unsigned length)
</span><span class="cx"> {
</span><span class="cx"> int failed = 0;
</span><del>- JSValueRef exception;
</del><ins>+ JSValueRef exception = nullptr;
</ins><span class="cx"> JSObjectRef typedArray;
</span><span class="cx">
</span><span class="cx"> // Test create with length.
</span><span class="lines">@@ -210,7 +209,7 @@
</span><span class="cx"> static int forEachTypedArrayType(const Functor& functor)
</span><span class="cx"> {
</span><span class="cx"> int failed = 0;
</span><del>- for (unsigned i = 0; i < kJSTypedArrayTypeNone; i++)
</del><ins>+ for (unsigned i = 0; i < kJSTypedArrayTypeArrayBuffer; i++)
</ins><span class="cx"> failed = failed || functor(static_cast<JSTypedArrayType>(i));
</span><span class="cx"> return failed;
</span><span class="cx"> }
</span><span class="lines">@@ -262,6 +261,8 @@
</span><span class="cx">
</span><span class="cx"> if (!failed)
</span><span class="cx"> printf("PASS: Typed Array C API Tests.\n");
</span><ins>+ else
+ printf("FAIL: Some Typed Array C API Tests failed.\n");
</ins><span class="cx">
</span><span class="cx"> return failed;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (197999 => 198000)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-03-11 07:10:18 UTC (rev 197999)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-03-11 07:13:10 UTC (rev 198000)
</span><span class="lines">@@ -57,6 +57,16 @@
</span><span class="cx">
</span><span class="cx"> 2016-03-10 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><ins>+ Unreviewed, fix testapi.
+
+ * API/tests/TypedArrayCTest.cpp:
+ (testAccess):
+ (testConstructors):
+ (forEachTypedArrayType):
+ (testTypedArrayCAPI):
+
+2016-03-10 Keith Miller <keith_miller@apple.com>
+
</ins><span class="cx"> Unreviewed, build fix for r197983, hopefully.
</span><span class="cx">
</span><span class="cx"> * API/WebKitAvailability.h:
</span></span></pre>
</div>
</div>
</body>
</html>