<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197784] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197784">197784</a></dd>
<dt>Author</dt> <dd>tonikitoo@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-08 10:57:54 -0800 (Tue, 08 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Scrolling does not work when the mouse down is handled by a node
https://bugs.webkit.org/show_bug.cgi?id=19033
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/events/prevent-default-prevents-interaction-with-scrollbars-.html
When a mouse press/down event happens on a scrollbar area, but event
is default prevented in the document level**, for example, event does not get
properly passed to scrollbars, although it should.
Problem started long ago with <a href="http://trac.webkit.org/projects/webkit/changeset/17770">r17770</a>, and was improved with <a href="http://trac.webkit.org/projects/webkit/changeset/19596">r19596</a>.
However, years later, the way Scrollbar* is obtained is still currently different
weither event is default prevented or not.
Patch uniforms the logic for both cases, and fixes the bug.
Note: code before used to look like
if (swallowEvent) {
<code>
} else {
<bleh>
<foo>
}
.. and now looks like
if (!swallowEvent)
<bleh>
<code>
if (!swallowEvent)
<foo>
** e.g. document.addEventListener('mousedown', function (e) { e.preventDefault(); });
* page/EventHandler.cpp:
(WebCore::scrollbarForMouseEvent):
(WebCore::EventHandler::handleMousePressEvent):
LayoutTests:
* fast/events/prevent-default-prevents-interaction-with-scrollbars-expected.txt: Added.
* fast/events/prevent-default-prevents-interaction-with-scrollbars.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlercpp">trunk/Source/WebCore/page/EventHandler.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventspreventdefaultpreventsinteractionwithscrollbarsexpectedtxt">trunk/LayoutTests/fast/events/prevent-default-prevents-interaction-with-scrollbars-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspreventdefaultpreventsinteractionwithscrollbarshtml">trunk/LayoutTests/fast/events/prevent-default-prevents-interaction-with-scrollbars.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (197783 => 197784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-03-08 18:54:05 UTC (rev 197783)
+++ trunk/LayoutTests/ChangeLog 2016-03-08 18:57:54 UTC (rev 197784)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-03-08 Antonio Gomes <tonikitoo@webkit.org>
+
+ Scrolling does not work when the mouse down is handled by a node
+ https://bugs.webkit.org/show_bug.cgi?id=19033
+
+ Reviewed by Simon Fraser.
+
+ * fast/events/prevent-default-prevents-interaction-with-scrollbars-expected.txt: Added.
+ * fast/events/prevent-default-prevents-interaction-with-scrollbars.html: Added.
+
</ins><span class="cx"> 2016-03-08 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Regular Expression canonicalization tables for Unicode need to be updated to use Unicode CaseFolding.txt
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspreventdefaultpreventsinteractionwithscrollbarsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/prevent-default-prevents-interaction-with-scrollbars-expected.txt (0 => 197784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/prevent-default-prevents-interaction-with-scrollbars-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/prevent-default-prevents-interaction-with-scrollbars-expected.txt 2016-03-08 18:57:54 UTC (rev 197784)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+This is a test for https://bugs.webkit.org/show_bug.cgi?id=19033
+
+PASS: scrollbar click could scroll document.
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventspreventdefaultpreventsinteractionwithscrollbarshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/prevent-default-prevents-interaction-with-scrollbars.html (0 => 197784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/prevent-default-prevents-interaction-with-scrollbars.html (rev 0)
+++ trunk/LayoutTests/fast/events/prevent-default-prevents-interaction-with-scrollbars.html 2016-03-08 18:57:54 UTC (rev 197784)
</span><span class="lines">@@ -0,0 +1,45 @@
</span><ins>+<!DOCTYPE html>
+<head>
+ <style type="text/css" media="screen">
+ body {
+ height: 5000px;
+ }
+ </style>
+ <script>
+ function scrollTest()
+ {
+ eventSender.mouseMoveTo(window.innerWidth - 4, window.innerHeight - 20);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+
+ setTimeout('checkOffset();', 100);
+ }
+
+ function checkOffset()
+ {
+ var scroller = document.scrollingElement;
+ if (scroller.scrollTop != 0)
+ document.getElementById('result').textContent = "PASS: scrollbar click could scroll document.";
+ else
+ document.getElementById('result').textContent = "FAIL: scrollbar click could not scroll document.";
+ testRunner.notifyDone();
+ }
+
+ function startTest()
+ {
+ if (window.eventSender) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+
+ setTimeout(scrollTest, 0);
+ }
+ }
+
+ window.addEventListener('load', startTest, false);
+ document.addEventListener('mousedown', function (e) { e.preventDefault(); });
+ </script>
+</head>
+<body style="min-height: 5000px">
+ <p>This is a test for <a href="https://bugs.webkit.org/show_bug.cgi?id=19033">https://bugs.webkit.org/show_bug.cgi?id=19033</a></p>
+ <div id="result"></div>
+</body>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (197783 => 197784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-08 18:54:05 UTC (rev 197783)
+++ trunk/Source/WebCore/ChangeLog 2016-03-08 18:57:54 UTC (rev 197784)
</span><span class="lines">@@ -1,3 +1,47 @@
</span><ins>+2016-03-08 Antonio Gomes <tonikitoo@webkit.org>
+
+ Scrolling does not work when the mouse down is handled by a node
+ https://bugs.webkit.org/show_bug.cgi?id=19033
+
+ Reviewed by Simon Fraser.
+
+ Test: fast/events/prevent-default-prevents-interaction-with-scrollbars-.html
+
+ When a mouse press/down event happens on a scrollbar area, but event
+ is default prevented in the document level**, for example, event does not get
+ properly passed to scrollbars, although it should.
+
+ Problem started long ago with r17770, and was improved with r19596.
+ However, years later, the way Scrollbar* is obtained is still currently different
+ weither event is default prevented or not.
+
+ Patch uniforms the logic for both cases, and fixes the bug.
+
+ Note: code before used to look like
+
+ if (swallowEvent) {
+ <code>
+ } else {
+ <bleh>
+ <foo>
+ }
+
+ .. and now looks like
+
+ if (!swallowEvent)
+ <bleh>
+
+ <code>
+
+ if (!swallowEvent)
+ <foo>
+
+ ** e.g. document.addEventListener('mousedown', function (e) { e.preventDefault(); });
+
+ * page/EventHandler.cpp:
+ (WebCore::scrollbarForMouseEvent):
+ (WebCore::EventHandler::handleMousePressEvent):
+
</ins><span class="cx"> 2016-03-08 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed Windows build fix after r197728.
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.cpp (197783 => 197784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.cpp 2016-03-08 18:54:05 UTC (rev 197783)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2016-03-08 18:57:54 UTC (rev 197784)
</span><span class="lines">@@ -1577,6 +1577,16 @@
</span><span class="cx"> return view ? view->windowToContents(windowPoint) : windowPoint;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static Scrollbar* scrollbarForMouseEvent(const MouseEventWithHitTestResults& mouseEvent, FrameView* view)
+{
+ if (view) {
+ if (auto* scrollbar = view->scrollbarAtPoint(mouseEvent.event().position()))
+ return scrollbar;
+ }
+ return mouseEvent.scrollbar();
+
+}
+
</ins><span class="cx"> bool EventHandler::handleMousePressEvent(const PlatformMouseEvent& platformMouseEvent)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<FrameView> protector(m_frame.view());
</span><span class="lines">@@ -1693,35 +1703,25 @@
</span><span class="cx"> m_lastScrollbarUnderMouse = nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (swallowEvent) {
- // scrollbars should get events anyway, even disabled controls might be scrollable
- Scrollbar* scrollbar = mouseEvent.scrollbar();
-
- updateLastScrollbarUnderMouse(scrollbar, true);
-
- if (scrollbar)
- passMousePressEventToScrollbar(mouseEvent, scrollbar);
- } else {
</del><ins>+ if (!swallowEvent) {
</ins><span class="cx"> // Refetch the event target node if it currently is the shadow node inside an <input> element.
</span><span class="cx"> // If a mouse event handler changes the input element type to one that has a widget associated,
</span><span class="cx"> // we'd like to EventHandler::handleMousePressEvent to pass the event to the widget and thus the
</span><span class="cx"> // event target node can't still be the shadow node.
</span><span class="cx"> if (is<ShadowRoot>(*mouseEvent.targetNode()) && is<HTMLInputElement>(*downcast<ShadowRoot>(*mouseEvent.targetNode()).host()))
</span><span class="cx"> mouseEvent = m_frame.document()->prepareMouseEvent(HitTestRequest(), documentPoint, platformMouseEvent);
</span><ins>+ }
</ins><span class="cx">
</span><del>- FrameView* view = m_frame.view();
- Scrollbar* scrollbar = view ? view->scrollbarAtPoint(platformMouseEvent.position()) : 0;
- if (!scrollbar)
- scrollbar = mouseEvent.scrollbar();
</del><ins>+ Scrollbar* scrollbar = scrollbarForMouseEvent(mouseEvent, m_frame.view());
+ updateLastScrollbarUnderMouse(scrollbar, true);
</ins><span class="cx">
</span><del>- updateLastScrollbarUnderMouse(scrollbar, true);
-
- if (scrollbar && passMousePressEventToScrollbar(mouseEvent, scrollbar))
</del><ins>+ bool passedToScrollbar = scrollbar && passMousePressEventToScrollbar(mouseEvent, scrollbar);
+ if (!swallowEvent) {
+ if (passedToScrollbar)
</ins><span class="cx"> swallowEvent = true;
</span><span class="cx"> else
</span><span class="cx"> swallowEvent = handleMousePressEvent(mouseEvent);
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> return swallowEvent;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>