<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197836] releases/WebKitGTK/webkit-2.12/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197836">197836</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-08 23:28:12 -0800 (Tue, 08 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/197547">r197547</a> - Unreviewed, remove test with flaky timeout that doesn't test anything anymore. This test
was relevant back when arguments got torn off; something that we don't do anymore. It
uses a loop that waits for the top-tier compiler to compile it. We don't write tests
like that anymore.
* js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Removed.
* js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Removed.
* js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsjsdfgosrexitbetweencreateandtearoffargumentsexpectedtxt">releases/WebKitGTK/webkit-2.12/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsjsdfgosrexitbetweencreateandtearoffargumentshtml">releases/WebKitGTK/webkit-2.12/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments.html</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsjsscripttestsdfgosrexitbetweencreateandtearoffargumentsjs">releases/WebKitGTK/webkit-2.12/LayoutTests/js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (197835 => 197836)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-03-09 06:27:54 UTC (rev 197835)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-03-09 07:28:12 UTC (rev 197836)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-03-03 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><ins>+ Unreviewed, remove test with flaky timeout that doesn't test anything anymore. This test
+ was relevant back when arguments got torn off; something that we don't do anymore. It
+ uses a loop that waits for the top-tier compiler to compile it. We don't write tests
+ like that anymore.
+
+ * js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Removed.
+ * js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Removed.
+ * js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Removed.
+
+2016-03-03 Filip Pizlo <fpizlo@apple.com>
+
</ins><span class="cx"> DFG should be able to compile StringReplace
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=154979
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsjsdfgosrexitbetweencreateandtearoffargumentsexpectedtxt"></a>
<div class="delfile"><h4>Deleted: releases/WebKitGTK/webkit-2.12/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt (197835 => 197836)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt 2016-03-09 06:27:54 UTC (rev 197835)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt 2016-03-09 07:28:12 UTC (rev 197836)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-Tests that an OSR exit between CreateArguments and TearOffArguments does not cause a crash.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsjsdfgosrexitbetweencreateandtearoffargumentshtml"></a>
<div class="delfile"><h4>Deleted: releases/WebKitGTK/webkit-2.12/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments.html (197835 => 197836)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments.html 2016-03-09 06:27:54 UTC (rev 197835)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments.html 2016-03-09 07:28:12 UTC (rev 197836)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../resources/js-test-pre.js"></script>
-</head>
-<body>
-<script src="script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js"></script>
-<script src="../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsjsscripttestsdfgosrexitbetweencreateandtearoffargumentsjs"></a>
<div class="delfile"><h4>Deleted: releases/WebKitGTK/webkit-2.12/LayoutTests/js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js (197835 => 197836)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js 2016-03-09 06:27:54 UTC (rev 197835)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js 2016-03-09 07:28:12 UTC (rev 197836)
</span><span class="lines">@@ -1,22 +0,0 @@
</span><del>-description(
-"Tests that an OSR exit between CreateArguments and TearOffArguments does not cause a crash."
-);
-
-var foo = function(x) {
- function goo(reenter) {
- var captured = x;
- return x + 5;
- }
-
- // Loop here to get this function to DFG compile. Because we have captured vars,
- // there will be a forced OSR exit on entry should we call this function again.
- // We need this OSR exit to occur between the DFG generated code for
- // CreateArguments and TearOffArguments in order for the bug to trigger a crash.
- // See https://webkit.org/b/140743.
- while (!dfgCompiled({f: foo}))
- goo();
- return arguments;
-}
-
-foo(1); // First call to get the DFG to compile foo() due to its big loop.
-foo(1); // Second call to trigger the OSR exit and verify that we don't crash.
</del></span></pre>
</div>
</div>
</body>
</html>