<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197654] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197654">197654</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-06 18:43:09 -0800 (Sun, 06 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[JSC] Remove a superfluous Move in front of every double unboxing
https://bugs.webkit.org/show_bug.cgi?id=155064
Reviewed by Saam Barati.
Double unboxing was always doing:
Move source, scratch
Add64 tag, scratch
IntToDouble scratch, fp
We do not need to "Move" to copy the source.
Both x86 and ARM64 have an efficient 3 operands Add instruction.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileDoubleRep):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::unboxDouble):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::unboxDoubleWithoutAssertions):
(JSC::AssemblyHelpers::unboxDouble):
(JSC::AssemblyHelpers::unboxDoubleNonDestructive):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSpeculativeJITcpp">trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSpeculativeJITh">trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h</a></li>
<li><a href="#trunkSourceJavaScriptCorejitAssemblyHelpersh">trunk/Source/JavaScriptCore/jit/AssemblyHelpers.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (197653 => 197654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-03-07 02:42:43 UTC (rev 197653)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-03-07 02:43:09 UTC (rev 197654)
</span><span class="lines">@@ -1,5 +1,31 @@
</span><span class="cx"> 2016-03-06 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><ins>+ [JSC] Remove a superfluous Move in front of every double unboxing
+ https://bugs.webkit.org/show_bug.cgi?id=155064
+
+ Reviewed by Saam Barati.
+
+ Double unboxing was always doing:
+ Move source, scratch
+ Add64 tag, scratch
+ IntToDouble scratch, fp
+
+ We do not need to "Move" to copy the source.
+ Both x86 and ARM64 have an efficient 3 operands Add instruction.
+
+ * dfg/DFGSpeculativeJIT.cpp:
+ (JSC::DFG::SpeculativeJIT::compileValueToInt32):
+ (JSC::DFG::SpeculativeJIT::compileDoubleRep):
+ (JSC::DFG::SpeculativeJIT::speculateRealNumber):
+ * dfg/DFGSpeculativeJIT.h:
+ (JSC::DFG::SpeculativeJIT::unboxDouble):
+ * jit/AssemblyHelpers.h:
+ (JSC::AssemblyHelpers::unboxDoubleWithoutAssertions):
+ (JSC::AssemblyHelpers::unboxDouble):
+ (JSC::AssemblyHelpers::unboxDoubleNonDestructive):
+
+2016-03-06 Benjamin Poulain <benjamin@webkit.org>
+
</ins><span class="cx"> [JSC] Use 3 operands Add in more places
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=155082
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSpeculativeJITcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp (197653 => 197654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp 2016-03-07 02:42:43 UTC (rev 197653)
+++ trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp 2016-03-07 02:43:09 UTC (rev 197654)
</span><span class="lines">@@ -2013,8 +2013,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // First, if we get here we have a double encoded as a JSValue
</span><del>- m_jit.move(gpr, resultGpr);
- unboxDouble(resultGpr, fpr);
</del><ins>+ unboxDouble(gpr, resultGpr, fpr);
</ins><span class="cx">
</span><span class="cx"> silentSpillAllRegisters(resultGpr);
</span><span class="cx"> callOperation(toInt32, resultGpr, fpr);
</span><span class="lines">@@ -2171,8 +2170,7 @@
</span><span class="cx"> #if USE(JSVALUE64)
</span><span class="cx"> GPRTemporary temp(this);
</span><span class="cx"> GPRReg tempGPR = temp.gpr();
</span><del>- m_jit.move(op1Regs.gpr(), tempGPR);
- m_jit.unboxDoubleWithoutAssertions(tempGPR, resultFPR);
</del><ins>+ m_jit.unboxDoubleWithoutAssertions(op1Regs.gpr(), tempGPR, resultFPR);
</ins><span class="cx"> #else
</span><span class="cx"> FPRTemporary temp(this);
</span><span class="cx"> FPRReg tempFPR = temp.fpr();
</span><span class="lines">@@ -2249,9 +2247,8 @@
</span><span class="cx"> JSValueRegs(op1GPR), node->child1(), SpecBytecodeNumber,
</span><span class="cx"> m_jit.branchTest64(MacroAssembler::Zero, op1GPR, GPRInfo::tagTypeNumberRegister));
</span><span class="cx"> }
</span><del>-
- m_jit.move(op1GPR, tempGPR);
- unboxDouble(tempGPR, resultFPR);
</del><ins>+
+ unboxDouble(op1GPR, tempGPR, resultFPR);
</ins><span class="cx"> done.append(m_jit.jump());
</span><span class="cx">
</span><span class="cx"> isInteger.link(&m_jit);
</span><span class="lines">@@ -6583,8 +6580,7 @@
</span><span class="cx"> #if USE(JSVALUE64)
</span><span class="cx"> GPRTemporary temp(this);
</span><span class="cx"> GPRReg tempGPR = temp.gpr();
</span><del>- m_jit.move(op1Regs.gpr(), tempGPR);
- m_jit.unboxDoubleWithoutAssertions(tempGPR, resultFPR);
</del><ins>+ m_jit.unboxDoubleWithoutAssertions(op1Regs.gpr(), tempGPR, resultFPR);
</ins><span class="cx"> #else
</span><span class="cx"> FPRTemporary temp(this);
</span><span class="cx"> FPRReg tempFPR = temp.fpr();
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSpeculativeJITh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h (197653 => 197654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h 2016-03-07 02:42:43 UTC (rev 197653)
+++ trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h 2016-03-07 02:43:09 UTC (rev 197654)
</span><span class="lines">@@ -452,9 +452,9 @@
</span><span class="cx"> {
</span><span class="cx"> return m_jit.boxDouble(fpr, gpr);
</span><span class="cx"> }
</span><del>- FPRReg unboxDouble(GPRReg gpr, FPRReg fpr)
</del><ins>+ FPRReg unboxDouble(GPRReg gpr, GPRReg resultGPR, FPRReg fpr)
</ins><span class="cx"> {
</span><del>- return m_jit.unboxDouble(gpr, fpr);
</del><ins>+ return m_jit.unboxDouble(gpr, resultGPR, fpr);
</ins><span class="cx"> }
</span><span class="cx"> GPRReg boxDouble(FPRReg fpr)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitAssemblyHelpersh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/AssemblyHelpers.h (197653 => 197654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/AssemblyHelpers.h 2016-03-07 02:42:43 UTC (rev 197653)
+++ trunk/Source/JavaScriptCore/jit/AssemblyHelpers.h 2016-03-07 02:43:09 UTC (rev 197654)
</span><span class="lines">@@ -1037,16 +1037,16 @@
</span><span class="cx"> jitAssertIsJSDouble(gpr);
</span><span class="cx"> return gpr;
</span><span class="cx"> }
</span><del>- FPRReg unboxDoubleWithoutAssertions(GPRReg gpr, FPRReg fpr)
</del><ins>+ FPRReg unboxDoubleWithoutAssertions(GPRReg gpr, GPRReg resultGPR, FPRReg fpr)
</ins><span class="cx"> {
</span><del>- add64(GPRInfo::tagTypeNumberRegister, gpr);
- move64ToDouble(gpr, fpr);
</del><ins>+ add64(GPRInfo::tagTypeNumberRegister, gpr, resultGPR);
+ move64ToDouble(resultGPR, fpr);
</ins><span class="cx"> return fpr;
</span><span class="cx"> }
</span><del>- FPRReg unboxDouble(GPRReg gpr, FPRReg fpr)
</del><ins>+ FPRReg unboxDouble(GPRReg gpr, GPRReg resultGPR, FPRReg fpr)
</ins><span class="cx"> {
</span><span class="cx"> jitAssertIsJSDouble(gpr);
</span><del>- return unboxDoubleWithoutAssertions(gpr, fpr);
</del><ins>+ return unboxDoubleWithoutAssertions(gpr, resultGPR, fpr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void boxDouble(FPRReg fpr, JSValueRegs regs)
</span><span class="lines">@@ -1054,10 +1054,9 @@
</span><span class="cx"> boxDouble(fpr, regs.gpr());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- void unboxDoubleNonDestructive(JSValueRegs regs, FPRReg destFPR, GPRReg scratchGPR, FPRReg)
</del><ins>+ void unboxDoubleNonDestructive(JSValueRegs regs, FPRReg destFPR, GPRReg resultGPR, FPRReg)
</ins><span class="cx"> {
</span><del>- move(regs.payloadGPR(), scratchGPR);
- unboxDouble(scratchGPR, destFPR);
</del><ins>+ unboxDouble(regs.payloadGPR(), resultGPR, destFPR);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Here are possible arrangements of source, target, scratch:
</span></span></pre>
</div>
</div>
</body>
</html>