<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197481] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197481">197481</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-02 17:20:56 -0800 (Wed, 02 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>HTML parser instantiates a custom element inside a template element with a wrong owner document
https://bugs.webkit.org/show_bug.cgi?id=154936
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Updated the expected results for newly passing test cases.
One test case in additions-to-parsing-xhtml-documents/node-document.html starts failing due to a bug in the test.
The bug in the test will be fixed in https://github.com/w3c/web-platform-tests/pull/2651
Finally, remove duplicated HTML template element tests in html-templates since there is a new copy under
web-platform-tests/html/semantics/scripting-1/the-template-element/. Unfortunately, we can't remove
html-templates/parsing-html-templates/ because we haven't imported web-platform-tests/html/syntax yet.
* html-templates/additions-to-parsing-xhtml-documents: Removed.
* html-templates/additions-to-serializing-xhtml-documents: Removed.
* html-templates/additions-to-the-css-user-agent-style-sheet: Removed.
* html-templates/additions-to-the-steps-to-clone-a-node: Removed.
* html-templates/definitions: Removed.
* html-templates/innerhtml-on-templates: Removed.
* html-templates/serializing-html-templates: Removed.
* html-templates/template-element: Removed.
* web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document.html:
* web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-001-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/node-document-changes-expected.txt:
Source/WebCore:
The bug was caused by our implementation following the old spec which didn't create a appropriate template
contents owner document [1] for a document without a browsing context. The new spec no longer has this clause,
and we should be always creating the appropriate template contents owner document unless the document itself
is an appropriate template contents owner document for another document (comes up in nested template elements).
No new tests since the behavior change is covered by existing tests.
[1] https://html.spec.whatwg.org/#appropriate-template-contents-owner-document
* dom/Document.h:
(WebCore::Document::templateDocument):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsscripting1thetemplateelementadditionstoparsingxhtmldocumentsnodedocumentexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsscripting1thetemplateelementdefinitionstemplatecontentsownertest001expectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-001-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsscripting1thetemplateelementtemplateelementnodedocumentchangesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/node-document-changes-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li>trunk/LayoutTests/imported/w3c/html-templates/additions-to-parsing-xhtml-documents/</li>
<li>trunk/LayoutTests/imported/w3c/html-templates/additions-to-serializing-xhtml-documents/</li>
<li>trunk/LayoutTests/imported/w3c/html-templates/additions-to-the-css-user-agent-style-sheet/</li>
<li>trunk/LayoutTests/imported/w3c/html-templates/additions-to-the-steps-to-clone-a-node/</li>
<li>trunk/LayoutTests/imported/w3c/html-templates/definitions/</li>
<li>trunk/LayoutTests/imported/w3c/html-templates/innerhtml-on-templates/</li>
<li>trunk/LayoutTests/imported/w3c/html-templates/serializing-html-templates/</li>
<li>trunk/LayoutTests/imported/w3c/html-templates/template-element/</li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (197480 => 197481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-03 01:19:51 UTC (rev 197480)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-03 01:20:56 UTC (rev 197481)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2016-03-02 Ryosuke Niwa <rniwa@webkit.org>
+
+ HTML parser instantiates a custom element inside a template element with a wrong owner document
+ https://bugs.webkit.org/show_bug.cgi?id=154936
+
+ Reviewed by Chris Dumez.
+
+ Updated the expected results for newly passing test cases.
+
+ One test case in additions-to-parsing-xhtml-documents/node-document.html starts failing due to a bug in the test.
+ The bug in the test will be fixed in https://github.com/w3c/web-platform-tests/pull/2651
+
+ Finally, remove duplicated HTML template element tests in html-templates since there is a new copy under
+ web-platform-tests/html/semantics/scripting-1/the-template-element/. Unfortunately, we can't remove
+ html-templates/parsing-html-templates/ because we haven't imported web-platform-tests/html/syntax yet.
+
+ * html-templates/additions-to-parsing-xhtml-documents: Removed.
+ * html-templates/additions-to-serializing-xhtml-documents: Removed.
+ * html-templates/additions-to-the-css-user-agent-style-sheet: Removed.
+ * html-templates/additions-to-the-steps-to-clone-a-node: Removed.
+ * html-templates/definitions: Removed.
+ * html-templates/innerhtml-on-templates: Removed.
+ * html-templates/serializing-html-templates: Removed.
+ * html-templates/template-element: Removed.
+ * web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document.html:
+ * web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-001-expected.txt:
+ * web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/node-document-changes-expected.txt:
+
</ins><span class="cx"> 2016-03-02 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Align HTMLInputElement.maxLength with the specification
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsscripting1thetemplateelementadditionstoparsingxhtmldocumentsnodedocumentexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document-expected.txt (197480 => 197481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document-expected.txt 2016-03-03 01:19:51 UTC (rev 197480)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document-expected.txt 2016-03-03 01:20:56 UTC (rev 197481)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx">
</span><del>-PASS Parsing XHTML: Node's node document must be set to that of the element to which it will be appended. Test empty template
</del><ins>+FAIL Parsing XHTML: Node's node document must be set to that of the element to which it will be appended. Test empty template assert_equals: Wrong template content owner document expected Document node with 2 children but got Document node with 0 children
</ins><span class="cx"> PASS Parsing XHTML: Node's node document must be set to that of the element to which it will be appended. Test not empty template
</span><span class="cx"> PASS Parsing XHTML: Node's node document must be set to that of the element to which it will be appended. Test nested templates
</span><span class="cx"> PASS Parsing XHTML: Node's node document must be set to that of the element to which it will be appended. Test loading XHTML document from a file
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsscripting1thetemplateelementdefinitionstemplatecontentsownertest001expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-001-expected.txt (197480 => 197481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-001-expected.txt 2016-03-03 01:19:51 UTC (rev 197480)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-001-expected.txt 2016-03-03 01:20:56 UTC (rev 197481)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx">
</span><del>-FAIL Test the template contents owner document when enclosing document has no browsing content. Template element is created by createElement() assert_not_equals: Wrong template content owner got disallowed value Document node with 2 children
-FAIL Test the template contents owner document when enclosing document has no browsing content. Template element is created by innerHTML assert_not_equals: Wrong template content owner got disallowed value Document node with 2 children
</del><ins>+PASS Test the template contents owner document when enclosing document has no browsing content. Template element is created by createElement()
+PASS Test the template contents owner document when enclosing document has no browsing content. Template element is created by innerHTML
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsscripting1thetemplateelementtemplateelementnodedocumentchangesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/node-document-changes-expected.txt (197480 => 197481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/node-document-changes-expected.txt 2016-03-03 01:19:51 UTC (rev 197480)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/node-document-changes-expected.txt 2016-03-03 01:20:56 UTC (rev 197481)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx">
</span><del>-FAIL Changing of template element's node document. Test that ownerDocument of an empty template and its content changes assert_not_equals: Wrong template content owner document got disallowed value Document node with 2 children
-FAIL Changing of template element's node document. Test that ownerDocument of a not empty template and its content changes assert_not_equals: Wrong template content owner document got disallowed value Document node with 2 children
-FAIL Changing of template element's node document. Test that ownerDocument of nested template and its content changes assert_not_equals: Wrong template content owner document got disallowed value Document node with 2 children
</del><ins>+PASS Changing of template element's node document. Test that ownerDocument of an empty template and its content changes
+PASS Changing of template element's node document. Test that ownerDocument of a not empty template and its content changes
+PASS Changing of template element's node document. Test that ownerDocument of nested template and its content changes
</ins><span class="cx"> PASS Changing of template element's node document. Test document loaded from a file
</span><span class="cx"> PASS Changing of template element's node document. Adobt template element into a document that has a browsing context
</span><span class="cx"> PASS Changing of template element's node document. Test the case when both old and new owner documents of template element have browsing context
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (197480 => 197481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-03 01:19:51 UTC (rev 197480)
+++ trunk/Source/WebCore/ChangeLog 2016-03-03 01:20:56 UTC (rev 197481)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-03-02 Ryosuke Niwa <rniwa@webkit.org>
+
+ HTML parser instantiates a custom element inside a template element with a wrong owner document
+ https://bugs.webkit.org/show_bug.cgi?id=154936
+
+ Reviewed by Chris Dumez.
+
+ The bug was caused by our implementation following the old spec which didn't create a appropriate template
+ contents owner document [1] for a document without a browsing context. The new spec no longer has this clause,
+ and we should be always creating the appropriate template contents owner document unless the document itself
+ is an appropriate template contents owner document for another document (comes up in nested template elements).
+
+ No new tests since the behavior change is covered by existing tests.
+
+ [1] https://html.spec.whatwg.org/#appropriate-template-contents-owner-document
+
+ * dom/Document.h:
+ (WebCore::Document::templateDocument):
+
</ins><span class="cx"> 2016-03-02 Gavin Barraclough <barraclough@apple.com>
</span><span class="cx">
</span><span class="cx"> PageThrottler should apply hysteresis to media activity
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (197480 => 197481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2016-03-03 01:19:51 UTC (rev 197480)
+++ trunk/Source/WebCore/dom/Document.h 2016-03-03 01:20:56 UTC (rev 197481)
</span><span class="lines">@@ -1798,11 +1798,7 @@
</span><span class="cx"> #if ENABLE(TEMPLATE_ELEMENT)
</span><span class="cx"> inline const Document* Document::templateDocument() const
</span><span class="cx"> {
</span><del>- // If DOCUMENT does not have a browsing context, Let TEMPLATE CONTENTS OWNER be DOCUMENT and abort these steps.
- if (!m_frame)
- return this;
-
- return m_templateDocument.get();
</del><ins>+ return m_templateDocumentHost ? this : m_templateDocument.get();
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>