<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197486] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197486">197486</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2016-03-02 19:30:30 -0800 (Wed, 02 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Paint table borders on empty cells even in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=154928
Reviewed by David Hyatt.
Enable border painting for empty cells unless 'empty-cells: hide' is set.
This is inline with FF and Chrome behaviour.
Source/WebCore:
Test: fast/table/border-on-empty-table-cells-quirks-mode.html
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations):
LayoutTests:
* fast/table/border-on-empty-table-cells-quirks-mode-expected.html: Added.
* fast/table/border-on-empty-table-cells-quirks-mode.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasttabletablecellbordernodoctypeexpectedhtml">trunk/LayoutTests/fast/table/table-cell-border-no-doctype-expected.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTableCellcpp">trunk/Source/WebCore/rendering/RenderTableCell.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasttableborderonemptytablecellsquirksmodeexpectedhtml">trunk/LayoutTests/fast/table/border-on-empty-table-cells-quirks-mode-expected.html</a></li>
<li><a href="#trunkLayoutTestsfasttableborderonemptytablecellsquirksmodehtml">trunk/LayoutTests/fast/table/border-on-empty-table-cells-quirks-mode.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (197485 => 197486)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-03-03 02:06:18 UTC (rev 197485)
+++ trunk/LayoutTests/ChangeLog 2016-03-03 03:30:30 UTC (rev 197486)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-03-02 Zalan Bujtas <zalan@apple.com>
+
+ Paint table borders on empty cells even in quirks mode.
+ https://bugs.webkit.org/show_bug.cgi?id=154928
+
+ Reviewed by David Hyatt.
+
+ Enable border painting for empty cells unless 'empty-cells: hide' is set.
+ This is inline with FF and Chrome behaviour.
+
+ * fast/table/border-on-empty-table-cells-quirks-mode-expected.html: Added.
+ * fast/table/border-on-empty-table-cells-quirks-mode.html: Added.
+
</ins><span class="cx"> 2016-03-02 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking storage/indexeddb/odd-strings.html as flaky on mac-wk1
</span></span></pre></div>
<a id="trunkLayoutTestsfasttableborderonemptytablecellsquirksmodeexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/table/border-on-empty-table-cells-quirks-mode-expected.html (0 => 197486)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/table/border-on-empty-table-cells-quirks-mode-expected.html (rev 0)
+++ trunk/LayoutTests/fast/table/border-on-empty-table-cells-quirks-mode-expected.html 2016-03-03 03:30:30 UTC (rev 197486)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<html>
+<head>
+<title>This tests that we paint borders on empty table cells even in quirks mode.</title>
+<style>
+div {
+ position: absolute;
+ border: 1px solid green;
+ height: 48px;
+ width: 52px;
+}
+</style>
+</head>
+<body>
+<div style="left: 10px; top: 10px"></div>
+<div style="left: 10px; top: 62px"></div>
+<div style="left: 10px; top: 168px"></div>
+<div style="left: 10px; top: 222px"></div>
+<div style="left: 10px; top: 274px"></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfasttableborderonemptytablecellsquirksmodehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/table/border-on-empty-table-cells-quirks-mode.html (0 => 197486)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/table/border-on-empty-table-cells-quirks-mode.html (rev 0)
+++ trunk/LayoutTests/fast/table/border-on-empty-table-cells-quirks-mode.html 2016-03-03 03:30:30 UTC (rev 197486)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<html>
+<head>
+<title>This tests that we paint borders on empty table cells even in quirks mode.</title>
+<style>
+td {
+ border: 1px solid green;
+ height: 50px;
+ width: 50px;
+}
+</style>
+</head>
+<body>
+ <table style="empty-cells: show"><tr><td></td></tr><tr><td>&nbsp</td></tr></table>
+ <table style="empty-cells: hide"><tr><td></td></tr><tr><td>&nbsp</td></tr></table>
+ <table><tr><td></td></tr><tr><td>&nbsp</td></tr></table>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfasttabletablecellbordernodoctypeexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/table/table-cell-border-no-doctype-expected.html (197485 => 197486)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/table/table-cell-border-no-doctype-expected.html 2016-03-03 02:06:18 UTC (rev 197485)
+++ trunk/LayoutTests/fast/table/table-cell-border-no-doctype-expected.html 2016-03-03 03:30:30 UTC (rev 197486)
</span><span class="lines">@@ -13,14 +13,14 @@
</span><span class="cx"> <table>
</span><span class="cx"> <tr>
</span><span class="cx"> <td width="50%" style=" border: 1px solid red;background-color: yellow;"><p></p></td>
</span><del>- <td width="50%" style=" border: none"></td>
</del><ins>+ <td width="50%" style=" border: 1px solid red;"></td>
</ins><span class="cx"> </tr>
</span><span class="cx"> </table>
</span><span class="cx"> </br>
</span><span class="cx"> <table>
</span><span class="cx"> <tr>
</span><span class="cx"> <td width="50%" style=" border: 1px solid red;background-color: yellow;"><p></p></td>
</span><del>- <td width="50%" style=" border: none"></td>
</del><ins>+ <td width="50%" style=" border: 1px solid red;"></td>
</ins><span class="cx"> </tr>
</span><span class="cx"> </table>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (197485 => 197486)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-03 02:06:18 UTC (rev 197485)
+++ trunk/Source/WebCore/ChangeLog 2016-03-03 03:30:30 UTC (rev 197486)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-03-02 Zalan Bujtas <zalan@apple.com>
+
+ Paint table borders on empty cells even in quirks mode.
+ https://bugs.webkit.org/show_bug.cgi?id=154928
+
+ Reviewed by David Hyatt.
+
+ Enable border painting for empty cells unless 'empty-cells: hide' is set.
+ This is inline with FF and Chrome behaviour.
+
+ Test: fast/table/border-on-empty-table-cells-quirks-mode.html
+
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::paintBoxDecorations):
+
</ins><span class="cx"> 2016-03-02 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> HTML parser instantiates a custom element inside a template element with a wrong owner document
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTableCellcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTableCell.cpp (197485 => 197486)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTableCell.cpp 2016-03-03 02:06:18 UTC (rev 197485)
+++ trunk/Source/WebCore/rendering/RenderTableCell.cpp 2016-03-03 03:30:30 UTC (rev 197486)
</span><span class="lines">@@ -1277,8 +1277,8 @@
</span><span class="cx"> if (!paintInfo.shouldPaintWithinRoot(*this))
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- RenderTable* tableElt = table();
- if (!tableElt->collapseBorders() && style().emptyCells() == HIDE && !firstChild())
</del><ins>+ RenderTable* table = this->table();
+ if (!table->collapseBorders() && style().emptyCells() == HIDE && !firstChild())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> LayoutRect paintRect = LayoutRect(paintOffset, frameRect().size());
</span><span class="lines">@@ -1289,7 +1289,7 @@
</span><span class="cx">
</span><span class="cx"> paintBoxShadow(paintInfo, paintRect, style(), Inset);
</span><span class="cx">
</span><del>- if (!style().hasBorder() || tableElt->collapseBorders() || (!firstChild() && document().inQuirksMode()))
</del><ins>+ if (!style().hasBorder() || table->collapseBorders())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> paintBorder(paintInfo, paintRect, style());
</span></span></pre>
</div>
</div>
</body>
</html>