<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197354] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197354">197354</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-02-29 09:32:18 -0800 (Mon, 29 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Align td.rowSpan / td.colSpan with the specification
https://bugs.webkit.org/show_bug.cgi?id=154803
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
* web-platform-tests/html/dom/reflection-tabular-expected.txt:
Source/WebCore:
Align td.rowSpan / td.colSpan with the specification:
- https://html.spec.whatwg.org/multipage/tables.html#htmltablecellelement
- https://html.spec.whatwg.org/multipage/tables.html#dom-tdth-colspan
- https://html.spec.whatwg.org/multipage/tables.html#dom-tdth-rowspan
In particular, the following changes were made:
- Change type from 'long' to 'unsigned long'.
- Use HTML rules for parsing unsigned integers:
- https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-non-negative-integers
- Use 1 as default value when the input value is out of range instead
of 0 when setting.
- rowspan is still clamped to [1, 8190] internally but we now expose the
unclamped value to JS as this is an internal restriction. The same is
done for a colSpan value of 0, we expose 0 to the Web but clamp to 1
internally.
No new tests, already covered by existing test.
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::colSpan):
(WebCore::HTMLTableCellElement::rowSpan):
(WebCore::HTMLTableCellElement::rowSpanForBindings):
(WebCore::HTMLTableCellElement::setColSpan):
(WebCore::HTMLTableCellElement::setRowSpanForBindings):
(WebCore::HTMLTableCellElement::axis): Deleted.
(WebCore::HTMLTableCellElement::headers): Deleted.
* html/HTMLTableCellElement.h:
* html/HTMLTableCellElement.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectiontabularexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableCellElementcpp">trunk/Source/WebCore/html/HTMLTableCellElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableCellElementh">trunk/Source/WebCore/html/HTMLTableCellElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableCellElementidl">trunk/Source/WebCore/html/HTMLTableCellElement.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (197353 => 197354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-29 17:28:13 UTC (rev 197353)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-29 17:32:18 UTC (rev 197354)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-02-29 Chris Dumez <cdumez@apple.com>
+
+ Align td.rowSpan / td.colSpan with the specification
+ https://bugs.webkit.org/show_bug.cgi?id=154803
+
+ Reviewed by Darin Adler.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-tabular-expected.txt:
+
</ins><span class="cx"> 2016-02-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Parse HTMLOLElement.start as per the HTML spec
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectiontabularexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt (197353 => 197354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt 2016-02-29 17:28:13 UTC (rev 197353)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt 2016-02-29 17:32:18 UTC (rev 197354)
</span><span class="lines">@@ -9871,7 +9871,7 @@
</span><span class="cx"> PASS td.colSpan: setAttribute() to -1 followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to -1 followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to 0 followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to 0 followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.colSpan: setAttribute() to 0 followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to 1 followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to 1 followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to 257 followed by getAttribute()
</span><span class="lines">@@ -9889,15 +9889,15 @@
</span><span class="cx"> PASS td.colSpan: setAttribute() to "-1" followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to "-1" followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to "-0" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to "-0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.colSpan: setAttribute() to "-0" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to "0" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to "0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.colSpan: setAttribute() to "0" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to "1" followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to "1" followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to "\t7" followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to "\t7" followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to "\v7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to "\v7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to "\v7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to "\f7" followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to "\f7" followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><span class="lines">@@ -9911,39 +9911,39 @@
</span><span class="cx"> PASS td.colSpan: setAttribute() to "\r7" followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to "\r7" followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to "
7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to "
7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to "
7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to "
7" followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to "
7" followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to "7" followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to "7" followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get
</span><span class="cx"> PASS td.colSpan: setAttribute() to undefined followed by getAttribute()
</span><span class="lines">@@ -9970,7 +9970,7 @@
</span><span class="cx"> PASS td.colSpan: setAttribute() to object "3" followed by IDL get
</span><span class="cx"> PASS td.colSpan: IDL set to 0 should not throw
</span><span class="cx"> PASS td.colSpan: IDL set to 0 followed by getAttribute()
</span><del>-FAIL td.colSpan: IDL set to 0 followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.colSpan: IDL set to 0 followed by IDL get
</ins><span class="cx"> PASS td.colSpan: IDL set to 1 should not throw
</span><span class="cx"> PASS td.colSpan: IDL set to 1 followed by getAttribute()
</span><span class="cx"> PASS td.colSpan: IDL set to 1 followed by IDL get
</span><span class="lines">@@ -9982,12 +9982,12 @@
</span><span class="cx"> PASS td.colSpan: IDL set to 2147483647 followed by IDL get
</span><span class="cx"> PASS td.colSpan: IDL set to "-0" should not throw
</span><span class="cx"> PASS td.colSpan: IDL set to "-0" followed by getAttribute()
</span><del>-FAIL td.colSpan: IDL set to "-0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.colSpan: IDL set to "-0" followed by IDL get
</ins><span class="cx"> PASS td.colSpan: IDL set to 2147483648 should not throw
</span><del>-FAIL td.colSpan: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "1" but got "-2147483648"
</del><ins>+PASS td.colSpan: IDL set to 2147483648 followed by getAttribute()
</ins><span class="cx"> PASS td.colSpan: IDL set to 2147483648 followed by IDL get
</span><span class="cx"> PASS td.colSpan: IDL set to 4294967295 should not throw
</span><del>-FAIL td.colSpan: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "1" but got "-1"
</del><ins>+PASS td.colSpan: IDL set to 4294967295 followed by getAttribute()
</ins><span class="cx"> PASS td.colSpan: IDL set to 4294967295 followed by IDL get
</span><span class="cx"> PASS td.rowSpan: typeof IDL attribute
</span><span class="cx"> PASS td.rowSpan: IDL get with DOM attribute unset
</span><span class="lines">@@ -10000,13 +10000,13 @@
</span><span class="cx"> PASS td.rowSpan: setAttribute() to -1 followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to -1 followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to 0 followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to 0 followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.rowSpan: setAttribute() to 0 followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to 1 followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to 1 followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to 257 followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to 257 followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to 2147483647 followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to 2147483647 followed by IDL get assert_equals: expected 2147483647 but got 8190
</del><ins>+PASS td.rowSpan: setAttribute() to 2147483647 followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to 2147483648 followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to 2147483648 followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to 4294967295 followed by getAttribute()
</span><span class="lines">@@ -10018,15 +10018,15 @@
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "-1" followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "-1" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "-0" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to "-0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.rowSpan: setAttribute() to "-0" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to "0" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to "0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.rowSpan: setAttribute() to "0" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to "1" followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "1" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "\t7" followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "\t7" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "\v7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to "\v7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to "\v7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to "\f7" followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "\f7" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><span class="lines">@@ -10040,39 +10040,39 @@
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "\r7" followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "\r7" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "
7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to "
7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to "
7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to "
7" followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "
7" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to "7" followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to "7" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL td.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS td.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get
</span><span class="cx"> PASS td.rowSpan: setAttribute() to undefined followed by getAttribute()
</span><span class="lines">@@ -10099,7 +10099,7 @@
</span><span class="cx"> PASS td.rowSpan: setAttribute() to object "3" followed by IDL get
</span><span class="cx"> PASS td.rowSpan: IDL set to 0 should not throw
</span><span class="cx"> PASS td.rowSpan: IDL set to 0 followed by getAttribute()
</span><del>-FAIL td.rowSpan: IDL set to 0 followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.rowSpan: IDL set to 0 followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: IDL set to 1 should not throw
</span><span class="cx"> PASS td.rowSpan: IDL set to 1 followed by getAttribute()
</span><span class="cx"> PASS td.rowSpan: IDL set to 1 followed by IDL get
</span><span class="lines">@@ -10108,15 +10108,15 @@
</span><span class="cx"> PASS td.rowSpan: IDL set to 257 followed by IDL get
</span><span class="cx"> PASS td.rowSpan: IDL set to 2147483647 should not throw
</span><span class="cx"> PASS td.rowSpan: IDL set to 2147483647 followed by getAttribute()
</span><del>-FAIL td.rowSpan: IDL set to 2147483647 followed by IDL get assert_equals: expected 2147483647 but got 8190
</del><ins>+PASS td.rowSpan: IDL set to 2147483647 followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: IDL set to "-0" should not throw
</span><span class="cx"> PASS td.rowSpan: IDL set to "-0" followed by getAttribute()
</span><del>-FAIL td.rowSpan: IDL set to "-0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS td.rowSpan: IDL set to "-0" followed by IDL get
</ins><span class="cx"> PASS td.rowSpan: IDL set to 2147483648 should not throw
</span><del>-FAIL td.rowSpan: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "1" but got "-2147483648"
</del><ins>+PASS td.rowSpan: IDL set to 2147483648 followed by getAttribute()
</ins><span class="cx"> PASS td.rowSpan: IDL set to 2147483648 followed by IDL get
</span><span class="cx"> PASS td.rowSpan: IDL set to 4294967295 should not throw
</span><del>-FAIL td.rowSpan: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "1" but got "-1"
</del><ins>+PASS td.rowSpan: IDL set to 4294967295 followed by getAttribute()
</ins><span class="cx"> PASS td.rowSpan: IDL set to 4294967295 followed by IDL get
</span><span class="cx"> PASS td.align: typeof IDL attribute
</span><span class="cx"> PASS td.align: IDL get with DOM attribute unset
</span><span class="lines">@@ -11663,7 +11663,7 @@
</span><span class="cx"> PASS th.colSpan: setAttribute() to -1 followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to -1 followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to 0 followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to 0 followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.colSpan: setAttribute() to 0 followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to 1 followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to 1 followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to 257 followed by getAttribute()
</span><span class="lines">@@ -11681,15 +11681,15 @@
</span><span class="cx"> PASS th.colSpan: setAttribute() to "-1" followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to "-1" followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to "-0" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to "-0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.colSpan: setAttribute() to "-0" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to "0" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to "0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.colSpan: setAttribute() to "0" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to "1" followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to "1" followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to "\t7" followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to "\t7" followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to "\v7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to "\v7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to "\v7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to "\f7" followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to "\f7" followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><span class="lines">@@ -11703,39 +11703,39 @@
</span><span class="cx"> PASS th.colSpan: setAttribute() to "\r7" followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to "\r7" followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to "
7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to "
7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to "
7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to "
7" followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to "
7" followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to "7" followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to "7" followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.colSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.colSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get
</span><span class="cx"> PASS th.colSpan: setAttribute() to undefined followed by getAttribute()
</span><span class="lines">@@ -11762,7 +11762,7 @@
</span><span class="cx"> PASS th.colSpan: setAttribute() to object "3" followed by IDL get
</span><span class="cx"> PASS th.colSpan: IDL set to 0 should not throw
</span><span class="cx"> PASS th.colSpan: IDL set to 0 followed by getAttribute()
</span><del>-FAIL th.colSpan: IDL set to 0 followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.colSpan: IDL set to 0 followed by IDL get
</ins><span class="cx"> PASS th.colSpan: IDL set to 1 should not throw
</span><span class="cx"> PASS th.colSpan: IDL set to 1 followed by getAttribute()
</span><span class="cx"> PASS th.colSpan: IDL set to 1 followed by IDL get
</span><span class="lines">@@ -11774,12 +11774,12 @@
</span><span class="cx"> PASS th.colSpan: IDL set to 2147483647 followed by IDL get
</span><span class="cx"> PASS th.colSpan: IDL set to "-0" should not throw
</span><span class="cx"> PASS th.colSpan: IDL set to "-0" followed by getAttribute()
</span><del>-FAIL th.colSpan: IDL set to "-0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.colSpan: IDL set to "-0" followed by IDL get
</ins><span class="cx"> PASS th.colSpan: IDL set to 2147483648 should not throw
</span><del>-FAIL th.colSpan: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "1" but got "-2147483648"
</del><ins>+PASS th.colSpan: IDL set to 2147483648 followed by getAttribute()
</ins><span class="cx"> PASS th.colSpan: IDL set to 2147483648 followed by IDL get
</span><span class="cx"> PASS th.colSpan: IDL set to 4294967295 should not throw
</span><del>-FAIL th.colSpan: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "1" but got "-1"
</del><ins>+PASS th.colSpan: IDL set to 4294967295 followed by getAttribute()
</ins><span class="cx"> PASS th.colSpan: IDL set to 4294967295 followed by IDL get
</span><span class="cx"> PASS th.rowSpan: typeof IDL attribute
</span><span class="cx"> PASS th.rowSpan: IDL get with DOM attribute unset
</span><span class="lines">@@ -11792,13 +11792,13 @@
</span><span class="cx"> PASS th.rowSpan: setAttribute() to -1 followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to -1 followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to 0 followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to 0 followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.rowSpan: setAttribute() to 0 followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to 1 followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to 1 followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to 257 followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to 257 followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to 2147483647 followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to 2147483647 followed by IDL get assert_equals: expected 2147483647 but got 8190
</del><ins>+PASS th.rowSpan: setAttribute() to 2147483647 followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to 2147483648 followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to 2147483648 followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to 4294967295 followed by getAttribute()
</span><span class="lines">@@ -11810,15 +11810,15 @@
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "-1" followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "-1" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "-0" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to "-0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.rowSpan: setAttribute() to "-0" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to "0" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to "0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.rowSpan: setAttribute() to "0" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to "1" followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "1" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "\t7" followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "\t7" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "\v7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to "\v7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to "\v7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to "\f7" followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "\f7" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><span class="lines">@@ -11832,39 +11832,39 @@
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "\r7" followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "\r7" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "
7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to "
7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to "
7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to "
7" followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "
7" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to "7" followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to "7" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL th.rowSpan: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS th.rowSpan: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get
</span><span class="cx"> PASS th.rowSpan: setAttribute() to undefined followed by getAttribute()
</span><span class="lines">@@ -11891,7 +11891,7 @@
</span><span class="cx"> PASS th.rowSpan: setAttribute() to object "3" followed by IDL get
</span><span class="cx"> PASS th.rowSpan: IDL set to 0 should not throw
</span><span class="cx"> PASS th.rowSpan: IDL set to 0 followed by getAttribute()
</span><del>-FAIL th.rowSpan: IDL set to 0 followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.rowSpan: IDL set to 0 followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: IDL set to 1 should not throw
</span><span class="cx"> PASS th.rowSpan: IDL set to 1 followed by getAttribute()
</span><span class="cx"> PASS th.rowSpan: IDL set to 1 followed by IDL get
</span><span class="lines">@@ -11900,15 +11900,15 @@
</span><span class="cx"> PASS th.rowSpan: IDL set to 257 followed by IDL get
</span><span class="cx"> PASS th.rowSpan: IDL set to 2147483647 should not throw
</span><span class="cx"> PASS th.rowSpan: IDL set to 2147483647 followed by getAttribute()
</span><del>-FAIL th.rowSpan: IDL set to 2147483647 followed by IDL get assert_equals: expected 2147483647 but got 8190
</del><ins>+PASS th.rowSpan: IDL set to 2147483647 followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: IDL set to "-0" should not throw
</span><span class="cx"> PASS th.rowSpan: IDL set to "-0" followed by getAttribute()
</span><del>-FAIL th.rowSpan: IDL set to "-0" followed by IDL get assert_equals: expected 0 but got 1
</del><ins>+PASS th.rowSpan: IDL set to "-0" followed by IDL get
</ins><span class="cx"> PASS th.rowSpan: IDL set to 2147483648 should not throw
</span><del>-FAIL th.rowSpan: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "1" but got "-2147483648"
</del><ins>+PASS th.rowSpan: IDL set to 2147483648 followed by getAttribute()
</ins><span class="cx"> PASS th.rowSpan: IDL set to 2147483648 followed by IDL get
</span><span class="cx"> PASS th.rowSpan: IDL set to 4294967295 should not throw
</span><del>-FAIL th.rowSpan: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "1" but got "-1"
</del><ins>+PASS th.rowSpan: IDL set to 4294967295 followed by getAttribute()
</ins><span class="cx"> PASS th.rowSpan: IDL set to 4294967295 followed by IDL get
</span><span class="cx"> PASS th.align: typeof IDL attribute
</span><span class="cx"> PASS th.align: IDL get with DOM attribute unset
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (197353 => 197354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-02-29 17:28:13 UTC (rev 197353)
+++ trunk/Source/WebCore/ChangeLog 2016-02-29 17:32:18 UTC (rev 197354)
</span><span class="lines">@@ -1,5 +1,41 @@
</span><span class="cx"> 2016-02-29 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Align td.rowSpan / td.colSpan with the specification
+ https://bugs.webkit.org/show_bug.cgi?id=154803
+
+ Reviewed by Darin Adler.
+
+ Align td.rowSpan / td.colSpan with the specification:
+ - https://html.spec.whatwg.org/multipage/tables.html#htmltablecellelement
+ - https://html.spec.whatwg.org/multipage/tables.html#dom-tdth-colspan
+ - https://html.spec.whatwg.org/multipage/tables.html#dom-tdth-rowspan
+
+ In particular, the following changes were made:
+ - Change type from 'long' to 'unsigned long'.
+ - Use HTML rules for parsing unsigned integers:
+ - https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-non-negative-integers
+ - Use 1 as default value when the input value is out of range instead
+ of 0 when setting.
+ - rowspan is still clamped to [1, 8190] internally but we now expose the
+ unclamped value to JS as this is an internal restriction. The same is
+ done for a colSpan value of 0, we expose 0 to the Web but clamp to 1
+ internally.
+
+ No new tests, already covered by existing test.
+
+ * html/HTMLTableCellElement.cpp:
+ (WebCore::HTMLTableCellElement::colSpan):
+ (WebCore::HTMLTableCellElement::rowSpan):
+ (WebCore::HTMLTableCellElement::rowSpanForBindings):
+ (WebCore::HTMLTableCellElement::setColSpan):
+ (WebCore::HTMLTableCellElement::setRowSpanForBindings):
+ (WebCore::HTMLTableCellElement::axis): Deleted.
+ (WebCore::HTMLTableCellElement::headers): Deleted.
+ * html/HTMLTableCellElement.h:
+ * html/HTMLTableCellElement.idl:
+
+2016-02-29 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> [Web IDL] Add support for [TreatNullAs=EmptyString] and use it
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=154654
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableCellElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableCellElement.cpp (197353 => 197354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableCellElement.cpp 2016-02-29 17:28:13 UTC (rev 197353)
+++ trunk/Source/WebCore/html/HTMLTableCellElement.cpp 2016-02-29 17:32:18 UTC (rev 197354)
</span><span class="lines">@@ -28,14 +28,12 @@
</span><span class="cx"> #include "CSSPropertyNames.h"
</span><span class="cx"> #include "CSSValueKeywords.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><ins>+#include "HTMLParserIdioms.h"
</ins><span class="cx"> #include "HTMLTableElement.h"
</span><span class="cx"> #include "RenderTableCell.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-// Clamp rowspan at 8k to match Firefox.
-static const int maxRowspan = 8190;
-
</del><span class="cx"> using namespace HTMLNames;
</span><span class="cx">
</span><span class="cx"> HTMLTableCellElement::HTMLTableCellElement(const QualifiedName& tagName, Document& document)
</span><span class="lines">@@ -44,18 +42,28 @@
</span><span class="cx"> ASSERT(tagName == thTag || tagName == tdTag);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-int HTMLTableCellElement::colSpan() const
</del><ins>+unsigned HTMLTableCellElement::colSpan() const
</ins><span class="cx"> {
</span><del>- const AtomicString& colSpanValue = fastGetAttribute(colspanAttr);
- return std::max(1, colSpanValue.toInt());
</del><ins>+ return std::max(1u, colSpanForBindings());
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-int HTMLTableCellElement::rowSpan() const
</del><ins>+unsigned HTMLTableCellElement::colSpanForBindings() const
</ins><span class="cx"> {
</span><del>- const AtomicString& rowSpanValue = fastGetAttribute(rowspanAttr);
- return std::max(1, std::min(rowSpanValue.toInt(), maxRowspan));
</del><ins>+ return limitToOnlyHTMLNonNegative(fastGetAttribute(colspanAttr), 1u);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+unsigned HTMLTableCellElement::rowSpan() const
+{
+ static const unsigned maxRowspan = 8190;
+ // FIXME: a rowSpan equal to 0 should be allowed, and mean that the cell is to span all the remaining rows in the row group.
+ return std::max(1u, std::min(rowSpanForBindings(), maxRowspan));
+}
+
+unsigned HTMLTableCellElement::rowSpanForBindings() const
+{
+ return limitToOnlyHTMLNonNegative(fastGetAttribute(rowspanAttr), 1u);
+}
+
</ins><span class="cx"> int HTMLTableCellElement::cellIndex() const
</span><span class="cx"> {
</span><span class="cx"> int index = 0;
</span><span class="lines">@@ -131,9 +139,9 @@
</span><span class="cx"> return fastGetAttribute(axisAttr);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLTableCellElement::setColSpan(int n)
</del><ins>+void HTMLTableCellElement::setColSpanForBindings(unsigned n)
</ins><span class="cx"> {
</span><del>- setIntegralAttribute(colspanAttr, n);
</del><ins>+ setAttributeWithoutSynchronization(colspanAttr, AtomicString::number(limitToOnlyHTMLNonNegative(n, 1)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String HTMLTableCellElement::headers() const
</span><span class="lines">@@ -141,9 +149,9 @@
</span><span class="cx"> return fastGetAttribute(headersAttr);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLTableCellElement::setRowSpan(int n)
</del><ins>+void HTMLTableCellElement::setRowSpanForBindings(unsigned n)
</ins><span class="cx"> {
</span><del>- setIntegralAttribute(rowspanAttr, n);
</del><ins>+ setAttributeWithoutSynchronization(rowspanAttr, AtomicString::number(limitToOnlyHTMLNonNegative(n, 1)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String HTMLTableCellElement::scope() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableCellElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableCellElement.h (197353 => 197354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableCellElement.h 2016-02-29 17:28:13 UTC (rev 197353)
+++ trunk/Source/WebCore/html/HTMLTableCellElement.h 2016-02-29 17:32:18 UTC (rev 197354)
</span><span class="lines">@@ -33,12 +33,14 @@
</span><span class="cx"> class HTMLTableCellElement : public HTMLTablePartElement {
</span><span class="cx"> public:
</span><span class="cx"> int cellIndex() const;
</span><del>- int colSpan() const;
- int rowSpan() const;
</del><ins>+ unsigned colSpan() const;
+ unsigned colSpanForBindings() const;
+ unsigned rowSpan() const;
+ unsigned rowSpanForBindings() const;
</ins><span class="cx">
</span><span class="cx"> void setCellIndex(int);
</span><del>- void setColSpan(int);
- void setRowSpan(int);
</del><ins>+ void setColSpanForBindings(unsigned);
+ void setRowSpanForBindings(unsigned);
</ins><span class="cx">
</span><span class="cx"> String abbr() const;
</span><span class="cx"> String axis() const;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableCellElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableCellElement.idl (197353 => 197354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableCellElement.idl 2016-02-29 17:28:13 UTC (rev 197353)
+++ trunk/Source/WebCore/html/HTMLTableCellElement.idl 2016-02-29 17:32:18 UTC (rev 197354)
</span><span class="lines">@@ -25,15 +25,21 @@
</span><span class="cx"> [Reflect] attribute DOMString bgColor;
</span><span class="cx"> [Reflect=char] attribute DOMString ch;
</span><span class="cx"> [Reflect=charoff] attribute DOMString chOff;
</span><del>- attribute long colSpan;
</del><span class="cx">
</span><ins>+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C || defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT
+ [ImplementedAs=colSpanForBindings] attribute long colSpan;
+ [ImplementedAs=rowSpanForBindings] attribute long rowSpan;
+#else
+ [ImplementedAs=colSpanForBindings] attribute unsigned long colSpan;
+ [ImplementedAs=rowSpanForBindings] attribute unsigned long rowSpan;
+#endif
+
</ins><span class="cx"> // FIXME: This is supposed to be:
</span><span class="cx"> // [PutForwards=value] readonly attribute DOMTokenList headers;
</span><span class="cx"> [Reflect] attribute DOMString headers;
</span><span class="cx">
</span><span class="cx"> [Reflect] attribute DOMString height;
</span><span class="cx"> [Reflect] attribute boolean noWrap;
</span><del>- attribute long rowSpan;
</del><span class="cx"> [Reflect] attribute DOMString vAlign;
</span><span class="cx"> [Reflect] attribute DOMString width;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>