<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197307] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197307">197307</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-02-28 20:36:06 -0800 (Sun, 28 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Parse HTMLOLElement.start as per the HTML spec
https://bugs.webkit.org/show_bug.cgi?id=154802
Reviewed by Andreas Kling.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
* web-platform-tests/html/dom/reflection-grouping-expected.txt:
Source/WebCore:
Parse HTMLOLElement.start as per the HTML spec:
- https://html.spec.whatwg.org/multipage/semantics.html#dom-ol-start
- https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-integers
No new tests, already covered by existing test.
* html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::parseAttribute):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectiongroupingexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-grouping-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOListElementcpp">trunk/Source/WebCore/html/HTMLOListElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (197306 => 197307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-29 01:57:41 UTC (rev 197306)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-29 04:36:06 UTC (rev 197307)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-02-28 Chris Dumez <cdumez@apple.com>
+
+ Parse HTMLOLElement.start as per the HTML spec
+ https://bugs.webkit.org/show_bug.cgi?id=154802
+
+ Reviewed by Andreas Kling.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-grouping-expected.txt:
+
</ins><span class="cx"> 2016-02-27 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Align HTMLMarqueeElement.scrollAmount / scrollDelay with the specification
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectiongroupingexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-grouping-expected.txt (197306 => 197307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-grouping-expected.txt 2016-02-29 01:57:41 UTC (rev 197306)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-grouping-expected.txt 2016-02-29 04:36:06 UTC (rev 197307)
</span><span class="lines">@@ -4440,7 +4440,7 @@
</span><span class="cx"> PASS ol.start: setAttribute() to "\t7" followed by getAttribute()
</span><span class="cx"> PASS ol.start: setAttribute() to "\t7" followed by IDL get
</span><span class="cx"> PASS ol.start: setAttribute() to "\v7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to "\v7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to "\v7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to "\f7" followed by getAttribute()
</span><span class="cx"> PASS ol.start: setAttribute() to "\f7" followed by IDL get
</span><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><span class="lines">@@ -4454,39 +4454,39 @@
</span><span class="cx"> PASS ol.start: setAttribute() to "\r7" followed by getAttribute()
</span><span class="cx"> PASS ol.start: setAttribute() to "\r7" followed by IDL get
</span><span class="cx"> PASS ol.start: setAttribute() to "
7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to "
7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to "
7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to "
7" followed by getAttribute()
</span><span class="cx"> PASS ol.start: setAttribute() to "
7" followed by IDL get
</span><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to "7" followed by getAttribute()
</span><span class="cx"> PASS ol.start: setAttribute() to "7" followed by IDL get
</span><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by IDL get
</span><span class="cx"> PASS ol.start: setAttribute() to " 7" followed by getAttribute()
</span><del>-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
</del><ins>+PASS ol.start: setAttribute() to " 7" followed by IDL get
</ins><span class="cx"> PASS ol.start: setAttribute() to undefined followed by getAttribute()
</span><span class="cx"> PASS ol.start: setAttribute() to undefined followed by IDL get
</span><span class="cx"> PASS ol.start: setAttribute() to 1.5 followed by getAttribute()
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (197306 => 197307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-02-29 01:57:41 UTC (rev 197306)
+++ trunk/Source/WebCore/ChangeLog 2016-02-29 04:36:06 UTC (rev 197307)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-02-28 Chris Dumez <cdumez@apple.com>
+
+ Parse HTMLOLElement.start as per the HTML spec
+ https://bugs.webkit.org/show_bug.cgi?id=154802
+
+ Reviewed by Andreas Kling.
+
+ Parse HTMLOLElement.start as per the HTML spec:
+ - https://html.spec.whatwg.org/multipage/semantics.html#dom-ol-start
+ - https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-integers
+
+ No new tests, already covered by existing test.
+
+ * html/HTMLOListElement.cpp:
+ (WebCore::HTMLOListElement::parseAttribute):
+
</ins><span class="cx"> 2016-02-28 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> Reduce uses of PassRefPtr in indexeddb
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOListElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOListElement.cpp (197306 => 197307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOListElement.cpp 2016-02-29 01:57:41 UTC (rev 197306)
+++ trunk/Source/WebCore/html/HTMLOListElement.cpp 2016-02-29 04:36:06 UTC (rev 197307)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #include "CSSPropertyNames.h"
</span><span class="cx"> #include "CSSValueKeywords.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><ins>+#include "HTMLParserIdioms.h"
</ins><span class="cx"> #include "RenderListItem.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -81,10 +82,9 @@
</span><span class="cx"> {
</span><span class="cx"> if (name == startAttr) {
</span><span class="cx"> int oldStart = start();
</span><del>- bool canParse;
- int parsedStart = value.toInt(&canParse);
- m_hasExplicitStart = canParse;
- m_start = canParse ? parsedStart : 0xBADBEEF;
</del><ins>+ m_hasExplicitStart = parseHTMLInteger(value, m_start);
+ if (!m_hasExplicitStart)
+ m_start = 0xBADBEEF;
</ins><span class="cx"> if (oldStart == start())
</span><span class="cx"> return;
</span><span class="cx"> updateItemValues();
</span></span></pre>
</div>
</div>
</body>
</html>