<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197232] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197232">197232</a></dd>
<dt>Author</dt> <dd>jonlee@apple.com</dd>
<dt>Date</dt> <dd>2016-02-26 20:43:57 -0800 (Fri, 26 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Address Dean's comments in 154673.
* Animometer/developer.html:
* Animometer/resources/debug-runner/animometer.js:
* Animometer/resources/debug-runner/graph.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsAnimometerdeveloperhtml">trunk/PerformanceTests/Animometer/developer.html</a></li>
<li><a href="#trunkPerformanceTestsAnimometerresourcesdebugrunneranimometerjs">trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometerresourcesdebugrunnergraphjs">trunk/PerformanceTests/Animometer/resources/debug-runner/graph.js</a></li>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsAnimometerdeveloperhtml"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/developer.html (197231 => 197232)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/developer.html 2016-02-27 04:39:05 UTC (rev 197231)
+++ trunk/PerformanceTests/Animometer/developer.html 2016-02-27 04:43:57 UTC (rev 197232)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx"> <script src="resources/runner/tests.js"></script>
</span><span class="cx"> <script src="resources/debug-runner/tests.js" charset="utf-8"></script>
</span><span class="cx"> <script src="resources/runner/animometer.js"></script>
</span><del>- <script src="resources/debug-runner/animometer.js"></script>
</del><ins>+ <script src="resources/debug-runner/animometer.js" charset="utf-8"></script>
</ins><span class="cx">
</span><span class="cx"> <script src="resources/runner/benchmark-runner.js"></script>
</span><span class="cx"> <script src="resources/debug-runner/d3.min.js"></script>
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometerresourcesdebugrunneranimometerjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js (197231 => 197232)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js 2016-02-27 04:39:05 UTC (rev 197231)
+++ trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js 2016-02-27 04:43:57 UTC (rev 197232)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> _addGraphButton: function(td, testName, testResult, testData)
</span><span class="cx"> {
</span><span class="cx"> var button = Utilities.createElement("button", { class: "small-button" }, td);
</span><del>- button.textContent = Strings.text.graph + "...";
</del><ins>+ button.textContent = Strings.text.graph + "…";
</ins><span class="cx"> button.testName = testName;
</span><span class="cx"> button.testResult = testResult;
</span><span class="cx"> button.testData = testData;
</span><span class="lines">@@ -495,9 +495,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var dashboard = benchmarkRunnerClient.results;
</span><del>- if (dashboard.options["adjustment"] == "ramp") {
</del><ins>+ if (dashboard.options["adjustment"] == "ramp")
</ins><span class="cx"> Headers.details[3].disabled = true;
</span><del>- } else {
</del><ins>+ else {
</ins><span class="cx"> Headers.details[1].disabled = true;
</span><span class="cx"> Headers.details[4].disabled = true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometerresourcesdebugrunnergraphjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/resources/debug-runner/graph.js (197231 => 197232)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/resources/debug-runner/graph.js 2016-02-27 04:39:05 UTC (rev 197231)
+++ trunk/PerformanceTests/Animometer/resources/debug-runner/graph.js 2016-02-27 04:43:57 UTC (rev 197232)
</span><span class="lines">@@ -5,9 +5,9 @@
</span><span class="cx"> {
</span><span class="cx"> var element = document.getElementById("test-graph-data");
</span><span class="cx"> element.innerHTML = "";
</span><del>- element.testResult = testResult;
- element.testData = testData;
- element.options = options;
</del><ins>+ element._testResult = testResult;
+ element._testData = testData;
+ element._options = options;
</ins><span class="cx"> document.querySelector("hr").style.width = this.layoutCounter++ + "px";
</span><span class="cx">
</span><span class="cx"> var margins = new Insets(30, 30, 30, 40);
</span><span class="lines">@@ -561,7 +561,7 @@
</span><span class="cx">
</span><span class="cx"> onGraphTypeChanged: function() {
</span><span class="cx"> var form = document.forms["graph-type"].elements;
</span><del>- var testResult = document.getElementById("test-graph-data").testResult;
</del><ins>+ var testResult = document.getElementById("test-graph-data")._testResult;
</ins><span class="cx"> var isTimeSelected = form["graph-type"].value == "time";
</span><span class="cx">
</span><span class="cx"> benchmarkController._showOrHideNodes(isTimeSelected, "#time-graph");
</span></span></pre></div>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (197231 => 197232)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2016-02-27 04:39:05 UTC (rev 197231)
+++ trunk/PerformanceTests/ChangeLog 2016-02-27 04:43:57 UTC (rev 197232)
</span><span class="lines">@@ -1,3 +1,11 @@
</span><ins>+2016-02-26 Jon Lee <jonlee@apple.com>
+
+ Address Dean's comments in 154673.
+
+ * Animometer/developer.html:
+ * Animometer/resources/debug-runner/animometer.js:
+ * Animometer/resources/debug-runner/graph.js:
+
</ins><span class="cx"> 2016-02-25 Jon Lee <jonlee@apple.com>
</span><span class="cx">
</span><span class="cx"> Update animation benchmark and tests
</span></span></pre>
</div>
</div>
</body>
</html>