<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197108] releases/WebKitGTK/webkit-2.12/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197108">197108</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-02-25 06:29:12 -0800 (Thu, 25 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/196991">r196991</a> - Lay the groundwork for more constness in StyleResolver-related code
https://bugs.webkit.org/show_bug.cgi?id=154598
Reviewed by Antti Koivisto.
Make some of the leaf functions that are used by the style resolver take
const CSSValues, and use 'auto' more to automatically get const stack variables
when appropriate.
* css/CSSBorderImageSliceValue.h:
(WebCore::CSSBorderImageSliceValue::slices):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isQuirkValue):
* css/FontVariantBuilder.cpp:
(WebCore::extractFontVariantLigatures):
(WebCore::extractFontVariantNumeric):
(WebCore::extractFontVariantEastAsian):
* css/FontVariantBuilder.h:
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertReflection):
(WebCore::StyleBuilderConverter::convertGridAutoFlow):
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueSize):
(WebCore::StyleBuilderCustom::applyValueStroke):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::createFilterOperations):
* css/StyleResolver.h:
* css/TransformFunctions.cpp:
(WebCore::transformsForValue):
* css/TransformFunctions.h:
* rendering/style/StylePendingImage.h:
* svg/SVGLength.cpp:
(WebCore::SVGLength::fromCSSPrimitiveValue):
* svg/SVGLength.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssCSSBorderImageSliceValueh">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/CSSBorderImageSliceValue.h</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssCSSPrimitiveValueh">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/CSSPrimitiveValue.h</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssFontVariantBuildercpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/FontVariantBuilder.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssFontVariantBuilderh">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/FontVariantBuilder.h</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssStyleBuilderConverterh">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleBuilderConverter.h</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssStyleBuilderCustomh">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleBuilderCustom.h</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssStyleResolvercpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleResolver.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssStyleResolverh">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleResolver.h</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssTransformFunctionscpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/TransformFunctions.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorecssTransformFunctionsh">releases/WebKitGTK/webkit-2.12/Source/WebCore/css/TransformFunctions.h</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorerenderingstyleStylePendingImageh">releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/style/StylePendingImage.h</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoresvgSVGLengthcpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGLength.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoresvgSVGLengthh">releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGLength.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -1,3 +1,42 @@
</span><ins>+2016-02-23 Simon Fraser <simon.fraser@apple.com>
+
+ Lay the groundwork for more constness in StyleResolver-related code
+ https://bugs.webkit.org/show_bug.cgi?id=154598
+
+ Reviewed by Antti Koivisto.
+
+ Make some of the leaf functions that are used by the style resolver take
+ const CSSValues, and use 'auto' more to automatically get const stack variables
+ when appropriate.
+
+ * css/CSSBorderImageSliceValue.h:
+ (WebCore::CSSBorderImageSliceValue::slices):
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::isQuirkValue):
+ * css/FontVariantBuilder.cpp:
+ (WebCore::extractFontVariantLigatures):
+ (WebCore::extractFontVariantNumeric):
+ (WebCore::extractFontVariantEastAsian):
+ * css/FontVariantBuilder.h:
+ * css/StyleBuilderConverter.h:
+ (WebCore::StyleBuilderConverter::convertReflection):
+ (WebCore::StyleBuilderConverter::convertGridAutoFlow):
+ * css/StyleBuilderCustom.h:
+ (WebCore::StyleBuilderCustom::applyValueSize):
+ (WebCore::StyleBuilderCustom::applyValueStroke):
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
+ (WebCore::StyleResolver::colorFromPrimitiveValue):
+ (WebCore::StyleResolver::createFilterOperations):
+ * css/StyleResolver.h:
+ * css/TransformFunctions.cpp:
+ (WebCore::transformsForValue):
+ * css/TransformFunctions.h:
+ * rendering/style/StylePendingImage.h:
+ * svg/SVGLength.cpp:
+ (WebCore::SVGLength::fromCSSPrimitiveValue):
+ * svg/SVGLength.h:
+
</ins><span class="cx"> 2016-02-23 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
</span><span class="cx">
</span><span class="cx"> [SVG] Update SVG source to return string literals as ASCIILiteral and add test cases for case sensitivity
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssCSSBorderImageSliceValueh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/CSSBorderImageSliceValue.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/CSSBorderImageSliceValue.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/CSSBorderImageSliceValue.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx">
</span><span class="cx"> String customCSSText() const;
</span><span class="cx">
</span><del>- Quad* slices() { return m_slices ? m_slices->getQuadValue() : 0; }
</del><ins>+ Quad* slices() const { return m_slices ? m_slices->getQuadValue() : nullptr; }
</ins><span class="cx">
</span><span class="cx"> bool equals(const CSSBorderImageSliceValue&) const;
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssCSSPrimitiveValueh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/CSSPrimitiveValue.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/CSSPrimitiveValue.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/CSSPrimitiveValue.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -369,7 +369,7 @@
</span><span class="cx">
</span><span class="cx"> String customCSSText() const;
</span><span class="cx">
</span><del>- bool isQuirkValue() { return m_isQuirkValue; }
</del><ins>+ bool isQuirkValue() const { return m_isQuirkValue; }
</ins><span class="cx">
</span><span class="cx"> void addSubresourceStyleURLs(ListHashSet<URL>&, const StyleSheetContents*) const;
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssFontVariantBuildercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/FontVariantBuilder.cpp (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/FontVariantBuilder.cpp 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/FontVariantBuilder.cpp 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-FontVariantLigaturesValues extractFontVariantLigatures(CSSValue& value)
</del><ins>+FontVariantLigaturesValues extractFontVariantLigatures(const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> FontVariantLigatures common = FontVariantLigatures::Normal;
</span><span class="cx"> FontVariantLigatures discretionary = FontVariantLigatures::Normal;
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx"> return FontVariantLigaturesValues(common, discretionary, historical, contextualAlternates);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-FontVariantNumericValues extractFontVariantNumeric(CSSValue& value)
</del><ins>+FontVariantNumericValues extractFontVariantNumeric(const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> FontVariantNumericFigure figure = FontVariantNumericFigure::Normal;
</span><span class="cx"> FontVariantNumericSpacing spacing = FontVariantNumericSpacing::Normal;
</span><span class="lines">@@ -137,7 +137,7 @@
</span><span class="cx"> return FontVariantNumericValues(figure, spacing, fraction, ordinal, slashedZero);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-FontVariantEastAsianValues extractFontVariantEastAsian(CSSValue& value)
</del><ins>+FontVariantEastAsianValues extractFontVariantEastAsian(const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> FontVariantEastAsianVariant variant = FontVariantEastAsianVariant::Normal;
</span><span class="cx"> FontVariantEastAsianWidth width = FontVariantEastAsianWidth::Normal;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssFontVariantBuilderh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/FontVariantBuilder.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/FontVariantBuilder.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/FontVariantBuilder.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -36,9 +36,9 @@
</span><span class="cx"> struct FontVariantNumericValues;
</span><span class="cx"> struct FontVariantEastAsianValues;
</span><span class="cx">
</span><del>-FontVariantLigaturesValues extractFontVariantLigatures(CSSValue&);
-FontVariantNumericValues extractFontVariantNumeric(CSSValue&);
-FontVariantEastAsianValues extractFontVariantEastAsian(CSSValue&);
</del><ins>+FontVariantLigaturesValues extractFontVariantLigatures(const CSSValue&);
+FontVariantNumericValues extractFontVariantNumeric(const CSSValue&);
+FontVariantEastAsianValues extractFontVariantEastAsian(const CSSValue&);
</ins><span class="cx">
</span><span class="cx"> Ref<CSSValue> computeFontVariant(const FontVariantSettings&);
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssStyleBuilderConverterh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleBuilderConverter.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleBuilderConverter.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleBuilderConverter.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -567,7 +567,7 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- CSSReflectValue& reflectValue = downcast<CSSReflectValue>(value);
</del><ins>+ auto& reflectValue = downcast<CSSReflectValue>(value);
</ins><span class="cx">
</span><span class="cx"> RefPtr<StyleReflection> reflection = StyleReflection::create();
</span><span class="cx"> reflection->setDirection(*reflectValue.direction());
</span><span class="lines">@@ -916,8 +916,8 @@
</span><span class="cx"> if (!list.length())
</span><span class="cx"> return RenderStyle::initialGridAutoFlow();
</span><span class="cx">
</span><del>- CSSPrimitiveValue& first = downcast<CSSPrimitiveValue>(*list.item(0));
- CSSPrimitiveValue* second = downcast<CSSPrimitiveValue>(list.item(1));
</del><ins>+ auto& first = downcast<CSSPrimitiveValue>(*list.item(0));
+ auto* second = downcast<CSSPrimitiveValue>(list.item(1));
</ins><span class="cx">
</span><span class="cx"> GridAutoFlow autoFlow = RenderStyle::initialGridAutoFlow();
</span><span class="cx"> switch (first.getValueID()) {
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssStyleBuilderCustomh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleBuilderCustom.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleBuilderCustom.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleBuilderCustom.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -396,8 +396,8 @@
</span><span class="cx"> auto& valueList = downcast<CSSValueList>(value);
</span><span class="cx"> switch (valueList.length()) {
</span><span class="cx"> case 2: {
</span><del>- CSSValue* firstValue = valueList.itemWithoutBoundsCheck(0);
- CSSValue* secondValue = valueList.itemWithoutBoundsCheck(1);
</del><ins>+ auto firstValue = valueList.itemWithoutBoundsCheck(0);
+ auto secondValue = valueList.itemWithoutBoundsCheck(1);
</ins><span class="cx"> // <length>{2} | <page-size> <orientation>
</span><span class="cx"> if (!is<CSSPrimitiveValue>(*firstValue) || !is<CSSPrimitiveValue>(*secondValue))
</span><span class="cx"> return;
</span><span class="lines">@@ -420,7 +420,7 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> case 1: {
</span><del>- CSSValue* value = valueList.itemWithoutBoundsCheck(0);
</del><ins>+ auto value = valueList.itemWithoutBoundsCheck(0);
</ins><span class="cx"> // <length> | auto | <page-size> | [ portrait | landscape]
</span><span class="cx"> if (!is<CSSPrimitiveValue>(*value))
</span><span class="cx"> return;
</span><span class="lines">@@ -1195,7 +1195,7 @@
</span><span class="cx"> inline void StyleBuilderCustom::applyValueStroke(StyleResolver& styleResolver, CSSValue& value)
</span><span class="cx"> {
</span><span class="cx"> SVGRenderStyle& svgStyle = styleResolver.style()->accessSVGStyle();
</span><del>- SVGPaint& svgPaint = downcast<SVGPaint>(value);
</del><ins>+ auto& svgPaint = downcast<SVGPaint>(value);
</ins><span class="cx"> svgStyle.setStrokePaint(svgPaint.paintType(), StyleBuilderConverter::convertSVGColor(styleResolver, svgPaint), svgPaint.uri(), styleResolver.applyPropertyToRegularStyle(), styleResolver.applyPropertyToVisitedLinkStyle());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssStyleResolvercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleResolver.cpp (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleResolver.cpp 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleResolver.cpp 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -1790,7 +1790,7 @@
</span><span class="cx"> return RenderTheme::defaultTheme()->systemColor(cssValueId);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool StyleResolver::colorFromPrimitiveValueIsDerivedFromElement(CSSPrimitiveValue& value)
</del><ins>+bool StyleResolver::colorFromPrimitiveValueIsDerivedFromElement(const CSSPrimitiveValue& value)
</ins><span class="cx"> {
</span><span class="cx"> int ident = value.getValueID();
</span><span class="cx"> switch (ident) {
</span><span class="lines">@@ -1804,7 +1804,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Color StyleResolver::colorFromPrimitiveValue(CSSPrimitiveValue& value, bool forVisitedLink) const
</del><ins>+Color StyleResolver::colorFromPrimitiveValue(const CSSPrimitiveValue& value, bool forVisitedLink) const
</ins><span class="cx"> {
</span><span class="cx"> if (value.isRGBColor())
</span><span class="cx"> return Color(value.getRGBA32Value());
</span><span class="lines">@@ -1897,13 +1897,13 @@
</span><span class="cx"> state.filtersWithPendingSVGDocuments().clear();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool StyleResolver::createFilterOperations(CSSValue& inValue, FilterOperations& outOperations)
</del><ins>+bool StyleResolver::createFilterOperations(const CSSValue& inValue, FilterOperations& outOperations)
</ins><span class="cx"> {
</span><span class="cx"> State& state = m_state;
</span><span class="cx"> ASSERT(outOperations.isEmpty());
</span><span class="cx">
</span><span class="cx"> if (is<CSSPrimitiveValue>(inValue)) {
</span><del>- CSSPrimitiveValue& primitiveValue = downcast<CSSPrimitiveValue>(inValue);
</del><ins>+ auto& primitiveValue = downcast<CSSPrimitiveValue>(inValue);
</ins><span class="cx"> if (primitiveValue.getValueID() == CSSValueNone)
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -1922,12 +1922,12 @@
</span><span class="cx"> if (operationType == FilterOperation::REFERENCE) {
</span><span class="cx"> if (filterValue.length() != 1)
</span><span class="cx"> continue;
</span><del>- CSSValue& argument = *filterValue.itemWithoutBoundsCheck(0);
</del><ins>+ auto& argument = *filterValue.itemWithoutBoundsCheck(0);
</ins><span class="cx">
</span><span class="cx"> if (!is<CSSPrimitiveValue>(argument))
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- CSSPrimitiveValue& primitiveValue = downcast<CSSPrimitiveValue>(argument);
</del><ins>+ auto& primitiveValue = downcast<CSSPrimitiveValue>(argument);
</ins><span class="cx"> String cssUrl = primitiveValue.getStringValue();
</span><span class="cx"> URL url = m_state.document().completeURL(cssUrl);
</span><span class="cx">
</span><span class="lines">@@ -1941,7 +1941,7 @@
</span><span class="cx">
</span><span class="cx"> // Check that all parameters are primitive values, with the
</span><span class="cx"> // exception of drop shadow which has a CSSShadowValue parameter.
</span><del>- CSSPrimitiveValue* firstValue = nullptr;
</del><ins>+ const CSSPrimitiveValue* firstValue = nullptr;
</ins><span class="cx"> if (operationType != FilterOperation::DROP_SHADOW) {
</span><span class="cx"> bool haveNonPrimitiveValue = false;
</span><span class="cx"> for (unsigned j = 0; j < filterValue.length(); ++j) {
</span><span class="lines">@@ -2006,11 +2006,11 @@
</span><span class="cx"> if (filterValue.length() != 1)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- CSSValue& cssValue = *filterValue.itemWithoutBoundsCheck(0);
</del><ins>+ auto& cssValue = *filterValue.itemWithoutBoundsCheck(0);
</ins><span class="cx"> if (!is<CSSShadowValue>(cssValue))
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- CSSShadowValue& item = downcast<CSSShadowValue>(cssValue);
</del><ins>+ auto& item = downcast<CSSShadowValue>(cssValue);
</ins><span class="cx"> int x = item.x->computeLength<int>(state.cssToLengthConversionData());
</span><span class="cx"> int y = item.y->computeLength<int>(state.cssToLengthConversionData());
</span><span class="cx"> IntPoint location(x, y);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssStyleResolverh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleResolver.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleResolver.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/StyleResolver.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -185,8 +185,8 @@
</span><span class="cx"> bool useSVGZoomRules();
</span><span class="cx"> bool useSVGZoomRulesForLength();
</span><span class="cx">
</span><del>- static bool colorFromPrimitiveValueIsDerivedFromElement(CSSPrimitiveValue&);
- Color colorFromPrimitiveValue(CSSPrimitiveValue&, bool forVisitedLink = false) const;
</del><ins>+ static bool colorFromPrimitiveValueIsDerivedFromElement(const CSSPrimitiveValue&);
+ Color colorFromPrimitiveValue(const CSSPrimitiveValue&, bool forVisitedLink = false) const;
</ins><span class="cx">
</span><span class="cx"> bool hasSelectorForId(const AtomicString&) const;
</span><span class="cx"> bool hasSelectorForClass(const AtomicString&) const;
</span><span class="lines">@@ -211,7 +211,7 @@
</span><span class="cx">
</span><span class="cx"> void clearCachedPropertiesAffectedByViewportUnits();
</span><span class="cx">
</span><del>- bool createFilterOperations(CSSValue& inValue, FilterOperations& outOperations);
</del><ins>+ bool createFilterOperations(const CSSValue& inValue, FilterOperations& outOperations);
</ins><span class="cx"> void loadPendingSVGDocuments();
</span><span class="cx">
</span><span class="cx"> void loadPendingResources();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssTransformFunctionscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/TransformFunctions.cpp (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/TransformFunctions.cpp 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/TransformFunctions.cpp 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> return primitiveValue ? primitiveValue->convertToLength<FixedFloatConversion | PercentConversion | CalculatedConversion>(conversionData) : Length(Undefined);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool transformsForValue(CSSValue& value, const CSSToLengthConversionData& conversionData, TransformOperations& outOperations)
</del><ins>+bool transformsForValue(const CSSValue& value, const CSSToLengthConversionData& conversionData, TransformOperations& outOperations)
</ins><span class="cx"> {
</span><span class="cx"> if (!is<CSSValueList>(value)) {
</span><span class="cx"> outOperations.clear();
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> if (haveNonPrimitiveValue)
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- CSSPrimitiveValue& firstValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(0));
</del><ins>+ auto& firstValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(0));
</ins><span class="cx">
</span><span class="cx"> switch (transformValue.operationType()) {
</span><span class="cx"> case WebKitCSSTransformValue::ScaleTransformOperation:
</span><span class="lines">@@ -121,7 +121,7 @@
</span><span class="cx"> sx = firstValue.getDoubleValue();
</span><span class="cx"> if (transformValue.operationType() != WebKitCSSTransformValue::ScaleXTransformOperation) {
</span><span class="cx"> if (transformValue.length() > 1) {
</span><del>- CSSPrimitiveValue& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</del><ins>+ auto& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</ins><span class="cx"> sy = secondValue.getDoubleValue();
</span><span class="cx"> } else
</span><span class="cx"> sy = sx;
</span><span class="lines">@@ -143,11 +143,11 @@
</span><span class="cx"> sx = firstValue.getDoubleValue();
</span><span class="cx"> if (transformValue.operationType() != WebKitCSSTransformValue::ScaleXTransformOperation) {
</span><span class="cx"> if (transformValue.length() > 2) {
</span><del>- CSSPrimitiveValue& thirdValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(2));
</del><ins>+ auto& thirdValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(2));
</ins><span class="cx"> sz = thirdValue.getDoubleValue();
</span><span class="cx"> }
</span><span class="cx"> if (transformValue.length() > 1) {
</span><del>- CSSPrimitiveValue& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</del><ins>+ auto& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</ins><span class="cx"> sy = secondValue.getDoubleValue();
</span><span class="cx"> } else
</span><span class="cx"> sy = sx;
</span><span class="lines">@@ -167,7 +167,7 @@
</span><span class="cx"> tx = convertToFloatLength(&firstValue, conversionData);
</span><span class="cx"> if (transformValue.operationType() != WebKitCSSTransformValue::TranslateXTransformOperation) {
</span><span class="cx"> if (transformValue.length() > 1) {
</span><del>- CSSPrimitiveValue& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</del><ins>+ auto& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</ins><span class="cx"> ty = convertToFloatLength(&secondValue, conversionData);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -192,11 +192,11 @@
</span><span class="cx"> tx = convertToFloatLength(&firstValue, conversionData);
</span><span class="cx"> if (transformValue.operationType() != WebKitCSSTransformValue::TranslateXTransformOperation) {
</span><span class="cx"> if (transformValue.length() > 2) {
</span><del>- CSSPrimitiveValue& thirdValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(2));
</del><ins>+ auto& thirdValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(2));
</ins><span class="cx"> tz = convertToFloatLength(&thirdValue, conversionData);
</span><span class="cx"> }
</span><span class="cx"> if (transformValue.length() > 1) {
</span><del>- CSSPrimitiveValue& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</del><ins>+ auto& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</ins><span class="cx"> ty = convertToFloatLength(&secondValue, conversionData);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -233,9 +233,9 @@
</span><span class="cx"> case WebKitCSSTransformValue::Rotate3DTransformOperation: {
</span><span class="cx"> if (transformValue.length() < 4)
</span><span class="cx"> break;
</span><del>- CSSPrimitiveValue& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
- CSSPrimitiveValue& thirdValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(2));
- CSSPrimitiveValue& fourthValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(3));
</del><ins>+ auto& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
+ auto& thirdValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(2));
+ auto& fourthValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(3));
</ins><span class="cx"> double x = firstValue.getDoubleValue();
</span><span class="cx"> double y = secondValue.getDoubleValue();
</span><span class="cx"> double z = thirdValue.getDoubleValue();
</span><span class="lines">@@ -255,7 +255,7 @@
</span><span class="cx"> angleX = angle;
</span><span class="cx"> if (transformValue.operationType() == WebKitCSSTransformValue::SkewTransformOperation) {
</span><span class="cx"> if (transformValue.length() > 1) {
</span><del>- CSSPrimitiveValue& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</del><ins>+ auto& secondValue = downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1));
</ins><span class="cx"> angleY = secondValue.computeDegrees();
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorecssTransformFunctionsh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/css/TransformFunctions.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/css/TransformFunctions.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/css/TransformFunctions.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> struct Length;
</span><span class="cx">
</span><del>-bool transformsForValue(CSSValue&, const CSSToLengthConversionData&, TransformOperations&);
</del><ins>+bool transformsForValue(const CSSValue&, const CSSToLengthConversionData&, TransformOperations&);
</ins><span class="cx"> Length convertToFloatLength(const CSSPrimitiveValue*, const CSSToLengthConversionData&);
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorerenderingstyleStylePendingImageh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/style/StylePendingImage.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/style/StylePendingImage.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/style/StylePendingImage.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> static Ref<StylePendingImage> create(CSSValue* value) { return adoptRef(*new StylePendingImage(value)); }
</span><span class="cx">
</span><span class="cx"> CSSImageValue* cssImageValue() const { return is<CSSImageValue>(m_value) ? downcast<CSSImageValue>(m_value) : nullptr; }
</span><del>- CSSImageGeneratorValue* cssImageGeneratorValue() const { return m_value && m_value->isImageGeneratorValue() ? static_cast<CSSImageGeneratorValue*>(m_value) : nullptr; }
</del><ins>+ CSSImageGeneratorValue* cssImageGeneratorValue() const { return is<CSSImageGeneratorValue>(m_value) ? static_cast<CSSImageGeneratorValue*>(m_value) : nullptr; }
</ins><span class="cx"> CSSCursorImageValue* cssCursorImageValue() const { return is<CSSCursorImageValue>(m_value) ? downcast<CSSCursorImageValue>(m_value) : nullptr; }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_IMAGE_SET)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoresvgSVGLengthcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGLength.cpp (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGLength.cpp 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGLength.cpp 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -281,7 +281,7 @@
</span><span class="cx"> m_unit = originalUnitAndType;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-SVGLength SVGLength::fromCSSPrimitiveValue(CSSPrimitiveValue& value)
</del><ins>+SVGLength SVGLength::fromCSSPrimitiveValue(const CSSPrimitiveValue& value)
</ins><span class="cx"> {
</span><span class="cx"> SVGLengthType svgType;
</span><span class="cx"> switch (value.primitiveType()) {
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoresvgSVGLengthh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGLength.h (197107 => 197108)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGLength.h 2016-02-25 14:18:23 UTC (rev 197107)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGLength.h 2016-02-25 14:29:12 UTC (rev 197108)
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> return !m_valueInSpecifiedUnits;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static SVGLength fromCSSPrimitiveValue(CSSPrimitiveValue&);
</del><ins>+ static SVGLength fromCSSPrimitiveValue(const CSSPrimitiveValue&);
</ins><span class="cx"> static Ref<CSSPrimitiveValue> toCSSPrimitiveValue(const SVGLength&);
</span><span class="cx"> static SVGLengthMode lengthModeForAnimatedLengthAttribute(const QualifiedName&);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>