<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197098] releases/WebKitGTK/webkit-2.12</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197098">197098</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-02-25 04:49:14 -0800 (Thu, 25 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/196961">r196961</a> - REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/196563">r196563</a>): Images not loading on https://klim.co.nz/blog/paypal-sans-design-information/
https://bugs.webkit.org/show_bug.cgi?id=154547
<rdar://problem/24772167>
Reviewed by Gavin Barraclough.
Source/WebCore:
The Website was doing the following:
$ var e = window.addEventListener;
$ e("eventname", handler)
In such case, the jsEventTargetPrototypeFunctionDispatchEvent() bindings
implementation was caused with a thisValue which is a JSLexicalEnvironment
and the implementation did not know how to convert it into a global object.
The previous implementation on JSDOMWindow used to handle tis correctly
because it was always calling JSValue::toThis() on the thisValue before
trying to cast it to a JSDOMWindow, and JSLexicalEnvironment::toThis()
gets the globalThisValue. This patch updates the EventTarget bindings
code to call always call toThis() on the thisValue before trying to
cast it. This should correctly deal with JSLexicalEnvironment and be a
no-op in usual cases.
No new tests, extended existing test.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateFunctionCastedThis):
LayoutTests:
Add regression test for <rdar://problem/24772167>.
* fast/dom/Window/addEventListener-implicit-this-expected.txt:
* fast/dom/Window/addEventListener-implicit-this.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsfastdomWindowaddEventListenerimplicitthisexpectedtxt">releases/WebKitGTK/webkit-2.12/LayoutTests/fast/dom/Window/addEventListener-implicit-this-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsfastdomWindowaddEventListenerimplicitthishtml">releases/WebKitGTK/webkit-2.12/LayoutTests/fast/dom/Window/addEventListener-implicit-this.html</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorebindingsscriptsCodeGeneratorJSpm">releases/WebKitGTK/webkit-2.12/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (197097 => 197098)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-02-25 12:01:32 UTC (rev 197097)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-02-25 12:49:14 UTC (rev 197098)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-02-22 Chris Dumez <cdumez@apple.com>
+
+ REGRESSION (r196563): Images not loading on https://klim.co.nz/blog/paypal-sans-design-information/
+ https://bugs.webkit.org/show_bug.cgi?id=154547
+ <rdar://problem/24772167>
+
+ Reviewed by Gavin Barraclough.
+
+ Add regression test for <rdar://problem/24772167>.
+
+ * fast/dom/Window/addEventListener-implicit-this-expected.txt:
+ * fast/dom/Window/addEventListener-implicit-this.html:
+
</ins><span class="cx"> 2016-02-22 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Repeated background images have the wrong position when using bottom/right-relative background-position
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsfastdomWindowaddEventListenerimplicitthisexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/fast/dom/Window/addEventListener-implicit-this-expected.txt (197097 => 197098)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/fast/dom/Window/addEventListener-implicit-this-expected.txt 2016-02-25 12:01:32 UTC (rev 197097)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/fast/dom/Window/addEventListener-implicit-this-expected.txt 2016-02-25 12:49:14 UTC (rev 197098)
</span><span class="lines">@@ -10,6 +10,9 @@
</span><span class="cx"> PASS wasWindowEventListenerCalled is true
</span><span class="cx"> PASS xhrDispatchEventFunction.call(undefined, new Event('myevent')) is true
</span><span class="cx"> PASS wasWindowEventListenerCalled is true
</span><ins>+PASS addEventListenerFunction('myevent2', function() { wasWindowEventListenerCalled = true; }); did not throw exception.
+PASS window.dispatchEvent(new Event('myevent2')) is true
+PASS wasWindowEventListenerCalled is true
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsfastdomWindowaddEventListenerimplicitthishtml"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/fast/dom/Window/addEventListener-implicit-this.html (197097 => 197098)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/fast/dom/Window/addEventListener-implicit-this.html 2016-02-25 12:01:32 UTC (rev 197097)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/fast/dom/Window/addEventListener-implicit-this.html 2016-02-25 12:49:14 UTC (rev 197098)
</span><span class="lines">@@ -32,6 +32,12 @@
</span><span class="cx">
</span><span class="cx"> shouldBeTrue("wasWindowEventListenerCalled");
</span><span class="cx">
</span><ins>+wasWindowEventListenerCalled = false;
+shouldNotThrow("addEventListenerFunction('myevent2', function() { wasWindowEventListenerCalled = true; });");
+shouldBeTrue("window.dispatchEvent(new Event('myevent2'))");
+shouldBeTrue("wasWindowEventListenerCalled");
+
+
</ins><span class="cx"> </script>
</span><span class="cx"> <script src="../../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (197097 => 197098)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-02-25 12:01:32 UTC (rev 197097)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-02-25 12:49:14 UTC (rev 197098)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2016-02-22 Chris Dumez <cdumez@apple.com>
+
+ REGRESSION (r196563): Images not loading on https://klim.co.nz/blog/paypal-sans-design-information/
+ https://bugs.webkit.org/show_bug.cgi?id=154547
+ <rdar://problem/24772167>
+
+ Reviewed by Gavin Barraclough.
+
+ The Website was doing the following:
+ $ var e = window.addEventListener;
+ $ e("eventname", handler)
+
+ In such case, the jsEventTargetPrototypeFunctionDispatchEvent() bindings
+ implementation was caused with a thisValue which is a JSLexicalEnvironment
+ and the implementation did not know how to convert it into a global object.
+ The previous implementation on JSDOMWindow used to handle tis correctly
+ because it was always calling JSValue::toThis() on the thisValue before
+ trying to cast it to a JSDOMWindow, and JSLexicalEnvironment::toThis()
+ gets the globalThisValue. This patch updates the EventTarget bindings
+ code to call always call toThis() on the thisValue before trying to
+ cast it. This should correctly deal with JSLexicalEnvironment and be a
+ no-op in usual cases.
+
+ No new tests, extended existing test.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateFunctionCastedThis):
+
</ins><span class="cx"> 2016-02-22 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Repeated background images have the wrong position when using bottom/right-relative background-position
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (197097 => 197098)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-02-25 12:01:32 UTC (rev 197097)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-02-25 12:49:14 UTC (rev 197098)
</span><span class="lines">@@ -3233,7 +3233,7 @@
</span><span class="cx"> if ($interfaceName eq "EventTarget") {
</span><span class="cx"> # We allow calling the EventTarget API without an explicit 'this' value and fall back to using the global object instead.
</span><span class="cx"> # As of early 2016, this matches Firefox and Chrome's behavior.
</span><del>- push(@implContent, " auto castedThis = thisValue.isUndefinedOrNull() ? $castingHelper(thisValue.toThis(state, NotStrictMode)) : $castingHelper(thisValue);\n");
</del><ins>+ push(@implContent, " auto castedThis = $castingHelper(thisValue.toThis(state, NotStrictMode));\n");
</ins><span class="cx"> } else {
</span><span class="cx"> push(@implContent, " auto castedThis = $castingHelper(thisValue);\n");
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>