<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[197001] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/197001">197001</a></dd>
<dt>Author</dt> <dd>keith_miller@apple.com</dd>
<dt>Date</dt> <dd>2016-02-23 15:03:35 -0800 (Tue, 23 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>JSC stress tests' standalone-pre.js should exit on the first failure by default
https://bugs.webkit.org/show_bug.cgi?id=154565
Reviewed by Mark Lam.
Currently, if a test writer does not call finishJSTest() at the end of
any test using stress/resources/standalone-pre.js then the test can fail
without actually reporting an error to the harness. By default, we
should throw on the first error so, in the event someone does not call
finishJSTest() the harness will still notice the error.
* tests/stress/regress-151324.js:
* tests/stress/resources/standalone-pre.js:
(testFailed):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressregress151324js">trunk/Source/JavaScriptCore/tests/stress/regress-151324.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressresourcesstandaloneprejs">trunk/Source/JavaScriptCore/tests/stress/resources/standalone-pre.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (197000 => 197001)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-02-23 22:54:04 UTC (rev 197000)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-02-23 23:03:35 UTC (rev 197001)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-02-23 Keith Miller <keith_miller@apple.com>
+
+ JSC stress tests' standalone-pre.js should exit on the first failure by default
+ https://bugs.webkit.org/show_bug.cgi?id=154565
+
+ Reviewed by Mark Lam.
+
+ Currently, if a test writer does not call finishJSTest() at the end of
+ any test using stress/resources/standalone-pre.js then the test can fail
+ without actually reporting an error to the harness. By default, we
+ should throw on the first error so, in the event someone does not call
+ finishJSTest() the harness will still notice the error.
+
+ * tests/stress/regress-151324.js:
+ * tests/stress/resources/standalone-pre.js:
+ (testFailed):
+
</ins><span class="cx"> 2016-02-23 Saam barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> Make JSObject::getMethod have fewer branches
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressregress151324js"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/regress-151324.js (197000 => 197001)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/regress-151324.js 2016-02-23 22:54:04 UTC (rev 197000)
+++ trunk/Source/JavaScriptCore/tests/stress/regress-151324.js 2016-02-23 23:03:35 UTC (rev 197001)
</span><span class="lines">@@ -1695,5 +1695,6 @@
</span><span class="cx"> "type":"RenderingFrame"
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>-})`, `new ReferenceError("Can't find variable: InspectorFrontendAPI")`);
</del><ins>+})`, `new ReferenceError("Can't find variable: InspectorFrontendAPI").toString()`);
</ins><span class="cx">
</span><ins>+finishJSTest();
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressresourcesstandaloneprejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/resources/standalone-pre.js (197000 => 197001)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/resources/standalone-pre.js 2016-02-23 22:54:04 UTC (rev 197000)
+++ trunk/Source/JavaScriptCore/tests/stress/resources/standalone-pre.js 2016-02-23 23:03:35 UTC (rev 197001)
</span><span class="lines">@@ -7,10 +7,11 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> var silentMode = true;
</span><ins>+var throwOnFirstFail = true;
</ins><span class="cx"> var silentTestPass, didPassSomeTestsSilently, didFailSomeTests, successfullyParsed;
</span><span class="cx"> silentTestPass = false;
</span><span class="cx"> didPassSomeTestsSilenty = false;
</span><del>-didFaileSomeTests = false;
</del><ins>+didFailSomeTests = false;
</ins><span class="cx">
</span><span class="cx"> function description(msg)
</span><span class="cx"> {
</span><span class="lines">@@ -46,9 +47,10 @@
</span><span class="cx"> function testFailed(msg)
</span><span class="cx"> {
</span><span class="cx"> didFailSomeTests = true;
</span><del>- if (silentMode)
- return;
- print("FAIL", escapeString(msg));
</del><ins>+ if (!silentMode)
+ print("FAIL", escapeString(msg));
+ if (throwOnFirstFail)
+ throw new Error(escapeString(msg));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function areNumbersEqual(_actual, _expected)
</span></span></pre>
</div>
</div>
</body>
</html>