<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[196890] trunk</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196890">196890</a></dd>

<dt>Author</dt> <dd>cdumez@apple.com</dd>

<dt>Date</dt> <dd>2016-02-21 19:28:55 -0800 (Sun, 21 Feb 2016)</dd>

</dl>

<h3>Log Message</h3>

<pre>Add username / password attributes to HTMLAnchorElement / HTMLAreaElement

https://bugs.webkit.org/show_bug.cgi?id=154519

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline now that more checks are passing.

* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Add username / password attributes to HTMLAnchorElement / HTMLAreaElement as per:

https://html.spec.whatwg.org/#htmlhyperlinkelementutils

Firefox and Chrome already implement these.

Also stop treating null as the empty string for the HTMLHyperlinkElementUtils

attributes. This behavior does not match the specification or other browsers

(tested Firefox and Chrome).

Test: fast/dom/HTMLAnchorElement/set-href-attribute-user-pass.html

* CMakeLists.txt:

* DerivedSources.make:

* WebCore.xcodeproj/project.pbxproj:

* html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::username):

(WebCore::HTMLAnchorElement::setUsername):

(WebCore::HTMLAnchorElement::password):

(WebCore::HTMLAnchorElement::setPassword):

* html/HTMLAnchorElement.h:

* html/HTMLAnchorElement.idl:

* html/HTMLAreaElement.idl:

* html/HTMLHyperlinkElementUtils.idl: Added.

LayoutTests:

* fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js:

* fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js:

* fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js:

* fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js:

* fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js:

* fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js:

* fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:

* fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:

* fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt:

* fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt:

* fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt:

* fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt:

Update / rebaseline tests now that we no longer treat null as the empty string.

* fast/dom/HTMLAnchorElement/set-href-attribute-user-pass-expected.txt: Added.

* fast/dom/HTMLAnchorElement/set-href-attribute-user-pass.html: Added.

Add test coverage for setting the username / password attributes.

* js/dom/dom-static-property-for-in-iteration-expected.txt:

Rebaseline now that HTMLAnchorElement / HTMLAreaElement have 2 additional

attributes: username and password.</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributehashjs">trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributehostjs">trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributehostnamejs">trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributepathnamejs">trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributeprotocoljs">trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributesearchjs">trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementsethrefattributehashexpectedtxt">trunk/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementsethrefattributehostexpectedtxt">trunk/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementsethrefattributehostnameexpectedtxt">trunk/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementsethrefattributepathnameexpectedtxt">trunk/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementsethrefattributeprotocolexpectedtxt">trunk/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementsethrefattributesearchexpectedtxt">trunk/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt</a></li>

<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>

<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>

<li><a href="#trunkLayoutTestsjsdomdomstaticpropertyforiniterationexpectedtxt">trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt</a></li>

<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoreDerivedSourcesmake">trunk/Source/WebCore/DerivedSources.make</a></li>

<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementcpp">trunk/Source/WebCore/html/HTMLAnchorElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementh">trunk/Source/WebCore/html/HTMLAnchorElement.h</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementidl">trunk/Source/WebCore/html/HTMLAnchorElement.idl</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLAreaElementidl">trunk/Source/WebCore/html/HTMLAreaElement.idl</a></li>

</ul>

<h3>Added Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementsethrefattributeuserpassexpectedtxt">trunk/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-user-pass-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementsethrefattributeuserpasshtml">trunk/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-user-pass.html</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLHyperlinkElementUtilsidl">trunk/Source/WebCore/html/HTMLHyperlinkElementUtils.idl</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkLayoutTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (196889 => 196890)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/ChangeLog        2016-02-22 03:27:44 UTC (rev 196889)

+++ trunk/LayoutTests/ChangeLog        2016-02-22 03:28:55 UTC (rev 196890)

</span><span class="lines">@@ -1,5 +1,34 @@

</span><span class="cx"> 2016-02-21  Chris Dumez  &lt;cdumez@apple.com&gt;

</span><span class="cx"> 

</span><ins>+        Add username / password attributes to HTMLAnchorElement / HTMLAreaElement

+        https://bugs.webkit.org/show_bug.cgi?id=154519

+

+        Reviewed by Sam Weinig.

+

+        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js:

+        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js:

+        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js:

+        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js:

+        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js:

+        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js:

+        * fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:

+        * fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:

+        * fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt:

+        * fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt:

+        * fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt:

+        * fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt:

+        Update / rebaseline tests now that we no longer treat null as the empty string.

+

+        * fast/dom/HTMLAnchorElement/set-href-attribute-user-pass-expected.txt: Added.

+        * fast/dom/HTMLAnchorElement/set-href-attribute-user-pass.html: Added.

+        Add test coverage for setting the username / password attributes.

+

+        * js/dom/dom-static-property-for-in-iteration-expected.txt:

+        Rebaseline now that HTMLAnchorElement / HTMLAreaElement have 2 additional

+        attributes: username and password.

+

+2016-02-21  Chris Dumez  &lt;cdumez@apple.com&gt;

+

</ins><span class="cx">         iframe/frame/object.contentDocument should be on the prototype

</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=154409

</span><span class="cx"> 

</span></span></pre></div>

<a id="trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributehashjs"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js (196889 => 196890)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js        2016-02-22 03:27:44 UTC (rev 196889)

+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js        2016-02-22 03:28:55 UTC (rev 196890)

</span><span class="lines">@@ -24,13 +24,10 @@

</span><span class="cx"> a.hash = &quot;#hash#value&quot;;

</span><span class="cx"> shouldBe(&quot;a.href&quot;, &quot;'https://www.my\&quot;d(){}|~om?ain#com/path/testurl.html#middle'&quot;);

</span><span class="cx"> 