<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196886] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196886">196886</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-02-21 17:45:45 -0800 (Sun, 21 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove arrowfunction test cases that rely on arguments variable in jsc
https://bugs.webkit.org/show_bug.cgi?id=154517
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-02-21
Reviewed by Yusuke Suzuki.
Allow to jsc has the same behavior in javascript as browser has
* tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js:
* tests/stress/arrowfunction-lexical-bind-arguments-strict.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressarrowfunctionlexicalbindargumentsnonstrict1js">trunk/Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressarrowfunctionlexicalbindargumentsstrictjs">trunk/Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-strict.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (196885 => 196886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-02-22 01:30:43 UTC (rev 196885)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-02-22 01:45:45 UTC (rev 196886)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-02-21 Skachkov Oleksandr <gskachkov@gmail.com>
+
+ Remove arrowfunction test cases that rely on arguments variable in jsc
+ https://bugs.webkit.org/show_bug.cgi?id=154517
+
+ Reviewed by Yusuke Suzuki.
+
+ Allow to jsc has the same behavior in javascript as browser has
+
+ * tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js:
+ * tests/stress/arrowfunction-lexical-bind-arguments-strict.js:
+
</ins><span class="cx"> 2016-02-21 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: it should be possible to omit generated code guarded by INSPECTOR_ALTERNATE_DISPATCHERS
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressarrowfunctionlexicalbindargumentsnonstrict1js"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js (196885 => 196886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js 2016-02-22 01:30:43 UTC (rev 196885)
+++ trunk/Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js 2016-02-22 01:45:45 UTC (rev 196886)
</span><span class="lines">@@ -48,20 +48,25 @@
</span><span class="cx"> testCase(af1('G', i), 'AB-CD-EF-G-' + i, txtMsg + "#5");
</span><span class="cx"> }
</span><span class="cx">
</span><del>-var af2 = (x, y) => arguments[0] + '-' + x + y;
</del><ins>+if (true) {
+ let arguments = [];
</ins><span class="cx">
</span><del>-noInline(af2);
</del><ins>+ var af2 = (x, y) => arguments[0] + '-' + x + y;
</ins><span class="cx">
</span><del>-for (var i = 0; i < 10000; i++) {
- testCase(af2('ABC', i), 'undefined-ABC' + i, txtMsg + "#6");
-}
</del><ins>+ noInline(af2);
</ins><span class="cx">
</span><del>-var af3 = () => arguments;
-noInline(af3);
</del><ins>+ for (var i = 0; i < 10000; i++) {
+ testCase(af2('ABC', i), 'undefined-ABC' + i, txtMsg + "#6");
+ }
</ins><span class="cx">
</span><del>-for (var i = 0; i < 10000; i++) {
- testCase(typeof af3('ABC', i), 'object', txtMsg + "#7");
- testCase(typeof af3('ABC', i)[0], 'undefined', txtMsg + "#8");
</del><ins>+ var af3 = () => arguments;
+
+ noInline(af3);
+
+ for (var i = 0; i < 10000; i++) {
+ testCase(typeof af3('ABC', i), 'object', txtMsg + "#7");
+ testCase(typeof af3('ABC', i)[0], 'undefined', txtMsg + "#8");
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var afFactory4 = function () {
</span><span class="lines">@@ -100,15 +105,19 @@
</span><span class="cx"> testCase(af6.func('VW', 'XY')('Z',i), 'GH_IJ_KL_VW_XY_Z_' + i, txtMsg + "#9");
</span><span class="cx"> }
</span><span class="cx">
</span><del>-var obj = {
- name : 'id',
- method : (index) => arguments[0] + '-' + index
-};
</del><ins>+if (true) {
+ let arguments = [];
</ins><span class="cx">
</span><del>-noInline(obj.method);
</del><ins>+ var obj = {
+ name : 'id',
+ method : (index) => arguments[0] + '-' + index
+ };
</ins><span class="cx">
</span><del>-for (var i = 0; i < 10000; i++) {
- testCase(obj.method(i), 'undefined-' + i, txtMsg + "#10");
</del><ins>+ noInline(obj.method);
+
+ for (var i = 0; i < 10000; i++) {
+ testCase(obj.method(i), 'undefined-' + i, txtMsg + "#10");
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var objFactory = function () {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressarrowfunctionlexicalbindargumentsstrictjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-strict.js (196885 => 196886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-strict.js 2016-02-22 01:30:43 UTC (rev 196885)
+++ trunk/Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-strict.js 2016-02-22 01:45:45 UTC (rev 196886)
</span><span class="lines">@@ -8,21 +8,6 @@
</span><span class="cx"> var txtMsg = 'Error: arguments is not lexically binded inside of the arrow function in strict mode';
</span><span class="cx"> var text_value = 'function_global_scope';
</span><span class="cx">
</span><del>-var arr = (error) => {
- if (error)
- return arguments;
- else
- return 'no-error';
-};
-
-noInline(arr);
-
-for (let i=0; i<10000; i++) {
- let value = arr(true);
- let isArray = typeof value === 'array';
- testCase(isArray, false, txtMsg + "#1");
-}
-
</del><span class="cx"> function afFactory0() {
</span><span class="cx"> return a => arguments;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>