<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196869] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196869">196869</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-02-20 16:17:01 -0800 (Sat, 20 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Opacity slider thumb sometimes goes past the bar in Visual Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=154497
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-02-20
Reviewed by Timothy Hatcher.
Since WebInspector.Slider uses CSS transforms to move the slider knob
along the track, if the width of the track changes then the position
of the knob would stay the same since it was translated instead of
adjusting its position relative to the new width.
* UserInterface/Views/Slider.js:
(WebInspector.Slider.prototype.recalculateKnobX):
Resets the maxX value to 0 to ensure that a new maxX is calculated with
the current width.
* UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
(WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.set specifiedWidth): Deleted.
(WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.recalculateWidth):
* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
(WebInspector.VisualStyleDetailsPanel.prototype._updateProperties):
(WebInspector.VisualStyleDetailsPanel.prototype._populateDisplaySection):
* UserInterface/Views/VisualStyleUnitSlider.js:
(WebInspector.VisualStyleUnitSlider.prototype.recalculateWidth):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSliderjs">trunk/Source/WebInspectorUI/UserInterface/Views/Slider.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleCommaSeparatedKeywordEditorjs">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleDetailsPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleUnitSliderjs">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleUnitSlider.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (196868 => 196869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-02-20 23:51:33 UTC (rev 196868)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-02-21 00:17:01 UTC (rev 196869)
</span><span class="lines">@@ -1,5 +1,34 @@
</span><span class="cx"> 2016-02-20 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Opacity slider thumb sometimes goes past the bar in Visual Styles sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=154497
+
+ Reviewed by Timothy Hatcher.
+
+ Since WebInspector.Slider uses CSS transforms to move the slider knob
+ along the track, if the width of the track changes then the position
+ of the knob would stay the same since it was translated instead of
+ adjusting its position relative to the new width.
+
+ * UserInterface/Views/Slider.js:
+ (WebInspector.Slider.prototype.recalculateKnobX):
+ Resets the maxX value to 0 to ensure that a new maxX is calculated with
+ the current width.
+
+ * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
+ (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.set specifiedWidth): Deleted.
+ (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.recalculateWidth):
+
+ * UserInterface/Views/VisualStyleDetailsPanel.js:
+ (WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
+ (WebInspector.VisualStyleDetailsPanel.prototype._updateProperties):
+ (WebInspector.VisualStyleDetailsPanel.prototype._populateDisplaySection):
+
+ * UserInterface/Views/VisualStyleUnitSlider.js:
+ (WebInspector.VisualStyleUnitSlider.prototype.recalculateWidth):
+
+2016-02-20 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Visual Styles: Modifying background expands Font section
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=154491
</span><span class="cx"> <rdar://problem/24755440>
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSliderjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Slider.js (196868 => 196869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Slider.js 2016-02-20 23:51:33 UTC (rev 196868)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Slider.js 2016-02-21 00:17:01 UTC (rev 196869)
</span><span class="lines">@@ -81,6 +81,12 @@
</span><span class="cx"> return this._maxX;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ recalculateKnobX()
+ {
+ this._maxX = 0;
+ this.knobX = this._value;
+ }
+
</ins><span class="cx"> // Protected
</span><span class="cx">
</span><span class="cx"> handleEvent(event)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleCommaSeparatedKeywordEditorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js (196868 => 196869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js 2016-02-20 23:51:33 UTC (rev 196868)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js 2016-02-21 00:17:01 UTC (rev 196869)
</span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx"> return this.value || null;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- set specifiedWidth(value)
</del><ins>+ recalculateWidth(value)
</ins><span class="cx"> {
</span><span class="cx"> if (this._titleElement) {
</span><span class="cx"> // 55px width and 4px margin on left and right for title element,
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleDetailsPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js (196868 => 196869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js 2016-02-20 23:51:33 UTC (rev 196868)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js 2016-02-21 00:17:01 UTC (rev 196869)
</span><span class="lines">@@ -118,14 +118,14 @@
</span><span class="cx"> {
</span><span class="cx"> super.widthDidChange();
</span><span class="cx">
</span><del>- let width = this.element.realOffsetWidth;
</del><ins>+ let sidebarWidth = this.element.realOffsetWidth;
</ins><span class="cx"> for (let key in this._groups) {
</span><span class="cx"> let group = this._groups[key];
</span><span class="cx"> if (!group.specifiedWidthProperties)
</span><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> for (let editor of group.specifiedWidthProperties)
</span><del>- editor.specifiedWidth = width;
</del><ins>+ editor.recalculateWidth(sidebarWidth);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -221,9 +221,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (group.specifiedWidthProperties) {
</span><del>- let width = this.element.realOffsetWidth;
</del><ins>+ let sidebarWidth = this.element.realOffsetWidth;
</ins><span class="cx"> for (let editor of group.specifiedWidthProperties)
</span><del>- editor.specifiedWidth = width;
</del><ins>+ editor.recalculateWidth(sidebarWidth);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -350,6 +350,8 @@
</span><span class="cx"> overflowRow.element.appendChild(properties.opacity.element);
</span><span class="cx"> overflowRow.element.appendChild(properties.overflow.element);
</span><span class="cx">
</span><ins>+ group.specifiedWidthProperties = [properties.opacity];
+
</ins><span class="cx"> let displayGroup = new WebInspector.DetailsSectionGroup([displayRow, sizingRow, overflowRow]);
</span><span class="cx"> this._populateSection(group, [displayGroup]);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleUnitSliderjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleUnitSlider.js (196868 => 196869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleUnitSlider.js 2016-02-20 23:51:33 UTC (rev 196868)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleUnitSlider.js 2016-02-21 00:17:01 UTC (rev 196869)
</span><span class="lines">@@ -55,6 +55,11 @@
</span><span class="cx"> return this.value;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ recalculateWidth(value)
+ {
+ this._slider.recalculateKnobX();
+ }
+
</ins><span class="cx"> sliderValueDidChange(slider, value)
</span><span class="cx"> {
</span><span class="cx"> this._valueDidChange();
</span></span></pre>
</div>
</div>
</body>
</html>