<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196742] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196742">196742</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-02-17 21:44:10 -0800 (Wed, 17 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Regression(<a href="http://trac.webkit.org/projects/webkit/changeset/196648">r196648</a>): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
https://bugs.webkit.org/show_bug.cgi?id=154357
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Make location.assign() / location.replace()'s parameter mandatory,
as per the specification:
https://html.spec.whatwg.org/multipage/browsers.html#the-location-interface
Previously, calling location.assign() / location.replace() without
parameter would be identical to calling location.assign("undefined") /
location.replace("undefined"), which is not useful.
After <a href="http://trac.webkit.org/projects/webkit/changeset/196648">r196648</a>, http://w3c-test.org/html/dom/interfaces.html was able to
test location.assign() / location.replace() further because they are now
on the instance (where they should be) instead of the prototype. One of
these tests calls these functions without parameter, expecting them to
throw an exception. However, in WebKit, it would not throw and it would
redirect us to http://w3c-test.org/html/dom/undefined.
Firefox and Chrome both follow the specification already and throw in
this case.
No new tests, already covered by existing test.
* page/Location.idl:
Make location.assign() / location.replace()'s parameter mandatory,
as per the specification.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageLocationidl">trunk/Source/WebCore/page/Location.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196741 => 196742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-18 05:27:31 UTC (rev 196741)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-18 05:44:10 UTC (rev 196742)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-02-17 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
+ https://bugs.webkit.org/show_bug.cgi?id=154357
+
+ Reviewed by Alexey Proskuryakov.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-02-17 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Import W3C HTML reflection tests
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=154310
</span><span class="cx"> <rdar://problem/24685826>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (196741 => 196742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-02-18 05:27:31 UTC (rev 196741)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-02-18 05:44:10 UTC (rev 196742)
</span><span class="lines">@@ -4147,13 +4147,9 @@
</span><span class="cx"> PASS Location interface: window.location must have own property "search"
</span><span class="cx"> PASS Location interface: window.location must have own property "hash"
</span><span class="cx"> FAIL Location interface: window.location must have own property "assign" assert_equals: property should be writable if and only if not unforgeable expected false but got true
</span><del>-FAIL Location interface: calling assign(USVString) on window.location with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" did not throw
</del><ins>+PASS Location interface: calling assign(USVString) on window.location with too few arguments must throw TypeError
</ins><span class="cx"> FAIL Location interface: window.location must have own property "replace" assert_equals: property should be writable if and only if not unforgeable expected false but got true
</span><del>-FAIL Location interface: calling replace(USVString) on window.location with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" did not throw
</del><ins>+PASS Location interface: calling replace(USVString) on window.location with too few arguments must throw TypeError
</ins><span class="cx"> FAIL Location interface: window.location must have own property "reload" assert_equals: property should be writable if and only if not unforgeable expected false but got true
</span><span class="cx"> PASS Location interface: window.location must have own property "ancestorOrigins"
</span><span class="cx"> PASS PopStateEvent interface: existence and properties of interface object
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (196741 => 196742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-02-18 05:27:31 UTC (rev 196741)
+++ trunk/Source/WebCore/ChangeLog 2016-02-18 05:44:10 UTC (rev 196742)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2016-02-17 Chris Dumez <cdumez@apple.com>
+
+ Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
+ https://bugs.webkit.org/show_bug.cgi?id=154357
+
+ Reviewed by Alexey Proskuryakov.
+
+ Make location.assign() / location.replace()'s parameter mandatory,
+ as per the specification:
+ https://html.spec.whatwg.org/multipage/browsers.html#the-location-interface
+
+ Previously, calling location.assign() / location.replace() without
+ parameter would be identical to calling location.assign("undefined") /
+ location.replace("undefined"), which is not useful.
+
+ After r196648, http://w3c-test.org/html/dom/interfaces.html was able to
+ test location.assign() / location.replace() further because they are now
+ on the instance (where they should be) instead of the prototype. One of
+ these tests calls these functions without parameter, expecting them to
+ throw an exception. However, in WebKit, it would not throw and it would
+ redirect us to http://w3c-test.org/html/dom/undefined.
+
+ Firefox and Chrome both follow the specification already and throw in
+ this case.
+
+ No new tests, already covered by existing test.
+
+ * page/Location.idl:
+ Make location.assign() / location.replace()'s parameter mandatory,
+ as per the specification.
+
</ins><span class="cx"> 2016-02-17 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r196738.
</span></span></pre></div>
<a id="trunkSourceWebCorepageLocationidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Location.idl (196741 => 196742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Location.idl 2016-02-18 05:27:31 UTC (rev 196741)
+++ trunk/Source/WebCore/page/Location.idl 2016-02-18 05:44:10 UTC (rev 196742)
</span><span class="lines">@@ -39,8 +39,8 @@
</span><span class="cx"> ] interface Location {
</span><span class="cx"> [SetterCallWith=ActiveWindow&FirstWindow] attribute DOMString href;
</span><span class="cx">
</span><del>- [CallWith=ActiveWindow&FirstWindow, ForwardDeclareInHeader] void assign([Default=Undefined] optional DOMString url);
- [CallWith=ActiveWindow&FirstWindow, ForwardDeclareInHeader] void replace([Default=Undefined] optional DOMString url);
</del><ins>+ [CallWith=ActiveWindow&FirstWindow, ForwardDeclareInHeader] void assign(DOMString url);
+ [CallWith=ActiveWindow&FirstWindow, ForwardDeclareInHeader] void replace(DOMString url);
</ins><span class="cx"> [CallWith=ActiveWindow, ForwardDeclareInHeader] void reload();
</span><span class="cx">
</span><span class="cx"> // URI decomposition attributes
</span></span></pre>
</div>
</div>
</body>
</html>