<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196633] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196633">196633</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2016-02-16 02:00:15 -0800 (Tue, 16 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Drop StyleResolver and SelectorQueryCache when entering PageCache.
<https://webkit.org/b/154238>
Reviewed by Antti Koivisto.
Source/WebCore:
Stop keeping these around for cached pages to save lots of memory.
We can easily rebuild them if a cached navigation occurs, and this
way we also don't need to worry about invalidating style for cached
pages in all the right places.
Restoring a cached page will now lead to a forced style recalc.
We don't try to defer this (beyond a zero-timer) since it's going
to happen anyway, and it's nicer to front-load the cost rather than
stuttering on the first user content interaction.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
* history/CachedPage.cpp:
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear): Deleted.
* history/CachedPage.h:
(WebCore::CachedPage::markForVisitedLinkStyleRecalc): Deleted.
(WebCore::CachedPage::markForFullStyleRecalc): Deleted.
* history/PageCache.cpp:
(WebCore::PageCache::markPagesForVisitedLinkStyleRecalc): Deleted.
(WebCore::PageCache::markPagesForFullStyleRecalc): Deleted.
* history/PageCache.h:
* page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors): Deleted.
* page/Page.cpp:
(WebCore::Page::setViewScaleFactor): Deleted.
(WebCore::Page::setDeviceScaleFactor): Deleted.
(WebCore::Page::setPagination): Deleted.
(WebCore::Page::setPaginationLineGridEnabled): Deleted.
(WebCore::Page::setVisitedLinkStore): Deleted.
Source/WebKit/win:
* WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::removeAllVisitedLinks): Deleted.
(WebVisitedLinkStore::addVisitedLinkHash): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryCachedPagecpp">trunk/Source/WebCore/history/CachedPage.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryCachedPageh">trunk/Source/WebCore/history/CachedPage.h</a></li>
<li><a href="#trunkSourceWebCorehistoryPageCachecpp">trunk/Source/WebCore/history/PageCache.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryPageCacheh">trunk/Source/WebCore/history/PageCache.h</a></li>
<li><a href="#trunkSourceWebCorepageFramecpp">trunk/Source/WebCore/page/Frame.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebVisitedLinkStoremm">trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebVisitedLinkStorecpp">trunk/Source/WebKit/win/WebCoreSupport/WebVisitedLinkStore.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllercpp">trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebCore/ChangeLog 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -1,3 +1,41 @@
</span><ins>+2016-02-16 Andreas Kling <akling@apple.com>
+
+ Drop StyleResolver and SelectorQueryCache when entering PageCache.
+ <https://webkit.org/b/154238>
+
+ Reviewed by Antti Koivisto.
+
+ Stop keeping these around for cached pages to save lots of memory.
+ We can easily rebuild them if a cached navigation occurs, and this
+ way we also don't need to worry about invalidating style for cached
+ pages in all the right places.
+
+ Restoring a cached page will now lead to a forced style recalc.
+ We don't try to defer this (beyond a zero-timer) since it's going
+ to happen anyway, and it's nicer to front-load the cost rather than
+ stuttering on the first user content interaction.
+
+ * dom/Document.cpp:
+ (WebCore::Document::setInPageCache):
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::restore):
+ (WebCore::CachedPage::clear): Deleted.
+ * history/CachedPage.h:
+ (WebCore::CachedPage::markForVisitedLinkStyleRecalc): Deleted.
+ (WebCore::CachedPage::markForFullStyleRecalc): Deleted.
+ * history/PageCache.cpp:
+ (WebCore::PageCache::markPagesForVisitedLinkStyleRecalc): Deleted.
+ (WebCore::PageCache::markPagesForFullStyleRecalc): Deleted.
+ * history/PageCache.h:
+ * page/Frame.cpp:
+ (WebCore::Frame::setPageAndTextZoomFactors): Deleted.
+ * page/Page.cpp:
+ (WebCore::Page::setViewScaleFactor): Deleted.
+ (WebCore::Page::setDeviceScaleFactor): Deleted.
+ (WebCore::Page::setPagination): Deleted.
+ (WebCore::Page::setPaginationLineGridEnabled): Deleted.
+ (WebCore::Page::setVisitedLinkStore): Deleted.
+
</ins><span class="cx"> 2016-02-16 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] clicking on the scrollbar trough steps rather than jumps to the clicked position
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -4599,6 +4599,9 @@
</span><span class="cx"> v->resetScrollbars();
</span><span class="cx"> }
</span><span class="cx"> m_styleRecalcTimer.stop();
</span><ins>+
+ clearStyleResolver();
+ clearSelectorQueryCache();
</ins><span class="cx"> } else {
</span><span class="cx"> if (childNeedsStyleRecalc())
</span><span class="cx"> scheduleStyleRecalc();
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryCachedPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/CachedPage.cpp (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/CachedPage.cpp 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebCore/history/CachedPage.cpp 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -74,6 +74,8 @@
</span><span class="cx"> ASSERT(m_cachedMainFrame->view()->frame().isMainFrame());
</span><span class="cx"> ASSERT(!page.subframeCount());
</span><span class="cx">
</span><ins>+ page.setNeedsRecalcStyleInAllFrames();
+
</ins><span class="cx"> m_cachedMainFrame->open();
</span><span class="cx">
</span><span class="cx"> // Restore the focus appearance for the focused element.
</span><span class="lines">@@ -100,17 +102,9 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (m_needStyleRecalcForVisitedLinks) {
- for (Frame* frame = &page.mainFrame(); frame; frame = frame->tree().traverseNext())
- frame->document()->visitedLinkState().invalidateStyleForAllLinks();
- }
-
</del><span class="cx"> if (m_needsDeviceOrPageScaleChanged)
</span><span class="cx"> page.mainFrame().deviceOrPageScaleFactorChanged();
</span><span class="cx">
</span><del>- if (m_needsFullStyleRecalc)
- page.setNeedsRecalcStyleInAllFrames();
-
</del><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx"> if (m_needsCaptionPreferencesChanged)
</span><span class="cx"> page.captionPreferencesChanged();
</span><span class="lines">@@ -129,8 +123,6 @@
</span><span class="cx"> ASSERT(m_cachedMainFrame);
</span><span class="cx"> m_cachedMainFrame->clear();
</span><span class="cx"> m_cachedMainFrame = nullptr;
</span><del>- m_needStyleRecalcForVisitedLinks = false;
- m_needsFullStyleRecalc = false;
</del><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx"> m_needsCaptionPreferencesChanged = false;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryCachedPageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/CachedPage.h (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/CachedPage.h 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebCore/history/CachedPage.h 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -50,8 +50,6 @@
</span><span class="cx">
</span><span class="cx"> CachedFrame* cachedMainFrame() { return m_cachedMainFrame.get(); }
</span><span class="cx">
</span><del>- void markForVisitedLinkStyleRecalc() { m_needStyleRecalcForVisitedLinks = true; }
- void markForFullStyleRecalc() { m_needsFullStyleRecalc = true; }
</del><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx"> void markForCaptionPreferencesChanged() { m_needsCaptionPreferencesChanged = true; }
</span><span class="cx"> #endif
</span><span class="lines">@@ -63,8 +61,6 @@
</span><span class="cx"> private:
</span><span class="cx"> double m_expirationTime;
</span><span class="cx"> std::unique_ptr<CachedFrame> m_cachedMainFrame;
</span><del>- bool m_needStyleRecalcForVisitedLinks { false };
- bool m_needsFullStyleRecalc { false };
</del><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx"> bool m_needsCaptionPreferencesChanged { false };
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryPageCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/PageCache.cpp (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/PageCache.cpp 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebCore/history/PageCache.cpp 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -311,23 +311,6 @@
</span><span class="cx"> return frameCount;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageCache::markPagesForVisitedLinkStyleRecalc()
-{
- for (auto& item : m_items) {
- ASSERT(item->m_cachedPage);
- item->m_cachedPage->markForVisitedLinkStyleRecalc();
- }
-}
-
-void PageCache::markPagesForFullStyleRecalc(Page& page)
-{
- for (auto& item : m_items) {
- CachedPage& cachedPage = *item->m_cachedPage;
- if (&page.mainFrame() == &cachedPage.cachedMainFrame()->view()->frame())
- cachedPage.markForFullStyleRecalc();
- }
-}
-
</del><span class="cx"> void PageCache::markPagesForDeviceOrPageScaleChanged(Page& page)
</span><span class="cx"> {
</span><span class="cx"> for (auto& item : m_items) {
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryPageCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/PageCache.h (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/PageCache.h 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebCore/history/PageCache.h 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -61,9 +61,6 @@
</span><span class="cx"> unsigned pageCount() const { return m_items.size(); }
</span><span class="cx"> WEBCORE_EXPORT unsigned frameCount() const;
</span><span class="cx">
</span><del>- WEBCORE_EXPORT void markPagesForVisitedLinkStyleRecalc();
- // Will mark all cached pages associated with the given page as needing style recalc.
- void markPagesForFullStyleRecalc(Page&);
</del><span class="cx"> void markPagesForDeviceOrPageScaleChanged(Page&);
</span><span class="cx"> void markPagesForContentsSizeChanged(Page&);
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span></span></pre></div>
<a id="trunkSourceWebCorepageFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Frame.cpp (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Frame.cpp 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebCore/page/Frame.cpp 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -977,9 +977,6 @@
</span><span class="cx"> if (document->renderView() && document->renderView()->needsLayout() && view->didFirstLayout())
</span><span class="cx"> view->layout();
</span><span class="cx"> }
</span><del>-
- if (isMainFrame())
- PageCache::singleton().markPagesForFullStyleRecalc(*page);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> float Frame::frameScaleFactor() const
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebCore/page/Page.cpp 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -845,7 +845,6 @@
</span><span class="cx">
</span><span class="cx"> m_viewScaleFactor = scale;
</span><span class="cx"> PageCache::singleton().markPagesForDeviceOrPageScaleChanged(*this);
</span><del>- PageCache::singleton().markPagesForFullStyleRecalc(*this);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Page::setDeviceScaleFactor(float scaleFactor)
</span><span class="lines">@@ -863,7 +862,6 @@
</span><span class="cx"> mainFrame().deviceOrPageScaleFactorChanged();
</span><span class="cx"> PageCache::singleton().markPagesForDeviceOrPageScaleChanged(*this);
</span><span class="cx">
</span><del>- PageCache::singleton().markPagesForFullStyleRecalc(*this);
</del><span class="cx"> GraphicsContext::updateDocumentMarkerResources();
</span><span class="cx">
</span><span class="cx"> mainFrame().pageOverlayController().didChangeDeviceScaleFactor();
</span><span class="lines">@@ -941,7 +939,6 @@
</span><span class="cx"> m_pagination = pagination;
</span><span class="cx">
</span><span class="cx"> setNeedsRecalcStyleInAllFrames();
</span><del>- PageCache::singleton().markPagesForFullStyleRecalc(*this);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Page::setPaginationLineGridEnabled(bool enabled)
</span><span class="lines">@@ -952,7 +949,6 @@
</span><span class="cx"> m_paginationLineGridEnabled = enabled;
</span><span class="cx">
</span><span class="cx"> setNeedsRecalcStyleInAllFrames();
</span><del>- PageCache::singleton().markPagesForFullStyleRecalc(*this);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unsigned Page::pageCount() const
</span><span class="lines">@@ -1731,7 +1727,6 @@
</span><span class="cx"> m_visitedLinkStore->addPage(*this);
</span><span class="cx">
</span><span class="cx"> invalidateStylesForAllLinks();
</span><del>- PageCache::singleton().markPagesForFullStyleRecalc(*this);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> SessionID Page::sessionID() const
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebVisitedLinkStoremm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -74,7 +74,6 @@
</span><span class="cx"> {
</span><span class="cx"> for (auto& visitedLinkStore : visitedLinkStores())
</span><span class="cx"> visitedLinkStore->removeVisitedLinkHashes();
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebVisitedLinkStore::addVisitedLink(NSString *urlString)
</span><span class="lines">@@ -103,7 +102,6 @@
</span><span class="cx"> m_visitedLinkHashes.remove(linkHash);
</span><span class="cx">
</span><span class="cx"> invalidateStylesForLink(linkHash);
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool WebVisitedLinkStore::isLinkVisited(Page& page, LinkHash linkHash, const URL& baseURL, const AtomicString& attributeURL)
</span><span class="lines">@@ -152,7 +150,6 @@
</span><span class="cx"> m_visitedLinkHashes.add(linkHash);
</span><span class="cx">
</span><span class="cx"> invalidateStylesForLink(linkHash);
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebVisitedLinkStore::removeVisitedLinkHashes()
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebKit/win/ChangeLog 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-02-16 Andreas Kling <akling@apple.com>
+
+ Drop StyleResolver and SelectorQueryCache when entering PageCache.
+ <https://webkit.org/b/154238>
+
+ Reviewed by Antti Koivisto.
+
+ * WebCoreSupport/WebVisitedLinkStore.cpp:
+ (WebVisitedLinkStore::removeAllVisitedLinks): Deleted.
+ (WebVisitedLinkStore::addVisitedLinkHash): Deleted.
+
</ins><span class="cx"> 2016-02-14 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed Window build fix.
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebVisitedLinkStorecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebVisitedLinkStore.cpp (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebVisitedLinkStore.cpp 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebVisitedLinkStore.cpp 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -71,7 +71,6 @@
</span><span class="cx"> {
</span><span class="cx"> for (auto& visitedLinkStore : visitedLinkStores())
</span><span class="cx"> visitedLinkStore->removeVisitedLinkHashes();
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebVisitedLinkStore::addVisitedLink(const String& urlString)
</span><span class="lines">@@ -124,7 +123,6 @@
</span><span class="cx"> m_visitedLinkHashes.add(linkHash);
</span><span class="cx">
</span><span class="cx"> invalidateStylesForLink(linkHash);
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebVisitedLinkStore::removeVisitedLinkHashes()
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp (196632 => 196633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp 2016-02-16 09:50:26 UTC (rev 196632)
+++ trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp 2016-02-16 10:00:15 UTC (rev 196633)
</span><span class="lines">@@ -97,20 +97,17 @@
</span><span class="cx"> m_visitedLinkTable.setSharedMemory(sharedMemory.release());
</span><span class="cx">
</span><span class="cx"> invalidateStylesForAllLinks();
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void VisitedLinkTableController::visitedLinkStateChanged(const Vector<WebCore::LinkHash>& linkHashes)
</span><span class="cx"> {
</span><span class="cx"> for (auto linkHash : linkHashes)
</span><span class="cx"> invalidateStylesForLink(linkHash);
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void VisitedLinkTableController::allVisitedLinkStateChanged()
</span><span class="cx"> {
</span><span class="cx"> invalidateStylesForAllLinks();
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void VisitedLinkTableController::removeAllVisitedLinks()
</span><span class="lines">@@ -118,7 +115,6 @@
</span><span class="cx"> m_visitedLinkTable.clear();
</span><span class="cx">
</span><span class="cx"> invalidateStylesForAllLinks();
</span><del>- PageCache::singleton().markPagesForVisitedLinkStyleRecalc();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebKit
</span></span></pre>
</div>
</div>
</body>
</html>