<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196575] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196575">196575</a></dd>
<dt>Author</dt> <dd>antti@apple.com</dd>
<dt>Date</dt> <dd>2016-02-15 02:30:36 -0800 (Mon, 15 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add test for class change style invalidation optimization
https://bugs.webkit.org/show_bug.cgi?id=154226
Reviewed by Myles Maxfield.
Test for https://trac.webkit.org/<a href="http://trac.webkit.org/projects/webkit/changeset/196383">r196383</a>
Source/WebCore:
Add internals.styleChangeType function.
Test: fast/css/style-invalidation-class-change-descendants.html
* testing/Internals.cpp:
(WebCore::Internals::nodeNeedsStyleRecalc):
(WebCore::asString):
(WebCore::Internals::styleChangeType):
(WebCore::Internals::description):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
* fast/css/style-invalidation-class-change-descendants-expected.txt: Added.
* fast/css/style-invalidation-class-change-descendants.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalsh">trunk/Source/WebCore/testing/Internals.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalsidl">trunk/Source/WebCore/testing/Internals.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssstyleinvalidationclasschangedescendantsexpectedtxt">trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssstyleinvalidationclasschangedescendantshtml">trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (196574 => 196575)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-02-15 09:50:29 UTC (rev 196574)
+++ trunk/LayoutTests/ChangeLog 2016-02-15 10:30:36 UTC (rev 196575)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-02-14 Antti Koivisto <antti@apple.com>
+
+ Add test for class change style invalidation optimization
+ https://bugs.webkit.org/show_bug.cgi?id=154226
+
+ Reviewed by Myles Maxfield.
+
+ Test for https://trac.webkit.org/r196383
+
+ * fast/css/style-invalidation-class-change-descendants-expected.txt: Added.
+ * fast/css/style-invalidation-class-change-descendants.html: Added.
+
</ins><span class="cx"> 2016-02-15 Hunseop Jeong <hs85.jeong@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed. EFL gardening. Mark more video tests to failure.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssstyleinvalidationclasschangedescendantsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt (0 => 196575)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt 2016-02-15 10:30:36 UTC (rev 196575)
</span><span class="lines">@@ -0,0 +1,57 @@
</span><ins>+Test that we invalidate the element subtree minimally on class attribute change
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS hasExpectedStyle is true
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "NoStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Adding class NotThere
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "NoStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+Adding class style1
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Adding class style2
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Removing class style2
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Adding class style3
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Removing class style3
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Adding class style4
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "NoStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Removing class NotThere
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "NoStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+Removing class style1
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssstyleinvalidationclasschangedescendantshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants.html (0 => 196575)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants.html (rev 0)
+++ trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants.html 2016-02-15 10:30:36 UTC (rev 196575)
</span><span class="lines">@@ -0,0 +1,148 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../resources/js-test-pre.js"></script>
+<style>
+* {
+ color: black;
+}
+root.style1 target {
+ color: rgb(1, 1, 1);
+}
+
+root.style2 > inert target {
+ color: rgb(2, 2, 2);
+}
+
+root.style3 inert + target {
+ color: rgb(3, 3, 3);
+}
+
+root.style4 > target inert {
+ color: rgb(4, 4, 4);
+}
+
+</style>
+</head>
+<body>
+ <root>
+ <!-- With renderer -->
+ <inert>
+ <inert>
+ <inert></inert>
+ <target>
+ <inert></inert>
+ <target></target>
+ </target>
+ </inert>
+ <target></target>
+ <inert></inert>
+ </inert>
+ </root>
+ <root style="display:none;">
+ <!-- Without renderer -->
+ <inert>
+ <inert>
+ <inert></inert>
+ <target>
+ <inert></inert>
+ <target></target>
+ </target>
+ </inert>
+ <target></target>
+ <inert></inert>
+ </inert>
+ </root>
+</body>
+<script>
+
+description('Test that we invalidate the element subtree minimally on class attribute change');
+
+function testStyleChangeType(tag, type)
+{
+ var elements = document.querySelectorAll(tag);
+ for (var i = 0; i < elements.length; ++i) {
+ if (window.internals.styleChangeType(elements[i]) != type)
+ return false;
+ }
+ return true;
+}
+
+function testStyleInvalidation(expectedDescendantStyleChange) {
+ // Ideally we would't invalidate the root at all.
+ shouldBeTrue('testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange")');
+
+ shouldBeTrue('testStyleChangeType("target", "' + expectedDescendantStyleChange +'")');
+
+ shouldBeTrue('testStyleChangeType("inert", "NoStyleChange")');
+}
+
+function addClass(name) {
+ debug("Adding class " + name);
+ var allRoots = document.querySelectorAll("root");
+ allRoots[0].classList.add(name);
+ allRoots[1].classList.add(name);
+}
+
+function removeClass(name) {
+ debug("Removing class " + name);
+ var allRoots = document.querySelectorAll("root");
+ allRoots[0].classList.remove(name);
+ allRoots[1].classList.remove(name);
+}
+
+function checkStyle(n) {
+ document.documentElement.offsetTop;
+
+ hasExpectedStyle = true;
+ expectedColor = 'rgb('+n+', '+n+', '+n+')';
+ var targets = document.querySelectorAll("target");
+ for (var i = 0; i < targets.length; ++i) {
+ hasExpectedStyle = getComputedStyle(targets[i]).color == expectedColor;
+ if (!hasExpectedStyle)
+ break;
+ }
+ shouldBeTrue("hasExpectedStyle");
+}
+
+checkStyle(0);
+testStyleInvalidation("NoStyleChange");
+checkStyle(0);
+
+addClass('NotThere');
+testStyleInvalidation("NoStyleChange");
+
+addClass('style1');
+testStyleInvalidation("InlineStyleChange");
+checkStyle(1);
+
+addClass('style2');
+testStyleInvalidation("InlineStyleChange");
+checkStyle(2);
+
+removeClass('style2');
+testStyleInvalidation("InlineStyleChange");
+checkStyle(1);
+
+addClass('style3');
+testStyleInvalidation("InlineStyleChange");
+checkStyle(3);
+
+removeClass('style3');
+testStyleInvalidation("InlineStyleChange");
+checkStyle(1);
+
+addClass('style4');
+testStyleInvalidation("NoStyleChange");
+checkStyle(1);
+
+removeClass('NotThere');
+testStyleInvalidation("NoStyleChange");
+
+removeClass('style1');
+testStyleInvalidation("InlineStyleChange");
+checkStyle(0);
+
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (196574 => 196575)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-02-15 09:50:29 UTC (rev 196574)
+++ trunk/Source/WebCore/ChangeLog 2016-02-15 10:30:36 UTC (rev 196575)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2016-02-14 Antti Koivisto <antti@apple.com>
+
+ Add test for class change style invalidation optimization
+ https://bugs.webkit.org/show_bug.cgi?id=154226
+
+ Reviewed by Myles Maxfield.
+
+ Test for https://trac.webkit.org/r196383
+
+ Add internals.styleChangeType function.
+
+ Test: fast/css/style-invalidation-class-change-descendants.html
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::nodeNeedsStyleRecalc):
+ (WebCore::asString):
+ (WebCore::Internals::styleChangeType):
+ (WebCore::Internals::description):
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
</ins><span class="cx"> 2016-02-14 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Filters] When applying an SVG filter on a composited image using CSS the image is rendered without the filter
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (196574 => 196575)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2016-02-15 09:50:29 UTC (rev 196574)
+++ trunk/Source/WebCore/testing/Internals.cpp 2016-02-15 10:30:36 UTC (rev 196575)
</span><span class="lines">@@ -464,6 +464,34 @@
</span><span class="cx"> return node->needsStyleRecalc();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static String styleChangeTypeToString(StyleChangeType type)
+{
+ switch (type) {
+ case NoStyleChange:
+ return "NoStyleChange";
+ case InlineStyleChange:
+ return "InlineStyleChange";
+ case FullStyleChange:
+ return "FullStyleChange";
+ case SyntheticStyleChange:
+ return "SyntheticStyleChange";
+ case ReconstructRenderTree:
+ return "ReconstructRenderTree";
+ }
+ ASSERT_NOT_REACHED();
+ return "";
+}
+
+String Internals::styleChangeType(Node* node, ExceptionCode& exception)
+{
+ if (!node) {
+ exception = INVALID_ACCESS_ERR;
+ return { };
+ }
+
+ return styleChangeTypeToString(node->styleChangeType());
+}
+
</ins><span class="cx"> String Internals::description(Deprecated::ScriptValue value)
</span><span class="cx"> {
</span><span class="cx"> return toString(value.jsValue());
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.h (196574 => 196575)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.h 2016-02-15 09:50:29 UTC (rev 196574)
+++ trunk/Source/WebCore/testing/Internals.h 2016-02-15 10:30:36 UTC (rev 196575)
</span><span class="lines">@@ -89,6 +89,7 @@
</span><span class="cx">
</span><span class="cx"> String address(Node*);
</span><span class="cx"> bool nodeNeedsStyleRecalc(Node*, ExceptionCode&);
</span><ins>+ String styleChangeType(Node*, ExceptionCode&);
</ins><span class="cx"> String description(Deprecated::ScriptValue);
</span><span class="cx">
</span><span class="cx"> bool isPreloaded(const String& url);
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalsidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.idl (196574 => 196575)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.idl 2016-02-15 09:50:29 UTC (rev 196574)
+++ trunk/Source/WebCore/testing/Internals.idl 2016-02-15 10:30:36 UTC (rev 196575)
</span><span class="lines">@@ -68,6 +68,7 @@
</span><span class="cx"> ] interface Internals {
</span><span class="cx"> DOMString address(Node node);
</span><span class="cx"> [RaisesException] boolean nodeNeedsStyleRecalc(Node node);
</span><ins>+ [RaisesException] DOMString styleChangeType(Node node);
</ins><span class="cx"> DOMString description(any value);
</span><span class="cx">
</span><span class="cx"> // Animated image pausing testing.
</span></span></pre>
</div>
</div>
</body>
</html>