<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196610] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196610">196610</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-02-15 16:50:21 -0800 (Mon, 15 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Visual sidebar minor regression fixes
https://bugs.webkit.org/show_bug.cgi?id=154237
<rdar://problem/24653135>
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-02-15
Reviewed by Timothy Hatcher.
* UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder):
Do not display the placeholder, as it is not used in comma separated value
property editors.
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle::before):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle): Deleted.
Added ::before to get rid of the "-" on subtitle elements (<a href="http://trac.webkit.org/projects/webkit/changeset/196266">r196266</a>).
* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
Recalculates the width for all comma separated value elements (<a href="http://trac.webkit.org/projects/webkit/changeset/196266">r196266</a>).
(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
Only open/close sections with properties that have values when a new node
or selector item is selected.
(WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection):
Make copies of the default unit lists to prevent modifying the values used
later in other sections (<a href="http://trac.webkit.org/projects/webkit/changeset/194728">r194728</a>).</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleCommaSeparatedKeywordEditorcss">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleDetailsPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (196609 => 196610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-02-16 00:20:46 UTC (rev 196609)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-02-16 00:50:21 UTC (rev 196610)
</span><span class="lines">@@ -1,3 +1,32 @@
</span><ins>+2016-02-15 Devin Rousso <dcrousso+webkit@gmail.com>
+
+ Web Inspector: Visual sidebar minor regression fixes
+ https://bugs.webkit.org/show_bug.cgi?id=154237
+ <rdar://problem/24653135>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder):
+ Do not display the placeholder, as it is not used in comma separated value
+ property editors.
+
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle::before):
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle): Deleted.
+ Added ::before to get rid of the "-" on subtitle elements (r196266).
+
+ * UserInterface/Views/VisualStyleDetailsPanel.js:
+ (WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
+ Recalculates the width for all comma separated value elements (r196266).
+
+ (WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
+ Only open/close sections with properties that have values when a new node
+ or selector item is selected.
+
+ (WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection):
+ Make copies of the default unit lists to prevent modifying the values used
+ later in other sections (r194728).
+
</ins><span class="cx"> 2016-02-15 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: eliminate the linear and rendering frames TimelineOverview subclasses
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleCommaSeparatedKeywordEditorcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css (196609 => 196610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2016-02-16 00:20:46 UTC (rev 196609)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2016-02-16 00:50:21 UTC (rev 196610)
</span><span class="lines">@@ -32,6 +32,10 @@
</span><span class="cx"> overflow: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder {
+ display: none;
+}
+
</ins><span class="cx"> .visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list {
</span><span class="cx"> min-height: 51px;
</span><span class="cx"> max-height: 94px;
</span><span class="lines">@@ -90,7 +94,7 @@
</span><span class="cx"> color: hsl(0, 0%, 83%);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle {
</del><ins>+.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle::before {
</ins><span class="cx"> content: none;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleDetailsPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js (196609 => 196610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js 2016-02-16 00:20:46 UTC (rev 196609)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js 2016-02-16 00:50:21 UTC (rev 196610)
</span><span class="lines">@@ -114,6 +114,21 @@
</span><span class="cx"> super.refresh();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ widthDidChange()
+ {
+ super.widthDidChange();
+
+ let width = this.element.realOffsetWidth;
+ for (let key in this._groups) {
+ let group = this._groups[key];
+ if (!group.specifiedWidthProperties)
+ continue;
+
+ for (let editor of group.specifiedWidthProperties)
+ editor.specifiedWidth = width;
+ }
+ }
+
</ins><span class="cx"> // Private
</span><span class="cx">
</span><span class="cx"> _generateSection(id, displayName)
</span><span class="lines">@@ -158,17 +173,18 @@
</span><span class="cx"> for (let key in this._groups)
</span><span class="cx"> this._updateProperties(this._groups[key], !!event);
</span><span class="cx">
</span><del>- for (let key in this._sections) {
- let section = this._sections[key];
- let oneSectionExpanded = false;
- for (let group of section.groups) {
- if (!group.collapsed) {
- oneSectionExpanded = true;
- break;
</del><ins>+ if (event) {
+ for (let key in this._sections) {
+ let section = this._sections[key];
+ let oneSectionExpanded = false;
+ for (let group of section.groups) {
+ if (!group.collapsed) {
+ oneSectionExpanded = true;
+ break;
+ }
</ins><span class="cx"> }
</span><ins>+ section.collapsed = !oneSectionExpanded;
</ins><span class="cx"> }
</span><del>-
- section.collapsed = !oneSectionExpanded;
</del><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1075,12 +1091,12 @@
</span><span class="cx">
</span><span class="cx"> let nonKeywordUnits = [WebInspector.UIString("Number")];
</span><span class="cx">
</span><del>- let borderImageUnits = this._units.defaults;
</del><ins>+ let borderImageUnits = Object.shallowCopy(this._units.defaults);
</ins><span class="cx"> borderImageUnits.basic = nonKeywordUnits.concat(borderImageUnits.basic);
</span><span class="cx"> let borderImageWidth = generateBorderImagePropertyEditors("border-image-width", this._keywords.boxModel, borderImageUnits);
</span><span class="cx"> properties.borderImageWidth = new WebInspector.VisualStylePropertyCombiner("border-image-width", borderImageWidth.properties, true);
</span><span class="cx">
</span><del>- let borderOutsetUnits = this._units.defaultsSansPercent;
</del><ins>+ let borderOutsetUnits = Object.shallowCopy(this._units.defaultsSansPercent);
</ins><span class="cx"> borderOutsetUnits.basic = nonKeywordUnits.concat(borderOutsetUnits.basic);
</span><span class="cx"> let borderImageOutset = generateBorderImagePropertyEditors("border-image-outset", this._keywords.defaults, borderOutsetUnits);
</span><span class="cx"> properties.borderImageOutset = new WebInspector.VisualStylePropertyCombiner("border-image-outset", borderImageOutset.properties, true);
</span></span></pre>
</div>
</div>
</body>
</html>