<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196459] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196459">196459</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-02-11 17:05:14 -0800 (Thu, 11 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add a script to process backlogs created while perf dashboard was in the maintenance mode
https://bugs.webkit.org/show_bug.cgi?id=154140
Reviewed by Chris Dumez.
Added a script to process the backlog JSONs created while the perf dashboard was put in the maintenance mode.
It re-submits each JSON file to the perf dashboard using the same server config file used by syncing scripts.
* public/include/report-processor.php:
(TestRunsGenerator::test_value_list_to_values_by_iterations): Fixed a bug in the error message code. It was
referencing an undeclared variable.
* tools/process-maintenance-backlog.py: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludereportprocessorphp">trunk/Websites/perf.webkit.org/public/include/report-processor.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgtoolsprocessmaintenancebacklogpy">trunk/Websites/perf.webkit.org/tools/process-maintenance-backlog.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (196458 => 196459)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2016-02-12 00:59:11 UTC (rev 196458)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-02-12 01:05:14 UTC (rev 196459)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2016-02-11 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Add a script to process backlogs created while perf dashboard was in the maintenance mode
+ https://bugs.webkit.org/show_bug.cgi?id=154140
+
+ Reviewed by Chris Dumez.
+
+ Added a script to process the backlog JSONs created while the perf dashboard was put in the maintenance mode.
+ It re-submits each JSON file to the perf dashboard using the same server config file used by syncing scripts.
+
+ * public/include/report-processor.php:
+ (TestRunsGenerator::test_value_list_to_values_by_iterations): Fixed a bug in the error message code. It was
+ referencing an undeclared variable.
+ * tools/process-maintenance-backlog.py: Added.
+
+2016-02-11 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> AnalysisResultsViewer never uses this._smallerIsBetter
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=154134
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludereportprocessorphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/report-processor.php (196458 => 196459)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/report-processor.php 2016-02-12 00:59:11 UTC (rev 196458)
+++ trunk/Websites/perf.webkit.org/public/include/report-processor.php 2016-02-12 01:05:14 UTC (rev 196459)
</span><span class="lines">@@ -335,7 +335,7 @@
</span><span class="cx"> if (count($values) != count($group_sizes)) {
</span><span class="cx"> // FIXME: We should support bootstrapping or just computing the mean in this case.
</span><span class="cx"> $this->exit_with_error('IterationGroupCountIsInconsistent', array('parent' => $test_metric['test_id'],
</span><del>- 'metric' => $test_metric['metric_name'], 'childTest' => $name_and_values['name'],
</del><ins>+ 'metric' => $test_metric['metric_name'], 'childTest' => $test_name,
</ins><span class="cx"> 'valuesByIterations' => $values_by_iterations, 'values' => $values));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -345,7 +345,7 @@
</span><span class="cx"> $run_iteration_value = $values[$group][$i];
</span><span class="cx"> if (!is_numeric($run_iteration_value)) {
</span><span class="cx"> $this->exit_with_error('NonNumeralIterationValueForAggregation', array('parent' => $test_metric['test_id'],
</span><del>- 'metric' => $test_metric['metric_name'], 'childTest' => $name_and_values['name'],
</del><ins>+ 'metric' => $test_metric['metric_name'], 'childTest' => $test_name,
</ins><span class="cx"> 'valuesByIterations' => $values_by_iterations, 'values' => $values, 'index' => $i));
</span><span class="cx"> }
</span><span class="cx"> array_push($values_by_iterations[$flattened_iteration_index], $run_iteration_value);
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgtoolsprocessmaintenancebacklogpy"></a>
<div class="addfile"><h4>Added: trunk/Websites/perf.webkit.org/tools/process-maintenance-backlog.py (0 => 196459)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/tools/process-maintenance-backlog.py (rev 0)
+++ trunk/Websites/perf.webkit.org/tools/process-maintenance-backlog.py 2016-02-12 01:05:14 UTC (rev 196459)
</span><span class="lines">@@ -0,0 +1,95 @@
</span><ins>+#!/usr/bin/python
+
+import argparse
+import json
+import os
+import sys
+import urllib2
+
+from util import load_server_config
+
+
+def main():
+ parser = argparse.ArgumentParser()
+ parser.add_argument('--server-config-json', required=True, help='The path to a JSON file that specifies the perf dashboard.')
+ args = parser.parse_args()
+
+ maintenace_dir = determine_maintenance_dir()
+
+ server_config = load_server_config(args.server_config_json)
+
+ print 'Submitting results in "%s" to "%s"' % (maintenace_dir, server_config['server']['url'])
+
+ for filename in os.listdir(maintenace_dir):
+ path = os.path.join(maintenace_dir, filename)
+ if os.path.isfile(path) and filename.endswith('.json'):
+
+ with open(os.path.join(maintenace_dir, path)) as submitted_json_file:
+ submitted_content = submitted_json_file.read()
+
+ print '%s...' % filename,
+ sys.stdout.flush()
+
+ suffix = '.done'
+ while True:
+ if submit_report(server_config, submitted_content):
+ break
+ if ask_yes_no_question('Suffix the file with .error and continue?'):
+ suffix = '.error'
+ break
+ else:
+ sys.exit(0)
+
+ os.rename(path, path + suffix)
+
+ print 'Done'
+
+
+def determine_maintenance_dir():
+ root_dir = os.path.join(os.path.dirname(__file__), '../')
+
+ config_json_path = os.path.abspath(os.path.join(root_dir, 'config.json'))
+ with open(config_json_path) as config_json_file:
+ config = json.load(config_json_file)
+
+ dirname = config.get('maintenanceDirectory')
+ if not dirname:
+ sys.exit('maintenanceDirectory is not specified in config.json')
+
+ return os.path.abspath(os.path.join(root_dir, dirname))
+
+
+def ask_yes_no_question(question):
+ while True:
+ action = raw_input(question + ' (y/n): ')
+ if action == 'y' or action == 'yes':
+ return True
+ elif action == 'n' or action == 'no':
+ return False
+ else:
+ print 'Please answer by yes or no'
+
+
+def submit_report(server_config, payload):
+ try:
+ request = urllib2.Request(server_config['server']['url'] + '/api/report')
+ request.add_header('Content-Type', 'application/json')
+ request.add_header('Content-Length', len(payload))
+
+ output = urllib2.urlopen(request, payload).read()
+ try:
+ result = json.loads(output)
+ except Exception, error:
+ raise Exception(error, output)
+
+ if result.get('status') != 'OK':
+ raise Exception(result)
+
+ return True
+ except Exception as error:
+ print >> sys.stderr, 'Failed to submit commits: %s' % str(error)
+ return False
+
+
+if __name__ == "__main__":
+ main()
</ins></span></pre>
</div>
</div>
</body>
</html>