<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196403] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196403">196403</a></dd>
<dt>Author</dt> <dd>jmarcell@apple.com</dd>
<dt>Date</dt> <dd>2016-02-10 16:29:26 -0800 (Wed, 10 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove calls to parseInt in order to work with non-integer revisions
https://bugs.webkit.org/show_bug.cgi?id=153820
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
revisions.
(BuildbotIteration.prototype._parseData): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.update): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
(MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
(MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueuejs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptstestsMockBuildbotQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptstestsMockTracjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsteststestsjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (196402 => 196403)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2016-02-11 00:29:26 UTC (rev 196403)
</span><span class="lines">@@ -214,17 +214,14 @@
</span><span class="cx"> fallbackKey = null;
</span><span class="cx"> }
</span><span class="cx"> var revision = parseRevisionProperty(revisionProperty, key, fallbackKey);
</span><del>- if (repository.isSVN)
- this.revision[repositoryName] = parseInt(revision);
- else
- this.revision[repositoryName] = revision;
</del><ins>+ this.revision[repositoryName] = revision;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function sourceStampChanges(sourceStamp) {
</span><span class="cx"> var result = [];
</span><span class="cx"> var changes = sourceStamp.changes;
</span><span class="cx"> for (var i = 0; i < changes.length; ++i) {
</span><del>- var change = { revisionNumber: parseInt(changes[i].revision, 10) }
</del><ins>+ var change = { revisionNumber: changes[i].revision }
</ins><span class="cx"> if (changes[i].repository)
</span><span class="cx"> change.repository = changes[i].repository;
</span><span class="cx"> if (changes[i].branch)
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueuejs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (196402 => 196403)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2016-02-11 00:29:26 UTC (rev 196403)
</span><span class="lines">@@ -209,7 +209,7 @@
</span><span class="cx"> for (var i = data.cachedBuilds.length - 1; i >= 0; --i) {
</span><span class="cx"> var iteration = this._knownIterations[data.cachedBuilds[i]];
</span><span class="cx"> if (!iteration) {
</span><del>- iteration = new BuildbotIteration(this, parseInt(data.cachedBuilds[i], 10), !(data.cachedBuilds[i] in currentBuilds));
</del><ins>+ iteration = new BuildbotIteration(this, data.cachedBuilds[i], !(data.cachedBuilds[i] in currentBuilds));
</ins><span class="cx"> newIterations.push(iteration);
</span><span class="cx"> this.iterations.push(iteration);
</span><span class="cx"> this._knownIterations[iteration.id] = iteration;
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptstestsMockBuildbotQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js (196402 => 196403)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js 2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js 2016-02-11 00:29:26 UTC (rev 196403)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> {
</span><span class="cx"> return {
</span><span class="cx"> revision: {
</span><del>- "openSource": 33020
</del><ins>+ "openSource": "33020"
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptstestsMockTracjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js (196402 => 196403)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js 2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js 2016-02-11 00:29:26 UTC (rev 196403)
</span><span class="lines">@@ -36,12 +36,12 @@
</span><span class="cx">
</span><span class="cx"> get oldestRecordedRevisionNumber()
</span><span class="cx"> {
</span><del>- return 33018;
</del><ins>+ return "33018";
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> get latestRecordedRevisionNumber()
</span><span class="cx"> {
</span><del>- return 33022;
</del><ins>+ return "33022";
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> loadMoreHistoricalData: function()
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx">
</span><span class="cx"> MockTrac.EXAMPLE_TRAC_COMMITS = [
</span><span class="cx"> {
</span><del>- "revisionNumber": 33018,
</del><ins>+ "revisionNumber": "33018",
</ins><span class="cx"> "link": "https://trac.webkit.org/changeset/33018",
</span><span class="cx"> "title": { innerHTML: "commit message" },
</span><span class="cx"> "author": "john@webkit.org",
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> "branches": ["trunk"]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "revisionNumber": 33019,
</del><ins>+ "revisionNumber": "33019",
</ins><span class="cx"> "link": "https://trac.webkit.org/changeset/33019",
</span><span class="cx"> "title": { innerHTML: "commit message" },
</span><span class="cx"> "author": "paul@webkit.org",
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> "branches": ["someOtherBranch"]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "revisionNumber": 33020,
</del><ins>+ "revisionNumber": "33020",
</ins><span class="cx"> "link": "https://trac.webkit.org/changeset/33020",
</span><span class="cx"> "title": { innerHTML: "commit message" },
</span><span class="cx"> "author": "george@webkit.org",
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> "branches": ["trunk"]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "revisionNumber": 33021,
</del><ins>+ "revisionNumber": "33021",
</ins><span class="cx"> "link": "https://trac.webkit.org/changeset/33021",
</span><span class="cx"> "title": { innerHTML: "commit message" },
</span><span class="cx"> "author": "ringo@webkit.org",
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx"> "branches": ["someOtherBranch"]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "revisionNumber": 33022,
</del><ins>+ "revisionNumber": "33022",
</ins><span class="cx"> "link": "https://trac.webkit.org/changeset/33022",
</span><span class="cx"> "title": { innerHTML: "commit message" },
</span><span class="cx"> "author": "bob@webkit.org",
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsteststestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js (196402 => 196403)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js 2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js 2016-02-11 00:29:26 UTC (rev 196403)
</span><span class="lines">@@ -75,34 +75,34 @@
</span><span class="cx"> test("nextRevision", function()
</span><span class="cx"> {
</span><span class="cx"> this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
</span><del>- strictEqual(this.trac.nextRevision("trunk", 33020), 33022, "nextRevision same branch");
- strictEqual(this.trac.nextRevision("trunk", 33019), 33020, "nextRevision different branch");
</del><ins>+ strictEqual(this.trac.nextRevision("trunk", "33020"), "33022", "nextRevision same branch");
+ strictEqual(this.trac.nextRevision("trunk", "33019"), "33020", "nextRevision different branch");
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test("indexOfRevision", function()
</span><span class="cx"> {
</span><span class="cx"> this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
</span><del>- strictEqual(this.trac.indexOfRevision(33020), 2, "indexOfRevision");
</del><ins>+ strictEqual(this.trac.indexOfRevision("33020"), 2, "indexOfRevision");
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test("commitsOnBranchLaterThanRevision", function()
</span><span class="cx"> {
</span><span class="cx"> this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
</span><del>- var commits = this.trac.commitsOnBranchLaterThanRevision("trunk", 33020);
</del><ins>+ var commits = this.trac.commitsOnBranchLaterThanRevision("trunk", "33020");
</ins><span class="cx"> equal(commits.length, 1, "greater than 33020");
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test("commitsOnBranchLaterThanRevision no commits", function()
</span><span class="cx"> {
</span><span class="cx"> this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
</span><del>- var commits = this.trac.commitsOnBranchLaterThanRevision("someOtherBranch", 33021);
</del><ins>+ var commits = this.trac.commitsOnBranchLaterThanRevision("someOtherBranch", "33021");
</ins><span class="cx"> equal(commits.length, 0, "greater than 33021");
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test("commitsOnBranchInRevisionRange", function()
</span><span class="cx"> {
</span><span class="cx"> this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
</span><del>- var commits = this.trac.commitsOnBranchInRevisionRange("trunk", 33020, 33022);
</del><ins>+ var commits = this.trac.commitsOnBranchInRevisionRange("trunk", "33020", "33022");
</ins><span class="cx"> equal(commits.length, 2, "in range 33020, 33022");
</span><span class="cx"> });
</span><span class="cx">
</span><span class="lines">@@ -134,7 +134,7 @@
</span><span class="cx">
</span><span class="cx"> test("_popoverLinesForCommitRange", function()
</span><span class="cx"> {
</span><del>- var lines = this.view._popoverLinesForCommitRange(this.trac, this.trunkBranch, 33018, 33020);
</del><ins>+ var lines = this.view._popoverLinesForCommitRange(this.trac, this.trunkBranch, "33018", "33020");
</ins><span class="cx"> strictEqual(lines.length, 2, "has 2 lines");
</span><span class="cx"> });
</span><span class="cx">
</span><span class="lines">@@ -161,7 +161,7 @@
</span><span class="cx"> this.view._latestProductiveIteration = function(queue)
</span><span class="cx"> {
</span><span class="cx"> var iteration = {
</span><del>- revision: { "openSource": 33021 },
</del><ins>+ revision: { "openSource": "33021" },
</ins><span class="cx"> };
</span><span class="cx"> return iteration;
</span><span class="cx"> }
</span><span class="lines">@@ -179,8 +179,8 @@
</span><span class="cx"> var context = {
</span><span class="cx"> trac: this.trac,
</span><span class="cx"> branch: this.trunkBranch,
</span><del>- firstRevision: 33018,
- lastRevision: 33020
</del><ins>+ firstRevision: "33018",
+ lastRevision: "33020"
</ins><span class="cx"> };
</span><span class="cx"> this.view._presentPopoverForRevisionRange(element, popover, context);
</span><span class="cx"> var nodeList = popover._element.getElementsByClassName("pending-commit");
</span><span class="lines">@@ -194,8 +194,8 @@
</span><span class="cx"> var context = {
</span><span class="cx"> trac: this.trac,
</span><span class="cx"> branch: this.trunkBranch,
</span><del>- firstRevision: 33020,
- lastRevision: 33018
</del><ins>+ firstRevision: "33020",
+ lastRevision: "33018"
</ins><span class="cx"> };
</span><span class="cx"> this.view._presentPopoverForRevisionRange(element, popover, context);
</span><span class="cx"> var nodeList = popover._element.getElementsByClassName("pending-commit");
</span><span class="lines">@@ -206,7 +206,7 @@
</span><span class="cx"> {
</span><span class="cx"> var finished = false;
</span><span class="cx"> var iteration = new BuildbotIteration(this.queue, 1, finished);
</span><del>- iteration.revision = { "openSource": 33018 };
</del><ins>+ iteration.revision = { "openSource": "33018" };
</ins><span class="cx"> var previousIteration = null;
</span><span class="cx"> var content = this.view._revisionContentWithPopoverForIteration(iteration, previousIteration, this.trunkBranch);
</span><span class="cx"> strictEqual(content.innerHTML, "r33018", "should have correct revision number.");
</span><span class="lines">@@ -218,9 +218,9 @@
</span><span class="cx"> {
</span><span class="cx"> var finished = false;
</span><span class="cx"> var iteration = new BuildbotIteration(this.queue, 2, finished);
</span><del>- iteration.revision = { "openSource": 33022 };
</del><ins>+ iteration.revision = { "openSource": "33022" };
</ins><span class="cx"> var previousIteration = new BuildbotIteration(this.queue, 1, finished);
</span><del>- previousIteration.revision = { "openSource": 33018 };
</del><ins>+ previousIteration.revision = { "openSource": "33018" };
</ins><span class="cx"> var content = this.view._revisionContentWithPopoverForIteration(iteration, previousIteration, this.trunkBranch);
</span><span class="cx"> strictEqual(content.innerHTML, "r33022", "should have correct revision number.");
</span><span class="cx"> strictEqual(content.classList.contains("revision-number"), true, "should have class 'revision-number'.");
</span><span class="lines">@@ -237,7 +237,7 @@
</span><span class="cx"> var repository = this.trunkBranch.repository;
</span><span class="cx"> repository.isSVN = true;
</span><span class="cx"> repository.isGit = false;
</span><del>- strictEqual(this.view._formatRevisionForDisplay(33018, repository), "r33018", "Should be r33018")
</del><ins>+ strictEqual(this.view._formatRevisionForDisplay("33018", repository), "r33018", "Should be r33018")
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test("_formatRevisionForDisplay Git", function()
</span><span class="lines">@@ -266,8 +266,8 @@
</span><span class="cx"> var finished = false;
</span><span class="cx"> var iteration1 = new BuildbotIteration(this.queue, 1, finished);
</span><span class="cx"> var iteration2 = new BuildbotIteration(this.queue, 2, finished);
</span><del>- iteration1.revision = { "openSource": 33018 };
- iteration2.revision = { "openSource": 33019 };
</del><ins>+ iteration1.revision = { "openSource": "33018" };
+ iteration2.revision = { "openSource": "33019" };
</ins><span class="cx"> iteration1.loaded = true;
</span><span class="cx"> iteration2.loaded = true;
</span><span class="cx"> ok(this.queue.compareIterations(iteration2, iteration1) < 0, "compareIterations: less than");
</span><span class="lines">@@ -281,7 +281,7 @@
</span><span class="cx"> var iteration1 = new BuildbotIteration(this.queue, 1, finished);
</span><span class="cx"> var iteration2 = new BuildbotIteration(this.queue, 2, finished);
</span><span class="cx"> iteration1.revision = {};
</span><del>- iteration2.revision = { "openSource": 33019 };
</del><ins>+ iteration2.revision = { "openSource": "33019" };
</ins><span class="cx"> iteration1.loaded = false;
</span><span class="cx"> iteration2.loaded = true;
</span><span class="cx"> ok(this.queue.compareIterations(iteration1, iteration2) > 0, "compareIterations: greater than");
</span><span class="lines">@@ -293,8 +293,8 @@
</span><span class="cx"> var finished = false;
</span><span class="cx"> var iteration1 = new BuildbotIteration(this.queue, 1, finished);
</span><span class="cx"> var iteration2 = new BuildbotIteration(this.queue, 2, finished);
</span><del>- iteration1.revision = { "openSource": 33019 };
- iteration2.revision = { "openSource": 33019 };
</del><ins>+ iteration1.revision = { "openSource": "33019" };
+ iteration2.revision = { "openSource": "33019" };
</ins><span class="cx"> iteration1.loaded = false;
</span><span class="cx"> iteration2.loaded = true;
</span><span class="cx"> ok(this.queue.compareIterations(iteration1, iteration2) > 0, "compareIterations: greater than");
</span><span class="lines">@@ -320,8 +320,8 @@
</span><span class="cx"> var finished = false;
</span><span class="cx"> var iteration1 = new BuildbotIteration(this.queue, 1, finished);
</span><span class="cx"> var iteration2 = new BuildbotIteration(this.queue, 2, finished);
</span><del>- iteration1.revision = { "openSource": 33019 };
- iteration2.revision = { "openSource": 33019 };
</del><ins>+ iteration1.revision = { "openSource": "33019" };
+ iteration2.revision = { "openSource": "33019" };
</ins><span class="cx"> iteration1.loaded = false;
</span><span class="cx"> iteration2.loaded = false;
</span><span class="cx"> ok(this.queue.compareIterations(iteration2, iteration1) < 0, "compareIterations: less than");
</span><span class="lines">@@ -334,8 +334,8 @@
</span><span class="cx"> var finished = false;
</span><span class="cx"> var iteration1 = new BuildbotIteration(this.queue, 1, finished);
</span><span class="cx"> var iteration2 = new BuildbotIteration(this.queue, 2, finished);
</span><del>- iteration1.revision = { "openSource": 33018 };
- iteration2.revision = { "openSource": 33019 };
</del><ins>+ iteration1.revision = { "openSource": "33018" };
+ iteration2.revision = { "openSource": "33019" };
</ins><span class="cx"> iteration1.loaded = true;
</span><span class="cx"> iteration2.loaded = false;
</span><span class="cx"> ok(this.queue.compareIterationsByRevisions(iteration2, iteration1) < 0, "compareIterationsByRevisions: less than");
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (196402 => 196403)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/ChangeLog 2016-02-11 00:29:26 UTC (rev 196403)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-02-10 Jason Marcell <jmarcell@apple.com>
</span><span class="cx">
</span><ins>+ Remove calls to parseInt in order to work with non-integer revisions
+ https://bugs.webkit.org/show_bug.cgi?id=153820
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
+ revisions.
+ (BuildbotIteration.prototype._parseData): Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ (BuildbotQueue.prototype.update): Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
+ (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
+ (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
+ (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
+
+2016-02-10 Jason Marcell <jmarcell@apple.com>
+
</ins><span class="cx"> Teach dashboard code to compare non-integer revisions
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=152345
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>