<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196150] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196150">196150</a></dd>
<dt>Author</dt> <dd>eric.carlson@apple.com</dd>
<dt>Date</dt> <dd>2016-02-04 14:54:02 -0800 (Thu, 04 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>media/video-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124932
<rdar://problem/23336430>
Reviewed by Jer Noble.
* media/video-size.html: Add logic to retry each stage silently twice before logging
failure because we can't predict how long it will take to load the poster frame.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediavideosizehtml">trunk/LayoutTests/media/video-size.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (196149 => 196150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-02-04 22:07:45 UTC (rev 196149)
+++ trunk/LayoutTests/ChangeLog 2016-02-04 22:54:02 UTC (rev 196150)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-02-04 Eric Carlson <eric.carlson@apple.com>
+
+ media/video-size.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=124932
+ <rdar://problem/23336430>
+
+ Reviewed by Jer Noble.
+
+ * media/video-size.html: Add logic to retry each stage silently twice before logging
+ failure because we can't predict how long it will take to load the poster frame.
+
</ins><span class="cx"> 2016-02-04 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Object.getOwnPropertyDescriptor() returns incomplete descriptor for instance properties
</span></span></pre></div>
<a id="trunkLayoutTestsmediavideosizehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/video-size.html (196149 => 196150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/video-size.html 2016-02-04 22:07:45 UTC (rev 196149)
+++ trunk/LayoutTests/media/video-size.html 2016-02-04 22:54:02 UTC (rev 196150)
</span><span class="lines">@@ -8,6 +8,7 @@
</span><span class="cx"> var movieInfo =
</span><span class="cx"> {
</span><span class="cx"> current:0,
</span><ins>+ retryCount: 0,
</ins><span class="cx"> movies:
</span><span class="cx"> [
</span><span class="cx"> {
</span><span class="lines">@@ -61,6 +62,8 @@
</span><span class="cx"> function setupNextConfiguration()
</span><span class="cx"> {
</span><span class="cx"> consoleWrite("");
</span><ins>+ movieInfo.current++;
+ movieInfo.retryCount = 0;
</ins><span class="cx"> if (movieInfo.current >= movieInfo.movies.length)
</span><span class="cx"> {
</span><span class="cx"> endTest();
</span><span class="lines">@@ -100,6 +103,16 @@
</span><span class="cx"> var temp = document.body.offsetWidth;
</span><span class="cx"> var movie = movieInfo.movies[movieInfo.current];
</span><span class="cx">
</span><ins>+ // We can't detect when the poster has loaded and the 100ms timeout may
+ // not be long enough on a slow/loaded machine.
+ if (video.clientWidth != movie.width || video.clientHeight != movie.height
+ || video.videoWidth != movie.videoWidth || video.videoHeight != movie.videoHeight) {
+ if (++movieInfo.retryCount <= 2) {
+ setTimeout(testMovie, 100);
+ return;
+ }
+ }
+
</ins><span class="cx"> var desc = "<b>Testing movie with " + movie.description + ".</b>";
</span><span class="cx"> consoleWrite(desc);
</span><span class="cx">
</span><span class="lines">@@ -108,7 +121,6 @@
</span><span class="cx"> testExpected("video.videoWidth", movie.videoWidth);
</span><span class="cx"> testExpected("video.videoHeight", movie.videoHeight);
</span><span class="cx">
</span><del>- movieInfo.current++;
</del><span class="cx"> setupNextConfiguration();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>