<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196061] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196061">196061</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-02-03 02:37:12 -0800 (Wed, 03 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
https://bugs.webkit.org/show_bug.cgi?id=145253
Reviewed by Michael Catanzaro.
Source/WebCore:
The problem is that when the load is cancelled while the
connection is still being established,
SoupMessage::notify::tls-errors is emitted and the handler calls
ResourceHandleClient::didFail() which can delete the ResourceHandle.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
for the scope of the callback because
ResourceHandleClient::didFail() could delete the object.
LayoutTests:
Update test expectation.
* platform/gtk/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworksoupResourceHandleSoupcpp">trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (196060 => 196061)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-02-03 10:31:27 UTC (rev 196060)
+++ trunk/LayoutTests/ChangeLog 2016-02-03 10:37:12 UTC (rev 196061)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ [GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=145253
+
+ Reviewed by Michael Catanzaro.
+
+ Update test expectation.
+
+ * platform/gtk/TestExpectations:
+
+2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=152797
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (196060 => 196061)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-02-03 10:31:27 UTC (rev 196060)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-02-03 10:37:12 UTC (rev 196061)
</span><span class="lines">@@ -1748,7 +1748,7 @@
</span><span class="cx"> webkit.org/b/123431 http/tests/local/link-stylesheet-load-order-preload.html [ Failure ]
</span><span class="cx"> webkit.org/b/123431 http/tests/local/link-stylesheet-load-order.html [ Failure Pass ]
</span><span class="cx">
</span><del>-webkit.org/b/145253 http/tests/appcache/different-https-origin-resource-main.html [ Failure Crash ]
</del><ins>+webkit.org/b/145253 http/tests/appcache/different-https-origin-resource-main.html [ Failure ]
</ins><span class="cx">
</span><span class="cx"> #////////////////////////////////////////////////////////////////////////////////////////
</span><span class="cx"> # Tests failing
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (196060 => 196061)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-02-03 10:31:27 UTC (rev 196060)
+++ trunk/Source/WebCore/ChangeLog 2016-02-03 10:37:12 UTC (rev 196061)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ [GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=145253
+
+ Reviewed by Michael Catanzaro.
+
+ The problem is that when the load is cancelled while the
+ connection is still being established,
+ SoupMessage::notify::tls-errors is emitted and the handler calls
+ ResourceHandleClient::didFail() which can delete the ResourceHandle.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
+ for the scope of the callback because
+ ResourceHandleClient::didFail() could delete the object.
+
+2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=152797
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworksoupResourceHandleSoupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (196060 => 196061)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2016-02-03 10:31:27 UTC (rev 196060)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2016-02-03 10:37:12 UTC (rev 196061)
</span><span class="lines">@@ -338,11 +338,11 @@
</span><span class="cx">
</span><span class="cx"> static void tlsErrorsChangedCallback(SoupMessage* message, GParamSpec*, gpointer data)
</span><span class="cx"> {
</span><del>- ResourceHandle* handle = static_cast<ResourceHandle*>(data);
</del><ins>+ RefPtr<ResourceHandle> handle = static_cast<ResourceHandle*>(data);
</ins><span class="cx"> if (!handle || handle->cancelledOrClientless())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (handleUnignoredTLSErrors(handle, message))
</del><ins>+ if (handleUnignoredTLSErrors(handle.get(), message))
</ins><span class="cx"> handle->cancel();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>