<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196060] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196060">196060</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-02-03 02:31:27 -0800 (Wed, 03 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/191948">r191948</a>): [GStreamer] 4 new timeouts on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=152797
Reviewed by Darin Adler.
Source/WebCore:
Always schedule messages to the main thread, even when the bus
sync handlder was called in the main thread. It seems that
GStreamer expects things to happen in the next main loop
iteration.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
LayoutTests:
Update test expectations.
* platform/gtk/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsgstreamerMediaPlayerPrivateGStreamercpp">trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (196059 => 196060)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-02-03 09:56:54 UTC (rev 196059)
+++ trunk/LayoutTests/ChangeLog 2016-02-03 10:31:27 UTC (rev 196060)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
+ https://bugs.webkit.org/show_bug.cgi?id=152797
+
+ Reviewed by Darin Adler.
+
+ Update test expectations.
+
+ * platform/gtk/TestExpectations:
+
</ins><span class="cx"> 2016-02-02 Fujii Hironori <Hironori.Fujii@jp.sony.com>
</span><span class="cx">
</span><span class="cx"> ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (196059 => 196060)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-02-03 09:56:54 UTC (rev 196059)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-02-03 10:31:27 UTC (rev 196060)
</span><span class="lines">@@ -1489,10 +1489,7 @@
</span><span class="cx"> webkit.org/b/144690 editing/spelling/spelling-with-punctuation-selection.html [ Timeout ]
</span><span class="cx"> webkit.org/b/144690 editing/spelling/delete-into-misspelled-word.html [ Timeout Pass ]
</span><span class="cx">
</span><del>-webkit.org/b/141835 media/video-controls-no-scripting.html [ Failure Timeout ]
-webkit.org/b/152797 media/video-source-error.html [ Timeout ]
-webkit.org/b/152797 media/video-source-load.html [ Timeout ]
-webkit.org/b/152797 media/video-source-moved.html [ Timeout ]
</del><ins>+webkit.org/b/141835 media/video-controls-no-scripting.html [ Failure ]
</ins><span class="cx">
</span><span class="cx"> # May take too long on the bots.
</span><span class="cx"> Bug(GTK) mathml/very-large-stretchy-operators.html [ Pass Timeout ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (196059 => 196060)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-02-03 09:56:54 UTC (rev 196059)
+++ trunk/Source/WebCore/ChangeLog 2016-02-03 10:31:27 UTC (rev 196060)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
+ https://bugs.webkit.org/show_bug.cgi?id=152797
+
+ Reviewed by Darin Adler.
+
+ Always schedule messages to the main thread, even when the bus
+ sync handlder was called in the main thread. It seems that
+ GStreamer expects things to happen in the next main loop
+ iteration.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
+
</ins><span class="cx"> 2016-02-03 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> [TexMap] CompositingCoordinator should store the overlay layer, flush it as appropriate
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsgstreamerMediaPlayerPrivateGStreamercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (196059 => 196060)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2016-02-03 09:56:54 UTC (rev 196059)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2016-02-03 10:31:27 UTC (rev 196060)
</span><span class="lines">@@ -1903,16 +1903,12 @@
</span><span class="cx"> auto& player = *static_cast<MediaPlayerPrivateGStreamer*>(userData);
</span><span class="cx">
</span><span class="cx"> if (!player.handleSyncMessage(message)) {
</span><del>- if (isMainThread())
- player.handleMessage(message);
- else {
- GRefPtr<GstMessage> protectMessage(message);
- auto weakThis = player.createWeakPtr();
- RunLoop::main().dispatch([weakThis, protectMessage] {
- if (weakThis)
- weakThis->handleMessage(protectMessage.get());
- });
- }
</del><ins>+ GRefPtr<GstMessage> protectedMessage(message);
+ auto weakThis = player.createWeakPtr();
+ RunLoop::main().dispatch([weakThis, protectedMessage] {
+ if (weakThis)
+ weakThis->handleMessage(protectedMessage.get());
+ });
</ins><span class="cx"> }
</span><span class="cx"> gst_message_unref(message);
</span><span class="cx"> return GST_BUS_DROP;
</span></span></pre>
</div>
</div>
</body>
</html>