<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[196007] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/196007">196007</a></dd>
<dt>Author</dt> <dd>g.czajkowski@samsung.com</dd>
<dt>Date</dt> <dd>2016-02-02 04:26:38 -0800 (Tue, 02 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Virtual Keyboard overlaps MiniBrowser's WebView
https://bugs.webkit.org/show_bug.cgi?id=153009
Reviewed by Gyuyoung Kim.
On mobile, virtual keyboard represented by ecore_imf module appears on
the top of application layer usually covering bottom part of the screen.
If the web page contains the editable content on the bottom of the page
it will be overlapped by keyboard which prevents user from seeing the
typed text.
Pack MiniBrowser layout into conformant widget to allow EFL to guess
the space that will be required by the keyboard, finally resizing it
to the desired size. As a result, webview gets resized and scrolled
into focused elements which makes the editable elements visible while
typing.
More details about elm_conformant widger can be found at:
https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
* MiniBrowser/efl/main.c:
(window_create): pack a box into conformant widget.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsereflmainc">trunk/Tools/MiniBrowser/efl/main.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (196006 => 196007)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-02-02 11:35:33 UTC (rev 196006)
+++ trunk/Tools/ChangeLog 2016-02-02 12:26:38 UTC (rev 196007)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-01-29 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
+ https://bugs.webkit.org/show_bug.cgi?id=153009
+
+ Reviewed by Gyuyoung Kim.
+
+ On mobile, virtual keyboard represented by ecore_imf module appears on
+ the top of application layer usually covering bottom part of the screen.
+ If the web page contains the editable content on the bottom of the page
+ it will be overlapped by keyboard which prevents user from seeing the
+ typed text.
+
+ Pack MiniBrowser layout into conformant widget to allow EFL to guess
+ the space that will be required by the keyboard, finally resizing it
+ to the desired size. As a result, webview gets resized and scrolled
+ into focused elements which makes the editable elements visible while
+ typing.
+
+ More details about elm_conformant widger can be found at:
+ https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
+ https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
+
+ * MiniBrowser/efl/main.c:
+ (window_create): pack a box into conformant widget.
+
</ins><span class="cx"> 2016-02-02 Alejandro G. Castro <alex@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK][EFL] Upgrade OpenWebRTC dependency
</span></span></pre></div>
<a id="trunkToolsMiniBrowsereflmainc"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/efl/main.c (196006 => 196007)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/efl/main.c 2016-02-02 11:35:33 UTC (rev 196006)
+++ trunk/Tools/MiniBrowser/efl/main.c 2016-02-02 12:26:38 UTC (rev 196007)
</span><span class="lines">@@ -2088,11 +2088,17 @@
</span><span class="cx"> elm_win_resize_object_add(window->elm_window, bg);
</span><span class="cx"> evas_object_show(bg);
</span><span class="cx">
</span><ins>+ /* Create conformant widget. */
+ Evas_Object *conformant = elm_conformant_add(window->elm_window);
+ evas_object_size_hint_weight_set(conformant, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
+ elm_win_resize_object_add(window->elm_window, conformant);
+ evas_object_show(conformant);
+
</ins><span class="cx"> /* Create vertical layout */
</span><span class="cx"> window->vertical_layout = elm_box_add(window->elm_window);
</span><ins>+ elm_object_content_set(conformant, window->vertical_layout);
</ins><span class="cx"> elm_box_padding_set(window->vertical_layout, 0, 2);
</span><span class="cx"> evas_object_size_hint_weight_set(window->vertical_layout, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
</span><del>- elm_win_resize_object_add(window->elm_window, window->vertical_layout);
</del><span class="cx"> evas_object_show(window->vertical_layout);
</span><span class="cx">
</span><span class="cx"> /* Create horizontal layout for top bar */
</span></span></pre>
</div>
</div>
</body>
</html>