<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195983] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195983">195983</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2016-02-01 15:37:02 -0800 (Mon, 01 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Xcode] Let Xcode know that the WebKit XPC service products are XPC services
https://bugs.webkit.org/show_bug.cgi?id=153773
Reviewed by Tim Horton.
* Configurations/BaseXPCService.xcconfig: Removed now-redundant definitions of
MACH_O_TYPE and WRAPPER_EXTENSION.
* WebKit2.xcodeproj/project.pbxproj: Updated product types.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ConfigurationsBaseXPCServicexcconfig">trunk/Source/WebKit2/Configurations/BaseXPCService.xcconfig</a></li>
<li><a href="#trunkSourceWebKit2WebKit2xcodeprojprojectpbxproj">trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (195982 => 195983)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-02-01 23:31:30 UTC (rev 195982)
+++ trunk/Source/WebKit2/ChangeLog 2016-02-01 23:37:02 UTC (rev 195983)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-02-01 Dan Bernstein <mitz@apple.com>
+
+ [Xcode] Let Xcode know that the WebKit XPC service products are XPC services
+ https://bugs.webkit.org/show_bug.cgi?id=153773
+
+ Reviewed by Tim Horton.
+
+ * Configurations/BaseXPCService.xcconfig: Removed now-redundant definitions of
+ MACH_O_TYPE and WRAPPER_EXTENSION.
+ * WebKit2.xcodeproj/project.pbxproj: Updated product types.
+
</ins><span class="cx"> 2016-02-01 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Crash using WKPDFView, in -[UIPDFPageView showContent]
</span></span></pre></div>
<a id="trunkSourceWebKit2ConfigurationsBaseXPCServicexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Configurations/BaseXPCService.xcconfig (195982 => 195983)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Configurations/BaseXPCService.xcconfig 2016-02-01 23:31:30 UTC (rev 195982)
+++ trunk/Source/WebKit2/Configurations/BaseXPCService.xcconfig 2016-02-01 23:37:02 UTC (rev 195983)
</span><span class="lines">@@ -36,9 +36,6 @@
</span><span class="cx">
</span><span class="cx"> EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(CONFIGURATION)) *.xib;
</span><span class="cx">
</span><del>-WRAPPER_EXTENSION = xpc;
-MACH_O_TYPE = mh_execute;
-
</del><span class="cx"> OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
</span><span class="cx">
</span><span class="cx"> WK_RELOCATABLE_FRAMEWORKS_LDFLAGS = $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS_$(WK_RELOCATABLE_FRAMEWORKS));
</span></span></pre></div>
<a id="trunkSourceWebKit2WebKit2xcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (195982 => 195983)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2016-02-01 23:31:30 UTC (rev 195982)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2016-02-01 23:37:02 UTC (rev 195983)
</span><span class="lines">@@ -8381,7 +8381,7 @@
</span><span class="cx"> name = Databases;
</span><span class="cx"> productName = Networking;
</span><span class="cx"> productReference = 51F7DC4A180CC93600212CA3 /* com.apple.WebKit.Databases.Development.xpc */;
</span><del>- productType = "com.apple.product-type.bundle";
</del><ins>+ productType = "com.apple.product-type.xpc-service";
</ins><span class="cx"> };
</span><span class="cx"> 51FA1E17180CCADE00C44BE9 /* DatabaseProcess */ = {
</span><span class="cx"> isa = PBXNativeTarget;
</span><span class="lines">@@ -8456,7 +8456,7 @@
</span><span class="cx"> name = WebContent;
</span><span class="cx"> productName = WebKit2Service;
</span><span class="cx"> productReference = BC3DE46615A91763008D26FC /* com.apple.WebKit.WebContent.Development.xpc */;
</span><del>- productType = "com.apple.product-type.bundle";
</del><ins>+ productType = "com.apple.product-type.xpc-service";
</ins><span class="cx"> };
</span><span class="cx"> BC8283B016B4BF7700A278FE /* Networking */ = {
</span><span class="cx"> isa = PBXNativeTarget;
</span><span class="lines">@@ -8474,7 +8474,7 @@
</span><span class="cx"> name = Networking;
</span><span class="cx"> productName = Networking;
</span><span class="cx"> productReference = BC8283B116B4BF7700A278FE /* com.apple.WebKit.Networking.Development.xpc */;
</span><del>- productType = "com.apple.product-type.bundle";
</del><ins>+ productType = "com.apple.product-type.xpc-service";
</ins><span class="cx"> };
</span><span class="cx"> BC8283F816B4FDDE00A278FE /* Plugin.32 */ = {
</span><span class="cx"> isa = PBXNativeTarget;
</span><span class="lines">@@ -8492,7 +8492,7 @@
</span><span class="cx"> name = Plugin.32;
</span><span class="cx"> productName = Plugin.32;
</span><span class="cx"> productReference = BC8283F916B4FDDE00A278FE /* com.apple.WebKit.Plugin.32.Development.xpc */;
</span><del>- productType = "com.apple.product-type.bundle";
</del><ins>+ productType = "com.apple.product-type.xpc-service";
</ins><span class="cx"> };
</span><span class="cx"> BC82841E16B4FDF600A278FE /* Plugin.64 */ = {
</span><span class="cx"> isa = PBXNativeTarget;
</span><span class="lines">@@ -8510,7 +8510,7 @@
</span><span class="cx"> name = Plugin.64;
</span><span class="cx"> productName = Plugin.64;
</span><span class="cx"> productReference = BC82841F16B4FDF600A278FE /* com.apple.WebKit.Plugin.64.Development.xpc */;
</span><del>- productType = "com.apple.product-type.bundle";
</del><ins>+ productType = "com.apple.product-type.xpc-service";
</ins><span class="cx"> };
</span><span class="cx"> BCDE093313272496001259FB /* PluginProcess */ = {
</span><span class="cx"> isa = PBXNativeTarget;
</span></span></pre>
</div>
</div>
</body>
</html>