<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195962] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195962">195962</a></dd>
<dt>Author</dt> <dd>jmarcell@apple.com</dd>
<dt>Date</dt> <dd>2016-02-01 09:02:38 -0800 (Mon, 01 Feb 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improvements to botwatcher's dashboard unit tests.
https://bugs.webkit.org/show_bug.cgi?id=153621
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
(PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac): Changing <a href="http://trac.webkit.org/projects/webkit/changeset/33019">revision 33019</a> to be on a different branch so that _appendPendingRevisionCount and
_popoverLinesForCommitRange have to traverse commits from different branches.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
_revisionContentWithPopoverForIteration.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsPopoverTrackerjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptstestsMockTracjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsteststestsjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsPopoverTrackerjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js (195961 => 195962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2016-02-01 17:01:56 UTC (rev 195961)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2016-02-01 17:02:38 UTC (rev 195962)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> element.classList.add("popover-tracking");
</span><span class="cx"> element.addEventListener("mouseenter", this._mouseEnteredPopoverOrElement.bind(this), true);
</span><span class="cx"> element.addEventListener("mouseleave", this._mouseExitedPopoverOrElement.bind(this), true);
</span><ins>+ element.popoverTracker = this;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // Only one popover may be active at any time. An active popover is not necessarily visible already.
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptstestsMockTracjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js (195961 => 195962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js 2016-02-01 17:01:56 UTC (rev 195961)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js 2016-02-01 17:02:38 UTC (rev 195962)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> "date": new Date("2015-11-16T01:18:23.000Z"),
</span><span class="cx"> "description": "description",
</span><span class="cx"> "containsBranchLocation": true,
</span><del>- "branchName": "trunk"
</del><ins>+ "branchName": "someOtherBranch"
</ins><span class="cx"> },
</span><span class="cx"> {
</span><span class="cx"> "revisionNumber": 33020,
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsteststestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js (195961 => 195962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js 2016-02-01 17:01:56 UTC (rev 195961)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js 2016-02-01 17:02:38 UTC (rev 195962)
</span><span class="lines">@@ -76,13 +76,13 @@
</span><span class="cx"> {
</span><span class="cx"> this.view._appendPendingRevisionCount(this.queue);
</span><span class="cx"> var revisionsBehind = this.view.element.getElementsByClassName("message")[0].innerHTML.match(/.*(\d+) revision(|s) behind/)[1];
</span><del>- equal(revisionsBehind, "1", "assert revisions behind");
</del><ins>+ strictEqual(revisionsBehind, "1", "assert revisions behind");
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test("_popoverLinesForCommitRange", function()
</span><span class="cx"> {
</span><span class="cx"> var lines = this.view._popoverLinesForCommitRange(this.trac, this.trunkBranch, 33018, 33020);
</span><del>- strictEqual(lines.length, 3, "has 3 lines");
</del><ins>+ strictEqual(lines.length, 2, "has 2 lines");
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test("_presentPopoverForPendingCommits", function()
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx"> };
</span><span class="cx"> this.view._presentPopoverForRevisionRange(element, popover, context);
</span><span class="cx"> var nodeList = popover._element.getElementsByClassName("pending-commit");
</span><del>- strictEqual(nodeList.length, 3, "has 3 commits");
</del><ins>+ strictEqual(nodeList.length, 2, "has 2 commits");
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test("_presentPopoverForRevisionRange no commits", function()
</span><span class="lines">@@ -147,6 +147,11 @@
</span><span class="cx"> strictEqual(content.innerHTML, "r33022", "should have correct revision number.");
</span><span class="cx"> strictEqual(content.classList.contains("revision-number"), true, "should have class 'revision-number'.");
</span><span class="cx"> strictEqual(content.classList.contains("popover-tracking"), true, "should have class 'popover-tracking'.");
</span><ins>+ var element = document.createElement("div");
+ var popover = new Dashboard.Popover();
+ this.view._presentPopoverForRevisionRange(element, popover, content.popoverTracker._context);
+ var nodeList = popover._element.getElementsByClassName("pending-commit");
+ strictEqual(nodeList.length, 2, "has 2 commits");
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> module("BuildBotQueue", {
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (195961 => 195962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-02-01 17:01:56 UTC (rev 195961)
+++ trunk/Tools/ChangeLog 2016-02-01 17:02:38 UTC (rev 195962)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-02-01 Jason Marcell <jmarcell@apple.com>
</span><span class="cx">
</span><ins>+ Improvements to botwatcher's dashboard unit tests.
+ https://bugs.webkit.org/show_bug.cgi?id=153621
+
+ Reviewed by Darin Adler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
+ (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
+ (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
+ _popoverLinesForCommitRange have to traverse commits from different branches.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
+ in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
+ _revisionContentWithPopoverForIteration.
+
+2016-02-01 Jason Marcell <jmarcell@apple.com>
+
</ins><span class="cx"> Refactor to add event listeners and start periodic updates for all trac instances.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=153609
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>