<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195950] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195950">195950</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2016-01-31 20:44:07 -0800 (Sun, 31 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
https://bugs.webkit.org/show_bug.cgi?id=153657
<rdar://problem/24413107>
Reviewed by Darin Adler.
Source/WebCore:
Tested by http/tests/plugins/visible_plugins.html.
A number of poorly-coded sites break when WebKit reports that it understands PDF mime types,
but does not have a list of plugins that the site can iterate through.
To avoid this compatibility problem, we should also expose the "WebKit built-in PDF" plugin
to avoid this edge case.
* plugins/PluginData.cpp:
(WebCore::shouldBePubliclyVisible): Add "WebKit built-in PDF" plugin.
LayoutTests:
* http/tests/plugins/visible_plugins-expected.txt: Added.
* http/tests/plugins/visible_plugins.html: Added.
* platform/mac-wk2/http/tests/plugins: Added.
* platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepluginsPluginDatacpp">trunk/Source/WebCore/plugins/PluginData.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestshttptestspluginsvisible_pluginsexpectedtxt">trunk/LayoutTests/http/tests/plugins/visible_plugins-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestspluginsvisible_pluginshtml">trunk/LayoutTests/http/tests/plugins/visible_plugins.html</a></li>
<li>trunk/LayoutTests/platform/mac-wk2/http/tests/plugins/</li>
<li><a href="#trunkLayoutTestsplatformmacwk2httptestspluginsvisible_pluginsexpectedtxt">trunk/LayoutTests/platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195949 => 195950)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-02-01 04:09:02 UTC (rev 195949)
+++ trunk/LayoutTests/ChangeLog 2016-02-01 04:44:07 UTC (rev 195950)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-01-31 Brent Fulgham <bfulgham@apple.com>
+
+ Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
+ https://bugs.webkit.org/show_bug.cgi?id=153657
+ <rdar://problem/24413107>
+
+ Reviewed by Darin Adler.
+
+ * http/tests/plugins/visible_plugins-expected.txt: Added.
+ * http/tests/plugins/visible_plugins.html: Added.
+ * platform/mac-wk2/http/tests/plugins: Added.
+ * platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt: Added.
+
</ins><span class="cx"> 2016-01-31 Doug Russell <d_russell@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Add a boundary value to AXTextStateChangeType
</span></span></pre></div>
<a id="trunkLayoutTestshttptestspluginsvisible_pluginsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/http/tests/plugins/visible_plugins-expected.txt (0 => 195950)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/plugins/visible_plugins-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/plugins/visible_plugins-expected.txt 2016-02-01 04:44:07 UTC (rev 195950)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+Check we only display the valid set of "public" plugins.
+
+None
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestspluginsvisible_pluginshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/http/tests/plugins/visible_plugins.html (0 => 195950)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/plugins/visible_plugins.html (rev 0)
+++ trunk/LayoutTests/http/tests/plugins/visible_plugins.html 2016-02-01 04:44:07 UTC (rev 195950)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<html>
+<head>
+<script>
+function test()
+{
+ if (window.testRunner) {
+ testRunner.waitUntilDone();
+ testRunner.dumpAsText();
+ internals.setShowAllPlugins(false);
+ }
+
+ var pluginList = "";
+ Array.prototype.forEach.call(navigator.plugins, function(plugin) {
+ if (pluginList.length)
+ pluginList = pluginList + "\n";
+ pluginList = pluginList + plugin.name;
+ });
+
+ if (pluginList.length)
+ document.getElementById("result").innerText = pluginList;
+ if (window.testRunner)
+ testRunner.notifyDone();
+}
+</script>
+</head>
+<body onload="test();">
+<p>
+ Check we only display the valid set of "public" plugins.
+</p>
+<div id="result">None</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2httptestspluginsvisible_pluginsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt (0 => 195950)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt 2016-02-01 04:44:07 UTC (rev 195950)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+Check we only display the valid set of "public" plugins.
+
+WebKit built-in PDF
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195949 => 195950)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-02-01 04:09:02 UTC (rev 195949)
+++ trunk/Source/WebCore/ChangeLog 2016-02-01 04:44:07 UTC (rev 195950)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-01-31 Brent Fulgham <bfulgham@apple.com>
+
+ Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
+ https://bugs.webkit.org/show_bug.cgi?id=153657
+ <rdar://problem/24413107>
+
+ Reviewed by Darin Adler.
+
+ Tested by http/tests/plugins/visible_plugins.html.
+
+ A number of poorly-coded sites break when WebKit reports that it understands PDF mime types,
+ but does not have a list of plugins that the site can iterate through.
+
+ To avoid this compatibility problem, we should also expose the "WebKit built-in PDF" plugin
+ to avoid this edge case.
+
+ * plugins/PluginData.cpp:
+ (WebCore::shouldBePubliclyVisible): Add "WebKit built-in PDF" plugin.
+
</ins><span class="cx"> 2016-01-31 Doug Russell <d_russell@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Add a boundary value to AXTextStateChangeType
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsPluginDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/PluginData.cpp (195949 => 195950)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/PluginData.cpp 2016-02-01 04:09:02 UTC (rev 195949)
+++ trunk/Source/WebCore/plugins/PluginData.cpp 2016-02-01 04:44:07 UTC (rev 195950)
</span><span class="lines">@@ -24,6 +24,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "PluginData.h"
</span><span class="cx">
</span><ins>+#include "LocalizedStrings.h"
</ins><span class="cx"> #include "Page.h"
</span><span class="cx"> #include "PlatformStrategies.h"
</span><span class="cx"> #include "PluginStrategy.h"
</span><span class="lines">@@ -45,6 +46,18 @@
</span><span class="cx"> return plugins;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#if PLATFORM(COCOA)
+static inline bool isBuiltInPDFPlugIn(const PluginInfo& plugIn)
+{
+ return plugIn.name == builtInPDFPluginName();
+}
+#else
+static inline bool isBuiltInPDFPlugIn(const PluginInfo&)
+{
+ return false;
+}
+#endif
+
</ins><span class="cx"> static bool shouldBePubliclyVisible(const PluginInfo& plugin)
</span><span class="cx"> {
</span><span class="cx"> // For practical website compatibility, there are a few plugins that need to be
</span><span class="lines">@@ -52,7 +65,8 @@
</span><span class="cx"> // there is a good track record that this does not harm compatibility.
</span><span class="cx"> return plugin.name.containsIgnoringASCIICase("Shockwave")
</span><span class="cx"> || plugin.name.containsIgnoringASCIICase("QuickTime")
</span><del>- || plugin.name.containsIgnoringASCIICase("Java");
</del><ins>+ || plugin.name.containsIgnoringASCIICase("Java")
+ || isBuiltInPDFPlugIn(plugin);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Vector<PluginInfo> PluginData::publiclyVisiblePlugins() const
</span></span></pre>
</div>
</div>
</body>
</html>