<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195901] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195901">195901</a></dd>
<dt>Author</dt> <dd>adachan@apple.com</dd>
<dt>Date</dt> <dd>2016-01-30 11:30:49 -0800 (Sat, 30 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
https://bugs.webkit.org/show_bug.cgi?id=153665
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
Source/WTF:
* wtf/Platform.h:
Remove this as the flag is already defined in FeatureDefines.xcconfig files.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreConfigurationsFeatureDefinesxcconfig">trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfPlatformh">trunk/Source/WTF/wtf/Platform.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreConfigurationsFeatureDefinesxcconfig">trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacConfigurationsFeatureDefinesxcconfig">trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ConfigurationsFeatureDefinesxcconfig">trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-01-29 Ada Chan <adachan@apple.com>
+
+ Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=153665
+
+ Reviewed by Dan Bernstein.
+
+ * Configurations/FeatureDefines.xcconfig:
+
</ins><span class="cx"> 2016-01-30 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [B3] REGRESSION(r195882): Should break early after modConstant replaceWithNewValue succeeds
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -169,10 +169,9 @@
</span><span class="cx"> ENABLE_USERSELECT_ALL = ENABLE_USERSELECT_ALL;
</span><span class="cx"> ENABLE_VIDEO = ENABLE_VIDEO;
</span><span class="cx"> ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
</span><del>-ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
</del><ins>+ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR)_$(CONFIGURATION))
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Release = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug);
</ins><span class="cx"> ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
</span><span class="cx"> ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
</span><span class="cx"> ENABLE_VIEW_MODE_CSS_MEDIA = ;
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WTF/ChangeLog 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-01-29 Ada Chan <adachan@apple.com>
+
+ Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=153665
+
+ Reviewed by Dan Bernstein.
+
+ * wtf/Platform.h:
+ Remove this as the flag is already defined in FeatureDefines.xcconfig files.
+
</ins><span class="cx"> 2016-01-30 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Enable SamplingProfiler on POSIX environment
</span></span></pre></div>
<a id="trunkSourceWTFwtfPlatformh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Platform.h (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Platform.h 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WTF/wtf/Platform.h 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -1144,10 +1144,6 @@
</span><span class="cx"> #define USE_MEDIATOOLBOX 1
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)
-#define ENABLE_VIDEO_PRESENTATION_MODE 1
-#endif
-
</del><span class="cx"> /* While 10.10 has support for fences, it is missing some API important for our integration of them. */
</span><span class="cx"> #if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100)
</span><span class="cx"> #define HAVE_COREANIMATION_FENCES 1
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebCore/ChangeLog 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-01-29 Ada Chan <adachan@apple.com>
+
+ Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=153665
+
+ Reviewed by Dan Bernstein.
+
+ * Configurations/FeatureDefines.xcconfig:
+
</ins><span class="cx"> 2016-01-30 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] WebKit1 apps crash in ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1
</span></span></pre></div>
<a id="trunkSourceWebCoreConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -169,10 +169,9 @@
</span><span class="cx"> ENABLE_USERSELECT_ALL = ENABLE_USERSELECT_ALL;
</span><span class="cx"> ENABLE_VIDEO = ENABLE_VIDEO;
</span><span class="cx"> ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
</span><del>-ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
</del><ins>+ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR)_$(CONFIGURATION))
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Release = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug);
</ins><span class="cx"> ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
</span><span class="cx"> ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
</span><span class="cx"> ENABLE_VIEW_MODE_CSS_MEDIA = ;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-01-29 Ada Chan <adachan@apple.com>
+
+ Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=153665
+
+ Reviewed by Dan Bernstein.
+
+ * Configurations/FeatureDefines.xcconfig:
+
</ins><span class="cx"> 2016-01-28 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
</span></span></pre></div>
<a id="trunkSourceWebKitmacConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -169,10 +169,9 @@
</span><span class="cx"> ENABLE_USERSELECT_ALL = ENABLE_USERSELECT_ALL;
</span><span class="cx"> ENABLE_VIDEO = ENABLE_VIDEO;
</span><span class="cx"> ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
</span><del>-ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
</del><ins>+ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR)_$(CONFIGURATION))
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Release = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug);
</ins><span class="cx"> ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
</span><span class="cx"> ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
</span><span class="cx"> ENABLE_VIEW_MODE_CSS_MEDIA = ;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebKit2/ChangeLog 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-01-29 Ada Chan <adachan@apple.com>
+
+ Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=153665
+
+ Reviewed by Dan Bernstein.
+
+ * Configurations/FeatureDefines.xcconfig:
+
</ins><span class="cx"> 2016-01-29 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> Don’t use the “.Development” suffix for engineering builds targeting iOS devices, because the XPC cache is only aware of the unsuffixed service identifiers.
</span></span></pre></div>
<a id="trunkSourceWebKit2ConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (195900 => 195901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2016-01-30 19:30:49 UTC (rev 195901)
</span><span class="lines">@@ -169,10 +169,9 @@
</span><span class="cx"> ENABLE_USERSELECT_ALL = ENABLE_USERSELECT_ALL;
</span><span class="cx"> ENABLE_VIDEO = ENABLE_VIDEO;
</span><span class="cx"> ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
</span><del>-ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
</del><ins>+ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR)_$(CONFIGURATION))
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Release = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug);
</ins><span class="cx"> ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
</span><span class="cx"> ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
</span><span class="cx"> ENABLE_VIEW_MODE_CSS_MEDIA = ;
</span></span></pre>
</div>
</div>
</body>
</html>