<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195904] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195904">195904</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-01-30 12:10:18 -0800 (Sat, 30 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move more 'constructor' properties to the prototype
https://bugs.webkit.org/show_bug.cgi?id=153667
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing. A lot of
the 'constructor' attributes checks are still failing because the
attribute is not writable. This is being addressed via Bug 149412.
* web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt:
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
* web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move more 'constructor' properties to the prototype. In particular, we
used to keep the 'constructor' on the instance for interfaces that have
an indexed / named property getter because our getOwnPropertySlot()
implementation used to be wrong for such interfaces.
However, getOwnPropertySlot() should be correct after <a href="http://trac.webkit.org/projects/webkit/changeset/188590">r188590</a> so we
should now be able to move the 'constructor' up to the prototype for
these interfaces, as per the specification:
http://heycam.github.io/webidl/#interface-prototype-object
No new tests, already covered by existing tests.
* bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
Add a null check for staticPropHashTable. It is now null because this
type no longer has any property on the instance now that 'constructor'
is on the prototype.
* bindings/scripts/CodeGeneratorJS.pm:
(ConstructorShouldBeOnInstance):
LayoutTests:
Rebaseline a couple of tests now that 'constructor' is on the prototype
for more interfaces.
* fast/dom/htmlcollection-getownpropertynames-expected.txt:
* storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomhtmlcollectiongetownpropertynamesexpectedtxt">trunk/LayoutTests/fast/dom/htmlcollection-getownpropertynames-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomcollectionsHTMLCollectionsupportedpropertynamesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesElementgetElementsByTagNameexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomdocumentsdomtreeaccessorsdocumentformsexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstoragedomstoragelocalstoragedeletedefinepropertyremovalexpectedtxt">trunk/LayoutTests/storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSPluginElementFunctionsh">trunk/Source/WebCore/bindings/js/JSPluginElementFunctions.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/ChangeLog 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-01-30 Chris Dumez <cdumez@apple.com>
+
+ Move more 'constructor' properties to the prototype
+ https://bugs.webkit.org/show_bug.cgi?id=153667
+
+ Reviewed by Darin Adler.
+
+ Rebaseline a couple of tests now that 'constructor' is on the prototype
+ for more interfaces.
+
+ * fast/dom/htmlcollection-getownpropertynames-expected.txt:
+ * storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:
+
</ins><span class="cx"> 2016-01-30 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> TouchList should be retargeted
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomhtmlcollectiongetownpropertynamesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/htmlcollection-getownpropertynames-expected.txt (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/htmlcollection-getownpropertynames-expected.txt 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/fast/dom/htmlcollection-getownpropertynames-expected.txt 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -4,7 +4,7 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> * Own properties
</span><del>-Actual: ['0', '1', '2', '3', '4', '5', '6', '7', 'some-id', 'some-name', 'another-id', 'another-name', 'constructor', 'length']
</del><ins>+Actual: ['0', '1', '2', '3', '4', '5', '6', '7', 'some-id', 'some-name', 'another-id', 'another-name', 'length']
</ins><span class="cx"> Expected: ['0', '1', '2', '3', '4', '5', '6', '7', 'some-id', 'some-name', 'another-id', 'another-name']
</span><span class="cx">
</span><span class="cx"> * Enumerated properties
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-01-30 Chris Dumez <cdumez@apple.com>
+
+ Move more 'constructor' properties to the prototype
+ https://bugs.webkit.org/show_bug.cgi?id=153667
+
+ Reviewed by Darin Adler.
+
+ Rebaseline several W3C tests now that more checks are passing. A lot of
+ the 'constructor' attributes checks are still failing because the
+ attribute is not writable. This is being addressed via Bug 149412.
+
+ * web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt:
+ * web-platform-tests/dom/interfaces-expected.txt:
+ * web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
+ * web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
</ins><span class="cx"> 2016-01-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Move attributes to the prototype for List types / and types with indexed/named property getters
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomcollectionsHTMLCollectionsupportedpropertynamesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx">
</span><del>-FAIL Object.getOwnPropertyNames on HTMLCollection assert_array_equals: lengths differ, expected 12 got 14
-FAIL Object.getOwnPropertyNames on HTMLCollection with non-HTML namespace assert_array_equals: lengths differ, expected 1 got 3
-FAIL Object.getOwnPropertyNames on HTMLCollection with expando object assert_array_equals: lengths differ, expected 2 got 4
</del><ins>+FAIL Object.getOwnPropertyNames on HTMLCollection assert_array_equals: lengths differ, expected 12 got 13
+FAIL Object.getOwnPropertyNames on HTMLCollection with non-HTML namespace assert_array_equals: lengths differ, expected 1 got 2
+FAIL Object.getOwnPropertyNames on HTMLCollection with expando object assert_array_equals: lengths differ, expected 2 got 3
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -121,7 +121,7 @@
</span><span class="cx"> PASS NodeList interface object length
</span><span class="cx"> PASS NodeList interface object name
</span><span class="cx"> PASS NodeList interface: existence and properties of interface prototype object
</span><del>-FAIL NodeList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: NodeList.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL NodeList interface: existence and properties of interface prototype object's "constructor" property assert_true: NodeList.prototype.constructor is not writable expected true got false
</ins><span class="cx"> PASS NodeList interface: operation item(unsigned long)
</span><span class="cx"> FAIL NodeList interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> PASS NodeList must be primary interface of document.querySelectorAll("script")
</span><span class="lines">@@ -133,7 +133,7 @@
</span><span class="cx"> PASS HTMLCollection interface object length
</span><span class="cx"> PASS HTMLCollection interface object name
</span><span class="cx"> PASS HTMLCollection interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLCollection interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLCollection.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLCollection interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLCollection.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLCollection interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> FAIL HTMLCollection interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> FAIL HTMLCollection interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="lines">@@ -927,7 +927,7 @@
</span><span class="cx"> PASS NamedNodeMap interface object length
</span><span class="cx"> PASS NamedNodeMap interface object name
</span><span class="cx"> PASS NamedNodeMap interface: existence and properties of interface prototype object
</span><del>-FAIL NamedNodeMap interface: existence and properties of interface prototype object's "constructor" property assert_own_property: NamedNodeMap.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL NamedNodeMap interface: existence and properties of interface prototype object's "constructor" property assert_true: NamedNodeMap.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL NamedNodeMap interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> FAIL NamedNodeMap interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> FAIL NamedNodeMap interface: operation getNamedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="lines">@@ -1550,7 +1550,7 @@
</span><span class="cx"> PASS DOMTokenList interface object length
</span><span class="cx"> PASS DOMTokenList interface object name
</span><span class="cx"> PASS DOMTokenList interface: existence and properties of interface prototype object
</span><del>-FAIL DOMTokenList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: DOMTokenList.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL DOMTokenList interface: existence and properties of interface prototype object's "constructor" property assert_true: DOMTokenList.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL DOMTokenList interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> PASS DOMTokenList interface: operation item(unsigned long)
</span><span class="cx"> PASS DOMTokenList interface: operation contains(DOMString)
</span><span class="lines">@@ -1575,6 +1575,6 @@
</span><span class="cx"> PASS DOMSettableTokenList interface object length
</span><span class="cx"> PASS DOMSettableTokenList interface object name
</span><span class="cx"> PASS DOMSettableTokenList interface: existence and properties of interface prototype object
</span><del>-FAIL DOMSettableTokenList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: DOMSettableTokenList.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL DOMSettableTokenList interface: existence and properties of interface prototype object's "constructor" property assert_true: DOMSettableTokenList.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL DOMSettableTokenList interface: attribute value assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesElementgetElementsByTagNameexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Should be able to set expando shadowing a proto prop (item)
</span><span class="cx"> PASS Should be able to set expando shadowing a proto prop (namedItem)
</span><del>-FAIL hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames assert_array_equals: lengths differ, expected 7 got 9
</del><ins>+FAIL hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames assert_array_equals: lengths differ, expected 7 got 8
</ins><span class="cx"> PASS HTML element with uppercase tagName never matches in HTML Documents
</span><span class="cx"> PASS Element in non-HTML namespace, no prefix, lowercase name
</span><span class="cx"> PASS Element in non-HTML namespace, no prefix, uppercase name
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomdocumentsdomtreeaccessorsdocumentformsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -5,5 +5,5 @@
</span><span class="cx"> PASS document.forms.item with string arg
</span><span class="cx"> PASS document.forms with empty string
</span><span class="cx"> FAIL document.forms iteration assert_array_equals: property 3, expected "item" but got "length"
</span><del>-FAIL document.forms getOwnPropertyNames assert_array_equals: lengths differ, expected 5 got 7
</del><ins>+FAIL document.forms getOwnPropertyNames assert_array_equals: lengths differ, expected 5 got 6
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -755,7 +755,7 @@
</span><span class="cx"> PASS HTMLAllCollection interface object length
</span><span class="cx"> PASS HTMLAllCollection interface object name
</span><span class="cx"> FAIL HTMLAllCollection interface: existence and properties of interface prototype object assert_equals: prototype of HTMLAllCollection.prototype is not HTMLCollection.prototype expected object "[object HTMLCollectionPrototype]" but got object "[object Object]"
</span><del>-FAIL HTMLAllCollection interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLAllCollection.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLAllCollection interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLAllCollection.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLAllCollection interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> FAIL HTMLAllCollection interface: operation item(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> PASS HTMLAllCollection interface: operation namedItem(DOMString)
</span><span class="lines">@@ -776,7 +776,7 @@
</span><span class="cx"> PASS HTMLFormControlsCollection interface object length
</span><span class="cx"> PASS HTMLFormControlsCollection interface object name
</span><span class="cx"> PASS HTMLFormControlsCollection interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLFormControlsCollection interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLFormControlsCollection.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLFormControlsCollection interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLFormControlsCollection.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLFormControlsCollection interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> FAIL HTMLFormControlsCollection must be primary interface of document.createElement("form").elements assert_equals: wrong typeof object expected "function" but got "object"
</span><span class="cx"> FAIL Stringification of document.createElement("form").elements assert_equals: wrong typeof object expected "function" but got "object"
</span><span class="lines">@@ -791,13 +791,13 @@
</span><span class="cx"> PASS RadioNodeList interface object length
</span><span class="cx"> PASS RadioNodeList interface object name
</span><span class="cx"> PASS RadioNodeList interface: existence and properties of interface prototype object
</span><del>-FAIL RadioNodeList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: RadioNodeList.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL RadioNodeList interface: existence and properties of interface prototype object's "constructor" property assert_true: RadioNodeList.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL RadioNodeList interface: attribute value assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLOptionsCollection interface: existence and properties of interface object assert_equals: class string of HTMLOptionsCollection expected "[object Function]" but got "[object HTMLOptionsCollectionConstructor]"
</span><span class="cx"> PASS HTMLOptionsCollection interface object length
</span><span class="cx"> PASS HTMLOptionsCollection interface object name
</span><span class="cx"> PASS HTMLOptionsCollection interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLOptionsCollection interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLOptionsCollection.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLOptionsCollection interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLOptionsCollection.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLOptionsCollection interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> PASS HTMLOptionsCollection interface: operation add([object Object],[object Object],[object Object],[object Object])
</span><span class="cx"> FAIL HTMLOptionsCollection interface: operation remove(long) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="lines">@@ -842,7 +842,7 @@
</span><span class="cx"> PASS DOMStringMap interface object length
</span><span class="cx"> PASS DOMStringMap interface object name
</span><span class="cx"> PASS DOMStringMap interface: existence and properties of interface prototype object
</span><del>-FAIL DOMStringMap interface: existence and properties of interface prototype object's "constructor" property assert_own_property: DOMStringMap.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL DOMStringMap interface: existence and properties of interface prototype object's "constructor" property assert_true: DOMStringMap.prototype.constructor is not writable expected true got false
</ins><span class="cx"> PASS DOMStringMap must be primary interface of document.head.dataset
</span><span class="cx"> PASS Stringification of document.head.dataset
</span><span class="cx"> FAIL DOMElementMap interface: existence and properties of interface object assert_own_property: self does not have own property "DOMElementMap" expected property "DOMElementMap" missing
</span><span class="lines">@@ -1794,7 +1794,7 @@
</span><span class="cx"> PASS HTMLEmbedElement interface object length
</span><span class="cx"> PASS HTMLEmbedElement interface object name
</span><span class="cx"> PASS HTMLEmbedElement interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLEmbedElement interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLEmbedElement.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLEmbedElement interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLEmbedElement.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLEmbedElement interface: attribute src assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLEmbedElement interface: attribute type assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLEmbedElement interface: attribute width assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="lines">@@ -1815,7 +1815,7 @@
</span><span class="cx"> PASS HTMLObjectElement interface object length
</span><span class="cx"> PASS HTMLObjectElement interface object name
</span><span class="cx"> PASS HTMLObjectElement interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLObjectElement interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLObjectElement.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLObjectElement interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLObjectElement.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLObjectElement interface: attribute data assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLObjectElement interface: attribute type assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLObjectElement interface: attribute typeMustMatch assert_true: The prototype object must have a property "typeMustMatch" expected true got false
</span><span class="lines">@@ -2308,7 +2308,7 @@
</span><span class="cx"> PASS TextTrackList interface object length
</span><span class="cx"> PASS TextTrackList interface object name
</span><span class="cx"> FAIL TextTrackList interface: existence and properties of interface prototype object assert_equals: prototype of TextTrackList.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</span><del>-FAIL TextTrackList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: TextTrackList.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL TextTrackList interface: existence and properties of interface prototype object's "constructor" property assert_true: TextTrackList.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL TextTrackList interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> PASS TextTrackList interface: operation getTrackById(DOMString)
</span><span class="cx"> FAIL TextTrackList interface: attribute onchange assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="lines">@@ -2377,7 +2377,7 @@
</span><span class="cx"> PASS TextTrackCueList interface object length
</span><span class="cx"> PASS TextTrackCueList interface object name
</span><span class="cx"> PASS TextTrackCueList interface: existence and properties of interface prototype object
</span><del>-FAIL TextTrackCueList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: TextTrackCueList.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL TextTrackCueList interface: existence and properties of interface prototype object's "constructor" property assert_true: TextTrackCueList.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL TextTrackCueList interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> PASS TextTrackCueList interface: operation getCueById(DOMString)
</span><span class="cx"> PASS TextTrackCueList must be primary interface of document.createElement("video").addTextTrack("subtitles").cues
</span><span class="lines">@@ -2750,7 +2750,7 @@
</span><span class="cx"> PASS HTMLFormElement interface object length
</span><span class="cx"> PASS HTMLFormElement interface object name
</span><span class="cx"> PASS HTMLFormElement interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLFormElement interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLFormElement.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLFormElement interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLFormElement.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLFormElement interface: attribute acceptCharset assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLFormElement interface: attribute action assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLFormElement interface: attribute autocomplete assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="lines">@@ -2979,7 +2979,7 @@
</span><span class="cx"> PASS HTMLSelectElement interface object length
</span><span class="cx"> PASS HTMLSelectElement interface object name
</span><span class="cx"> PASS HTMLSelectElement interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLSelectElement interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLSelectElement.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLSelectElement interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLSelectElement.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLSelectElement interface: attribute autocomplete assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLSelectElement interface: attribute autofocus assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLSelectElement interface: attribute disabled assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="lines">@@ -4078,7 +4078,7 @@
</span><span class="cx"> PASS History interface object length
</span><span class="cx"> PASS History interface object name
</span><span class="cx"> PASS History interface: existence and properties of interface prototype object
</span><del>-FAIL History interface: existence and properties of interface prototype object's "constructor" property assert_own_property: History.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL History interface: existence and properties of interface prototype object's "constructor" property assert_true: History.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL History interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> FAIL History interface: attribute state assert_true: The prototype object must have a property "state" expected true got false
</span><span class="cx"> PASS History interface: operation go(long)
</span><span class="lines">@@ -4106,7 +4106,7 @@
</span><span class="cx"> PASS Location interface object length
</span><span class="cx"> PASS Location interface object name
</span><span class="cx"> PASS Location interface: existence and properties of interface prototype object
</span><del>-FAIL Location interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Location.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL Location interface: existence and properties of interface prototype object's "constructor" property assert_true: Location.prototype.constructor is not writable expected true got false
</ins><span class="cx"> PASS Location must be primary interface of window.location
</span><span class="cx"> PASS Stringification of window.location
</span><span class="cx"> FAIL Location interface: window.location must have own property "href" assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="lines">@@ -4302,7 +4302,7 @@
</span><span class="cx"> PASS PluginArray interface object length
</span><span class="cx"> PASS PluginArray interface object name
</span><span class="cx"> PASS PluginArray interface: existence and properties of interface prototype object
</span><del>-FAIL PluginArray interface: existence and properties of interface prototype object's "constructor" property assert_own_property: PluginArray.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL PluginArray interface: existence and properties of interface prototype object's "constructor" property assert_true: PluginArray.prototype.constructor is not writable expected true got false
</ins><span class="cx"> PASS PluginArray interface: operation refresh(boolean)
</span><span class="cx"> FAIL PluginArray interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> FAIL PluginArray interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="lines">@@ -4311,7 +4311,7 @@
</span><span class="cx"> PASS MimeTypeArray interface object length
</span><span class="cx"> PASS MimeTypeArray interface object name
</span><span class="cx"> PASS MimeTypeArray interface: existence and properties of interface prototype object
</span><del>-FAIL MimeTypeArray interface: existence and properties of interface prototype object's "constructor" property assert_own_property: MimeTypeArray.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL MimeTypeArray interface: existence and properties of interface prototype object's "constructor" property assert_true: MimeTypeArray.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL MimeTypeArray interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> FAIL MimeTypeArray interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> FAIL MimeTypeArray interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="lines">@@ -4319,7 +4319,7 @@
</span><span class="cx"> PASS Plugin interface object length
</span><span class="cx"> PASS Plugin interface object name
</span><span class="cx"> PASS Plugin interface: existence and properties of interface prototype object
</span><del>-FAIL Plugin interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Plugin.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL Plugin interface: existence and properties of interface prototype object's "constructor" property assert_true: Plugin.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL Plugin interface: attribute name assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL Plugin interface: attribute description assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL Plugin interface: attribute filename assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="lines">@@ -4541,7 +4541,7 @@
</span><span class="cx"> PASS Storage interface object length
</span><span class="cx"> PASS Storage interface object name
</span><span class="cx"> PASS Storage interface: existence and properties of interface prototype object
</span><del>-FAIL Storage interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Storage.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL Storage interface: existence and properties of interface prototype object's "constructor" property assert_true: Storage.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL Storage interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> PASS Storage interface: operation key(unsigned long)
</span><span class="cx"> PASS Storage interface: operation getItem(DOMString)
</span><span class="lines">@@ -4562,7 +4562,7 @@
</span><span class="cx"> PASS HTMLAppletElement interface object length
</span><span class="cx"> PASS HTMLAppletElement interface object name
</span><span class="cx"> PASS HTMLAppletElement interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLAppletElement interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLAppletElement.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLAppletElement interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLAppletElement.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLAppletElement interface: attribute align assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLAppletElement interface: attribute alt assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLAppletElement interface: attribute archive assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="lines">@@ -4630,7 +4630,7 @@
</span><span class="cx"> PASS HTMLFrameSetElement interface object length
</span><span class="cx"> PASS HTMLFrameSetElement interface object name
</span><span class="cx"> PASS HTMLFrameSetElement interface: existence and properties of interface prototype object
</span><del>-FAIL HTMLFrameSetElement interface: existence and properties of interface prototype object's "constructor" property assert_own_property: HTMLFrameSetElement.prototype does not have own property "constructor" expected property "constructor" missing
</del><ins>+FAIL HTMLFrameSetElement interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLFrameSetElement.prototype.constructor is not writable expected true got false
</ins><span class="cx"> FAIL HTMLFrameSetElement interface: attribute cols assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLFrameSetElement interface: attribute rows assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLFrameSetElement interface: attribute onafterprint assert_true: The prototype object must have a property "onafterprint" expected true got false
</span></span></pre></div>
<a id="trunkLayoutTestsstoragedomstoragelocalstoragedeletedefinepropertyremovalexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/LayoutTests/storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -1,10 +1,10 @@
</span><del>-CONSOLE MESSAGE: line 12: constructor,length
-CONSOLE MESSAGE: line 15: 1,constructor,length
-CONSOLE MESSAGE: line 18: 1,constructor,length
-CONSOLE MESSAGE: line 21: 1,2,constructor,length
-CONSOLE MESSAGE: line 24: 1,constructor,length
-CONSOLE MESSAGE: line 27: 1,constructor,length,Test
-CONSOLE MESSAGE: line 30: 1,constructor,length
-CONSOLE MESSAGE: line 33: 1,constructor,length,Test1
-CONSOLE MESSAGE: line 36: 1,constructor,length,Test1
</del><ins>+CONSOLE MESSAGE: line 12: length
+CONSOLE MESSAGE: line 15: 1,length
+CONSOLE MESSAGE: line 18: 1,length
+CONSOLE MESSAGE: line 21: 1,2,length
+CONSOLE MESSAGE: line 24: 1,length
+CONSOLE MESSAGE: line 27: 1,length,Test
+CONSOLE MESSAGE: line 30: 1,length
+CONSOLE MESSAGE: line 33: 1,length,Test1
+CONSOLE MESSAGE: line 36: 1,length,Test1
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/Source/WebCore/ChangeLog 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2016-01-30 Chris Dumez <cdumez@apple.com>
+
+ Move more 'constructor' properties to the prototype
+ https://bugs.webkit.org/show_bug.cgi?id=153667
+
+ Reviewed by Darin Adler.
+
+ Move more 'constructor' properties to the prototype. In particular, we
+ used to keep the 'constructor' on the instance for interfaces that have
+ an indexed / named property getter because our getOwnPropertySlot()
+ implementation used to be wrong for such interfaces.
+
+ However, getOwnPropertySlot() should be correct after r188590 so we
+ should now be able to move the 'constructor' up to the prototype for
+ these interfaces, as per the specification:
+ http://heycam.github.io/webidl/#interface-prototype-object
+
+ No new tests, already covered by existing tests.
+
+ * bindings/js/JSPluginElementFunctions.h:
+ (WebCore::pluginElementCustomGetOwnPropertySlot):
+ Add a null check for staticPropHashTable. It is now null because this
+ type no longer has any property on the instance now that 'constructor'
+ is on the prototype.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (ConstructorShouldBeOnInstance):
+
</ins><span class="cx"> 2016-01-29 Ada Chan <adachan@apple.com>
</span><span class="cx">
</span><span class="cx"> Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSPluginElementFunctionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSPluginElementFunctions.h (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSPluginElementFunctions.h 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/Source/WebCore/bindings/js/JSPluginElementFunctions.h 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> template <class Type, class Base> bool pluginElementCustomGetOwnPropertySlot(JSC::ExecState* exec, JSC::PropertyName propertyName, JSC::PropertySlot& slot, Type* element)
</span><span class="cx"> {
</span><span class="cx"> if (!element->globalObject()->world().isNormal()) {
</span><del>- if (JSC::getStaticValueSlot<Type, Base>(exec, *Type::info()->staticPropHashTable, element, propertyName, slot))
</del><ins>+ if (Type::info()->staticPropHashTable && JSC::getStaticValueSlot<Type, Base>(exec, *Type::info()->staticPropHashTable, element, propertyName, slot))
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> JSC::JSValue proto = element->prototype();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (195903 => 195904)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-01-30 20:06:53 UTC (rev 195903)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-01-30 20:10:18 UTC (rev 195904)
</span><span class="lines">@@ -684,8 +684,9 @@
</span><span class="cx"> sub ConstructorShouldBeOnInstance
</span><span class="cx"> {
</span><span class="cx"> my $interface = shift;
</span><ins>+
</ins><span class="cx"> return 1 if $interface->extendedAttributes->{"CheckSecurity"};
</span><del>- return HasComplexGetOwnProperty($interface);
</del><ins>+ return 0;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub AttributeShouldBeOnInstanceForCompatibility
</span></span></pre>
</div>
</div>
</body>
</html>