<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195809] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195809">195809</a></dd>
<dt>Author</dt> <dd>changseok.oh@collabora.com</dd>
<dt>Date</dt> <dd>2016-01-29 01:58:02 -0800 (Fri, 29 Jan 2016)</dd>
</dl>

<h3>Log Message</h3>
<pre>[GStreamer] built-in media player doesn't update
https://bugs.webkit.org/show_bug.cgi?id=151816

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The timeline of audio controls in media document is not properly updated since it is assumed
that the controls are hidden as soon as playing. However, such full page audio always has
opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
in controlsAreHidden();

Test: media/audio-controls-timeline-in-media-document.html

* Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.controlsAreAlwaysVisible):
(Controller.prototype.controlsAreHidden):

LayoutTests:

* media/audio-controls-timeline-in-media-document-expected.txt: Added.
* media/audio-controls-timeline-in-media-document.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsBasejs">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediaaudiocontrolstimelineinmediadocumentexpectedtxt">trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediaaudiocontrolstimelineinmediadocumenthtml">trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195808 => 195809)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-01-29 09:22:28 UTC (rev 195808)
+++ trunk/LayoutTests/ChangeLog        2016-01-29 09:58:02 UTC (rev 195809)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-01-29  ChangSeok Oh  &lt;changseok.oh@collabora.com&gt;
+
+        [GStreamer] built-in media player doesn't update
+        https://bugs.webkit.org/show_bug.cgi?id=151816
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * media/audio-controls-timeline-in-media-document-expected.txt: Added.
+        * media/audio-controls-timeline-in-media-document.html: Added.
+
</ins><span class="cx"> 2016-01-28  Brady Eidson  &lt;beidson@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Modern IDB: SQLite backend mismanages key generator values.
</span></span></pre></div>
<a id="trunkLayoutTestsmediaaudiocontrolstimelineinmediadocumentexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt (0 => 195809)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt                                (rev 0)
+++ trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt        2016-01-29 09:58:02 UTC (rev 195809)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+Pass if the timeline of audio in a media document is properly updated during playback.
+
+EVENT(timeupdate)
+TEST(timeLineValue() &gt; 0) OK
+END OF TEST
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediaaudiocontrolstimelineinmediadocumenthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html (0 => 195809)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html                                (rev 0)
+++ trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html        2016-01-29 09:58:02 UTC (rev 195809)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;p&gt;Pass if the timeline of audio in a media document is properly updated during playback.&lt;/p&gt;
+&lt;script src=&quot;media-file.js&quot;&gt;&lt;/script&gt;
+&lt;script src=&quot;video-test.js&quot;&gt;&lt;/script&gt;
+&lt;script src=&quot;media-controls.js&quot;&gt;&lt;/script&gt;
+&lt;script&gt;
+function timeLineValue()
+{
+    const timeline = mediaControlsElement(internals.shadowRoot(video).firstChild.firstChild, &quot;-webkit-media-controls-timeline&quot;);
+    if (!timeline)
+        throw &quot;Failed to find -webkit-media-controls-timeline&quot;;
+
+    return timeline.value;
+}
+
+function iframeLoaded()
+{
+    video = iframe.contentDocument.querySelector(&quot;video&quot;);
+    video.addEventListener(&quot;timeupdate&quot;, function() {
+        consoleWrite(&quot;EVENT(timeupdate)&quot;);
+        testAndEnd(&quot;timeLineValue() &gt; 0&quot;);
+    });
+}
+
+var video;
+const iframe = document.createElement(&quot;iframe&quot;);
+iframe.onload = iframeLoaded;
+iframe.src = findMediaFile(&quot;audio&quot;, &quot;content/test&quot;);
+
+document.body.appendChild(iframe);
+&lt;/script&gt;
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195808 => 195809)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-01-29 09:22:28 UTC (rev 195808)
+++ trunk/Source/WebCore/ChangeLog        2016-01-29 09:58:02 UTC (rev 195809)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-01-29  ChangSeok Oh  &lt;changseok.oh@collabora.com&gt;
+
+        [GStreamer] built-in media player doesn't update
+        https://bugs.webkit.org/show_bug.cgi?id=151816
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        The timeline of audio controls in media document is not properly updated since it is assumed
+        that the controls are hidden as soon as playing. However, such full page audio always has
+        opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
+        i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
+        in controlsAreHidden();
+
+        Test: media/audio-controls-timeline-in-media-document.html
+
+        * Modules/mediacontrols/mediaControlsBase.js:
+        (Controller.prototype.controlsAreAlwaysVisible):
+        (Controller.prototype.controlsAreHidden):
+
</ins><span class="cx"> 2016-01-29  Manuel Rego Casasnovas  &lt;rego@igalia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [css-grid] Store lines instead of tracks in GridResolvedPosition
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsBasejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js (195808 => 195809)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js        2016-01-29 09:22:28 UTC (rev 195808)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js        2016-01-29 09:58:02 UTC (rev 195809)
</span><span class="lines">@@ -1024,8 +1024,16 @@
</span><span class="cx">         this.controls.panel.classList.remove(this.ClassNames.show);
</span><span class="cx">     },
</span><span class="cx"> 
</span><ins>+    controlsAreAlwaysVisible: function()
+    {
+        return this.controls.panel.classList.contains(this.ClassNames.noVideo);
+    },
+
</ins><span class="cx">     controlsAreHidden: function()
</span><span class="cx">     {
</span><ins>+        if (this.controlsAreAlwaysVisible())
+            return false;
+
</ins><span class="cx">         var panel = this.controls.panel;
</span><span class="cx">         return (!panel.classList.contains(this.ClassNames.show) || panel.classList.contains(this.ClassNames.hidden))
</span><span class="cx">             &amp;&amp; (panel.parentElement.querySelector(':hover') !== panel);
</span></span></pre>
</div>
</div>

</body>
</html>