<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195760] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195760">195760</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-01-28 10:55:07 -0800 (Thu, 28 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Storage interface's attributes / operations should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=153573
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Storage interface's attributes / operations should be enumerable:
- https://html.spec.whatwg.org/#the-storage-interface
Firefox matches the specification.
No new tests, already covered by existing test.
* storage/Storage.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstoragedomstoragelocalstorageenumeratestorageexpectedtxt">trunk/LayoutTests/storage/domstorage/localstorage/enumerate-storage-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstoragedomstoragesessionstorageenumeratestorageexpectedtxt">trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstoragedomstoragesessionstorageenumeratewithlengthandkeyexpectedtxt">trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorestorageStorageidl">trunk/Source/WebCore/storage/Storage.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195759 => 195760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-28 18:55:07 UTC (rev 195760)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-01-28 Chris Dumez <cdumez@apple.com>
+
+ Storage interface's attributes / operations should be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=153573
+
+ Reviewed by Darin Adler.
+
+ Rebaseline W3C HTML test now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
</ins><span class="cx"> 2016-01-27 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Expose ValidityState on the global Window object
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (195759 => 195760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-28 18:55:07 UTC (rev 195760)
</span><span class="lines">@@ -4543,11 +4543,11 @@
</span><span class="cx"> PASS Storage interface: existence and properties of interface prototype object
</span><span class="cx"> FAIL Storage interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Storage.prototype does not have own property "constructor" expected property "constructor" missing
</span><span class="cx"> FAIL Storage interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><del>-FAIL Storage interface: operation key(unsigned long) assert_true: property is not enumerable expected true got false
-FAIL Storage interface: operation getItem(DOMString) assert_true: property is not enumerable expected true got false
-FAIL Storage interface: operation setItem(DOMString,DOMString) assert_true: property is not enumerable expected true got false
-FAIL Storage interface: operation removeItem(DOMString) assert_true: property is not enumerable expected true got false
-FAIL Storage interface: operation clear() assert_true: property is not enumerable expected true got false
</del><ins>+PASS Storage interface: operation key(unsigned long)
+PASS Storage interface: operation getItem(DOMString)
+PASS Storage interface: operation setItem(DOMString,DOMString)
+PASS Storage interface: operation removeItem(DOMString)
+PASS Storage interface: operation clear()
</ins><span class="cx"> FAIL StorageEvent interface: existence and properties of interface object assert_equals: class string of StorageEvent expected "[object Function]" but got "[object StorageEventConstructor]"
</span><span class="cx"> PASS StorageEvent interface object length
</span><span class="cx"> PASS StorageEvent interface object name
</span></span></pre></div>
<a id="trunkLayoutTestsstoragedomstoragelocalstorageenumeratestorageexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/domstorage/localstorage/enumerate-storage-expected.txt (195759 => 195760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/domstorage/localstorage/enumerate-storage-expected.txt 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/storage/domstorage/localstorage/enumerate-storage-expected.txt 2016-01-28 18:55:07 UTC (rev 195760)
</span><span class="lines">@@ -2,8 +2,14 @@
</span><span class="cx"> alpha
</span><span class="cx"> bar
</span><span class="cx"> batman
</span><ins>+clear
</ins><span class="cx"> foo
</span><span class="cx"> fu
</span><ins>+getItem
+key
+length
</ins><span class="cx"> prototypeTestKey
</span><ins>+removeItem
+setItem
</ins><span class="cx"> zeta
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstoragedomstoragesessionstorageenumeratestorageexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt (195759 => 195760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt 2016-01-28 18:55:07 UTC (rev 195760)
</span><span class="lines">@@ -2,8 +2,14 @@
</span><span class="cx"> alpha
</span><span class="cx"> bar
</span><span class="cx"> batman
</span><ins>+clear
</ins><span class="cx"> foo
</span><span class="cx"> fu
</span><ins>+getItem
+key
+length
</ins><span class="cx"> prototypeTestKey
</span><ins>+removeItem
+setItem
</ins><span class="cx"> zeta
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstoragedomstoragesessionstorageenumeratewithlengthandkeyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt (195759 => 195760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt 2016-01-28 18:55:07 UTC (rev 195760)
</span><span class="lines">@@ -2,8 +2,14 @@
</span><span class="cx"> alpha
</span><span class="cx"> bar
</span><span class="cx"> batman
</span><ins>+clear
</ins><span class="cx"> foo
</span><span class="cx"> fu
</span><ins>+getItem
+key
+length
</ins><span class="cx"> prototypeTestKey
</span><ins>+removeItem
+setItem
</ins><span class="cx"> zeta
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195759 => 195760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/Source/WebCore/ChangeLog 2016-01-28 18:55:07 UTC (rev 195760)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-01-28 Chris Dumez <cdumez@apple.com>
+
+ Storage interface's attributes / operations should be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=153573
+
+ Reviewed by Darin Adler.
+
+ Storage interface's attributes / operations should be enumerable:
+ - https://html.spec.whatwg.org/#the-storage-interface
+
+ Firefox matches the specification.
+
+ No new tests, already covered by existing test.
+
+ * storage/Storage.idl:
+
</ins><span class="cx"> 2016-01-26 Ada Chan <adachan@apple.com>
</span><span class="cx">
</span><span class="cx"> Get WebVideoFullscreenManager and related classes to also compile for Mac platform
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/Storage.idl (195759 => 195760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/Storage.idl 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/Source/WebCore/storage/Storage.idl 2016-01-28 18:55:07 UTC (rev 195760)
</span><span class="lines">@@ -30,11 +30,11 @@
</span><span class="cx"> CustomNamedSetter,
</span><span class="cx"> SkipVTableValidation,
</span><span class="cx"> ] interface Storage {
</span><del>- [NotEnumerable, GetterRaisesException] readonly attribute unsigned long length;
- [NotEnumerable, TreatReturnedNullStringAs=Null, RaisesException] DOMString key(unsigned long index);
- [NotEnumerable, TreatReturnedNullStringAs=Null, RaisesException] getter DOMString getItem(DOMString key);
- [NotEnumerable, RaisesException] void setItem(DOMString key, DOMString data);
- [NotEnumerable, RaisesException] void removeItem(DOMString key);
- [NotEnumerable, RaisesException] void clear();
</del><ins>+ [GetterRaisesException] readonly attribute unsigned long length;
+ [TreatReturnedNullStringAs=Null, RaisesException] DOMString key(unsigned long index);
+ [TreatReturnedNullStringAs=Null, RaisesException] getter DOMString getItem(DOMString key);
+ [RaisesException] void setItem(DOMString key, DOMString data);
+ [RaisesException] void removeItem(DOMString key);
+ [RaisesException] void clear();
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>