<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195778] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195778">195778</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-01-28 12:35:19 -0800 (Thu, 28 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>EventHandler IDL attributes should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=153595
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that EventHandler attributes are enumerable,
as per the specification.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Most of our EventHandler IDL attributes were marked as [NotEnumerable]
but should not have been according to the specification:
- https://html.spec.whatwg.org/#globaleventhandlers
- https://html.spec.whatwg.org/#windoweventhandlers
Firefox and Chrome behave according to the specification.
This patch aligns our behavior.
No new tests, already covered by existing tests.
* dom/Document.idl:
* dom/GlobalEventHandlers.idl:
* page/WindowEventHandlers.idl:
LayoutTests:
Rebaseline test now that more EventHandler attributes are enumerable.
* js/dom/dom-static-property-for-in-iteration-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomdomstaticpropertyforiniterationexpectedtxt">trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
<li><a href="#trunkSourceWebCoredomGlobalEventHandlersidl">trunk/Source/WebCore/dom/GlobalEventHandlers.idl</a></li>
<li><a href="#trunkSourceWebCorepageWindowEventHandlersidl">trunk/Source/WebCore/page/WindowEventHandlers.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195777 => 195778)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-01-28 20:20:01 UTC (rev 195777)
+++ trunk/LayoutTests/ChangeLog 2016-01-28 20:35:19 UTC (rev 195778)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-01-28 Chris Dumez <cdumez@apple.com>
+
+ EventHandler IDL attributes should be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=153595
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline test now that more EventHandler attributes are enumerable.
+
+ * js/dom/dom-static-property-for-in-iteration-expected.txt:
+
</ins><span class="cx"> 2016-01-28 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Modern IDB: Index uniqueness broken in the SQLite backend.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195777 => 195778)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-28 20:20:01 UTC (rev 195777)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-28 20:35:19 UTC (rev 195778)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-01-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ EventHandler IDL attributes should be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=153595
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline W3C HTML test now that EventHandler attributes are enumerable,
+ as per the specification.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-01-28 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Storage interface's attributes / operations should be enumerable
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=153573
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (195777 => 195778)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-28 20:20:01 UTC (rev 195777)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-28 20:35:19 UTC (rev 195778)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> FAIL Document interface: operation queryCommandSupported(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> FAIL Document interface: operation queryCommandValue(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> FAIL Document interface: attribute commands assert_true: The prototype object must have a property "commands" expected true got false
</span><del>-FAIL Document interface: attribute onreadystatechange assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute onreadystatechange assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute fgColor assert_true: The prototype object must have a property "fgColor" expected true got false
</span><span class="cx"> FAIL Document interface: attribute linkColor assert_true: The prototype object must have a property "linkColor" expected true got false
</span><span class="cx"> FAIL Document interface: attribute vlinkColor assert_true: The prototype object must have a property "vlinkColor" expected true got false
</span><span class="lines">@@ -60,69 +60,69 @@
</span><span class="cx"> FAIL Document interface: operation captureEvents() assert_own_property: interface prototype object missing non-static operation expected property "captureEvents" missing
</span><span class="cx"> FAIL Document interface: operation releaseEvents() assert_own_property: interface prototype object missing non-static operation expected property "releaseEvents" missing
</span><span class="cx"> FAIL Document interface: attribute all assert_true: The prototype object must have a property "all" expected true got false
</span><del>-FAIL Document interface: attribute onabort assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute onabort assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute onautocomplete assert_true: The prototype object must have a property "onautocomplete" expected true got false
</span><span class="cx"> FAIL Document interface: attribute onautocompleteerror assert_true: The prototype object must have a property "onautocompleteerror" expected true got false
</span><del>-FAIL Document interface: attribute onblur assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute onblur assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute oncancel assert_true: The prototype object must have a property "oncancel" expected true got false
</span><del>-FAIL Document interface: attribute oncanplay assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute oncanplaythrough assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onchange assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onclick assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute oncanplay assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute oncanplaythrough assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onchange assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onclick assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute onclose assert_true: The prototype object must have a property "onclose" expected true got false
</span><del>-FAIL Document interface: attribute oncontextmenu assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute oncontextmenu assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute oncuechange assert_true: The prototype object must have a property "oncuechange" expected true got false
</span><del>-FAIL Document interface: attribute ondblclick assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute ondrag assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute ondragend assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute ondragenter assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute ondblclick assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute ondrag assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute ondragend assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute ondragenter assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute ondragexit assert_true: The prototype object must have a property "ondragexit" expected true got false
</span><del>-FAIL Document interface: attribute ondragleave assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute ondragover assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute ondragstart assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute ondrop assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute ondurationchange assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onemptied assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onended assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onerror assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onfocus assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute oninput assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute oninvalid assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onkeydown assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onkeypress assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onkeyup assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onload assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onloadeddata assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onloadedmetadata assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onloadstart assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onmousedown assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onmouseenter assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onmouseleave assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onmousemove assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onmouseout assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onmouseover assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onmouseup assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onmousewheel assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onpause assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onplay assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onplaying assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onprogress assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onratechange assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onreset assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute ondragleave assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute ondragover assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute ondragstart assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute ondrop assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute ondurationchange assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onemptied assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onended assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onerror assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onfocus assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute oninput assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute oninvalid assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onkeydown assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onkeypress assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onkeyup assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onload assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onloadeddata assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onloadedmetadata assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onloadstart assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onmousedown assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onmouseenter assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onmouseleave assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onmousemove assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onmouseout assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onmouseover assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onmouseup assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onmousewheel assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onpause assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onplay assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onplaying assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onprogress assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onratechange assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onreset assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute onresize assert_true: The prototype object must have a property "onresize" expected true got false
</span><del>-FAIL Document interface: attribute onscroll assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onseeked assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onseeking assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onselect assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute onscroll assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onseeked assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onseeking assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onselect assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute onshow assert_true: The prototype object must have a property "onshow" expected true got false
</span><span class="cx"> FAIL Document interface: attribute onsort assert_true: The prototype object must have a property "onsort" expected true got false
</span><del>-FAIL Document interface: attribute onstalled assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onsubmit assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onsuspend assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute ontimeupdate assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute onstalled assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onsubmit assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onsuspend assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute ontimeupdate assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Document interface: attribute ontoggle assert_true: The prototype object must have a property "ontoggle" expected true got false
</span><del>-FAIL Document interface: attribute onvolumechange assert_true: property is not enumerable expected true got false
-FAIL Document interface: attribute onwaiting assert_true: property is not enumerable expected true got false
</del><ins>+FAIL Document interface: attribute onvolumechange assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL Document interface: attribute onwaiting assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL Stringification of iframe.contentDocument assert_equals: class string of iframe.contentDocument expected "[object Document]" but got "[object HTMLDocument]"
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "implementation" with the proper type (0)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "URL" with the proper type (1)
</span><span class="lines">@@ -1435,17 +1435,17 @@
</span><span class="cx"> FAIL HTMLBodyElement interface: attribute background assert_equals: getter must be Function expected "function" but got "undefined"
</span><span class="cx"> FAIL HTMLBodyElement interface: attribute onafterprint assert_true: The prototype object must have a property "onafterprint" expected true got false
</span><span class="cx"> FAIL HTMLBodyElement interface: attribute onbeforeprint assert_true: The prototype object must have a property "onbeforeprint" expected true got false
</span><del>-FAIL HTMLBodyElement interface: attribute onbeforeunload assert_true: property is not enumerable expected true got false
-FAIL HTMLBodyElement interface: attribute onhashchange assert_true: property is not enumerable expected true got false
</del><ins>+FAIL HTMLBodyElement interface: attribute onbeforeunload assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL HTMLBodyElement interface: attribute onhashchange assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> FAIL HTMLBodyElement interface: attribute onlanguagechange assert_true: The prototype object must have a property "onlanguagechange" expected true got false
</span><del>-FAIL HTMLBodyElement interface: attribute onmessage assert_true: property is not enumerable expected true got false
-FAIL HTMLBodyElement interface: attribute onoffline assert_true: property is not enumerable expected true got false
-FAIL HTMLBodyElement interface: attribute ononline assert_true: property is not enumerable expected true got false
-FAIL HTMLBodyElement interface: attribute onpagehide assert_true: property is not enumerable expected true got false
-FAIL HTMLBodyElement interface: attribute onpageshow assert_true: property is not enumerable expected true got false
-FAIL HTMLBodyElement interface: attribute onpopstate assert_true: property is not enumerable expected true got false
-FAIL HTMLBodyElement interface: attribute onstorage assert_true: property is not enumerable expected true got false
-FAIL HTMLBodyElement interface: attribute onunload assert_true: property is not enumerable expected true got false
</del><ins>+FAIL HTMLBodyElement interface: attribute onmessage assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL HTMLBodyElement interface: attribute onoffline assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL HTMLBodyElement interface: attribute ononline assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL HTMLBodyElement interface: attribute onpagehide assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL HTMLBodyElement interface: attribute onpageshow assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL HTMLBodyElement interface: attribute onpopstate assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL HTMLBodyElement interface: attribute onstorage assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL HTMLBodyElement interface: attribute onunload assert_equals: getter must be Function expected "function" but got "undefined"
</ins><span class="cx"> PASS HTMLBodyElement must be primary interface of document.createElement("body")
</span><span class="cx"> PASS Stringification of document.createElement("body")
</span><span class="cx"> PASS HTMLBodyElement interface: document.createElement("body") must inherit property "text" with the proper type (0)
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomdomstaticpropertyforiniterationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt (195777 => 195778)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-01-28 20:20:01 UTC (rev 195777)
+++ trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-01-28 20:35:19 UTC (rev 195778)
</span><span class="lines">@@ -68,6 +68,59 @@
</span><span class="cx"> PASS a["webkitRegionOverset"] is undefined
</span><span class="cx"> PASS a["shadowRoot"] is null
</span><span class="cx"> PASS a["slot"] is
</span><ins>+PASS a["onabort"] is null
+PASS a["onblur"] is null
+PASS a["oncanplay"] is null
+PASS a["oncanplaythrough"] is null
+PASS a["onchange"] is null
+PASS a["onclick"] is null
+PASS a["oncontextmenu"] is null
+PASS a["ondblclick"] is null
+PASS a["ondrag"] is null
+PASS a["ondragend"] is null
+PASS a["ondragenter"] is null
+PASS a["ondragleave"] is null
+PASS a["ondragover"] is null
+PASS a["ondragstart"] is null
+PASS a["ondrop"] is null
+PASS a["ondurationchange"] is null
+PASS a["onemptied"] is null
+PASS a["onended"] is null
+PASS a["onerror"] is null
+PASS a["onfocus"] is null
+PASS a["oninput"] is null
+PASS a["oninvalid"] is null
+PASS a["onkeydown"] is null
+PASS a["onkeypress"] is null
+PASS a["onkeyup"] is null
+PASS a["onload"] is null
+PASS a["onloadeddata"] is null
+PASS a["onloadedmetadata"] is null
+PASS a["onloadstart"] is null
+PASS a["onmousedown"] is null
+PASS a["onmouseenter"] is null
+PASS a["onmouseleave"] is null
+PASS a["onmousemove"] is null
+PASS a["onmouseout"] is null
+PASS a["onmouseover"] is null
+PASS a["onmouseup"] is null
+PASS a["onmousewheel"] is null
+PASS a["onpause"] is null
+PASS a["onplay"] is null
+PASS a["onplaying"] is null
+PASS a["onprogress"] is null
+PASS a["onratechange"] is null
+PASS a["onreset"] is null
+PASS a["onscroll"] is null
+PASS a["onseeked"] is null
+PASS a["onseeking"] is null
+PASS a["onselect"] is null
+PASS a["onstalled"] is null
+PASS a["onsubmit"] is null
+PASS a["onsuspend"] is null
+PASS a["ontimeupdate"] is null
+PASS a["onvolumechange"] is null
+PASS a["onwaiting"] is null
</ins><span class="cx"> PASS a["previousElementSibling"] is [object HTMLDivElement]
</span><span class="cx"> PASS a["nextElementSibling"] is [object HTMLScriptElement]
</span><span class="cx"> PASS a["assignedSlot"] is null
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195777 => 195778)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-28 20:20:01 UTC (rev 195777)
+++ trunk/Source/WebCore/ChangeLog 2016-01-28 20:35:19 UTC (rev 195778)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2016-01-28 Chris Dumez <cdumez@apple.com>
+
+ EventHandler IDL attributes should be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=153595
+
+ Reviewed by Sam Weinig.
+
+ Most of our EventHandler IDL attributes were marked as [NotEnumerable]
+ but should not have been according to the specification:
+ - https://html.spec.whatwg.org/#globaleventhandlers
+ - https://html.spec.whatwg.org/#windoweventhandlers
+
+ Firefox and Chrome behave according to the specification.
+ This patch aligns our behavior.
+
+ No new tests, already covered by existing tests.
+
+ * dom/Document.idl:
+ * dom/GlobalEventHandlers.idl:
+ * page/WindowEventHandlers.idl:
+
</ins><span class="cx"> 2016-01-28 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> Windows build fix; PRId64 formatting macro for int64_t undefined, so provide Windows-specific alternative.
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (195777 => 195778)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2016-01-28 20:20:01 UTC (rev 195777)
+++ trunk/Source/WebCore/dom/Document.idl 2016-01-28 20:35:19 UTC (rev 195778)
</span><span class="lines">@@ -325,7 +325,7 @@
</span><span class="cx"> [NotEnumerable] attribute EventHandler onselectionchange;
</span><span class="cx">
</span><span class="cx"> // Unique to Document
</span><del>- [NotEnumerable, LenientThis] attribute EventHandler onreadystatechange;
</del><ins>+ [LenientThis] attribute EventHandler onreadystatechange;
</ins><span class="cx"> [NotEnumerable, Conditional=CSP_NEXT] attribute EventHandler onsecuritypolicyviolation;
</span><span class="cx"> [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockchange;
</span><span class="cx"> [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockerror;
</span></span></pre></div>
<a id="trunkSourceWebCoredomGlobalEventHandlersidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/GlobalEventHandlers.idl (195777 => 195778)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/GlobalEventHandlers.idl 2016-01-28 20:20:01 UTC (rev 195777)
+++ trunk/Source/WebCore/dom/GlobalEventHandlers.idl 2016-01-28 20:35:19 UTC (rev 195778)
</span><span class="lines">@@ -31,69 +31,69 @@
</span><span class="cx"> // Commented out event handlers are defined by the HTML5 specification but
</span><span class="cx"> // are not yet implemented.
</span><span class="cx">
</span><del>- [NotEnumerable] attribute EventHandler onabort;
- [NotEnumerable, Conditional=REQUEST_AUTOCOMPLETE] attribute EventHandler onautocomplete;
- [NotEnumerable, Conditional=REQUEST_AUTOCOMPLETE] attribute EventHandler onautocompleteerror;
- [NotEnumerable] attribute EventHandler onblur;
- // [NotEnumerable] attribute EventHandler oncancel;
- [NotEnumerable] attribute EventHandler oncanplay;
- [NotEnumerable] attribute EventHandler oncanplaythrough;
- [NotEnumerable] attribute EventHandler onchange;
- [NotEnumerable] attribute EventHandler onclick;
- // [NotEnumerable] attribute EventHandler onclose;
- [NotEnumerable] attribute EventHandler oncontextmenu;
- // [NotEnumerable] attribute EventHandler oncuechange;
- [NotEnumerable] attribute EventHandler ondblclick;
- [NotEnumerable] attribute EventHandler ondrag;
- [NotEnumerable] attribute EventHandler ondragend;
- [NotEnumerable] attribute EventHandler ondragenter;
- // [NotEnumerable] attribute EventHandler ondragexit;
- [NotEnumerable] attribute EventHandler ondragleave;
- [NotEnumerable] attribute EventHandler ondragover;
- [NotEnumerable] attribute EventHandler ondragstart;
- [NotEnumerable] attribute EventHandler ondrop;
- [NotEnumerable] attribute EventHandler ondurationchange;
- [NotEnumerable] attribute EventHandler onemptied;
- [NotEnumerable] attribute EventHandler onended;
- [NotEnumerable] attribute EventHandler onerror;
- [NotEnumerable] attribute EventHandler onfocus;
- [NotEnumerable] attribute EventHandler oninput;
- [NotEnumerable] attribute EventHandler oninvalid;
- [NotEnumerable] attribute EventHandler onkeydown;
- [NotEnumerable] attribute EventHandler onkeypress;
- [NotEnumerable] attribute EventHandler onkeyup;
- [NotEnumerable] attribute EventHandler onload;
- [NotEnumerable] attribute EventHandler onloadeddata;
- [NotEnumerable] attribute EventHandler onloadedmetadata;
- [NotEnumerable] attribute EventHandler onloadstart;
- [NotEnumerable] attribute EventHandler onmousedown;
- [NotEnumerable, LenientThis] attribute EventHandler onmouseenter;
- [NotEnumerable, LenientThis] attribute EventHandler onmouseleave;
- [NotEnumerable] attribute EventHandler onmousemove;
- [NotEnumerable] attribute EventHandler onmouseout;
- [NotEnumerable] attribute EventHandler onmouseover;
- [NotEnumerable] attribute EventHandler onmouseup;
- [NotEnumerable] attribute EventHandler onmousewheel;
- [NotEnumerable] attribute EventHandler onpause;
- [NotEnumerable] attribute EventHandler onplay;
- [NotEnumerable] attribute EventHandler onplaying;
- [NotEnumerable] attribute EventHandler onprogress;
- [NotEnumerable] attribute EventHandler onratechange;
- [NotEnumerable] attribute EventHandler onreset;
- // [NotEnumerable] attribute EventHandler onresize;
- [NotEnumerable] attribute EventHandler onscroll;
- [NotEnumerable] attribute EventHandler onseeked;
- [NotEnumerable] attribute EventHandler onseeking;
- [NotEnumerable] attribute EventHandler onselect;
- // [NotEnumerable] attribute EventHandler onshow;
- // [NotEnumerable] attribute EventHandler onsort;
- [NotEnumerable] attribute EventHandler onstalled;
- [NotEnumerable] attribute EventHandler onsubmit;
- [NotEnumerable] attribute EventHandler onsuspend;
- [NotEnumerable] attribute EventHandler ontimeupdate;
- // [NotEnumerable] attribute EventHandler ontoggle;
- [NotEnumerable] attribute EventHandler onvolumechange;
- [NotEnumerable] attribute EventHandler onwaiting;
</del><ins>+ attribute EventHandler onabort;
+ [Conditional=REQUEST_AUTOCOMPLETE] attribute EventHandler onautocomplete;
+ [Conditional=REQUEST_AUTOCOMPLETE] attribute EventHandler onautocompleteerror;
+ attribute EventHandler onblur;
+ // attribute EventHandler oncancel;
+ attribute EventHandler oncanplay;
+ attribute EventHandler oncanplaythrough;
+ attribute EventHandler onchange;
+ attribute EventHandler onclick;
+ // attribute EventHandler onclose;
+ attribute EventHandler oncontextmenu;
+ // attribute EventHandler oncuechange;
+ attribute EventHandler ondblclick;
+ attribute EventHandler ondrag;
+ attribute EventHandler ondragend;
+ attribute EventHandler ondragenter;
+ // attribute EventHandler ondragexit;
+ attribute EventHandler ondragleave;
+ attribute EventHandler ondragover;
+ attribute EventHandler ondragstart;
+ attribute EventHandler ondrop;
+ attribute EventHandler ondurationchange;
+ attribute EventHandler onemptied;
+ attribute EventHandler onended;
+ attribute EventHandler onerror;
+ attribute EventHandler onfocus;
+ attribute EventHandler oninput;
+ attribute EventHandler oninvalid;
+ attribute EventHandler onkeydown;
+ attribute EventHandler onkeypress;
+ attribute EventHandler onkeyup;
+ attribute EventHandler onload;
+ attribute EventHandler onloadeddata;
+ attribute EventHandler onloadedmetadata;
+ attribute EventHandler onloadstart;
+ attribute EventHandler onmousedown;
+ [LenientThis] attribute EventHandler onmouseenter;
+ [LenientThis] attribute EventHandler onmouseleave;
+ attribute EventHandler onmousemove;
+ attribute EventHandler onmouseout;
+ attribute EventHandler onmouseover;
+ attribute EventHandler onmouseup;
+ attribute EventHandler onmousewheel;
+ attribute EventHandler onpause;
+ attribute EventHandler onplay;
+ attribute EventHandler onplaying;
+ attribute EventHandler onprogress;
+ attribute EventHandler onratechange;
+ attribute EventHandler onreset;
+ // attribute EventHandler onresize;
+ attribute EventHandler onscroll;
+ attribute EventHandler onseeked;
+ attribute EventHandler onseeking;
+ attribute EventHandler onselect;
+ // attribute EventHandler onshow;
+ // attribute EventHandler onsort;
+ attribute EventHandler onstalled;
+ attribute EventHandler onsubmit;
+ attribute EventHandler onsuspend;
+ attribute EventHandler ontimeupdate;
+ // attribute EventHandler ontoggle;
+ attribute EventHandler onvolumechange;
+ attribute EventHandler onwaiting;
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> // Additions that are not yet part of the standard.
</span></span></pre></div>
<a id="trunkSourceWebCorepageWindowEventHandlersidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/WindowEventHandlers.idl (195777 => 195778)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/WindowEventHandlers.idl 2016-01-28 20:20:01 UTC (rev 195777)
+++ trunk/Source/WebCore/page/WindowEventHandlers.idl 2016-01-28 20:35:19 UTC (rev 195778)
</span><span class="lines">@@ -31,19 +31,19 @@
</span><span class="cx"> // Commented out event handlers are defined by the HTML5 specification but
</span><span class="cx"> // are not yet implemented.
</span><span class="cx">
</span><del>- // [NotEnumerable, WindowEventHandler] attribute EventHandler onafterprint;.
- // [NotEnumerable, WindowEventHandler] attribute EventHandler onbeforeprint;.
- [NotEnumerable, WindowEventHandler] attribute EventHandler onbeforeunload;
- [NotEnumerable, WindowEventHandler] attribute EventHandler onhashchange;
- // [NotEnumerable, WindowEventHandler] attribute EventHandler onlanguagechange;.
- [NotEnumerable, WindowEventHandler] attribute EventHandler onmessage;
- [NotEnumerable, WindowEventHandler] attribute EventHandler onoffline;
- [NotEnumerable, WindowEventHandler] attribute EventHandler ononline;
- [NotEnumerable, WindowEventHandler] attribute EventHandler onpagehide;
- [NotEnumerable, WindowEventHandler] attribute EventHandler onpageshow;
- [NotEnumerable, WindowEventHandler] attribute EventHandler onpopstate;
- [NotEnumerable, WindowEventHandler] attribute EventHandler onstorage;
- [NotEnumerable, WindowEventHandler] attribute EventHandler onunload;
</del><ins>+ // [WindowEventHandler] attribute EventHandler onafterprint;.
+ // [WindowEventHandler] attribute EventHandler onbeforeprint;.
+ [WindowEventHandler] attribute EventHandler onbeforeunload;
+ [WindowEventHandler] attribute EventHandler onhashchange;
+ // [WindowEventHandler] attribute EventHandler onlanguagechange;.
+ [WindowEventHandler] attribute EventHandler onmessage;
+ [WindowEventHandler] attribute EventHandler onoffline;
+ [WindowEventHandler] attribute EventHandler ononline;
+ [WindowEventHandler] attribute EventHandler onpagehide;
+ [WindowEventHandler] attribute EventHandler onpageshow;
+ [WindowEventHandler] attribute EventHandler onpopstate;
+ [WindowEventHandler] attribute EventHandler onstorage;
+ [WindowEventHandler] attribute EventHandler onunload;
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> // Additions that are not yet part of the standard.
</span></span></pre>
</div>
</div>
</body>
</html>