<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195725] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195725">195725</a></dd>
<dt>Author</dt> <dd>k.czech@samsung.com</dd>
<dt>Date</dt> <dd>2016-01-27 18:28:03 -0800 (Wed, 27 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Remove unused accessibility related code
https://bugs.webkit.org/show_bug.cgi?id=153543
Reviewed by Darin Adler.
Source/WebKit2:
Do not need to load external library to expose WebKit's
accessibility tree. There have been changes in EFL/Elementary
in terms of support of accessibility and we should follow those.
* WebProcess/efl/WebProcessMainEfl.cpp:
(eailLibraryPath): Deleted.
(eail): Deleted.
Tools:
Removed reference to EAIL library.
It not going to be support anymore. There have been changes in
EFL/Elementary in terms of the accessibility and we should
follow those.
* efl/jhbuild-optional.modules:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcesseflWebProcessMainEflcpp">trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsefljhbuildoptionalmodules">trunk/Tools/efl/jhbuild-optional.modules</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (195724 => 195725)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog        2016-01-28 02:21:25 UTC (rev 195724)
+++ trunk/Source/WebKit2/ChangeLog        2016-01-28 02:28:03 UTC (rev 195725)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-01-27 Krzysztof Czech <k.czech@samsung.com>
+
+ [EFL] Remove unused accessibility related code
+ https://bugs.webkit.org/show_bug.cgi?id=153543
+
+ Reviewed by Darin Adler.
+
+ Do not need to load external library to expose WebKit's
+ accessibility tree. There have been changes in EFL/Elementary
+ in terms of support of accessibility and we should follow those.
+
+ * WebProcess/efl/WebProcessMainEfl.cpp:
+ (eailLibraryPath): Deleted.
+ (eail): Deleted.
+
</ins><span class="cx"> 2016-01-27 Enrica Casucci <enrica@apple.com>
</span><span class="cx">
</span><span class="cx"> Cache results of data detection in the UI process when load completes.
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcesseflWebProcessMainEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp (195724 => 195725)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp        2016-01-28 02:21:25 UTC (rev 195724)
+++ trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp        2016-01-28 02:28:03 UTC (rev 195725)
</span><span class="lines">@@ -35,28 +35,6 @@
</span><span class="cx"> #include <WebCore/SoupNetworkSession.h>
</span><span class="cx"> #include <libsoup/soup.h>
</span><span class="cx">
</span><del>-#if HAVE(ACCESSIBILITY)
-#include "Module.h"
-/*
- * This should be defined and filled in elementary but to avoid undefined reference it's defined here.
- * Setting this variable to nullptr will not cause any trouble to webkit and eail as well.
- */
-Eina_List* _elm_win_list = nullptr;
-
-typedef int (*EailFunction)(void*);
-
-static char* eailLibraryPath()
-{
- return getenv("ACCESSIBILITY_EAIL_LIBRARY_PATH");
-}
-
-static WebKit::Module& eail()
-{
- static NeverDestroyed<WebKit::Module> eail(eailLibraryPath());
- return eail;
-}
-#endif
-
</del><span class="cx"> #ifdef HAVE_ECORE_X
</span><span class="cx"> #include <Ecore_X.h>
</span><span class="cx"> #include <X11/Xlib.h>
</span><span class="lines">@@ -120,14 +98,6 @@
</span><span class="cx"> if (!ecore_main_loop_glib_integrate())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>-#if HAVE(ACCESSIBILITY)
- // Initialize EAIL module (adding listeners, init atk-bridge)
- if (eailLibraryPath() && eail().load()) {
- if (EailFunction eailInit = eail().functionPointer<EailFunction>("elm_modapi_init"))
- eailInit(nullptr);
- }
-#endif
-
</del><span class="cx"> SoupNetworkSession::defaultSession().setupHTTPProxyFromEnvironment();
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -146,13 +116,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> ecore_shutdown();
</span><span class="cx"> eina_shutdown();
</span><del>-
-#if HAVE(ACCESSIBILITY)
- if (eailLibraryPath()) {
- if (EailFunction eailShutdown = eail().functionPointer<EailFunction>("elm_modapi_shutdown"))
- eailShutdown(nullptr);
- }
-#endif
</del><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (195724 => 195725)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2016-01-28 02:21:25 UTC (rev 195724)
+++ trunk/Tools/ChangeLog        2016-01-28 02:28:03 UTC (rev 195725)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-01-27 Krzysztof Czech <k.czech@samsung.com>
+
+ [EFL] Remove unused accessibility related code
+ https://bugs.webkit.org/show_bug.cgi?id=153543
+
+ Reviewed by Darin Adler.
+
+ Removed reference to EAIL library.
+ It not going to be support anymore. There have been changes in
+ EFL/Elementary in terms of the accessibility and we should
+ follow those.
+
+ * efl/jhbuild-optional.modules:
+
</ins><span class="cx"> 2016-01-27 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove WebKitSystemInterface for iOS SDK < 9
</span></span></pre></div>
<a id="trunkToolsefljhbuildoptionalmodules"></a>
<div class="modfile"><h4>Modified: trunk/Tools/efl/jhbuild-optional.modules (195724 => 195725)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/efl/jhbuild-optional.modules        2016-01-28 02:21:25 UTC (rev 195724)
+++ trunk/Tools/efl/jhbuild-optional.modules        2016-01-28 02:28:03 UTC (rev 195725)
</span><span class="lines">@@ -5,8 +5,6 @@
</span><span class="cx">
</span><span class="cx"> <repository type="tarball" name="ftp.gnome.org"
</span><span class="cx"> href="http://ftp.gnome.org"/>
</span><del>- <repository type="git" name="github"
- href="https://github.com/czechk"/>
</del><span class="cx">
</span><span class="cx"> <autotools id="at-spi2-core"
</span><span class="cx"> autogenargs="--disable-introspection">
</span><span class="lines">@@ -31,8 +29,4 @@
</span><span class="cx"> </dependencies>
</span><span class="cx"> </autotools>
</span><span class="cx">
</span><del>- <autotools id="eail" autogen-sh="autogen.sh">
- <branch repo="github" module="eail.git" checkoutdir="eail-1.0.0"/>
-</autotools>
-
</del><span class="cx"> </moduleset>
</span></span></pre>
</div>
</div>
</body>
</html>