<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195706] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195706">195706</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-27 16:18:37 -0800 (Wed, 27 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Regression (<a href="http://trac.webkit.org/projects/webkit/changeset/195303">r195303</a>) - Changes to TreeOutline break styling of lists in Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=153563
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-01-27
Reviewed by Timothy Hatcher.
Removed duplicate properties and used new methods of TreeOutline to achieve
the desired styling effects.
* UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles): Deleted.
* UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection):
* UserInterface/Views/VisualStyleSelectorTreeItem.css:
(.item.visual-style-selector-item > .icon):
(.item.visual-style-selector-item > .titles):
(.item.visual-style-selector-item > .titles > .subtitle):
(.item.visual-style-selector-item.selected > .titles > .subtitle):
(.item.visual-style-selector-item > .titles > .subtitle::before): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleCommaSeparatedKeywordEditorcss">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleSelectorSectionjs">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleSelectorTreeItemcss">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (195705 => 195706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-01-28 00:17:20 UTC (rev 195705)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-01-28 00:18:37 UTC (rev 195706)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2016-01-27 Devin Rousso <dcrousso+webkit@gmail.com>
+
+ Web Inspector: Regression (r195303) - Changes to TreeOutline break styling of lists in Visual sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=153563
+
+ Reviewed by Timothy Hatcher.
+
+ Removed duplicate properties and used new methods of TreeOutline to achieve
+ the desired styling effects.
+
+ * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles): Deleted.
+
+ * UserInterface/Views/VisualStyleSelectorSection.js:
+ (WebInspector.VisualStyleSelectorSection):
+
+ * UserInterface/Views/VisualStyleSelectorTreeItem.css:
+ (.item.visual-style-selector-item > .icon):
+ (.item.visual-style-selector-item > .titles):
+ (.item.visual-style-selector-item > .titles > .subtitle):
+ (.item.visual-style-selector-item.selected > .titles > .subtitle):
+ (.item.visual-style-selector-item > .titles > .subtitle::before): Deleted.
+
</ins><span class="cx"> 2016-01-27 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Support CSS3 Images values for the image-rendering property
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleCommaSeparatedKeywordEditorcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css (195705 => 195706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2016-01-28 00:17:20 UTC (rev 195705)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2016-01-28 00:18:37 UTC (rev 195706)
</span><span class="lines">@@ -65,10 +65,6 @@
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles {
- padding-left: 3px;
-}
-
</del><span class="cx"> .visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item.selected:not(.editor-hidden) > .titles > * {
</span><span class="cx"> color: transparent;
</span><span class="cx"> }
</span><span class="lines">@@ -76,12 +72,12 @@
</span><span class="cx"> .visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor {
</span><span class="cx"> position: absolute;
</span><span class="cx"> top: 0;
</span><del>- right: 3px;
</del><ins>+ right: 0;
</ins><span class="cx"> bottom: 0;
</span><del>- left: 3px;
</del><ins>+ left: 5px;
</ins><span class="cx"> margin: 0;
</span><span class="cx"> padding: 0;
</span><del>- line-height: 13px;
</del><ins>+ line-height: 17px;
</ins><span class="cx"> border: none;
</span><span class="cx"> background-color: transparent;
</span><span class="cx"> font-family: inherit;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleSelectorSectionjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js (195705 => 195706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js 2016-01-28 00:17:20 UTC (rev 195705)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js 2016-01-28 00:18:37 UTC (rev 195706)
</span><span class="lines">@@ -55,6 +55,7 @@
</span><span class="cx"> selectorSection.element.appendChild(selectorListElement);
</span><span class="cx">
</span><span class="cx"> this._selectors = new WebInspector.TreeOutline(selectorListElement);
</span><ins>+ this._selectors.disclosureButtons = false;
</ins><span class="cx"> this._selectors.addEventListener(WebInspector.TreeOutline.Event.SelectionDidChange, this._selectorChanged, this);
</span><span class="cx">
</span><span class="cx"> this._newInspectorRuleSelector = null;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleSelectorTreeItemcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css (195705 => 195706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css 2016-01-28 00:17:20 UTC (rev 195705)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css 2016-01-28 00:18:37 UTC (rev 195706)
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> .item.visual-style-selector-item > .icon {
</span><span class="cx"> width: 16px;
</span><span class="cx"> height: 16px;
</span><del>- margin-left: 4px;
</del><ins>+ margin: 0 3px 0 4px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .item.visual-style-selector-item.modified > .icon {
</span><span class="lines">@@ -103,10 +103,11 @@
</span><span class="cx">
</span><span class="cx"> .item.visual-style-selector-item > .titles {
</span><span class="cx"> flex: 1;
</span><ins>+ top: 0;
+ line-height: inherit;
</ins><span class="cx"> overflow: hidden;
</span><span class="cx"> white-space: nowrap;
</span><span class="cx"> text-overflow: ellipsis;
</span><del>- padding: 0 2px 0 3px;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .item.visual-style-selector-item:not(.dom-element-icon) > .titles > .title {
</span><span class="lines">@@ -128,14 +129,11 @@
</span><span class="cx"> box-shadow: hsla(0, 0%, 0%, 0.15) 0 1px 0, 0 0 0 3px hsla(0, 100%, 100%, 0.3);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.item.visual-style-selector-item > .titles > .subtitle::before {
- margin-right: 5px;
- font-size: 11px;
- /* The extra space at the beginning is necessary to prevent the -webkit-user-modify
- cursor bar from displaying at the beginning of the em-dash. */
- content: " \2014"; /* em-dash */
-}
-
</del><span class="cx"> .item.visual-style-selector-item > .titles > .subtitle {
</span><ins>+ vertical-align: 1px;
</ins><span class="cx"> font-size: 9px;
</span><span class="cx"> }
</span><ins>+
+.item.visual-style-selector-item.selected > .titles > .subtitle {
+ color: inherit;
+}
</ins></span></pre>
</div>
</div>
</body>
</html>