<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195642] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195642">195642</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-01-26 17:16:16 -0800 (Tue, 26 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Setting HTMLInputElement.value to null to set its value to the empty string
https://bugs.webkit.org/show_bug.cgi?id=153519
Reviewed by Ryosuke Niwa.
Source/WebCore:
Setting HTMLInputElement.value to null to set its value to the empty string:
- https://html.spec.whatwg.org/#htmlinputelement
- http://heycam.github.io/webidl/#TreatNullAs
WebKit would previously unset the value attribute instead, which caused
it to fallback to input.defaultValue if set.
Firefox and Chrome behave correctly.
Test: fast/dom/HTMLInputElement/input-value-set-null.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue):
LayoutTests:
Add a layout test to make sure that setting HTMLInputElement.value to null
actually sets its value to the empty string.
* fast/dom/HTMLInputElement/input-value-set-null-expected.txt: Added.
* fast/dom/HTMLInputElement/input-value-set-null.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementcpp">trunk/Source/WebCore/html/HTMLInputElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomHTMLInputElementinputvaluesetnullexpectedtxt">trunk/LayoutTests/fast/dom/HTMLInputElement/input-value-set-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLInputElementinputvaluesetnullhtml">trunk/LayoutTests/fast/dom/HTMLInputElement/input-value-set-null.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195641 => 195642)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-01-27 01:11:53 UTC (rev 195641)
+++ trunk/LayoutTests/ChangeLog        2016-01-27 01:16:16 UTC (rev 195642)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2016-01-26 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Setting HTMLInputElement.value to null to set its value to the empty string
+ https://bugs.webkit.org/show_bug.cgi?id=153519
+
+ Reviewed by Ryosuke Niwa.
+
+ Add a layout test to make sure that setting HTMLInputElement.value to null
+ actually sets its value to the empty string.
+
+ * fast/dom/HTMLInputElement/input-value-set-null-expected.txt: Added.
+ * fast/dom/HTMLInputElement/input-value-set-null.html: Added.
+
+2016-01-26 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Unreviewed, temporarily skip fast/history/page-cache-webdatabase-no-transaction-db.html
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=153525
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLInputElementinputvaluesetnullexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLInputElement/input-value-set-null-expected.txt (0 => 195642)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLInputElement/input-value-set-null-expected.txt         (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLInputElement/input-value-set-null-expected.txt        2016-01-27 01:16:16 UTC (rev 195642)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+Checks that setting input.value to null sets the input value to the empty string.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+input.defaultValue = 'defaultValue'
+PASS input.value is "defaultValue"
+input.value = null
+PASS input.value is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLInputElementinputvaluesetnullhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLInputElement/input-value-set-null.html (0 => 195642)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLInputElement/input-value-set-null.html         (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLInputElement/input-value-set-null.html        2016-01-27 01:16:16 UTC (rev 195642)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<!DOCTYPE html>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+description("Checks that setting input.value to null sets the input value to the empty string.");
+
+var input = document.createElement("input");
+evalAndLog("input.defaultValue = 'defaultValue'");
+
+shouldBeEqualToString("input.value", "defaultValue");
+
+// HTMLInputElement.value treats null as the empty String so this should set the value to "".
+evalAndLog("input.value = null");
+shouldBeEqualToString("input.value", "");
+</script>
+<script src="../../../resources/js-test-post.js"></script>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195641 => 195642)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-01-27 01:11:53 UTC (rev 195641)
+++ trunk/Source/WebCore/ChangeLog        2016-01-27 01:16:16 UTC (rev 195642)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2016-01-26 Chris Dumez <cdumez@apple.com>
+
+ Setting HTMLInputElement.value to null to set its value to the empty string
+ https://bugs.webkit.org/show_bug.cgi?id=153519
+
+ Reviewed by Ryosuke Niwa.
+
+ Setting HTMLInputElement.value to null to set its value to the empty string:
+ - https://html.spec.whatwg.org/#htmlinputelement
+ - http://heycam.github.io/webidl/#TreatNullAs
+
+ WebKit would previously unset the value attribute instead, which caused
+ it to fallback to input.defaultValue if set.
+
+ Firefox and Chrome behave correctly.
+
+ Test: fast/dom/HTMLInputElement/input-value-set-null.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setValue):
+
</ins><span class="cx"> 2016-01-26 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> WebKitAdditions should be able to modify derived source rules
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (195641 => 195642)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.cpp        2016-01-27 01:11:53 UTC (rev 195641)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp        2016-01-27 01:16:16 UTC (rev 195642)
</span><span class="lines">@@ -983,7 +983,7 @@
</span><span class="cx"> ec = INVALID_STATE_ERR;
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- setValue(value, eventBehavior);
</del><ins>+ setValue(value.isNull() ? emptyString() : value, eventBehavior);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior eventBehavior)
</span></span></pre>
</div>
</div>
</body>
</html>