<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195579] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195579">195579</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-01-25 21:40:28 -0800 (Mon, 25 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Give the layout test results file a <title> showing the date and time the tests were run
https://bugs.webkit.org/show_bug.cgi?id=153187
Reviewed by Darin Adler.
Tools:
Include a 'date' property in the JSON with the date and time the tests completed.
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
LayoutTests:
Generate a <title> element from the 'date' property in the JSON.
* fast/harness/results.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastharnessresultshtml">trunk/LayoutTests/fast/harness/results.html</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpylayout_testsmodelstest_run_resultspy">trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195578 => 195579)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-01-26 04:01:33 UTC (rev 195578)
+++ trunk/LayoutTests/ChangeLog 2016-01-26 05:40:28 UTC (rev 195579)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-01-25 Simon Fraser <simon.fraser@apple.com>
+
+ Give the layout test results file a <title> showing the date and time the tests were run
+ https://bugs.webkit.org/show_bug.cgi?id=153187
+
+ Reviewed by Darin Adler.
+
+ Generate a <title> element from the 'date' property in the JSON.
+
+ * fast/harness/results.html:
+
</ins><span class="cx"> 2016-01-25 Carlos Alberto Lopez Perez <clopez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Unreviewed GTK gardening.
</span></span></pre></div>
<a id="trunkLayoutTestsfastharnessresultshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/harness/results.html (195578 => 195579)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/harness/results.html 2016-01-26 04:01:33 UTC (rev 195578)
+++ trunk/LayoutTests/fast/harness/results.html 2016-01-26 05:40:28 UTC (rev 195579)
</span><span class="lines">@@ -1385,9 +1385,18 @@
</span><span class="cx"> return header + tableRowHtml + '</table></div>';
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function updateTitle()
+{
+ var dateString = globalState().results.date;
+
+ var title = document.createElement('title');
+ title.textContent = 'Layout Test Results from ' + dateString;
+ document.head.appendChild(title);
+}
</ins><span class="cx">
</span><span class="cx"> function generatePage()
</span><span class="cx"> {
</span><ins>+ updateTitle();
</ins><span class="cx"> forEachTest(processGlobalStateFor);
</span><span class="cx"> forOtherCrashes();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (195578 => 195579)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-01-26 04:01:33 UTC (rev 195578)
+++ trunk/Tools/ChangeLog 2016-01-26 05:40:28 UTC (rev 195579)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-01-25 Simon Fraser <simon.fraser@apple.com>
+
+ Give the layout test results file a <title> showing the date and time the tests were run
+ https://bugs.webkit.org/show_bug.cgi?id=153187
+
+ Reviewed by Darin Adler.
+
+ Include a 'date' property in the JSON with the date and time the tests completed.
+
+ * Scripts/webkitpy/layout_tests/models/test_run_results.py:
+ (summarize_results):
+
</ins><span class="cx"> 2016-01-25 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r195543.
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpylayout_testsmodelstest_run_resultspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (195578 => 195579)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py 2016-01-26 04:01:33 UTC (rev 195578)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py 2016-01-26 05:40:28 UTC (rev 195579)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
</span><span class="cx"> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">
</span><ins>+import datetime
</ins><span class="cx"> import logging
</span><span class="cx"> import signal
</span><span class="cx">
</span><span class="lines">@@ -133,6 +134,7 @@
</span><span class="cx"> 'num_missing': The number of tests with missing results
</span><span class="cx"> 'num_passes': The number of unexpected passes
</span><span class="cx"> 'tests': a dict of tests -> {'expected': '...', 'actual': '...'}
</span><ins>+ 'date': the current date and time
</ins><span class="cx"> """
</span><span class="cx"> results = {}
</span><span class="cx"> results['version'] = 4
</span><span class="lines">@@ -264,6 +266,7 @@
</span><span class="cx"> results['has_pretty_patch'] = port_obj.pretty_patch.pretty_patch_available()
</span><span class="cx"> results['pixel_tests_enabled'] = port_obj.get_option('pixel_tests')
</span><span class="cx"> results['other_crashes'] = other_crashes_dict
</span><ins>+ results['date'] = datetime.datetime.now().strftime("%I:%M%p on %B %d, %Y")
</ins><span class="cx">
</span><span class="cx"> try:
</span><span class="cx"> # We only use the svn revision for using trac links in the results.html file,
</span></span></pre>
</div>
</div>
</body>
</html>