<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195516] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195516">195516</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-01-24 12:39:49 -0800 (Sun, 24 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make the dumped display list representation a bit more compact
https://bugs.webkit.org/show_bug.cgi?id=153409
Reviewed by Zalan Bujtas.
Source/WebCore:
Don't make a group for every display list item.
* platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::asText):
LayoutTests:
Updated results.
* displaylists/extent-includes-shadow-expected.txt:
* displaylists/extent-includes-transforms-expected.txt:
* displaylists/layer-dispay-list-expected.txt:
* displaylists/replay-skip-clipped-rect-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsdisplaylistsextentincludesshadowexpectedtxt">trunk/LayoutTests/displaylists/extent-includes-shadow-expected.txt</a></li>
<li><a href="#trunkLayoutTestsdisplaylistsextentincludestransformsexpectedtxt">trunk/LayoutTests/displaylists/extent-includes-transforms-expected.txt</a></li>
<li><a href="#trunkLayoutTestsdisplaylistslayerdispaylistexpectedtxt">trunk/LayoutTests/displaylists/layer-dispay-list-expected.txt</a></li>
<li><a href="#trunkLayoutTestsdisplaylistsreplayskipclippedrectexpectedtxt">trunk/LayoutTests/displaylists/replay-skip-clipped-rect-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsdisplaylistsDisplayListcpp">trunk/Source/WebCore/platform/graphics/displaylists/DisplayList.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195515 => 195516)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-01-24 20:39:42 UTC (rev 195515)
+++ trunk/LayoutTests/ChangeLog 2016-01-24 20:39:49 UTC (rev 195516)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2016-01-24 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Make the dumped display list representation a bit more compact
+ https://bugs.webkit.org/show_bug.cgi?id=153409
+
+ Reviewed by Zalan Bujtas.
+
+ Updated results.
+
+ * displaylists/extent-includes-shadow-expected.txt:
+ * displaylists/extent-includes-transforms-expected.txt:
+ * displaylists/layer-dispay-list-expected.txt:
+ * displaylists/replay-skip-clipped-rect-expected.txt:
+
+2016-01-24 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Add testing for display list replay, and skip clipped-out items on replay
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=153408
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsdisplaylistsextentincludesshadowexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/displaylists/extent-includes-shadow-expected.txt (195515 => 195516)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/displaylists/extent-includes-shadow-expected.txt 2016-01-24 20:39:42 UTC (rev 195515)
+++ trunk/LayoutTests/displaylists/extent-includes-shadow-expected.txt 2016-01-24 20:39:49 UTC (rev 195516)
</span><span class="lines">@@ -1,21 +1,16 @@
</span><span class="cx">
</span><del>-(
- (translate
- (x 0.00)
- (y 0.00)))
-(
- (save
- (restore-index 4)))
-(
- (set-state
- (change-flags 1024)
- (shadow-blur 12.00)
- (shadow-offset width=10 height=20)
- (shadows-use-legacy-radius 0)))
-(
- (fill-rect-with-color
- (extent at (43,50) size 134x137)
- (rect at (50,50) size 100x100)
- (color #0000FF)))
-(
- (restore))
</del><ins>+(translate
+ (x 0.00)
+ (y 0.00))
+(save
+ (restore-index 4))
+(set-state
+ (change-flags 1024)
+ (shadow-blur 12.00)
+ (shadow-offset width=10 height=20)
+ (shadows-use-legacy-radius 0))
+(fill-rect-with-color
+ (extent at (43,50) size 134x137)
+ (rect at (50,50) size 100x100)
+ (color #0000FF))
+(restore)
</ins></span></pre></div>
<a id="trunkLayoutTestsdisplaylistsextentincludestransformsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/displaylists/extent-includes-transforms-expected.txt (195515 => 195516)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/displaylists/extent-includes-transforms-expected.txt 2016-01-24 20:39:42 UTC (rev 195515)
+++ trunk/LayoutTests/displaylists/extent-includes-transforms-expected.txt 2016-01-24 20:39:49 UTC (rev 195516)
</span><span class="lines">@@ -1,24 +1,18 @@
</span><span class="cx">
</span><del>-(
- (translate
- (x 0.00)
- (y 22.00)))
-(
- (concatentate-ctm
- (ctm {m=((0.87,0.50)(-0.50,0.87)) t=(81.70,-18.30)})))
-(
- (save
- (restore-index 5)))
-(
- (set-state
- (change-flags 1024)
- (shadow-blur 12.00)
- (shadow-offset width=10 height=20)
- (shadows-use-legacy-radius 0)))
-(
- (fill-rect-with-color
- (extent at (7.14,0.20) size 184.55x185.65)
- (rect at (0,0) size 100x100)
- (color #0000FF)))
-(
- (restore))
</del><ins>+(translate
+ (x 0.00)
+ (y 22.00))
+(concatentate-ctm
+ (ctm {m=((0.87,0.50)(-0.50,0.87)) t=(81.70,-18.30)}))
+(save
+ (restore-index 5))
+(set-state
+ (change-flags 1024)
+ (shadow-blur 12.00)
+ (shadow-offset width=10 height=20)
+ (shadows-use-legacy-radius 0))
+(fill-rect-with-color
+ (extent at (7.14,0.20) size 184.55x185.65)
+ (rect at (0,0) size 100x100)
+ (color #0000FF))
+(restore)
</ins></span></pre></div>
<a id="trunkLayoutTestsdisplaylistslayerdispaylistexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/displaylists/layer-dispay-list-expected.txt (195515 => 195516)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/displaylists/layer-dispay-list-expected.txt 2016-01-24 20:39:42 UTC (rev 195515)
+++ trunk/LayoutTests/displaylists/layer-dispay-list-expected.txt 2016-01-24 20:39:49 UTC (rev 195516)
</span><span class="lines">@@ -1,36 +1,29 @@
</span><span class="cx">
</span><del>-(
- (translate
- (x 0.00)
- (y 0.00)))
-(
- (fill-rect-with-color
- (extent at (0,0) size 104x104)
- (rect at (0,0) size 104x104)
- (color #008000)))
-(
- (set-state
- (change-flags 131456)
- (fill-color #0000FF)
- (stroke-style 0)
- (should-antialias 0)))
-(
- (draw-rect
- (extent at (0,0) size 104x2)
- (rect at (0,0) size 104x2)
- (border-thickness 1.00)))
-(
- (draw-rect
- (extent at (0,102) size 104x2)
- (rect at (0,102) size 104x2)
- (border-thickness 1.00)))
-(
- (draw-rect
- (extent at (0,0) size 2x104)
- (rect at (0,0) size 2x104)
- (border-thickness 1.00)))
-(
- (draw-rect
- (extent at (102,0) size 2x104)
- (rect at (102,0) size 2x104)
- (border-thickness 1.00)))
</del><ins>+(translate
+ (x 0.00)
+ (y 0.00))
+(fill-rect-with-color
+ (extent at (0,0) size 104x104)
+ (rect at (0,0) size 104x104)
+ (color #008000))
+(set-state
+ (change-flags 131456)
+ (fill-color #0000FF)
+ (stroke-style 0)
+ (should-antialias 0))
+(draw-rect
+ (extent at (0,0) size 104x2)
+ (rect at (0,0) size 104x2)
+ (border-thickness 1.00))
+(draw-rect
+ (extent at (0,102) size 104x2)
+ (rect at (0,102) size 104x2)
+ (border-thickness 1.00))
+(draw-rect
+ (extent at (0,0) size 2x104)
+ (rect at (0,0) size 2x104)
+ (border-thickness 1.00))
+(draw-rect
+ (extent at (102,0) size 2x104)
+ (rect at (102,0) size 2x104)
+ (border-thickness 1.00))
</ins></span></pre></div>
<a id="trunkLayoutTestsdisplaylistsreplayskipclippedrectexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/displaylists/replay-skip-clipped-rect-expected.txt (195515 => 195516)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/displaylists/replay-skip-clipped-rect-expected.txt 2016-01-24 20:39:42 UTC (rev 195515)
+++ trunk/LayoutTests/displaylists/replay-skip-clipped-rect-expected.txt 2016-01-24 20:39:49 UTC (rev 195516)
</span><span class="lines">@@ -1,16 +1,15 @@
</span><span class="cx"> recorded:
</span><del>-(
- (translate
- (x 0.00)
- (y 0.00)))
-(
- (fill-rect-with-color
- (extent at (412,0) size 100x100)
- (rect at (412,0) size 100x100)
- (color #0000FF)))
</del><ins>+(translate
+ (x 0.00)
+ (y 0.00))
+(fill-rect-with-color
+ (extent at (412,0) size 100x100)
+ (rect at (412,0) size 100x100)
+ (color #0000FF))
</ins><span class="cx">
</span><span class="cx"> replayed:
</span><span class="cx"> (
</span><del>- (translate
- (x 0.00)
- (y 0.00)))
</del><ins>+ (clip at (512,0) size 512x200)
+(translate
+ (x 0.00)
+ (y 0.00))
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195515 => 195516)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-24 20:39:42 UTC (rev 195515)
+++ trunk/Source/WebCore/ChangeLog 2016-01-24 20:39:49 UTC (rev 195516)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-01-24 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Make the dumped display list representation a bit more compact
+ https://bugs.webkit.org/show_bug.cgi?id=153409
+
+ Reviewed by Zalan Bujtas.
+
+ Don't make a group for every display list item.
+
+ * platform/graphics/displaylists/DisplayList.cpp:
+ (WebCore::DisplayList::DisplayList::asText):
+
+2016-01-24 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Add testing for display list replay, and skip clipped-out items on replay
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=153408
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsdisplaylistsDisplayListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayList.cpp (195515 => 195516)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayList.cpp 2016-01-24 20:39:42 UTC (rev 195515)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayList.cpp 2016-01-24 20:39:49 UTC (rev 195516)
</span><span class="lines">@@ -91,13 +91,9 @@
</span><span class="cx"> String DisplayList::asText(AsTextFlags flags) const
</span><span class="cx"> {
</span><span class="cx"> TextStream stream;
</span><del>- size_t numItems = m_list.size();
- for (size_t i = 0; i < numItems; ++i) {
- const auto& item = m_list[i].get();
</del><ins>+ for (auto& item : m_list) {
</ins><span class="cx"> if (!shouldDumpForFlags(flags, item))
</span><span class="cx"> continue;
</span><del>-
- TextStream::GroupScope scope(stream);
</del><span class="cx"> stream << item;
</span><span class="cx"> }
</span><span class="cx"> return stream.release();
</span></span></pre>
</div>
</div>
</body>
</html>