<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195512] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195512">195512</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-23 18:47:42 -0800 (Sat, 23 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: AXI: node-link-list should be collapsible
https://bugs.webkit.org/show_bug.cgi?id=130911
.:
Added a manual test to test the node list in the Accessibility Inspector
Patch by Aaron Chu <arona.chu@gmail.com> on 2016-01-23
Reviewed by Timothy Hatcher.
* ManualTests/accessibility/collapsible-node-link-list.html: Added.
Source/WebInspectorUI:
Patch by Aaron Chu <arona.chu@gmail.com> on 2016-01-23
Reviewed by Timothy Hatcher.
Accessibility Inspector: for a very long children node list, only the first 5 nodes are shown.
Remaining nodes are hidden by a "# More…" link by which a user can click to reveal the remainder
of the node list.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.linkListForNodeIds):
* UserInterface/Views/Main.css:
(.expand-list-button):
(.node-link-list, .node-link-list li:not([hidden])):
(.node-link-list, .node-link-list li): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMNodeDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsMaincss">trunk/Source/WebInspectorUI/UserInterface/Views/Main.css</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkManualTestsaccessibilitycollapsiblenodelinklisthtml">trunk/ManualTests/accessibility/collapsible-node-link-list.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (195511 => 195512)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2016-01-23 22:51:40 UTC (rev 195511)
+++ trunk/ChangeLog 2016-01-24 02:47:42 UTC (rev 195512)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-01-23 Aaron Chu <arona.chu@gmail.com>
+
+ Web Inspector: AXI: node-link-list should be collapsible
+ https://bugs.webkit.org/show_bug.cgi?id=130911
+
+ Added a manual test to test the node list in the Accessibility Inspector
+
+ Reviewed by Timothy Hatcher.
+
+ * ManualTests/accessibility/collapsible-node-link-list.html: Added.
+
</ins><span class="cx"> 2016-01-22 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Fix internal Windows build
</span></span></pre></div>
<a id="trunkManualTestsaccessibilitycollapsiblenodelinklisthtml"></a>
<div class="addfile"><h4>Added: trunk/ManualTests/accessibility/collapsible-node-link-list.html (0 => 195512)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ManualTests/accessibility/collapsible-node-link-list.html (rev 0)
+++ trunk/ManualTests/accessibility/collapsible-node-link-list.html 2016-01-24 02:47:42 UTC (rev 195512)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<html>
+<body>
+
+
+<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=130911">Bug 130911: Web Inspector: AXI: node-link-list should be collapsible</a>.</p>
+<ol>
+<li>Open Accessibility Inspector.</li>
+<li>In DOM tree in the Web Inspector, click on the unordered list below.</li>
+<li>In the Accessibility Inspector, you should be able to see that 5 out of 10 nodes are showing. The remaining 5 are hidden. If you do not see this, the test fails.</li>
+<li>In the Accessibility Inspector click on "5 more&hellip;" to reveal the remaining 5 nodes.</li>
+<li>If the click on the said link does not function as described in #4, the test fails.</li>
+</ol>
+
+<ul>
+<li>Item 1</li>
+<li>Item 2</li>
+<li>Item 3</li>
+<li>Item 4</li>
+<li>Item 5</li>
+<li>Item 6</li>
+<li>Item 7</li>
+<li>Item 8</li>
+<li>Item 9</li>
+<li>Item 10</li>
+</ul>
+
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (195511 => 195512)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-01-23 22:51:40 UTC (rev 195511)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-01-24 02:47:42 UTC (rev 195512)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-01-23 Aaron Chu <arona.chu@gmail.com>
+
+ Web Inspector: AXI: node-link-list should be collapsible
+ https://bugs.webkit.org/show_bug.cgi?id=130911
+
+ Reviewed by Timothy Hatcher.
+
+ Accessibility Inspector: for a very long children node list, only the first 5 nodes are shown.
+ Remaining nodes are hidden by a "# More…" link by which a user can click to reveal the remainder
+ of the node list.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+ (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.linkListForNodeIds):
+ * UserInterface/Views/Main.css:
+ (.expand-list-button):
+ (.node-link-list, .node-link-list li:not([hidden])):
+ (.node-link-list, .node-link-list li): Deleted.
+
</ins><span class="cx"> 2016-01-22 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Reduce unnecessary forced layouts in TimelineRuler
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (195511 => 195512)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2016-01-23 22:51:40 UTC (rev 195511)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2016-01-24 02:47:42 UTC (rev 195512)
</span><span class="lines">@@ -1,5 +1,6 @@
</span><span class="cx"> \xFE\xFFvar localizedStrings = new Object;
</span><span class="cx">
</span><ins>+localizedStrings["%d More\u2026"] = "%d More\u2026";
</ins><span class="cx"> localizedStrings[" (Prototype)"] = " (Prototype)";
</span><span class="cx"> localizedStrings[" (line %s)"] = " (line %s)";
</span><span class="cx"> localizedStrings["%.0f B"] = "%.0f B";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMNodeDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (195511 => 195512)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2016-01-23 22:51:40 UTC (rev 195511)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2016-01-24 02:47:42 UTC (rev 195512)
</span><span class="lines">@@ -300,25 +300,43 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function linkListForNodeIds(nodeIds) {
</span><del>- var hasLinks = false;
- var linkList = null;
- if (nodeIds !== undefined) {
- linkList = document.createElement("ul");
- linkList.className = "node-link-list";
- for (var nodeId of nodeIds) {
- var node = WebInspector.domTreeManager.nodeForId(nodeId);
- if (node) {
- var link = WebInspector.linkifyAccessibilityNodeReference(node);
- if (link) {
- hasLinks = true;
- var listitem = document.createElement("li");
- listitem.appendChild(link);
- linkList.appendChild(listitem);
- }
- }
- }
</del><ins>+ if (!nodeIds)
+ return null;
+
+ const itemsToShow = 5;
+ let hasLinks = false;
+ let listItemCount = 0;
+ let container = document.createElement("div");
+ container.classList.add("list-container")
+ let linkList = container.createChild("ul", "node-link-list");
+ let initiallyHiddenItems = [];
+ for (let nodeId of nodeIds) {
+ let node = WebInspector.domTreeManager.nodeForId(nodeId);
+ if (!node)
+ continue;
+ let link = WebInspector.linkifyAccessibilityNodeReference(node);
+ hasLinks = true;
+ let li = linkList.createChild("li");
+ li.appendChild(link);
+ if (listItemCount >= itemsToShow) {
+ li.hidden = true;
+ initiallyHiddenItems.push(li);
+ }
+ listItemCount++;
</ins><span class="cx"> }
</span><del>- return hasLinks ? linkList : null;
</del><ins>+ container.appendChild(linkList);
+ if (listItemCount > itemsToShow) {
+ let moreNodesButton = container.createChild("button", "expand-list-button");
+ moreNodesButton.textContent = WebInspector.UIString("%d More\u2026").format(listItemCount - itemsToShow);
+ moreNodesButton.addEventListener("click", () => {
+ initiallyHiddenItems.forEach((element) => element.hidden = false);
+ moreNodesButton.remove();
+ });
+ }
+ if (hasLinks)
+ return container;
+
+ return null;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function accessibilityPropertiesCallback(accessibilityProperties) {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsMaincss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Main.css (195511 => 195512)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2016-01-23 22:51:40 UTC (rev 195511)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2016-01-24 02:47:42 UTC (rev 195512)
</span><span class="lines">@@ -305,12 +305,23 @@
</span><span class="cx"> display: none !important;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.expand-list-button {
+ -webkit-appearance: none;
+ text-decoration: underline;
+ background-color: transparent;
+ padding: 0;
+ margin: 0;
+ border: 0;
+ cursor: pointer;
+ color: black;
+}
+
</ins><span class="cx"> .node-link {
</span><span class="cx"> text-decoration: underline;
</span><span class="cx"> cursor: pointer;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.node-link-list, .node-link-list li {
</del><ins>+.node-link-list, .node-link-list li:not([hidden]) {
</ins><span class="cx"> display: block;
</span><span class="cx"> margin: 0;
</span><span class="cx"> padding: 0;
</span></span></pre>
</div>
</div>
</body>
</html>