<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195447] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195447">195447</a></dd>
<dt>Author</dt> <dd>changseok.oh@collabora.com</dd>
<dt>Date</dt> <dd>2016-01-22 01:19:44 -0800 (Fri, 22 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Remove a focus ring on anchor node when focused by mouse.
https://bugs.webkit.org/show_bug.cgi?id=136121
Reviewed by Michael Catanzaro.
Source/WebCore:
Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
for mouse clicking. I think the behavior is reasonable and looks better.
No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
affect the focus ring for tab navigation.
No new tests since an existing test can cover this.
Tests: fast/events/click-focus-anchor.html
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable):
LayoutTests:
Removed gtk and efl specific results for the test.
* platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
* platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementcpp">trunk/Source/WebCore/html/HTMLAnchorElement.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformeflfasteventsclickfocusanchorexpectedtxt">trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfasteventsclickfocusanchorexpectedtxt">trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195446 => 195447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/ChangeLog 2016-01-22 09:19:44 UTC (rev 195447)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-01-22 ChangSeok Oh <changseok.oh@collabora.com>
+
+ [GTK] Remove a focus ring on anchor node when focused by mouse.
+ https://bugs.webkit.org/show_bug.cgi?id=136121
+
+ Reviewed by Michael Catanzaro.
+
+ Removed gtk and efl specific results for the test.
+
+ * platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
+ * platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.
+
</ins><span class="cx"> 2016-01-21 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflfasteventsclickfocusanchorexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt (195446 => 195447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt 2016-01-22 09:19:44 UTC (rev 195447)
</span><span class="lines">@@ -1,11 +0,0 @@
</span><del>-This test ensures that we can click to focus an a element. Click on the element below.
-
-The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable.
-
-Result
-
-
-a1 received focus (focusable)
-a3 received focus (focusable on GTK, QT and EFL)
-a4 received focus (focusable)
-a5 received focus (focusable)
</del></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfasteventsclickfocusanchorexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt (195446 => 195447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt 2016-01-22 09:19:44 UTC (rev 195447)
</span><span class="lines">@@ -1,11 +0,0 @@
</span><del>-This test ensures that we can click to focus an a element. Click on the element below.
-
-The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable.
-
-Result
-
-
-a1 received focus (focusable)
-a3 received focus (focusable on GTK, QT and EFL)
-a4 received focus (focusable)
-a5 received focus (focusable)
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195446 => 195447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/Source/WebCore/ChangeLog 2016-01-22 09:19:44 UTC (rev 195447)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-01-22 ChangSeok Oh <changseok.oh@collabora.com>
+
+ [GTK] Remove a focus ring on anchor node when focused by mouse.
+ https://bugs.webkit.org/show_bug.cgi?id=136121
+
+ Reviewed by Michael Catanzaro.
+
+ Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
+ for mouse clicking. I think the behavior is reasonable and looks better.
+ No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
+ affect the focus ring for tab navigation.
+
+ No new tests since an existing test can cover this.
+ Tests: fast/events/click-focus-anchor.html
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isMouseFocusable):
+
</ins><span class="cx"> 2016-01-21 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAnchorElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (195446 => 195447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2016-01-22 09:19:44 UTC (rev 195447)
</span><span class="lines">@@ -95,12 +95,9 @@
</span><span class="cx">
</span><span class="cx"> bool HTMLAnchorElement::isMouseFocusable() const
</span><span class="cx"> {
</span><del>-#if !(PLATFORM(EFL) || PLATFORM(GTK))
</del><span class="cx"> // Only allow links with tabIndex or contentEditable to be mouse focusable.
</span><del>- // This is our rule for the Mac platform; on many other platforms we focus any link you click on.
</del><span class="cx"> if (isLink())
</span><span class="cx"> return HTMLElement::supportsFocus();
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> return HTMLElement::isMouseFocusable();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>