<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195456] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195456">195456</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-22 10:07:58 -0800 (Fri, 22 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Sidebar's should remember their width's
https://bugs.webkit.org/show_bug.cgi?id=153007
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-01-22
Reviewed by Timothy Hatcher.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.widthDidChange):
Now calls superclass function.
* UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.set selectedSidebarPanel):
Now calls _recalculateWidth with the saved width value of the sidebar as
the first parameter.
(WebInspector.Sidebar.prototype.set collapsed):
Now only calls _recalculateWidth if the selected sidebar panel is visible,
seeing as if it is hidden the width is irrelevant.
* UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel):
Creates a setting object using the panel's identifier to store the current width.
(WebInspector.SidebarPanel.prototype.get savedWidth):
(WebInspector.SidebarPanel.prototype.widthDidChange):
So long as the current width has a value, save it to the setting object.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSidebarjs">trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (195455 => 195456)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-01-22 18:06:18 UTC (rev 195455)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-01-22 18:07:58 UTC (rev 195456)
</span><span class="lines">@@ -1,5 +1,33 @@
</span><span class="cx"> 2016-01-22 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Sidebar's should remember their width's
+ https://bugs.webkit.org/show_bug.cgi?id=153007
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+ (WebInspector.CSSStyleDetailsSidebarPanel.prototype.widthDidChange):
+ Now calls superclass function.
+
+ * UserInterface/Views/Sidebar.js:
+ (WebInspector.Sidebar.prototype.set selectedSidebarPanel):
+ Now calls _recalculateWidth with the saved width value of the sidebar as
+ the first parameter.
+
+ (WebInspector.Sidebar.prototype.set collapsed):
+ Now only calls _recalculateWidth if the selected sidebar panel is visible,
+ seeing as if it is hidden the width is irrelevant.
+
+ * UserInterface/Views/SidebarPanel.js:
+ (WebInspector.SidebarPanel):
+ Creates a setting object using the panel's identifier to store the current width.
+
+ (WebInspector.SidebarPanel.prototype.get savedWidth):
+ (WebInspector.SidebarPanel.prototype.widthDidChange):
+ So long as the current width has a value, save it to the setting object.
+
+2016-01-22 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Class toggle add icon flashes when changing nodes
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=153341
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (195455 => 195456)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2016-01-22 18:06:18 UTC (rev 195455)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2016-01-22 18:07:58 UTC (rev 195456)
</span><span class="lines">@@ -172,6 +172,8 @@
</span><span class="cx">
</span><span class="cx"> widthDidChange()
</span><span class="cx"> {
</span><ins>+ super.widthDidChange();
+
</ins><span class="cx"> this._updateNoForcedPseudoClassesScrollOffset();
</span><span class="cx">
</span><span class="cx"> if (this._selectedPanel)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSidebarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js (195455 => 195456)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2016-01-22 18:06:18 UTC (rev 195455)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2016-01-22 18:07:58 UTC (rev 195456)
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx"> if (this._selectedSidebarPanel.visible) {
</span><span class="cx"> this._selectedSidebarPanel.shown();
</span><span class="cx"> this._selectedSidebarPanel.visibilityDidChange();
</span><del>- this._recalculateWidth();
</del><ins>+ this._recalculateWidth(this._selectedSidebarPanel.savedWidth);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -200,14 +200,13 @@
</span><span class="cx"> this._navigationBar.needsLayout();
</span><span class="cx">
</span><span class="cx"> if (this._selectedSidebarPanel) {
</span><del>- if (this._selectedSidebarPanel.visible)
</del><ins>+ if (this._selectedSidebarPanel.visible) {
</ins><span class="cx"> this._selectedSidebarPanel.shown();
</span><del>- else
</del><ins>+ this._recalculateWidth(this._selectedSidebarPanel.savedWidth);
+ } else
</ins><span class="cx"> this._selectedSidebarPanel.hidden();
</span><span class="cx">
</span><span class="cx"> this._selectedSidebarPanel.visibilityDidChange();
</span><del>- this._selectedSidebarPanel.widthDidChange();
- this._recalculateWidth();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this.dispatchEventToListeners(WebInspector.Sidebar.Event.CollapsedStateDidChange);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js (195455 => 195456)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js 2016-01-22 18:06:18 UTC (rev 195455)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js 2016-01-22 18:07:58 UTC (rev 195456)
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx"> this._displayName = displayName;
</span><span class="cx"> this._selected = false;
</span><span class="cx">
</span><ins>+ this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 0);
</ins><span class="cx"> this._savedScrollPosition = 0;
</span><span class="cx">
</span><span class="cx"> this.element.classList.add("panel", identifier);
</span><span class="lines">@@ -87,6 +88,11 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ get savedWidth()
+ {
+ return this._widthSetting.value;
+ }
+
</ins><span class="cx"> show()
</span><span class="cx"> {
</span><span class="cx"> if (!this.parentSidebar)
</span><span class="lines">@@ -148,6 +154,10 @@
</span><span class="cx">
</span><span class="cx"> widthDidChange()
</span><span class="cx"> {
</span><ins>+ let width = this.element.realOffsetWidth;
+ if (width && width !== this._widthSetting.value)
+ this._widthSetting.value = width;
+
</ins><span class="cx"> // Implemented by subclasses.
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>