<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195243] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195243">195243</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-18 18:56:34 -0800 (Mon, 18 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Reduce PassRefPtr uses in dom - 3
https://bugs.webkit.org/show_bug.cgi?id=153055
Reviewed by Darin Adler.
Third patch to reduce uses of PassRefPtr in WebCore/dom.
* dom/MutationObserverInterestGroup.cpp:
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
* dom/MutationRecord.cpp:
(WebCore::MutationRecord::createChildList):
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createCharacterData):
(WebCore::MutationRecord::createWithNullOldValue):
* dom/MutationRecord.h:
* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::createCSSOMSnapshot):
* dom/NamedFlowCollection.h:
* dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
* dom/PendingScript.h:
* dom/ScriptRunner.h:
* dom/SecurityContext.h:
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
* dom/ShadowRoot.h:
* dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitStringData::create):
* dom/SpaceSplitString.h:
* dom/TreeWalker.cpp:
(WebCore::TreeWalker::setCurrent):
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
* dom/TreeWalker.h:
* dom/default/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::entangledChannel):
* dom/default/PlatformMessagePortChannel.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomMutationObserverInterestGroupcpp">trunk/Source/WebCore/dom/MutationObserverInterestGroup.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMutationRecordcpp">trunk/Source/WebCore/dom/MutationRecord.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMutationRecordh">trunk/Source/WebCore/dom/MutationRecord.h</a></li>
<li><a href="#trunkSourceWebCoredomNamedFlowCollectioncpp">trunk/Source/WebCore/dom/NamedFlowCollection.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNamedFlowCollectionh">trunk/Source/WebCore/dom/NamedFlowCollection.h</a></li>
<li><a href="#trunkSourceWebCoredomPendingScriptcpp">trunk/Source/WebCore/dom/PendingScript.cpp</a></li>
<li><a href="#trunkSourceWebCoredomPendingScripth">trunk/Source/WebCore/dom/PendingScript.h</a></li>
<li><a href="#trunkSourceWebCoredomScriptRunnerh">trunk/Source/WebCore/dom/ScriptRunner.h</a></li>
<li><a href="#trunkSourceWebCoredomSecurityContexth">trunk/Source/WebCore/dom/SecurityContext.h</a></li>
<li><a href="#trunkSourceWebCoredomShadowRootcpp">trunk/Source/WebCore/dom/ShadowRoot.cpp</a></li>
<li><a href="#trunkSourceWebCoredomShadowRooth">trunk/Source/WebCore/dom/ShadowRoot.h</a></li>
<li><a href="#trunkSourceWebCoredomSpaceSplitStringcpp">trunk/Source/WebCore/dom/SpaceSplitString.cpp</a></li>
<li><a href="#trunkSourceWebCoredomSpaceSplitStringh">trunk/Source/WebCore/dom/SpaceSplitString.h</a></li>
<li><a href="#trunkSourceWebCoredomTreeWalkercpp">trunk/Source/WebCore/dom/TreeWalker.cpp</a></li>
<li><a href="#trunkSourceWebCoredomTreeWalkerh">trunk/Source/WebCore/dom/TreeWalker.h</a></li>
<li><a href="#trunkSourceWebCoredomdefaultPlatformMessagePortChannelcpp">trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.cpp</a></li>
<li><a href="#trunkSourceWebCoredomdefaultPlatformMessagePortChannelh">trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/ChangeLog 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -1,3 +1,44 @@
</span><ins>+2016-01-18 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Reduce PassRefPtr uses in dom - 3
+ https://bugs.webkit.org/show_bug.cgi?id=153055
+
+ Reviewed by Darin Adler.
+
+ Third patch to reduce uses of PassRefPtr in WebCore/dom.
+
+ * dom/MutationObserverInterestGroup.cpp:
+ (WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
+ * dom/MutationRecord.cpp:
+ (WebCore::MutationRecord::createChildList):
+ (WebCore::MutationRecord::createAttributes):
+ (WebCore::MutationRecord::createCharacterData):
+ (WebCore::MutationRecord::createWithNullOldValue):
+ * dom/MutationRecord.h:
+ * dom/NamedFlowCollection.cpp:
+ (WebCore::NamedFlowCollection::createCSSOMSnapshot):
+ * dom/NamedFlowCollection.h:
+ * dom/PendingScript.cpp:
+ (WebCore::PendingScript::releaseElementAndClear):
+ * dom/PendingScript.h:
+ * dom/ScriptRunner.h:
+ * dom/SecurityContext.h:
+ * dom/ShadowRoot.cpp:
+ (WebCore::ShadowRoot::cloneNode):
+ * dom/ShadowRoot.h:
+ * dom/SpaceSplitString.cpp:
+ (WebCore::SpaceSplitStringData::create):
+ * dom/SpaceSplitString.h:
+ * dom/TreeWalker.cpp:
+ (WebCore::TreeWalker::setCurrent):
+ (WebCore::TreeWalker::parentNode):
+ (WebCore::TreeWalker::previousNode):
+ (WebCore::TreeWalker::nextNode):
+ * dom/TreeWalker.h:
+ * dom/default/PlatformMessagePortChannel.cpp:
+ (WebCore::PlatformMessagePortChannel::entangledChannel):
+ * dom/default/PlatformMessagePortChannel.h:
+
</ins><span class="cx"> 2016-01-18 Nan Wang <n_wang@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: [Mac] Implement next/previous text marker functions using TextIterator
</span></span></pre></div>
<a id="trunkSourceWebCoredomMutationObserverInterestGroupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MutationObserverInterestGroup.cpp (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MutationObserverInterestGroup.cpp 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/MutationObserverInterestGroup.cpp 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> if (mutation->oldValue().isNull())
</span><span class="cx"> mutationWithNullOldValue = mutation;
</span><span class="cx"> else
</span><del>- mutationWithNullOldValue = MutationRecord::createWithNullOldValue(mutation).get();
</del><ins>+ mutationWithNullOldValue = MutationRecord::createWithNullOldValue(*mutation).ptr();
</ins><span class="cx"> }
</span><span class="cx"> observer->enqueueMutationRecord(mutationWithNullOldValue);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomMutationRecordcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MutationRecord.cpp (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MutationRecord.cpp 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/MutationRecord.cpp 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx">
</span><span class="cx"> class MutationRecordWithNullOldValue : public MutationRecord {
</span><span class="cx"> public:
</span><del>- MutationRecordWithNullOldValue(PassRefPtr<MutationRecord> record)
</del><ins>+ MutationRecordWithNullOldValue(MutationRecord& record)
</ins><span class="cx"> : m_record(record)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -141,7 +141,7 @@
</span><span class="cx">
</span><span class="cx"> virtual String oldValue() override { return String(); }
</span><span class="cx">
</span><del>- RefPtr<MutationRecord> m_record;
</del><ins>+ Ref<MutationRecord> m_record;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> const AtomicString& ChildListRecord::type()
</span><span class="lines">@@ -164,24 +164,24 @@
</span><span class="cx">
</span><span class="cx"> } // namespace
</span><span class="cx">
</span><del>-PassRefPtr<MutationRecord> MutationRecord::createChildList(ContainerNode& target, PassRefPtr<NodeList> added, PassRefPtr<NodeList> removed, PassRefPtr<Node> previousSibling, PassRefPtr<Node> nextSibling)
</del><ins>+Ref<MutationRecord> MutationRecord::createChildList(ContainerNode& target, PassRefPtr<NodeList> added, PassRefPtr<NodeList> removed, PassRefPtr<Node> previousSibling, PassRefPtr<Node> nextSibling)
</ins><span class="cx"> {
</span><del>- return adoptRef(static_cast<MutationRecord*>(new ChildListRecord(target, added, removed, previousSibling, nextSibling)));
</del><ins>+ return adoptRef(static_cast<MutationRecord&>(*new ChildListRecord(target, added, removed, previousSibling, nextSibling)));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<MutationRecord> MutationRecord::createAttributes(Element& target, const QualifiedName& name, const AtomicString& oldValue)
</del><ins>+Ref<MutationRecord> MutationRecord::createAttributes(Element& target, const QualifiedName& name, const AtomicString& oldValue)
</ins><span class="cx"> {
</span><del>- return adoptRef(static_cast<MutationRecord*>(new AttributesRecord(target, name, oldValue)));
</del><ins>+ return adoptRef(static_cast<MutationRecord&>(*new AttributesRecord(target, name, oldValue)));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<MutationRecord> MutationRecord::createCharacterData(CharacterData& target, const String& oldValue)
</del><ins>+Ref<MutationRecord> MutationRecord::createCharacterData(CharacterData& target, const String& oldValue)
</ins><span class="cx"> {
</span><del>- return adoptRef(static_cast<MutationRecord*>(new CharacterDataRecord(target, oldValue)));
</del><ins>+ return adoptRef(static_cast<MutationRecord&>(*new CharacterDataRecord(target, oldValue)));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<MutationRecord> MutationRecord::createWithNullOldValue(PassRefPtr<MutationRecord> record)
</del><ins>+Ref<MutationRecord> MutationRecord::createWithNullOldValue(MutationRecord& record)
</ins><span class="cx"> {
</span><del>- return adoptRef(static_cast<MutationRecord*>(new MutationRecordWithNullOldValue(record)));
</del><ins>+ return adoptRef(static_cast<MutationRecord&>(*new MutationRecordWithNullOldValue(record)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> MutationRecord::~MutationRecord()
</span></span></pre></div>
<a id="trunkSourceWebCoredomMutationRecordh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MutationRecord.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MutationRecord.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/MutationRecord.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -47,11 +47,11 @@
</span><span class="cx">
</span><span class="cx"> class MutationRecord : public RefCounted<MutationRecord> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<MutationRecord> createChildList(ContainerNode& target, PassRefPtr<NodeList> added, PassRefPtr<NodeList> removed, PassRefPtr<Node> previousSibling, PassRefPtr<Node> nextSibling);
- static PassRefPtr<MutationRecord> createAttributes(Element& target, const QualifiedName&, const AtomicString& oldValue);
- static PassRefPtr<MutationRecord> createCharacterData(CharacterData& target, const String& oldValue);
</del><ins>+ static Ref<MutationRecord> createChildList(ContainerNode& target, PassRefPtr<NodeList> added, PassRefPtr<NodeList> removed, PassRefPtr<Node> previousSibling, PassRefPtr<Node> nextSibling);
+ static Ref<MutationRecord> createAttributes(Element& target, const QualifiedName&, const AtomicString& oldValue);
+ static Ref<MutationRecord> createCharacterData(CharacterData& target, const String& oldValue);
</ins><span class="cx">
</span><del>- static PassRefPtr<MutationRecord> createWithNullOldValue(PassRefPtr<MutationRecord>);
</del><ins>+ static Ref<MutationRecord> createWithNullOldValue(MutationRecord&);
</ins><span class="cx">
</span><span class="cx"> virtual ~MutationRecord();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomNamedFlowCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NamedFlowCollection.cpp (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NamedFlowCollection.cpp 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/NamedFlowCollection.cpp 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx"> return downcast<Document>(context);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<DOMNamedFlowCollection> NamedFlowCollection::createCSSOMSnapshot()
</del><ins>+Ref<DOMNamedFlowCollection> NamedFlowCollection::createCSSOMSnapshot()
</ins><span class="cx"> {
</span><span class="cx"> Vector<WebKitNamedFlow*> createdFlows;
</span><span class="cx"> for (auto& namedFlow : m_namedFlows) {
</span></span></pre></div>
<a id="trunkSourceWebCoredomNamedFlowCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NamedFlowCollection.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NamedFlowCollection.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/NamedFlowCollection.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -34,7 +34,6 @@
</span><span class="cx"> #include "WebKitNamedFlow.h"
</span><span class="cx"> #include <wtf/Forward.h>
</span><span class="cx"> #include <wtf/ListHashSet.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx">
</span><span class="lines">@@ -57,7 +56,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~NamedFlowCollection() { }
</span><span class="cx">
</span><del>- PassRefPtr<DOMNamedFlowCollection> createCSSOMSnapshot();
</del><ins>+ Ref<DOMNamedFlowCollection> createCSSOMSnapshot();
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> struct NamedFlowHashFunctions;
</span></span></pre></div>
<a id="trunkSourceWebCoredomPendingScriptcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/PendingScript.cpp (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/PendingScript.cpp 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/PendingScript.cpp 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -37,12 +37,12 @@
</span><span class="cx"> m_cachedScript->removeClient(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Element> PendingScript::releaseElementAndClear()
</del><ins>+RefPtr<Element> PendingScript::releaseElementAndClear()
</ins><span class="cx"> {
</span><span class="cx"> setCachedScript(nullptr);
</span><span class="cx"> m_watchingForLoad = false;
</span><span class="cx"> m_startingPosition = TextPosition::belowRangePosition();
</span><del>- return m_element.release();
</del><ins>+ return WTFMove(m_element);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void PendingScript::setCachedScript(CachedScript* cachedScript)
</span></span></pre></div>
<a id="trunkSourceWebCoredomPendingScripth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/PendingScript.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/PendingScript.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/PendingScript.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx">
</span><span class="cx"> Element* element() const { return m_element.get(); }
</span><span class="cx"> void setElement(Element* element) { m_element = element; }
</span><del>- PassRefPtr<Element> releaseElementAndClear();
</del><ins>+ RefPtr<Element> releaseElementAndClear();
</ins><span class="cx">
</span><span class="cx"> CachedScript* cachedScript() const;
</span><span class="cx"> void setCachedScript(CachedScript*);
</span></span></pre></div>
<a id="trunkSourceWebCoredomScriptRunnerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptRunner.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptRunner.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/ScriptRunner.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -30,7 +30,6 @@
</span><span class="cx"> #include "Timer.h"
</span><span class="cx"> #include <wtf/HashMap.h>
</span><span class="cx"> #include <wtf/Noncopyable.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCoredomSecurityContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/SecurityContext.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/SecurityContext.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/SecurityContext.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx"> #define SecurityContext_h
</span><span class="cx">
</span><span class="cx"> #include <memory>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomShadowRootcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -123,12 +123,6 @@
</span><span class="cx"> setNeedsStyleRecalc();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> ShadowRoot::cloneNode(bool, ExceptionCode& ec)
-{
- ec = DATA_CLONE_ERR;
- return 0;
-}
-
</del><span class="cx"> String ShadowRoot::innerHTML() const
</span><span class="cx"> {
</span><span class="cx"> return createMarkup(*this, ChildrenOnly);
</span></span></pre></div>
<a id="trunkSourceWebCoredomShadowRooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ShadowRoot.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ShadowRoot.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/ShadowRoot.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -81,8 +81,6 @@
</span><span class="cx">
</span><span class="cx"> Type type() const { return m_type; }
</span><span class="cx">
</span><del>- PassRefPtr<Node> cloneNode(bool, ExceptionCode&);
-
</del><span class="cx"> virtual void removeAllEventListeners() override;
</span><span class="cx">
</span><span class="cx"> #if ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT)
</span></span></pre></div>
<a id="trunkSourceWebCoredomSpaceSplitStringcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/SpaceSplitString.cpp (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/SpaceSplitString.cpp 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/SpaceSplitString.cpp 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -173,7 +173,7 @@
</span><span class="cx"> AtomicString* m_memoryBucket;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-inline PassRefPtr<SpaceSplitStringData> SpaceSplitStringData::create(const AtomicString& keyString, unsigned tokenCount)
</del><ins>+inline Ref<SpaceSplitStringData> SpaceSplitStringData::create(const AtomicString& keyString, unsigned tokenCount)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(tokenCount);
</span><span class="cx">
</span><span class="lines">@@ -188,10 +188,10 @@
</span><span class="cx"> ASSERT(static_cast<unsigned>(tokenInitializer.nextMemoryBucket() - tokenArrayStart) == tokenCount);
</span><span class="cx"> ASSERT(reinterpret_cast<const char*>(tokenInitializer.nextMemoryBucket()) == reinterpret_cast<const char*>(spaceSplitStringData) + sizeToAllocate);
</span><span class="cx">
</span><del>- return adoptRef(spaceSplitStringData);
</del><ins>+ return adoptRef(*spaceSplitStringData);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<SpaceSplitStringData> SpaceSplitStringData::create(const AtomicString& keyString)
</del><ins>+RefPtr<SpaceSplitStringData> SpaceSplitStringData::create(const AtomicString& keyString)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(isMainThread());
</span><span class="cx"> ASSERT(!keyString.isNull());
</span><span class="lines">@@ -211,7 +211,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<SpaceSplitStringData> spaceSplitStringData = create(keyString, tokenCount);
</span><span class="cx"> addResult.iterator->value = spaceSplitStringData.get();
</span><del>- return spaceSplitStringData.release();
</del><ins>+ return spaceSplitStringData;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomSpaceSplitStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/SpaceSplitString.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/SpaceSplitString.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/SpaceSplitString.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -30,7 +30,7 @@
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(SpaceSplitStringData);
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassRefPtr<SpaceSplitStringData> create(const AtomicString&);
</del><ins>+ static RefPtr<SpaceSplitStringData> create(const AtomicString&);
</ins><span class="cx">
</span><span class="cx"> bool contains(const AtomicString& string)
</span><span class="cx"> {
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx"> static ptrdiff_t tokensMemoryOffset() { return sizeof(SpaceSplitStringData); }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- static PassRefPtr<SpaceSplitStringData> create(const AtomicString&, unsigned tokenCount);
</del><ins>+ static Ref<SpaceSplitStringData> create(const AtomicString&, unsigned tokenCount);
</ins><span class="cx"> SpaceSplitStringData(const AtomicString& string, unsigned size)
</span><span class="cx"> : m_keyString(string)
</span><span class="cx"> , m_refCount(1)
</span></span></pre></div>
<a id="trunkSourceWebCoredomTreeWalkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TreeWalker.cpp (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TreeWalker.cpp 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/TreeWalker.cpp 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> m_current = node;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline Node* TreeWalker::setCurrent(PassRefPtr<Node> node)
</del><ins>+inline Node* TreeWalker::setCurrent(RefPtr<Node>&& node)
</ins><span class="cx"> {
</span><span class="cx"> m_current = node;
</span><span class="cx"> return m_current.get();
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> short acceptNodeResult = acceptNode(node.get());
</span><span class="cx"> if (acceptNodeResult == NodeFilter::FILTER_ACCEPT)
</span><del>- return setCurrent(node.release());
</del><ins>+ return setCurrent(WTFMove(node));
</ins><span class="cx"> }
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="lines">@@ -196,7 +196,7 @@
</span><span class="cx"> node = parent;
</span><span class="cx"> short acceptNodeResult = acceptNode(node.get());
</span><span class="cx"> if (acceptNodeResult == NodeFilter::FILTER_ACCEPT)
</span><del>- return setCurrent(node.release());
</del><ins>+ return setCurrent(WTFMove(node));
</ins><span class="cx"> }
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="lines">@@ -209,7 +209,7 @@
</span><span class="cx"> node = firstChild;
</span><span class="cx"> short acceptNodeResult = acceptNode(node.get());
</span><span class="cx"> if (acceptNodeResult == NodeFilter::FILTER_ACCEPT)
</span><del>- return setCurrent(node.release());
</del><ins>+ return setCurrent(WTFMove(node));
</ins><span class="cx"> if (acceptNodeResult == NodeFilter::FILTER_REJECT)
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -217,7 +217,7 @@
</span><span class="cx"> node = nextSibling;
</span><span class="cx"> short acceptNodeResult = acceptNode(node.get());
</span><span class="cx"> if (acceptNodeResult == NodeFilter::FILTER_ACCEPT)
</span><del>- return setCurrent(node.release());
</del><ins>+ return setCurrent(WTFMove(node));
</ins><span class="cx"> if (acceptNodeResult == NodeFilter::FILTER_SKIP)
</span><span class="cx"> goto Children;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomTreeWalkerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TreeWalker.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TreeWalker.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/TreeWalker.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx"> #include "NodeFilter.h"
</span><span class="cx"> #include "ScriptWrappable.h"
</span><span class="cx"> #include "Traversal.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -58,7 +57,7 @@
</span><span class="cx"> enum class SiblingTraversalType { Previous, Next };
</span><span class="cx"> template<SiblingTraversalType> Node* traverseSiblings();
</span><span class="cx">
</span><del>- Node* setCurrent(PassRefPtr<Node>);
</del><ins>+ Node* setCurrent(RefPtr<Node>&&);
</ins><span class="cx">
</span><span class="cx"> RefPtr<Node> m_current;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoredomdefaultPlatformMessagePortChannelcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.cpp (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.cpp 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.cpp 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -169,7 +169,7 @@
</span><span class="cx"> m_remotePort = port;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<PlatformMessagePortChannel> PlatformMessagePortChannel::entangledChannel()
</del><ins>+RefPtr<PlatformMessagePortChannel> PlatformMessagePortChannel::entangledChannel()
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: What guarantees that the result remains the same after we release the lock?
</span><span class="cx"> // This lock only guarantees that the returned pointer will not be pointing to released memory,
</span></span></pre></div>
<a id="trunkSourceWebCoredomdefaultPlatformMessagePortChannelh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.h (195242 => 195243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.h 2016-01-19 01:23:08 UTC (rev 195242)
+++ trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.h 2016-01-19 02:56:34 UTC (rev 195243)
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx"> static Ref<PlatformMessagePortChannel> create(PassRefPtr<MessagePortQueue> incoming, PassRefPtr<MessagePortQueue> outgoing);
</span><span class="cx"> PlatformMessagePortChannel(PassRefPtr<MessagePortQueue> incoming, PassRefPtr<MessagePortQueue> outgoing);
</span><span class="cx">
</span><del>- PassRefPtr<PlatformMessagePortChannel> entangledChannel();
</del><ins>+ RefPtr<PlatformMessagePortChannel> entangledChannel();
</ins><span class="cx">
</span><span class="cx"> void setRemotePort(MessagePort*);
</span><span class="cx"> void closeInternal();
</span></span></pre>
</div>
</div>
</body>
</html>