<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195151] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195151">195151</a></dd>
<dt>Author</dt> <dd>jiewen_tan@apple.com</dd>
<dt>Date</dt> <dd>2016-01-15 15:03:02 -0800 (Fri, 15 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Refine http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer*
https://bugs.webkit.org/show_bug.cgi?id=153140
Reviewed by Alexey Proskuryakov.
* http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html:
* http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html:
* http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html:
* http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html:
* http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html:
* http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html:
* http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html:
* http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html:
* http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped.js:
(onload):
(navigation): Deleted.
The reason why the tests are not completed after calling testRunner.notifyDone() is that the original navigation()
is bound as the onload of the iframe which will dispatch two load events. Therefore, navigation() will be called
twice. Here, change the navigation() to be bound with the main frame's onload function, which will restrict it to
be called only once.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefereralwayshtml">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefererdefaulthtml">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefererneverhtml">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetareferernoreferrerwhendowngradehtml">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetareferernoreferrerhtml">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefereroriginhtml">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefererunsafeurlhtml">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedhtml">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html</a></li>
<li><a href="#trunkLayoutTestshttptestscontentdispositionattachmentsandboxresourcesrefererheaderstrippedjs">trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/ChangeLog 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2016-01-15 Jiewen Tan <jiewen_tan@apple.com>
+
+ Refine http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer*
+ https://bugs.webkit.org/show_bug.cgi?id=153140
+
+ Reviewed by Alexey Proskuryakov.
+
+ * http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html:
+ * http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html:
+ * http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html:
+ * http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html:
+ * http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html:
+ * http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html:
+ * http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html:
+ * http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html:
+ * http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped.js:
+ (onload):
+ (navigation): Deleted.
+ The reason why the tests are not completed after calling testRunner.notifyDone() is that the original navigation()
+ is bound as the onload of the iframe which will dispatch two load events. Therefore, navigation() will be called
+ twice. Here, change the navigation() to be bound with the main frame's onload function, which will restrict it to
+ be called only once.
+
</ins><span class="cx"> 2016-01-15 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] Font features are not applied to the system font
</span></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefereralwayshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script src="resources/referer-header-stripped.js"></script>
</span><span class="cx"> <p>This test verifies that a link redirected by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
</span><del>-<iframe src="resources/referer-header-stripped-frame.php?referrer=always" onload="navigation()"></iframe>
</del><ins>+<iframe src="resources/referer-header-stripped-frame.php?referrer=always"></iframe>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefererdefaulthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script src="resources/referer-header-stripped.js"></script>
</span><span class="cx"> <p>This test verifies that a link redirected by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
</span><del>-<iframe src="resources/referer-header-stripped-frame.php?referrer=default" onload="navigation()"></iframe>
</del><ins>+<iframe src="resources/referer-header-stripped-frame.php?referrer=default"></iframe>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefererneverhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script src="resources/referer-header-stripped.js"></script>
</span><span class="cx"> <p>This test verifies that a link redirected by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
</span><del>-<iframe src="resources/referer-header-stripped-frame.php?referrer=never" onload="navigation()"></iframe>
</del><ins>+<iframe src="resources/referer-header-stripped-frame.php?referrer=never"></iframe>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetareferernoreferrerwhendowngradehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script src="resources/referer-header-stripped.js"></script>
</span><span class="cx"> <p>This test verifies that a link redirected by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
</span><del>-<iframe src="resources/referer-header-stripped-frame.php?referrer=no-referrer-when-downgrade" onload="navigation()"></iframe>
</del><ins>+<iframe src="resources/referer-header-stripped-frame.php?referrer=no-referrer-when-downgrade"></iframe>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetareferernoreferrerhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script src="resources/referer-header-stripped.js"></script>
</span><span class="cx"> <p>This test verifies that a link redirected by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
</span><del>-<iframe src="resources/referer-header-stripped-frame.php?referrer=no-referrer" onload="navigation()"></iframe>
</del><ins>+<iframe src="resources/referer-header-stripped-frame.php?referrer=no-referrer"></iframe>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefereroriginhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script src="resources/referer-header-stripped.js"></script>
</span><span class="cx"> <p>This test verifies that a link redirected by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
</span><del>-<iframe src="resources/referer-header-stripped-frame.php?referrer=origin" onload="navigation()"></iframe>
</del><ins>+<iframe src="resources/referer-header-stripped-frame.php?referrer=origin"></iframe>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedwithmetarefererunsafeurlhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script src="resources/referer-header-stripped.js"></script>
</span><span class="cx"> <p>This test verifies that a link redirected by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
</span><del>-<iframe src="resources/referer-header-stripped-frame.php?referrer=unsafe-url" onload="navigation()"></iframe>
</del><span class="cx">\ No newline at end of file
</span><ins>+<iframe src="resources/referer-header-stripped-frame.php?referrer=unsafe-url"></iframe>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxrefererheaderstrippedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script src="resources/referer-header-stripped.js"></script>
</span><span class="cx"> <p>This test verifies that a link redirected by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
</span><del>-<iframe src="resources/referer-header-stripped-frame.php" onload="navigation()"></iframe>
</del><ins>+<iframe src="resources/referer-header-stripped-frame.php"></iframe>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestscontentdispositionattachmentsandboxresourcesrefererheaderstrippedjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped.js (195150 => 195151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped.js 2016-01-15 22:58:45 UTC (rev 195150)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped.js 2016-01-15 23:03:02 UTC (rev 195151)
</span><span class="lines">@@ -7,7 +7,7 @@
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function navigation() {
</del><ins>+onload = function() {
</ins><span class="cx"> // Due to the sandbox, it's not possible to run script in the iframe or even access its contentDocument.
</span><span class="cx"> var element = document.getElementsByTagName("iframe")[0];
</span><span class="cx"> var x = element.offsetLeft + 10;
</span></span></pre>
</div>
</div>
</body>
</html>