<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195091] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195091">195091</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-14 22:12:56 -0800 (Thu, 14 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>createElement should not lowercase non-ASCII characters
https://bugs.webkit.org/show_bug.cgi?id=153114
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaselined the tests for document.createElement now that more test cases are passing.
* web-platform-tests/dom/nodes/Document-createElement-expected.txt:
* web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
* web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
* web-platform-tests/dom/nodes/case-expected.txt:
Source/WebCore:
According to step 2 in https://dom.spec.whatwg.org/#dom-document-createelement, document.createElement should not
lowercase non-ASCII letters, and this is also what Firefox does. Match that behavior by lowercasing the tag name
by convertToASCIILowercase() instead of lower() in createElement.
Also merged HTMLDocument::createElement into Document::createElement for simplicity and avoid duplicating
the call to isValidName and setting a DOM exception.
No new tests since the behavior change is covered by the existing W3C tests.
* dom/Document.cpp:
(WebCore::Document::createElement): Create a HTML element with ASCII-lowercased tag name inside a HTML document.
* dom/Document.h:
* html/HTMLDocument.cpp:
(WebCore::addLocalNameToSet):
(WebCore::HTMLDocument::createElement): Merged into Document::createElement.
* html/HTMLDocument.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentcreateElementexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElement-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentgetElementsByTagNameexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesElementgetElementsByTagNameexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodescaseexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/case-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDocumentcpp">trunk/Source/WebCore/html/HTMLDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDocumenth">trunk/Source/WebCore/html/HTMLDocument.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-01-14 Ryosuke Niwa <rniwa@webkit.org>
+
+ createElement should not lowercase non-ASCII characters
+ https://bugs.webkit.org/show_bug.cgi?id=153114
+
+ Reviewed by Alex Christensen.
+
+ Rebaselined the tests for document.createElement now that more test cases are passing.
+
+ * web-platform-tests/dom/nodes/Document-createElement-expected.txt:
+ * web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
+ * web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
+ * web-platform-tests/dom/nodes/case-expected.txt:
+
</ins><span class="cx"> 2016-01-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> Fix problems with cross-origin redirects
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentcreateElementexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElement-expected.txt (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElement-expected.txt 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElement-expected.txt 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -19,8 +19,8 @@
</span><span class="cx"> PASS createElement("svg")
</span><span class="cx"> PASS createElement("math")
</span><span class="cx"> PASS createElement("FOO")
</span><del>-FAIL createElement("marK") assert_equals: expected "marK" but got "mark"
-FAIL createElement("İnput") assert_equals: expected "İnput" but got "i̇nput"
</del><ins>+PASS createElement("marK")
+PASS createElement("İnput")
</ins><span class="cx"> FAIL createElement("ınput") assert_equals: expected "ıNPUT" but got "INPUT"
</span><span class="cx"> PASS createElement("")
</span><span class="cx"> PASS createElement("1foo")
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentgetElementsByTagNameexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> PASS Element in non-HTML namespace, no prefix, uppercase name
</span><span class="cx"> PASS Element in non-HTML namespace, prefix, lowercase name
</span><span class="cx"> PASS Element in non-HTML namespace, prefix, uppercase name
</span><del>-FAIL Element in HTML namespace, no prefix, non-ascii characters in name assert_equals: expected "aÇ" but got "aç"
</del><ins>+PASS Element in HTML namespace, no prefix, non-ascii characters in name
</ins><span class="cx"> PASS Element in non-HTML namespace, non-ascii characters in name
</span><span class="cx"> PASS Element in HTML namespace, prefix, non-ascii characters in name
</span><span class="cx"> PASS Element in non-HTML namespace, prefix, non-ascii characters in name
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesElementgetElementsByTagNameexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> PASS Element in non-HTML namespace, no prefix, uppercase name
</span><span class="cx"> PASS Element in non-HTML namespace, prefix, lowercase name
</span><span class="cx"> PASS Element in non-HTML namespace, prefix, uppercase name
</span><del>-FAIL Element in HTML namespace, no prefix, non-ascii characters in name assert_equals: expected "aÇ" but got "aç"
</del><ins>+PASS Element in HTML namespace, no prefix, non-ascii characters in name
</ins><span class="cx"> PASS Element in non-HTML namespace, non-ascii characters in name
</span><span class="cx"> PASS Element in HTML namespace, prefix, non-ascii characters in name
</span><span class="cx"> PASS Element in non-HTML namespace, prefix, non-ascii characters in name
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodescaseexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/case-expected.txt (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/case-expected.txt 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/case-expected.txt 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -19,7 +19,7 @@
</span><span class="cx"> PASS getAttribute ä
</span><span class="cx"> PASS getElementsByTagName a:ä
</span><span class="cx"> PASS getElementsByTagName ä
</span><del>-FAIL createElement Ä assert_equals: expected "Ä" but got "ä"
</del><ins>+PASS createElement Ä
</ins><span class="cx"> PASS setAttribute Ä
</span><span class="cx"> PASS getAttribute Ä
</span><span class="cx"> PASS getElementsByTagName a:Ä
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/Source/WebCore/ChangeLog 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2016-01-14 Ryosuke Niwa <rniwa@webkit.org>
+
+ createElement should not lowercase non-ASCII characters
+ https://bugs.webkit.org/show_bug.cgi?id=153114
+
+ Reviewed by Alex Christensen.
+
+ According to step 2 in https://dom.spec.whatwg.org/#dom-document-createelement, document.createElement should not
+ lowercase non-ASCII letters, and this is also what Firefox does. Match that behavior by lowercasing the tag name
+ by convertToASCIILowercase() instead of lower() in createElement.
+
+ Also merged HTMLDocument::createElement into Document::createElement for simplicity and avoid duplicating
+ the call to isValidName and setting a DOM exception.
+
+ No new tests since the behavior change is covered by the existing W3C tests.
+
+ * dom/Document.cpp:
+ (WebCore::Document::createElement): Create a HTML element with ASCII-lowercased tag name inside a HTML document.
+ * dom/Document.h:
+ * html/HTMLDocument.cpp:
+ (WebCore::addLocalNameToSet):
+ (WebCore::HTMLDocument::createElement): Merged into Document::createElement.
+ * html/HTMLDocument.h:
+
</ins><span class="cx"> 2016-01-14 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Modern IDB: Support opening and deleting SQLite databases on disk.
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -888,6 +888,9 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ if (isHTMLDocument())
+ return HTMLElementFactory::createElement(QualifiedName(nullAtom, name.convertToASCIILowercase(), xhtmlNamespaceURI), *this);
+
</ins><span class="cx"> if (isXHTMLDocument())
</span><span class="cx"> return HTMLElementFactory::createElement(QualifiedName(nullAtom, name, xhtmlNamespaceURI), *this);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/Source/WebCore/dom/Document.h 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -385,7 +385,7 @@
</span><span class="cx">
</span><span class="cx"> bool hasManifest() const;
</span><span class="cx">
</span><del>- virtual RefPtr<Element> createElement(const AtomicString& tagName, ExceptionCode&);
</del><ins>+ WEBCORE_EXPORT RefPtr<Element> createElement(const AtomicString& tagName, ExceptionCode&);
</ins><span class="cx"> WEBCORE_EXPORT Ref<DocumentFragment> createDocumentFragment();
</span><span class="cx"> WEBCORE_EXPORT Ref<Text> createTextNode(const String& data);
</span><span class="cx"> Ref<Comment> createComment(const String& data);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDocument.cpp (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDocument.cpp 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/Source/WebCore/html/HTMLDocument.cpp 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -226,15 +226,6 @@
</span><span class="cx"> // not part of the DOM
</span><span class="cx"> // --------------------------------------------------------------------------
</span><span class="cx">
</span><del>-RefPtr<Element> HTMLDocument::createElement(const AtomicString& name, ExceptionCode& ec)
-{
- if (!isValidName(name)) {
- ec = INVALID_CHARACTER_ERR;
- return 0;
- }
- return HTMLElementFactory::createElement(QualifiedName(nullAtom, name.lower(), xhtmlNamespaceURI), *this);
-}
-
</del><span class="cx"> static void addLocalNameToSet(HashSet<AtomicStringImpl*>* set, const QualifiedName& qName)
</span><span class="cx"> {
</span><span class="cx"> set->add(qName.localName().impl());
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDocument.h (195090 => 195091)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDocument.h 2016-01-15 05:40:39 UTC (rev 195090)
+++ trunk/Source/WebCore/html/HTMLDocument.h 2016-01-15 06:12:56 UTC (rev 195091)
</span><span class="lines">@@ -86,8 +86,6 @@
</span><span class="cx"> HTMLDocument(Frame*, const URL&, DocumentClassFlags = 0, unsigned constructionFlags = 0);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual RefPtr<Element> createElement(const AtomicString& tagName, ExceptionCode&) override;
-
</del><span class="cx"> virtual bool isFrameSet() const override;
</span><span class="cx"> virtual Ref<DocumentParser> createParser() override;
</span><span class="cx"> virtual Ref<Document> cloneDocumentWithoutChildren() const override final;
</span></span></pre>
</div>
</div>
</body>
</html>