<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195047] releases/WebKitGTK/webkit-2.10/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195047">195047</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-14 05:23:10 -0800 (Thu, 14 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/192775">r192775</a> - [GTK] Do not use the WebCore garbage collector timer
https://bugs.webkit.org/show_bug.cgi?id=151623
Reviewed by Martin Robinson.
Now that garbage collector timers have been implemented in
JavaScriptCore for glib, we don't need to use another Timer in WebCore.
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectSoon):
(WebCore::GCController::garbageCollectNowIfNotDoneRecently):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCorebindingsjsGCControllercpp">releases/WebKitGTK/webkit-2.10/Source/WebCore/bindings/js/GCController.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit210SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (195046 => 195047)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2016-01-14 13:22:14 UTC (rev 195046)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2016-01-14 13:23:10 UTC (rev 195047)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-11-27 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] Do not use the WebCore garbage collector timer
+ https://bugs.webkit.org/show_bug.cgi?id=151623
+
+ Reviewed by Martin Robinson.
+
+ Now that garbage collector timers have been implemented in
+ JavaScriptCore for glib, we don't need to use another Timer in WebCore.
+
+ * bindings/js/GCController.cpp:
+ (WebCore::GCController::garbageCollectSoon):
+ (WebCore::GCController::garbageCollectNowIfNotDoneRecently):
+
</ins><span class="cx"> 2015-11-25 Pranjal Jumde <pjumde@apple.com>
</span><span class="cx">
</span><span class="cx"> Checks for buffer-overflows when reading characters from textRun
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCorebindingsjsGCControllercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/bindings/js/GCController.cpp (195046 => 195047)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/bindings/js/GCController.cpp 2016-01-14 13:22:14 UTC (rev 195046)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/bindings/js/GCController.cpp 2016-01-14 13:23:10 UTC (rev 195047)
</span><span class="lines">@@ -57,12 +57,10 @@
</span><span class="cx">
</span><span class="cx"> void GCController::garbageCollectSoon()
</span><span class="cx"> {
</span><del>- // We only use reportAbandonedObjectGraph on systems with CoreFoundation
- // since it uses a run-loop-based timer that is currently only available on
- // systems with CoreFoundation. If and when the notion of a run loop is pushed
- // down into WTF so that more platforms can take advantage of it, we will be
- // able to use reportAbandonedObjectGraph on more platforms.
-#if USE(CF)
</del><ins>+ // We only use reportAbandonedObjectGraph for systems for which there's an implementation
+ // of the garbage collector timers in JavaScriptCore. We wouldn't need this if JavaScriptCore
+ // used a timer implementation from WTF like RunLoop::Timer.
+#if USE(CF) || USE(GLIB)
</ins><span class="cx"> JSLockHolder lock(JSDOMWindow::commonVM());
</span><span class="cx"> JSDOMWindow::commonVM().heap.reportAbandonedObjectGraph();
</span><span class="cx"> #else
</span><span class="lines">@@ -92,7 +90,7 @@
</span><span class="cx">
</span><span class="cx"> void GCController::garbageCollectNowIfNotDoneRecently()
</span><span class="cx"> {
</span><del>-#if USE(CF)
</del><ins>+#if USE(CF) || USE(GLIB)
</ins><span class="cx"> JSLockHolder lock(JSDOMWindow::commonVM());
</span><span class="cx"> if (!JSDOMWindow::commonVM().heap.isBusy())
</span><span class="cx"> JSDOMWindow::commonVM().heap.collectAllGarbageIfNotDoneRecently();
</span></span></pre>
</div>
</div>
</body>
</html>